Trilok Soni | 2 Mar 08:02 2012

Re: [PATCH v3 1/1] rc: Add support for GPIO based IR Receiver driver.

Hi Mauro/Wilson,

On 2/29/2012 5:54 PM, Trilok Soni wrote:
> Hi Mauro/Wilson,
>
> On 2/29/2012 1:59 AM, James Hogan wrote:
>> On Tue, Feb 28, 2012 at 11:21:40AM +0530, Ravi Kumar V wrote:
>>> Adds GPIO based IR Receiver driver. It decodes signals using decoders
>>> available in rc framework.
>>>
>>> Signed-off-by: Ravi Kumar V<kumarrav <at> codeaurora.org>
>>
>> Looks good to me (but I'm no expert).
>>
>
> Please review this patch.
>
> Thank you James for the review comments.

Please review and check if this patch can be merged in your tree.

---Trilok Soni

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Samuel Omlin | 3 Mar 03:51 2012
Picon

Re: Terms of MSM/QSD in QAEP

Hi David,

Thank you for your reply quickly.

As far as I can know, all parts after the name of chipset (like
msm7630) indicate that what case the chipset is applied to. Let's say,
CSFB short for Circuit Switch Fall Back in the naming of xxxxxx_csfb
means being with the functionality of LTE in the modem side for the
chipset. In other words, it is exactly available when required to
support LTE on the air. Note that xxxxxxx here stands for chipset name
that looks something like msm7630.

So, all i would like to know is what situations those "fusion" and
"surf" and "ffa" for chipesets like msm7630  are applied tor,
separately. That's it.

Thanks a lot.

Best Regards,
Samuel

On Thu, Mar 1, 2012 at 5:18 AM, David Brown <davidb <at> codeaurora.org> wrote:
> On Wed, Feb 29, 2012 at 11:21:51PM +0800, Samuel Omlin wrote:
>> Hi CodeAurora,
>>
>> While going through the whole source code by the GitWeb interface
>> (https://www.codeaurora.org/gitweb/quic/la/), there are so many very
>> obscure terms of MSM/QSD chipset in QAEP (MSM/QSD Android Enablement
>> Project) making people stuck out there, who are trying being aware of
>> exactly what they indicate like me, as below.
(Continue reading)

David Brown | 5 Mar 17:35 2012

Re: Terms of MSM/QSD in QAEP

On Sat, Mar 03, 2012 at 10:51:40AM +0800, Samuel Omlin wrote:
> Hi David,
> 
> Thank you for your reply quickly.
> 
> As far as I can know, all parts after the name of chipset (like
> msm7630) indicate that what case the chipset is applied to. Let's say,
> CSFB short for Circuit Switch Fall Back in the naming of xxxxxx_csfb
> means being with the functionality of LTE in the modem side for the
> chipset. In other words, it is exactly available when required to
> support LTE on the air. Note that xxxxxxx here stands for chipset name
> that looks something like msm7630.
> 
> So, all i would like to know is what situations those "fusion" and
> "surf" and "ffa" for chipesets like msm7630  are applied tor,
> separately. That's it.

They are the names of particular boards that have the msm7630 chip on
them.  My guess is that they would be used when building for that
specific target.

David

> Thanks a lot.
> 
> 
> Best Regards,
> Samuel
> 
> 
(Continue reading)

Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 2/5] Add a2mp.h to library_sources

---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index c0e362b..b0aaf79 100644
--- a/Makefile.am
+++ b/Makefile.am
 <at>  <at>  -2,7 +2,7  <at>  <at> 
 AM_MAKEFLAGS = --no-print-directory

 library_sources = lib/bluetooth.h lib/bluetooth.c \
-			lib/hci_lib.h lib/hci.h lib/hci.c lib/l2cap.h
+			lib/hci_lib.h lib/hci.h lib/hci.c lib/l2cap.h lib/a2mp.h

 parser_sources =  parser/parser.h parser/parser.c \
 					parser/lmp.c \
--

-- 
1.7.4.1

--
Peter Krystad
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 5/5] Minor indentation cleanup and fix display of physical link key

---
 parser/hci.c |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/parser/hci.c b/parser/hci.c
index a0e3034..e459e9e 100644
--- a/parser/hci.c
+++ b/parser/hci.c
 <at>  <at>  -1124,12 +1124,11  <at>  <at>  static inline void create_physical_link_dump(int level, struct frame *frm)
 	int i;

 	p_indent(level, frm);
-
 	printf("handle %d key length %d key type %d\n",
 		cp->handle, cp->key_length, cp->key_type);
+	p_indent(level, frm);
 	printf("key ");
-
-	for (i = 0; i < cp->key_length && cp->key_length < 32; i++)
+	for (i = 0; i < cp->key_length && cp->key_length <= 32; i++)
 		printf("%2.2x", cp->key[i]);
 	printf("\n");
 }
 <at>  <at>  -1140,12 +1139,16  <at>  <at>  static inline void create_logical_link_dump(int level, struct frame *frm)
 	int i;

 	p_indent(level, frm);
-
 	printf("handle %d\n", cp->handle);
+
(Continue reading)

Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 4/5] Add parsing of A2MP signals

---
 parser/l2cap.c  |  354 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 parser/parser.h |    1 +
 src/hcidump.c   |    1 +
 3 files changed, 356 insertions(+), 0 deletions(-)

diff --git a/parser/l2cap.c b/parser/l2cap.c
index 39e29a0..69383e6 100644
--- a/parser/l2cap.c
+++ b/parser/l2cap.c
 <at>  <at>  -37,6 +37,7  <at>  <at> 
 #include "parser/sdp.h"
 #include "lib/hci.h"
 #include "lib/l2cap.h"
+#include "lib/a2mp.h"

 typedef struct {
 	uint16_t handle;
 <at>  <at>  -269,6 +270,16  <at>  <at>  static char *reason2str(uint16_t reason)
 	}
 }

+static char *a2mpreason2str(uint16_t reason)
+{
+	switch (reason) {
+	case A2MP_COMMAND_NOT_RECOGNIZED:
+		return "Command not recognized";
+	default:
+		return "Reserved";
+	}
(Continue reading)

Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 0/5] Add parsing of BT 3.0+HS signals

v5 - put Makefile.am change into separate commit

Peter Krystad (5):
  lib: Add A2MP definitions
  Add a2mp.h to library_sources
  Add parsing of L2CAP Create/Move Channel signals
  Add parsing of A2MP signals
  Minor indentation cleanup and fix display of physical link key

 Makefile.am     |    2 +-
 lib/a2mp.h      |  115 ++++++++++++++
 parser/hci.c    |   15 ++-
 parser/l2cap.c  |  450 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 parser/parser.h |    1 +
 src/hcidump.c   |    1 +
 6 files changed, 578 insertions(+), 6 deletions(-)

--

-- 
1.7.4.1

--
Peter Krystad
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 1/5] lib: Add A2MP definitions

---
 lib/a2mp.h |  115 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 115 insertions(+), 0 deletions(-)

diff --git a/lib/a2mp.h b/lib/a2mp.h
index f6d07df..da937d1 100644
--- a/lib/a2mp.h
+++ b/lib/a2mp.h
 <at>  <at>  -3,6 +3,7  <at>  <at> 
  *  BlueZ - Bluetooth protocol stack for Linux
  *
  *  Copyright (C) 2012  Intel Corporation. All rights reserved.
+ *  Copyright (c) 2012  Code Aurora Forum. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
 <at>  <at>  -27,6 +28,120  <at>  <at> 
 extern "C" {
 #endif

+/* A2MP Protocol */
+
+/* A2MP command codes */
+
+#define A2MP_COMMAND_REJ	0x01
+#define A2MP_DISCOVER_REQ	0x02
+#define A2MP_DISCOVER_RSP	0x03
+#define A2MP_CHANGE_NOTIFY	0x04
+#define A2MP_CHANGE_RSP		0x05
+#define A2MP_INFO_REQ		0x06
(Continue reading)

Peter Krystad | 6 Mar 01:14 2012

[PATCH v5 3/5] Add parsing of L2CAP Create/Move Channel signals

---
 parser/l2cap.c |   96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 96 insertions(+), 0 deletions(-)

diff --git a/parser/l2cap.c b/parser/l2cap.c
index 03aa9f6..39e29a0 100644
--- a/parser/l2cap.c
+++ b/parser/l2cap.c
 <at>  <at>  -868,6 +868,78  <at>  <at>  static void l2cap_ctrl_parse(int level, struct frame *frm, uint32_t ctrl)
 		printf(" F-bit");
 }

+static inline void create_req(int level, l2cap_cmd_hdr *cmd, struct frame *frm)
+{
+	l2cap_create_req *h = frm->ptr;
+	uint16_t psm = btohs(h->psm);
+	uint16_t scid = btohs(h->scid);
+
+	if (p_filter(FILT_L2CAP))
+		return;
+
+	printf("Create req: psm %d scid 0x%4.4x id %d\n", psm, scid, h->id);
+}
+
+static inline void create_rsp(int level, l2cap_cmd_hdr *cmd, struct frame *frm)
+{
+	l2cap_create_rsp *h = frm->ptr;
+	uint16_t scid = btohs(h->scid);
+	uint16_t dcid = btohs(h->dcid);
+	uint16_t result = btohs(h->result);
(Continue reading)

Subhash Jadavani | 6 Mar 08:24 2012

[PATCH v1 1/1] mmc: core: hs200 fixes

This patch fixes following issues when HS200 is enabled:

1. If executing_tuning() host ops is called without mmc_host_clk_hold(),
   card clocks might get turned off (if MMC_CLK_GATING is enabled)
   while execute_tuning() is in progress. So this patch makes sure
   that execute_tuning() is called with mmc_host_clk_hold().

2. If host timing mode is set to HS200 mode, there should not be
   any communication with the card until execute_tuning() is completed.
   But there is a chance that CMD6 might be sent to enable set HPI_EN
   (of HPI_MGMT field in EXT_CSD) before execute_tuning() is called.
   So this patch moves this operation after execute_tuning() is completed.

Signed-off-by: Subhash Jadavani <subhashj <at> codeaurora.org>
---
 drivers/mmc/core/mmc.c |   37 ++++++++++++++++++++-----------------
 1 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index a480663..08574ae 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
 <at>  <at>  -1030,22 +1030,6  <at>  <at>  static int mmc_init_card(struct mmc_host *host, u32 ocr,
 	}

 	/*
-	 * Enable HPI feature (if supported)
-	 */
-	if (card->ext_csd.hpi) {
-		err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
(Continue reading)


Gmane