Discussing the Linux ARM kernel

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 6/8] mtd: nand: rename CREATE_EMPTY bbt flag with proper prefix

According to our new prefix rules, we should rename NAND_CREATE_EMPTY_BBT
with a NAND_BBT prefix, i.e., NAND_BBT_CREATE_EMPTY.

Signed-off-by: Brian Norris <computersforpeace <at> gmail.com>
---
 drivers/mtd/nand/nand_bbt.c |    2 +-
 include/linux/mtd/bbm.h     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index 2e4e259..9af703d 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
 <at>  <at>  -970,7 +970,7  <at>  <at>  static int check_create(struct mtd_info *mtd, uint8_t *buf, struct nand_bbt_desc
 			continue;

 		/* Create the table in memory by scanning the chip(s) */
-		if (!(this->bbt_options & NAND_CREATE_EMPTY_BBT))
+		if (!(this->bbt_options & NAND_BBT_CREATE_EMPTY))
 			create_bbt(mtd, buf, bd, chipsel);

 		td->version[i] = 1;
diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index 3cf4a8a..0fa030a 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
 <at>  <at>  -92,7 +92,7  <at>  <at>  struct nand_bbt_descr {
  * layout or if this information is already purged. Must be used in conjunction
  * with NAND_BBT_CREATE.
  */

(Continue reading)

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 5/8] mtd: nand: move NAND_CREATE_EMPTY_BBT flag

The NAND_CREATE_EMPTY_BBT flag was added by commit:
  453281a973c10bce941b240d1c654d536623b16b
  mtd: nand: introduce NAND_CREATE_EMPTY_BBT
This flag is not used within the kernel and not explained well, so I
took the liberty to edit its comments.

Also, this is a BBT-related flag (and closely tied with NAND_BBT_CREATE)
so I'm moving it to bbm.h next to NAND_BBT_CREATE, thus requiring that
we use the flag in nand_chip.bbt_options, *not* in nand_chip.options.

Signed-off-by: Brian Norris <computersforpeace <at> gmail.com>
---
 drivers/mtd/nand/nand_bbt.c |    2 +-
 include/linux/mtd/bbm.h     |    7 +++++++
 include/linux/mtd/nand.h    |    2 --
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index dfea9fd..2e4e259 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
 <at>  <at>  -970,7 +970,7  <at>  <at>  static int check_create(struct mtd_info *mtd, uint8_t *buf, struct nand_bbt_desc
 			continue;

 		/* Create the table in memory by scanning the chip(s) */
-		if (!(this->options & NAND_CREATE_EMPTY_BBT))
+		if (!(this->bbt_options & NAND_CREATE_EMPTY_BBT))
 			create_bbt(mtd, buf, bd, chipsel);

 		td->version[i] = 1;

(Continue reading)

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 3/8] mtd: nand: consolidate redundant flash-based BBT flags

This patch works with the following three flags from two headers (nand.h
and bbm.h):
  (1) NAND_USE_FLASH_BBT (nand.h)
  (2) NAND_USE_FLASH_BBT_NO_OOB (nand.h)
  (3) NAND_BBT_NO_OOB (bbm.h)

These flags are all related and interdependent, yet they were in
different headers. Flag (2) is simply the combination of (1) and (3) and
can be eliminated.

This patch accomplishes the following:
  * eliminate NAND_USE_FLASH_BBT_NO_OOB (i.e., flag (2))
  * move NAND_USE_FLASH_BBT (i.e., flag (1)) to bbm.h

It's important to note that because (1) and (3) are now both found in
bbm.h, they should NOT be used in the "nand_chip.options" field.

I removed a small section from the mtdnand DocBook because it referes to
NAND_USE_FLASH_BBT in nand.h, which has been moved to bbm.h.

Signed-off-by: Brian Norris <computersforpeace <at> gmail.com>
---
 Documentation/DocBook/mtdnand.tmpl             |    5 +----
 arch/arm/mach-davinci/board-da830-evm.c        |    2 +-
 arch/arm/mach-davinci/board-da850-evm.c        |    2 +-
 arch/arm/mach-davinci/board-dm355-evm.c        |    2 +-
 arch/arm/mach-davinci/board-dm355-leopard.c    |    2 +-
 arch/arm/mach-davinci/board-dm365-evm.c        |    2 +-
 arch/arm/mach-davinci/board-dm644x-evm.c       |    2 +-
 arch/arm/mach-davinci/board-mityomapl138.c     |    3 ++-

(Continue reading)

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 8/8] mtd: nand: improve comment on NAND_BBT_DYNAMIC_STRUCT

In an attempt to improve the documentation of the BBT code, I am expanding
the comments I left in commit:
    58373ff0afff4cc8ac40608872995f4d87eb72ec
    mtd: nand: more BB Detection refactoring and dynamic scan options

Signed-off-by: Brian Norris <computersforpeace <at> gmail.com>
---
 include/linux/mtd/bbm.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index 57d6a8d..c4eec22 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
 <at>  <at>  -113,7 +113,11  <at>  <at>  struct nand_bbt_descr {
 /* Do not store flash based bad block table in OOB area; store it in-band */
 #define NAND_BBT_NO_OOB		0x00040000

-/* The nand_bbt_descr was created dynamicaly and must be freed */
+/*
+ * Flag set by nand_create_default_bbt_descr(), marking that the nand_bbt_descr
+ * was allocated dynamicaly and must be freed in nand_release(). Has no meaning
+ * in nand_chip.bbt_options.
+ */
 #define NAND_BBT_DYNAMICSTRUCT	0x80000000

 /* The maximum number of blocks to scan for a bbt */
--

-- 
1.7.0.4

(Continue reading)

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 1/8] mtd: nand: remove NAND_BBT_SCANBYTE1AND6 option

This patch reverts most of:
    commit 58373ff0afff4cc8ac40608872995f4d87eb72ec
    mtd: nand: more BB Detection refactoring and dynamic scan options

According to the discussion at:
    http://lists.infradead.org/pipermail/linux-mtd/2011-May/035696.html
the NAND_BBT_SCANBYTE1AND6 flag, although technically valid, can break
some existing ECC layouts that use the 6th byte in the OOB for ECC data.
Furthermore, we apparently do not need to scan both bytes 1 and 6 in
the OOB region of the devices under consideration; instead, we only need
to scan one or the other.

Thus, the NAND_BBT_SCANBYTE1AND6 flag is at best unnecessary and at
worst a regression.

Signed-off-by: Brian Norris <computersforpeace <at> gmail.com>
---
 drivers/mtd/nand/nand_base.c |   29 +++++------------------------
 drivers/mtd/nand/nand_bbt.c  |   32 +-------------------------------
 include/linux/mtd/bbm.h      |    2 --
 3 files changed, 6 insertions(+), 57 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index a46e9bb..456fb34 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
 <at>  <at>  -410,10 +410,11  <at>  <at>  static int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
 	else {
 		nand_get_device(chip, mtd, FL_WRITING);

(Continue reading)

Brian Norris | 1 Jun 2011 01:31

Picon

[PATCH 0/8] clean-up NAND / BBT code, flags

Hello,

This patch series handles several issues with NAND chip flags and BBT
flags, especially those related to the nand_chip.options and
nand_bbt_descr.options fields. This topic was discussed and reviewed a
bit on the linux-mtd thread found here:
    http://lists.infradead.org/pipermail/linux-mtd/2011-April/035146.html

These changes have affected many drivers in relatively small ways, so
I copied all the maintainers/contributors given by the
scripts/getmaintainer.pl scripts. FYI, this patch set is based on the
mtd-2.6.git repository from linux-mtd.

Also, the first patch:
    mtd: nand: remove NAND_BBT_SCANBYTE1AND6 option
solves the regression issues discussed here:
    http://lists.infradead.org/pipermail/linux-mtd/2011-May/035696.html

Thanks for the review.

Brian

Brian Norris (8):
  mtd: nand: remove NAND_BBT_SCANBYTE1AND6 option
  mtd: nand: separate chip options / bbt_options
  mtd: nand: consolidate redundant flash-based BBT flags
  mtd: nand: rename NAND_USE_FLASH_BBT
  mtd: nand: move NAND_CREATE_EMPTY_BBT flag
  mtd: nand: rename CREATE_EMPTY bbt flag with proper prefix
  mtd: nand: renumber the reorganized flags in nand.h / bbm.h

(Continue reading)

Grant Likely | 1 Jun 2011 01:28

Picon

Re: [PATCH] gpio: ep93xx: move driver to drivers/gpio

On Tue, May 31, 2011 at 4:37 PM, H Hartley Sweeten
<hartleys <at> visionengravers.com> wrote:
> On Tuesday, May 31, 2011 1:41 PM, Grant Likely wrote:
>> On Tue, May 31, 2011 at 1:49 PM, H Hartley Sweeten wrote:
>>> The GPIO driver should reside in drivers/gpio.
>>>
>>> Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
>>> Cc: Ryan Mallon <ryan <at> bluewatersys.com>
>>> Cc: Grant Likely <grant.likely <at> secretlab.ca>
>>>
>>> ---
>>>
>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>>> index 342d634..7307302 100644
>>> --- a/drivers/gpio/Kconfig
>>> +++ b/drivers/gpio/Kconfig
>>>  <at>  <at>  -86,6 +86,13  <at>  <at>  config GPIO_IT8761E
>>>        help
>>>          Say yes here to support GPIO functionality of IT8761E super I/O chip.
>>>
>>> +config GPIO_EP93XX
>>> +       bool "Cirrus EP93xx GPIO support"
>>> +       depends on ARCH_EP93XX
>>> +       default y
>>> +       help
>>> +         Say yes here to support the Cirrus EP93xx GPIO peripheral.
>>> +
>>
>> Do you really want a user-visible Kconfig symbol here?  If it cannot
>> be built as a module, then I suspect that for most on-chip gpio

(Continue reading)

H Hartley Sweeten | 1 Jun 2011 01:36

[PATCH v2] gpio: ep93xx: mode driver to drivers/gpio

The GPIO driver should reside in drivers/gpio.

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc: Ryan Mallon <ryan <at> bluewatersys.com>
Cc: Grant Likely <grant.likely <at> secretlab.ca>

---

v2: Make the Kconfig symbol a silent option, dependent on ARCH_EP93XX

diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index 33ee2c8..6b7c41d 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
 <at>  <at>  -1,7 +1,7  <at>  <at> 
 #
 # Makefile for the linux kernel.
 #
-obj-y			:= core.o clock.o dma-m2p.o gpio.o
+obj-y			:= core.o clock.o dma-m2p.o
 obj-m			:=
 obj-n			:=
 obj-			:=
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 342d634..5f87cad 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
 <at>  <at>  -86,6 +86,11  <at>  <at>  config GPIO_IT8761E
 	help
 	  Say yes here to support GPIO functionality of IT8761E super I/O chip.

(Continue reading)

Will Drewry | 1 Jun 2011 05:10

[PATCH v3 07/13] arm: select HAVE_SECCOMP_FILTER

Enable support for CONFIG_SECCOMP_FILTER by selecting HAVE_SECCOMP_FILTER by
default.

Signed-off-by: Will Drewry <wad <at> chromium.org>
---
 arch/arm/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 377a7a5..4725fbc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
 <at>  <at>  -16,6 +16,7  <at>  <at>  config ARM
 	select HAVE_FTRACE_MCOUNT_RECORD if (!XIP_KERNEL)
 	select HAVE_DYNAMIC_FTRACE if (!XIP_KERNEL)
 	select HAVE_FUNCTION_GRAPH_TRACER if (!THUMB2_KERNEL)
+	select HAVE_SECCOMP_FILTER
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_KERNEL_GZIP
 	select HAVE_KERNEL_LZO
--

-- 
1.7.0.4

Bryan Wu | 1 Jun 2011 05:43

[RFC] Consolidation: Replace all led drivers in arch/arm to leds trigger drivers

Russell,

After a quick review the led drivers in arch/arm, I found most of them
are based on arch/arm/kernel/leds.c driver, which is a specific led
event driver.
In mainline 3.0-rc1:
--
linux-2.6$ find arch/arm/ -name *led*
arch/arm/mach-ks8695/leds.c
arch/arm/mach-sa1100/leds.c
arch/arm/mach-sa1100/leds-cerf.c
arch/arm/mach-sa1100/leds-lart.c
arch/arm/mach-sa1100/leds-hackkit.c
arch/arm/mach-sa1100/leds.h
arch/arm/mach-sa1100/leds-assabet.c
arch/arm/mach-sa1100/leds-simpad.c
arch/arm/mach-sa1100/leds-badge4.c
arch/arm/mach-integrator/leds.c
arch/arm/include/asm/leds.h
arch/arm/mach-s3c2410/include/mach/leds-gpio.h
arch/arm/mach-omap1/leds.c
arch/arm/mach-omap1/leds.h
arch/arm/mach-omap1/leds-h2p2-debug.c
arch/arm/mach-omap1/leds-osk.c
arch/arm/mach-omap1/leds-innovator.c
arch/arm/mach-pxa/leds.c
arch/arm/mach-pxa/leds-mainstone.c
arch/arm/mach-pxa/leds-lubbock.c
arch/arm/mach-pxa/leds-idp.c
arch/arm/mach-pxa/leds.h

(Continue reading)

Group

gmane.linux.ports.arm.kernel.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 168

Articles in period: 1670

June 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH v2] ARM: mm: Get rid of L_PTE_USER ref from PAGE_S2_DEVICE (25 May 2013)
[v2] ARM: mm: Get rid of L_PTE_USER ref from PAGE_S2_DEVICE (25 May 2013)
[PATCH] ARM: nomadik: move the pin configuration to DT (24 May 2013)
[PATCH 1/2] ARM: imx: irq-common: Include header to avoid sparse warni (24 May 2013)
Allwinner sunXi Fixes for 3.10 (24 May 2013)
rmk is away (24 May 2013)
[PATCHv4 1/6] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA (24 May 2013)
[PATCH v3 1/2] ARM:dts:mx53qsb: Add support for parallel display (24 May 2013)
[PATCH v2] gpio-rcar: Add support for IRQ_TYPE_EDGE_BOTH (24 May 2013)
[PATCHv3 0/5] arm: arch_timer cleanups and niceties (24 May 2013)
[PATCH] ARM: OMAP2+: omap-usb-host: Fix memory leaks (24 May 2013)
clock framework: Don't disable a clock already enabled by boot loader? (24 May 2013)
Доброго времени суток (24 May 2013)
FW: Linux 2.6.39.4 in a AT91SAM9M10G45-EK 10 Mbytes dma buffer allocat (24 May 2013)
[PATCH v2 0/4] Optimise cache-flushing system call (24 May 2013)
[PATCH 00/21] ARM: kirkwood: improve pinmux configs in Device Tree (24 May 2013)
[PATCH 1/2] ARM: sunxi: Update datasheet documentation (24 May 2013)
[PATCH] ARM: ux500: update defconfig base (24 May 2013)
[PATCH] ARM: ux500: enable the crypto and hash on all dbx500 (24 May 2013)
[PATCH 0/8] MCPM support for big.LITTLE Virtual Express RTSM (24 May 2013)
[PATCH] clk: use platform_{get,set}_drvdata() (24 May 2013)

Archives

1352	May 2013
2136	April 2013
1948	March 2013
1364	February 2013
2152	January 2013
1141	December 2012
2189	November 2012
1647	October 2012
1768	September 2012
1752	August 2012
1857	July 2012
1436	June 2012
1795	May 2012
1837	April 2012
1341	March 2012
1437	February 2012
1508	January 2012
1218	December 2011
1753	November 2011
1465	October 2011
1769	September 2011
1913	August 2011
1852	July 2011
1615	June 2011
1236	May 2011
1732	April 2011
1445	March 2011
1279	February 2011
1512	January 2011
1511	December 2010
1479	November 2010
1216	October 2010
1282	September 2010
1214	August 2010
1483	July 2010
1410	June 2010
1432	May 2010
843	April 2010
1195	March 2010
993	February 2010
1266	January 2010
912	December 2009
1217	November 2009
1133	October 2009
1494	September 2009
1429	August 2009
1829	July 2009
1923	June 2009
2494	May 2009
1974	April 2009
1646	March 2009
1057	February 2009
1415	January 2009
924	December 2008
1263	November 2008
1098	October 2008
1116	September 2008
1401	August 2008
1690	July 2008
1540	June 2008
977	May 2008
1080	April 2008
956	March 2008
1064	February 2008
1011	January 2008
538	December 2007
1100	November 2007
641	October 2007
404	September 2007
554	August 2007
726	July 2007
784	June 2007
932	May 2007
483	April 2007
503	March 2007
480	February 2007
597	January 2007
570	December 2006
496	November 2006
444	October 2006
561	September 2006
565	August 2006
530	July 2006
621	June 2006
628	May 2006
568	April 2006
615	March 2006
388	February 2006
614	January 2006
552	December 2005
610	November 2005
502	October 2005
404	September 2005
496	August 2005
693	July 2005
721	June 2005
523	May 2005
646	April 2005
783	March 2005
642	February 2005
432	January 2005
509	December 2004
534	November 2004
373	October 2004
481	September 2004
588	August 2004
601	July 2004
723	June 2004
620	May 2004
989	April 2004
818	March 2004
633	February 2004
507	January 2004
401	December 2003
495	November 2003
576	October 2003
399	September 2003
423	August 2003
563	July 2003
434	June 2003
391	May 2003
544	April 2003
435	March 2003
633	February 2003
769	January 2003
409	December 2002
435	November 2002
407	October 2002
16	September 2002
20	May 2002
703	April 2002
237	March 2002
2	April 2001
2	January 2001

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template