headers
Kukjin Kim | 1 Jun 2010 04:14

[PATCH] ARM: S5P: Bug fix on external interrupt for S5P series

From: Boojin Kim <boojin.kim <at> samsung.com>

This patch fixes bug on eint type set function, s5p_irq_eint_set_type().
In the IRQ_TYPE_EDGE_FALLING case, S5P_EXTINT_FALLEDGE is right
instead of S5P_EXTINT_RISEEDGE

Signed-off-by: Boojin Kim <boojin.kim <at> samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim <at> samsung.com>
---
 arch/arm/plat-s5p/irq-eint.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-s5p/irq-eint.c b/arch/arm/plat-s5p/irq-eint.c
index e56c807..f36cd33 100644
--- a/arch/arm/plat-s5p/irq-eint.c
+++ b/arch/arm/plat-s5p/irq-eint.c
 <at>  <at>  -71,7 +71,7  <at>  <at>  static int s5p_irq_eint_set_type(unsigned int irq, unsigned int type)
 		break;

 	case IRQ_TYPE_EDGE_FALLING:
-		newvalue = S5P_EXTINT_RISEEDGE;
+		newvalue = S5P_EXTINT_FALLEDGE;
 		break;

 	case IRQ_TYPE_EDGE_BOTH:
--

-- 
1.6.2.5
Permalink | Reply | 0 comments |
headers
Pratyush Anand | 1 Jun 2010 05:58
Picon
Favicon

Support for multiple MSI with ARM platform

Hi All,

I am using a PCIE device having MSI capability. It sends 4 different MSI vecotrs to host controller. 
The host controller which I am using is based on ARM platform( SPEAr).

Currently, arch_setup_msi_irqs function (which may be replaced by arch specific code) is not defined
for ARM. So my code used one default definition in driver/pci/msi.c But this code does not support 
multiple MSI.

what would be the best way to do it:

1. add following defines in arch/arm/include/asm/pci.h

#define arch_setup_msi_irqs arch_setup_msi_irqs

and then define this function in arch/arm/mach-xxxx/msi.c
or.

2. add following defines in arch/arm/include/asm/pci.h

#define arch_setup_msi_irqs arch_setup_msi_irqs

and then define this function in arch/arm/kernel/msi.c.
Now call some mach sepicif function from this routine.

or.
3 any other better solution.

Regards
Pratyush
(Continue reading)

Permalink | Reply | 0 comments |
headers
Wan ZongShun | 1 Jun 2010 07:03
Picon

Re: [PATCH] NUC900/rtc: change the waiting for device ready implement

Hi Andrew,

How about this patch?
Do you think this change is necessary?

在 2010年5月27日 下午2:59，Wan ZongShun <mcuos.com <at> gmail.com> 写道：
> Dear Andrew,
>
> This patch is only to change the waiting for device ready implement
> for winbond nuc900 platform.
>
> Signed-off-by:Wan ZongShun<mcuos.com <at> gmail.com>
>
> ---
>  drivers/rtc/rtc-nuc900.c |   15 +++++++--------
>  1 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
> index a351bd5..21d1330 100644
> --- a/drivers/rtc/rtc-nuc900.c
> +++ b/drivers/rtc/rtc-nuc900.c
>  <at>  <at>  -85,22 +85,21  <at>  <at>  static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc)
>
>  static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
>  {
> -       unsigned int i;
> +       unsigned int i, timeout = 0x1000;
>        __raw_writel(INIRRESET, nuc900_rtc->rtc_reg + REG_RTC_INIR);
>
>        mdelay(10);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Miao | 1 Jun 2010 07:58
Picon
Gravatar

Re: [PATCH 1/3] Add battery support into Zipit Z2

On Mon, May 31, 2010 at 10:51 PM, Marek Vasut <marek.vasut <at> gmail.com> wrote:
> This patch adds support for the AER915 battery chip into Zipit Z2
> platform file.
>
> Signed-off-by: Marek Vasut <marek.vasut <at> gmail.com>

Applied to 'devel'.

> ---
>  arch/arm/mach-pxa/z2.c |   42 +++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 39 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> index f5d1ae3..194865e 100644
> --- a/arch/arm/mach-pxa/z2.c
> +++ b/arch/arm/mach-pxa/z2.c
>  <at>  <at>  -16,6 +16,7  <at>  <at> 
>  #include <linux/mtd/mtd.h>
>  #include <linux/mtd/partitions.h>
>  #include <linux/pwm_backlight.h>
> +#include <linux/z2_battery.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/libertas_spi.h>
>  <at>  <at>  -458,6 +459,39  <at>  <at>  static inline void z2_keys_init(void) {}
>  #endif
>
>  /******************************************************************************
> + * Battery
> + ******************************************************************************/
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Miao | 1 Jun 2010 08:13
Picon
Gravatar

Re: [PATCH 3/3] pxa/z2: Register WM8750

On Mon, May 31, 2010 at 10:51 PM, Marek Vasut <marek.vasut <at> gmail.com> wrote:
> This patch registers the WM8750 codec on a proper place on the ZipitZ2
> machine after the WM8750 driver was converted to new API.
>
> Signed-off-by: Marek Vasut <marek.vasut <at> gmail.com>

This seems to be dependent on the previous z2 battery support patch.
Is this fixing the wm8750 registration bug, otherwise I'll queue this into
the -devel branch. Or you can help make this independent of the battery
support patch so I can merge this into -fix.

> ---
>  arch/arm/mach-pxa/z2.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> index 194865e..4cba5b6 100644
> --- a/arch/arm/mach-pxa/z2.c
> +++ b/arch/arm/mach-pxa/z2.c
>  <at>  <at>  -479,7 +479,10  <at>  <at>  static struct i2c_board_info __initdata z2_i2c_board_info[] = {
>        {
>                I2C_BOARD_INFO("aer915", 0x55),
>                .platform_data  = &batt_chip_info,
> -       }
> +       }, {
> +               I2C_BOARD_INFO("wm8750", 0x1b),
> +       },
> +
>  };
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Colin Tuckley | 1 Jun 2010 09:46
Favicon

RE: 2.6.34 hangs during boot on PB11MPCore

> -----Original Message-----
> From: linux-arm-kernel-bounces <at> lists.infradead.org [mailto:linux-arm-
> kernel-bounces <at> lists.infradead.org] On Behalf Of Catalin Marinas

> Regarding the SMSC 911x driver synchronisation - I've been asking SMSC
> for more than a year to look into this.

I'm still waiting for them to take up our offer of a PB11MPCore system for testing.

One thing Bjoern hasn't mentioned... is the board firmware up to date? I.e. has the fpga image been updated
to the latest release (from the latest CD).

Colin

--
Colin Tuckley - ARM Ltd.
110 Fulbourn Rd
Cambridge, CB1 9NJ
Tel: +44 1223 400536

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be
privileged. If you are not the intended recipient, please notify the sender immediately and do not
disclose the contents to any other person, use it for any purpose, or store or copy the information in any
medium.  Thank you.
Permalink | Reply | 1 comment |
headers
Mikael Pettersson | 1 Jun 2010 10:05
Picon
Gravatar

[PATCH] Augment __naked__ function attribute with __noinline__ and __noclone__

The asm() bodies of naked functions often depend on standard calling
conventions, therefore they must be noinline and noclone.  GCC 4.[56]
currently fail to enforce this, see GCC PR44290.  The effect is that
most arch/arm/mm/copypage-*.c modules get miscompiled, resulting in
kernel crashes during bootup.

Part of the fix is to augment the __naked attribute to imply noinline
and noclone.  This patch implements that, and has been verified to fix
the failure to boot a gcc-4.5 compiled 2.6.34 kernel on a Thecus n2100
(XScale-based mach-iop32x).

Signed-off-by: Mikael Pettersson <mikpe <at> it.uu.se>
Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 include/linux/compiler-gcc.h  |   11 ++++++++++-
 include/linux/compiler-gcc4.h |    4 ++++
 2 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 73dcf80..83bd87c 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
 <at>  <at>  -58,8 +58,12  <at>  <at> 
  * naked functions because then mcount is called without stack and frame pointer
  * being set up and there is no chance to restore the lr register to the value
  * before mcount was called.
+ *
+ * The asm() bodies of naked functions often depend on standard calling conventions,
+ * therefore they must be noinline and noclone.  GCC 4.[56] currently fail to enforce
+ * this, so we must do so ourselves.  See GCC PR44290.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Khem Raj | 1 Jun 2010 10:06
Picon
Gravatar

[PATCH] Add kto and kfrom to input operands list.

When functions incoming parameters are not in input operands list gcc 4.5 does not
load the parameters into registers before calling this function but the
inline assembly assumes valid addresses inside this function. This
breaks the code because r0 and r1 are invalid when execution enters
v4wb_copy_user_page ()

Also the constant needs to be used as third input operand so account for that
as well.

Tested on qemu arm.

Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 arch/arm/mm/copypage-feroceon.c |    4 ++--
 arch/arm/mm/copypage-v4wb.c     |    4 ++--
 arch/arm/mm/copypage-v4wt.c     |    4 ++--
 arch/arm/mm/copypage-xsc3.c     |    4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mm/copypage-feroceon.c b/arch/arm/mm/copypage-feroceon.c
index 5eb4fd9..ac163de 100644
--- a/arch/arm/mm/copypage-feroceon.c
+++ b/arch/arm/mm/copypage-feroceon.c
 <at>  <at>  -18,7 +18,7  <at>  <at>  feroceon_copy_user_page(void *kto, const void *kfrom)
 {
 	asm("\
 	stmfd	sp!, {r4-r9, lr}		\n\
-	mov	ip, %0				\n\
+	mov	ip, %2				\n\
 1:	mov	lr, r1				\n\
(Continue reading)

Permalink | Reply | 2 comments |
headers
Marc Kleine-Budde | 1 Jun 2010 10:51
Picon
Favicon

Re: [PATCH V2] i2c-imx: do not allow interruptions when waiting for I2C to complete

Marc Kleine-Budde wrote:
> The i2c_imx_trx_complete() function is using
> wait_event_interruptible_timeout() to wait for the I2C controller to
> signal that it has completed an I2C bus operation. If the process that
> causes the I2C operation receives a signal, the wait will be
> interrupted, returning an error. It is better to let the I2C operation
> finished before handling the signal (i.e. returning into userspace).
> 
> It is safe to use wait_event_timeout() instead, because the timeout
> will allow the process to exit if the I2C bus hangs. It's also better
> to allow the I2C operation to finish, because unacknowledged I2C
> operations can cause the I2C bus to hang.

Ping, can someone please comment the patch and/or push upstream.

Marc
> 
> Signed-off-by: Marc Kleine-Budde <mkl <at> pengutronix.de>
> Reviewed-by: Wolfram Sang <w.sang <at> pengutronix.de>
> ---
> 
> V2: Remove check for "result < 0" as commented by Wolfram Sang.
> 
>  drivers/i2c/busses/i2c-imx.c |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index d1ff940..58df809 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
(Continue reading)

Permalink | Reply | 0 comments |
headers
Marek Vasut | 1 Jun 2010 11:42
Picon

Re: [PATCH 3/3] pxa/z2: Register WM8750

Dne Út 1. června 2010 08:13:38 Eric Miao napsal(a):
> On Mon, May 31, 2010 at 10:51 PM, Marek Vasut <marek.vasut <at> gmail.com> wrote:
> > This patch registers the WM8750 codec on a proper place on the ZipitZ2
> > machine after the WM8750 driver was converted to new API.
> > 
> > Signed-off-by: Marek Vasut <marek.vasut <at> gmail.com>
> 
> This seems to be dependent on the previous z2 battery support patch.
> Is this fixing the wm8750 registration bug, otherwise I'll queue this into
> the -devel branch. Or you can help make this independent of the battery
> support patch so I can merge this into -fix.

Merge this into -devel please. This patch doesn't fix anything :)

Thanks!
> 
> > ---
> >  arch/arm/mach-pxa/z2.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> > index 194865e..4cba5b6 100644
> > --- a/arch/arm/mach-pxa/z2.c
> > +++ b/arch/arm/mach-pxa/z2.c
> >  <at>  <at>  -479,7 +479,10  <at>  <at>  static struct i2c_board_info __initdata
> > z2_i2c_board_info[] = { {
> >                I2C_BOARD_INFO("aer915", 0x55),
> >                .platform_data  = &batt_chip_info,
> > -       }
> > +       }, {
(Continue reading)

Permalink | Reply | 0 comments |

Gmane