headers
Ben Dooks | 1 Nov 2009 01:48

Re: Possible suspend/resume regression in .32-rc?

On Sat, Oct 31, 2009 at 05:39:32PM +0100, Robert Jarzmik wrote:
> Daniel Mack <daniel <at> caiaq.de> writes:
> 
> > Does anyone use that successfully? Any idea for possible regressions?
> The issue seems confirmed. My mioa701 phone doesn't resume either, with
> 2.6.32-rc5 kernel.

Works with several S3C24XX based machines, so it doesn't seem to be a
core problem.

--

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
Permalink | Reply | 0 comments |
headers
Ryan Mallon | 1 Nov 2009 20:54
Favicon

Re: Possible suspend/resume regression in .32-rc?

Daniel Mack wrote:
> Is anyone using suspend/resume with a recent git mainline kernel on PXA
> or other ARM embedded boards? My platform used to suspend and resume
> just fine on 2.6.31 but now as I rebased it, it fails the resume part.

Are you using the same .config? I have had drivers with dodgy
suspend/resume code before. You could try removing unneeded drivers and
see if the problem still exists.

> Unfortunately, I can't bisect it as the platform is not mainline yet and
> so I always have mandatory patches (without my platform won't do
> anything) on top of the git repository. Which breaks the bisect logic.

You can do the bisect by creating a patch (or series of patches) between
mainline and your code. Do the bisect on the clean mainline and then
apply the patch on top of the bisect point at each stage.

> What puzzles me is that I see the current raising at wakeup time, so at
> least the processor seems to resume, but I can't see any serial console
> output, just like if the kernel crashed very early after wakeup.
> 'no_console_suspend' didn't help either.

You could try enabling CONFIG_DEBUG_LL and adding the following to
kernel/printk.c just above the call to vscnprintf:

	{
		extern void printascii(const char *);
		printascii(printk_buf);
	}
(Continue reading)

Permalink | Reply | 0 comments |
headers
Uwe Kleine-König | 1 Nov 2009 21:22
Picon
Favicon
Gravatar

Re: Possible suspend/resume regression in .32-rc?

Hallo Daniel, 

On Sat, Oct 31, 2009 at 02:34:27AM +0100, Daniel Mack wrote:
> Is anyone using suspend/resume with a recent git mainline kernel on PXA
> or other ARM embedded boards? My platform used to suspend and resume
> just fine on 2.6.31 but now as I rebased it, it fails the resume part.
> 
> Unfortunately, I can't bisect it as the platform is not mainline yet and
> so I always have mandatory patches (without my platform won't do
> anything) on top of the git repository. Which breaks the bisect logic.
What you can do is call 2.6.31 good and to test a vanilla state, do
something like

	git merge my_support_branch_based_on_2.6.31
	... test ...
	git reset --hard HEAD^
	git bisect --good_or_bad_as_found_by_test_above

Best regards
Uwe

--

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
Permalink | Reply | 0 comments |
headers
Uwe Kleine-König | 1 Nov 2009 21:32
Picon
Favicon
Gravatar

Re: [PATCH] at91: support for eco920

Hello,

On Wed, Oct 21, 2009 at 10:58:47AM +0200, Uwe Kleine-König wrote:
> CONFIG_MACH_ECO920 is enabled in at91rm9200dk_defconfig.  The name is
> wrong, but this is better than adding another defconfig or don't get
> compile coverage at all.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig <at> pengutronix.de>
> Cc: Sascha Hauer <s.hauer <at> pengutronix.de>
> ---
> Hello,
> 
> as pointed by Russell I included linux/gpio.h instead of mach/gpio.h.
Is this patch OK now, should I sent to the patch system even if
Jean-Christophe PLAGNIOL-VILLARD pointed out the defconfig stuff isn't
optimal?

Best regards
Uwe

--

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
Permalink | Reply | 3 comments |
headers
Uwe Kleine-König | 1 Nov 2009 21:39
Picon
Favicon
Gravatar

Re: [PATCH] imx/gpio: Use handle_level_irq

On Tue, Oct 20, 2009 at 10:13:03AM +0200, Sascha Hauer wrote:
> On Mon, Oct 19, 2009 at 10:19:28PM +0200, Uwe Kleine-König wrote:
> > According to Russell King handle_edge_irq is only useful for "edge-based
> > inputs where the controller does not remember transitions with the input
> > masked."
> > 
> > So using handle_edge_irq unconditionally for both edge and level irqs is
> > wrong.  Testing showed that the controller does remember transitions
> > while the interrupt is masked.  So use handle_level_irq unconditionally.
> 
> As this fixes only rt kernels and we have no reports that something is
> not working on non rt kernels I suggest putting this into the next merge
> window.
I didn't find my patch in your imx tree.  Assuming I don't have
overlooked it, what is stopping you?

Best regards
Uwe

--

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
Permalink | Reply | 0 comments |
headers
Daniel Mack | 1 Nov 2009 21:54
Picon
Favicon

Re: Possible suspend/resume regression in .32-rc?

On Sat, Oct 31, 2009 at 02:34:27AM +0100, Daniel Mack wrote:
> Is anyone using suspend/resume with a recent git mainline kernel on PXA
> or other ARM embedded boards? My platform used to suspend and resume
> just fine on 2.6.31 but now as I rebased it, it fails the resume part.
> 
> Unfortunately, I can't bisect it as the platform is not mainline yet and
> so I always have mandatory patches (without my platform won't do
> anything) on top of the git repository. Which breaks the bisect logic.
> 
> What puzzles me is that I see the current raising at wakeup time, so at
> least the processor seems to resume, but I can't see any serial console
> output, just like if the kernel crashed very early after wakeup.
> 'no_console_suspend' didn't help either.

Ok, got it. The culprit is commit d2c37068 ("[ARM] pxa: initialize
default interrupt priority and use ICHP for IRQ handling"). Reverting it
make suspend/resume work again on my board.

Haojian, Eric, could you have a look at this?

Many thanks for all input, everyone :)

Thanks,
Daniel
Permalink | Reply | 18 comments |
headers
Pavel Machek | 1 Nov 2009 22:12
Picon

Re: [PATCH 02/12] ARM: S3C24XX: Introduce S3C2442B CPU

On Wed 2009-10-28 12:15:43, Ben Dooks wrote:
> From: Harald Welte <laforge <at> gnumonks.org>
> 
> Add the S3C2442B CPU ID to aid support the Openmoko GTA02 / Freerunner.
> 
> Signed-off-by: Harald Welte <laforge <at> gnumonks.org>
> Signed-off-by: Andy Green <andy <at> warmcat.com>
> Signed-off-by: Nelson Castillo <arhuaco <at> freaks-unidos.net>
> [ben-linux <at> fluff.org: edit description for clarity and S3C2442B as uppercase]
> Signed-off-by: Ben Dooks <ben-linux <at> fluff.org>
> ---
>  arch/arm/plat-s3c24xx/cpu.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c24xx/cpu.c b/arch/arm/plat-s3c24xx/cpu.c
> index 5447e60..4af9dd9 100644
> --- a/arch/arm/plat-s3c24xx/cpu.c
> +++ b/arch/arm/plat-s3c24xx/cpu.c
>  <at>  <at>  -61,6 +61,7  <at>  <at>  static const char name_s3c2410[]  = "S3C2410";
>  static const char name_s3c2412[]  = "S3C2412";
>  static const char name_s3c2440[]  = "S3C2440";
>  static const char name_s3c2442[]  = "S3C2442";
> +static const char name_s3c2442b[]  = "S3C2442B";
>  static const char name_s3c2443[]  = "S3C2443";
>  static const char name_s3c2410a[] = "S3C2410A";
>  static const char name_s3c2440a[] = "S3C2440A";
>  <at>  <at>  -112,6 +113,15  <at>  <at>  static struct cpu_table cpu_ids[] __initdata = {
>  		.name		= name_s3c2442
>  	},
>  	{
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pavel Machek | 1 Nov 2009 22:13
Picon

Re: Possible suspend/resume regression in .32-rc?

Hi!

> Is anyone using suspend/resume with a recent git mainline kernel on PXA
> or other ARM embedded boards? My platform used to suspend and resume
> just fine on 2.6.31 but now as I rebased it, it fails the resume part.

2.6.32-rc* broke resume on spitz (pxa). I narrowed it down to crash in
arch_suspend_enable_irqs() in kernel/power/suspend.c...

Can you try to light a led or something just before it to see if you
hit same problem?
									Pavel

--

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Permalink | Reply | 1 comment |
headers
Daniel Mack | 1 Nov 2009 22:16
Picon
Favicon

Re: Possible suspend/resume regression in .32-rc?

On Sun, Nov 01, 2009 at 10:13:25PM +0100, Pavel Machek wrote:
> > Is anyone using suspend/resume with a recent git mainline kernel on PXA
> > or other ARM embedded boards? My platform used to suspend and resume
> > just fine on 2.6.31 but now as I rebased it, it fails the resume part.
> 
> 2.6.32-rc* broke resume on spitz (pxa). I narrowed it down to crash in
> arch_suspend_enable_irqs() in kernel/power/suspend.c...
> 
> Can you try to light a led or something just before it to see if you
> hit same problem?

The problem seems more related to how the IRQs are set up, as I wrote in
my follow-up. Does reverting d2c370684 fix the problem for you, too?

Daniel
Permalink | Reply | 0 comments |
headers
Pavel Machek | 1 Nov 2009 22:33
Picon

Re: Possible suspend/resume regression in .32-rc?

Hi!

> > Is anyone using suspend/resume with a recent git mainline kernel on PXA
> > or other ARM embedded boards? My platform used to suspend and resume
> > just fine on 2.6.31 but now as I rebased it, it fails the resume part.
> > 
> > Unfortunately, I can't bisect it as the platform is not mainline yet and
> > so I always have mandatory patches (without my platform won't do
> > anything) on top of the git repository. Which breaks the bisect logic.
> > 
> > What puzzles me is that I see the current raising at wakeup time, so at
> > least the processor seems to resume, but I can't see any serial console
> > output, just like if the kernel crashed very early after wakeup.
> > 'no_console_suspend' didn't help either.
> 
> Ok, got it. The culprit is commit d2c37068 ("[ARM] pxa: initialize
> default interrupt priority and use ICHP for IRQ handling"). Reverting it
> make suspend/resume work again on my board.
> 
> Haojian, Eric, could you have a look at this?

Okay, patch is this one: I'll test reverting it shortly.

commit d2c37068429b29d6549cf3486fc84b836689e122
Author: Haojian Zhuang <haojian.zhuang <at> marvell.com>
Date:   Wed Aug 19 19:49:31 2009 +0800

    [ARM] pxa: initialize default interrupt priority and use ICHP for IRQ handling

    Signed-off-by: Haojian Zhuang <haojian.zhuang <at> marvell.com>
(Continue reading)

Permalink | Reply | 17 comments |

Gmane