1 Oct 2008 05:20
Re: [PATCH 21/25] [ARM] fix value of MAX_DMA_ADDRESS
Nicolas Pitre <nico <at> cam.org>
2008-10-01 03:20:30 GMT
2008-10-01 03:20:30 GMT
On Tue, 30 Sep 2008, Russell King - ARM Linux wrote: > On Tue, Sep 30, 2008 at 02:24:00PM -0400, Nicolas Pitre wrote: > > On Tue, 30 Sep 2008, Russell King - ARM Linux wrote: > > > Given the definition I've just given, if there's no restrictions on > > > what can be DMA'd from, defining 'MAX_DMA_ADDRESS' to a constant well > > > in excess of the maximum amount of RAM is quite reasonable. Since most > > > ARM platforms don't have any restrictions on memory that can be DMA'd, > > > the existing code is perfectly reasonable and correct. > > > > It falls apart when the range check on values passed to __pa() is > > enabled in a highmem context. > > As I say, having it in excess of the real amount of RAM fitted is not a > problem. Unfortunately, it makes the range check fall apart but I suspect > that's because of inappropriate use. Being in excess of the real amount of RAM might be fine, but has no real benefit that I can see. Since this is marginally used anyway, and only relevant for devices unlikely to be found on ARM systems with highmem, maybe we could simply define it as the maximum allowed kernel virtual address when CONFIG_DEBUG_HIGHMEM is set? Any other ideas? Nicolas ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php(Continue reading)
).
Thanks and regards,
Adhiraj.
-------------------------------------------------------------------
List admin:
RSS Feed