1 May 2006 15:34
Re: [PATCH 2.6.17-rc3] AT91: Remove unnecessary use of bitfields
Bill Gatliff <bgat <at> billgatliff.com>
2006-05-01 13:34:59 GMT
2006-05-01 13:34:59 GMT
David: David Brownell wrote: >With the CodeSourcery GCC, just five mask instructions total ... and >that's on kernels that include programmable clock support; otherwise >just one (init code). There's only one multibit field, and all those >fields in that "struct clk" are readonly. > > That's the way I would code it in asm, too. ARM is pretty friendly to bit fields. What version is the CodeSourcery GCC? Is this just something that older gcc's did poorly? b.g. -- -- Bill Gatliff bgat <at> billgatliff.com ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
I couldn't care less about this topic if I hadn't such a board and the
the need to hack around official sources ...
>> Opinions? How is that handled on other architectures with GPIO?
>
> Some of the PXA code stores callbacks in the platform_data.
And these callbacks does set/unset pin? Or are they more specific?
In case of at91_cf use something like
static struct at91_cf_data __initdata multiIO_cf_data = {
.irq_pin = AT91_PIN_PA23, /* I/O IRQ */
.det_pin = AT91_PIN_PC14, /* Card detect */
.enable_vcc = myboard_toggle_vcc, /* power switching */
.reset_cf = myboard_pull_reset, /* card reset */
...
}
???
RSS Feed