1 Feb 2004 01:46
Re: [PATCH 2/3] 2.6 PXA PCMCIA
Nicolas Pitre <nico <at> cam.org>
2004-02-01 00:46:01 GMT
2004-02-01 00:46:01 GMT
On Sat, 31 Jan 2004 stefan.eletzhofer <at> eletztrick.de wrote: > On Sat, Jan 31, 2004 at 03:08:23PM -0500, Nicolas Pitre wrote: > > First of all, it looks like 95% of the code in pxa2xx_core.c is a perfect > > duplicate of what's in sa11xx_core.c, with name substitution applied. New > > files, say sa-pxa_common.c and sa-pxa_common.h, should be created to hold > > Ok, that looks like a sane name to me. I first thought about naming it > intelarm_common.c or similar. The thing is, I really dont know whether or > not the code we are about to factor out here is really processor specific or not. Maybe it could be used by other chips with integrated PCMCIA too. What about soc_common.[ch] ? > The only processor specific thing is the way IOs are set up and what registers need what > massaging to get the right timings. This is all done in the probe function and some > cpufreq callbacks, maybe in power management callbacs, too. > > So it might be that its completely generic, and calling it pcmcia_core.c would be ok. That's too generic a name though. > > What sa11xx_core.c and pxa2xx_core.c should keep are the real hardware > > dependent functions, such as: > > > > sa1100_pcmcia_default_mecr_timing / pxa2xx_core_pcmcia_default_mecr_timing > > sa1100_pcmcia_set_mecr / pxa2xx_core_pcmcia_set_mecr > > Hmm, the MECR stuf basically doesnt exist in pxa, its somewhat similar but(Continue reading)
RSS Feed