Re: ntop release candidate
Ludovico Cavedon <cavedon <at> debian.org>
2012-03-04 05:13:28 GMT
On Mon, Feb 20, 2012 at 4:47 AM, Luca Deri <deri <at> ntop.org> wrote:
> you can find the first release candidate code for ntop. I would like you to
I have been working on packaging it for Debian/Ubuntu.
However, it was consistently crashing a few seconds after startup on my system.
I was able to find two out-of-bound memory access using valgrind.
I am attaching 2 patches, which fix such accesses and seem to prevent
the crash. The one for ip.c is pretty obvious.
For the one on session.c, I am not 100% sure that is the right fix,
however it looks to me that major_proto should not be bigger than
Moreover, port 443 is mapped to POP rather than HTTPS (but maybe is a
wrong side effect of my fix).
Also, valgrind still generates a lot of warnings about invalid reads.
They are mostly in 3rd party libs (rrd, fontconfig, pcap, gdbm),
however they can be caused by ntop passing uninitialized data to such
Last issue, specific about the Debian packaging:
html/exporting.js and html/highcharts.js are not free for commercial
purposes, therefore cannot be included in Debian.
Do you know if there is some other (maybe less fancy) API-compatible
library? Otherwise I can package ntop without such files. It seems to
work fine apart from the missing graphs. I can then prepare a
ntop-charts package uploaded in the non-free section containing such 2