svn-commit | 2 Mar 2012 11:22

r5214 - in trunk/PF_RING: drivers/DNA/ixgbe-3.7.17-DNA/scripts userland/lib userland/lib/libs

Author: cardigliano
Date: 2012-03-02 11:22:37 +0100 (Fri, 02 Mar 2012)
New Revision: 5214

Modified:
   trunk/PF_RING/drivers/DNA/ixgbe-3.7.17-DNA/scripts/set_irq_affinity.sh
   trunk/PF_RING/userland/lib/libs/libpfring_dna_x86_64.a
   trunk/PF_RING/userland/lib/pfring.c
   trunk/PF_RING/userland/lib/pfring_mod_dna.c
Log:
minor dna optimizations
svn-commit | 2 Mar 2012 11:42

r5215 - trunk/PF_RING/drivers/DNA/ixgbe-3.7.17-DNA/src

Author: cardigliano
Date: 2012-03-02 11:42:14 +0100 (Fri, 02 Mar 2012)
New Revision: 5215

Modified:
   trunk/PF_RING/drivers/DNA/ixgbe-3.7.17-DNA/src/load_dna_driver.sh
Log:
changed default (as many queues as the number of processors)
svn-commit | 2 Mar 2012 11:51

r5216 - trunk/PF_RING/userland/lib/libs

Author: cardigliano
Date: 2012-03-02 11:51:59 +0100 (Fri, 02 Mar 2012)
New Revision: 5216

Modified:
   trunk/PF_RING/userland/lib/libs/libpfring_dna_i686.a
Log:
dna i686 lib refresh
svn-commit | 3 Mar 2012 09:34

r5217 - in trunk/PF_RING: drivers/DNA/e1000e-1.6.3-DNA/src drivers/DNA/igb-3.2.10-DNA/src drivers/DNA/ixgbe-3.7.17-DNA/src userland/lib userland/lib/libs

Author: deri
Date: 2012-03-03 09:34:38 +0100 (Sat, 03 Mar 2012)
New Revision: 5217

Modified:
   trunk/PF_RING/drivers/DNA/e1000e-1.6.3-DNA/src/e1000e_dna.c
   trunk/PF_RING/drivers/DNA/igb-3.2.10-DNA/src/igb_dna.c
   trunk/PF_RING/drivers/DNA/ixgbe-3.7.17-DNA/src/ixgbe_dna.c
   trunk/PF_RING/userland/lib/libs/libpfring_dna_x86_64.a
   trunk/PF_RING/userland/lib/pfring.c
   trunk/PF_RING/userland/lib/pfring.h
   trunk/PF_RING/userland/lib/pfring_hw_filtering.c
   trunk/PF_RING/userland/lib/pfring_hw_filtering.h
   trunk/PF_RING/userland/lib/pfring_i82599.c
   trunk/PF_RING/userland/lib/pfring_mod.c
   trunk/PF_RING/userland/lib/pfring_mod.h
   trunk/PF_RING/userland/lib/pfring_mod_dag.c
   trunk/PF_RING/userland/lib/pfring_mod_dag.h
   trunk/PF_RING/userland/lib/pfring_mod_dna.c
   trunk/PF_RING/userland/lib/pfring_mod_dna.h
   trunk/PF_RING/userland/lib/pfring_mod_usring.c
   trunk/PF_RING/userland/lib/pfring_mod_usring.h
   trunk/PF_RING/userland/lib/pfring_mod_virtual.h
   trunk/PF_RING/userland/lib/pfring_redirector.c
   trunk/PF_RING/userland/lib/pfring_utils.c
Log:
Added RX/TX locks
svn-commit | 3 Mar 2012 09:39

r5218 - trunk/PF_RING/userland/lib/libs

Author: deri
Date: 2012-03-03 09:39:20 +0100 (Sat, 03 Mar 2012)
New Revision: 5218

Modified:
   trunk/PF_RING/userland/lib/libs/libpfring_dna_i686.a
Log:
Library refresh
Ludovico Cavedon | 4 Mar 2012 06:13
Picon
Favicon

Re: ntop release candidate

Hi,

On Mon, Feb 20, 2012 at 4:47 AM, Luca Deri <deri <at> ntop.org> wrote:
> http://sourceforge.net/projects/ntop/files/ntop/Stable/ntop-4.1.99-rc0.tar.gz/download
> you can find the first release candidate code for ntop. I would like you to

I have been working on packaging it for Debian/Ubuntu.
However, it was consistently crashing a few seconds after startup on my system.
I was able to find two out-of-bound memory access using valgrind.
I am attaching 2 patches, which fix such accesses and seem to prevent
the crash. The one for ip.c is pretty obvious.
For the one on session.c, I am not 100% sure that is the right fix,
however it looks to me that major_proto should not be bigger than
IPOQUE_MAX_SUPPORTED_PROTOCOLS.

Moreover, port 443 is mapped to POP rather than HTTPS (but maybe is a
wrong side effect of my fix).

Also, valgrind still generates a lot of warnings about invalid reads.
They are mostly in 3rd party libs (rrd, fontconfig, pcap, gdbm),
however they can be caused by ntop passing uninitialized data to such
libs.

Last issue, specific about the Debian packaging:
html/exporting.js and html/highcharts.js are not free for commercial
purposes, therefore cannot be included in Debian.
Do you know if there is some other (maybe less fancy) API-compatible
library? Otherwise I can package ntop without such files. It seems to
work fine apart from the missing graphs. I can then prepare a
ntop-charts package uploaded in the non-free section containing such 2
(Continue reading)

Luca Deri | 4 Mar 2012 09:37

Re: ntop release candidate

Ludovico
thanks for your work. I have already made some patches to the SVN code since I released rc0, so some issues are
solved already

I have looked at your patches and honestly I am not sure they address the issues you reported

-        u_char *tcp_data = (u_char *)(tcp + tp.th_off * 4);
+        u_char *tcp_data = ((u_char *) tcp) + tp.th_off * 4;
The above does not seem to change much the meaning; can you please explain why you believe it's better this way?

-       theSession->l7.major_proto = IPOQUE_MAX_SUPPORTED_PROTOCOLS + rc;
+       theSession->l7.major_proto = rc;
As for the second patch, as soon as I have some time, I believe I should completely remove from ntop the
support of extra protocols based on ports, and move it to nDPI.

The license is kind of hard for me as I am not an expert. Highcharts are distributed with
http://creativecommons.org/licenses/by-nc/3.0/ that I believe it's good. If you don't like it for
Debian packages, then I need to find an alternative as ntop without charts is not a good idea. What other
alternatives shall I look at, that are compatible with Debian packages?

Thanks Luca

On Mar 4, 2012, at 6:13 AM, Ludovico Cavedon wrote:

> Hi,
> 
> On Mon, Feb 20, 2012 at 4:47 AM, Luca Deri <deri <at> ntop.org> wrote:
>> http://sourceforge.net/projects/ntop/files/ntop/Stable/ntop-4.1.99-rc0.tar.gz/download
>> you can find the first release candidate code for ntop. I would like you to
> 
(Continue reading)

svn-commit | 4 Mar 2012 11:00

r5219 - in trunk/PF_RING/userland/snort/pfring-daq-module: . m4

Author: deri
Date: 2012-03-04 11:00:22 +0100 (Sun, 04 Mar 2012)
New Revision: 5219

Modified:
   trunk/PF_RING/userland/snort/pfring-daq-module/README.1st
   trunk/PF_RING/userland/snort/pfring-daq-module/configure.ac
   trunk/PF_RING/userland/snort/pfring-daq-module/daq_pfring.c
   trunk/PF_RING/userland/snort/pfring-daq-module/m4/libtool.m4
   trunk/PF_RING/userland/snort/pfring-daq-module/m4/ltoptions.m4
   trunk/PF_RING/userland/snort/pfring-daq-module/m4/ltversion.m4
   trunk/PF_RING/userland/snort/pfring-daq-module/m4/lt~obsolete.m4
Log:
- Added "no-kernel-filters" option for avoid setting PF_RING kernel filters automatically
- Added ability to purge periodically idle (i.e. with no matching packets for at least 1 hour) filtering rules
- Enhanced README file with examples of usage of advanced PF_RING DAQ options
svn-commit | 4 Mar 2012 18:36

r5220 - trunk/ntop

Author: deri
Date: 2012-03-04 18:36:21 +0100 (Sun, 04 Mar 2012)
New Revision: 5220

Modified:
   trunk/ntop/globals-core.c
   trunk/ntop/globals-core.h
   trunk/ntop/globals-structtypes.h
   trunk/ntop/hash.c
   trunk/ntop/initialize.c
   trunk/ntop/sessions.c
Log:
l7 protocol detection is now per-device
svn-commit | 4 Mar 2012 18:59

r5221 - trunk/ntop

Author: deri
Date: 2012-03-04 18:59:08 +0100 (Sun, 04 Mar 2012)
New Revision: 5221

Modified:
   trunk/ntop/globals-core.c
   trunk/ntop/globals-structtypes.h
   trunk/ntop/ip.c
   trunk/ntop/sessions.c
   trunk/ntop/util.c
Log:
Added mutex for l7 detection

Gmane