headers
Chuck Lever | 1 Dec 2007 01:00
Picon
Favicon

Re: [RFC,PATCH 36/38] svc: Add svc API that queries for a transport instance

On Nov 29, 2007, at 5:41 PM, Tom Tucker wrote:
> Add a new svc function that allows a service to query whether a
> transport instance has already been created. This is used in lockd
> to determine whether or not a transport needs to be created when
> a lockd instance is brought up.
>
> Specifying 0 for the address family or port is effectively a wild- 
> card,
> and will result in matching the first transport in the service's list
> that has a matching class name.

Suggestion: this paragraph ^^^ would be good documentation to add to  
the block comment in front of svc_find_xprt().

> Signed-off-by: Tom Tucker <tom@...>
> ---
>
>  fs/lockd/svc.c                  |   16 ++--------------
>  include/linux/sunrpc/svc_xprt.h |    2 ++
>  net/sunrpc/svc_xprt.c           |   31 ++++++++++++++++++++++++++++ 
> +++
>  3 files changed, 35 insertions(+), 14 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index a8e79a9..470af01 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
>  <at>  <at>  -219,18 +219,6  <at>  <at>  lockd(struct svc_rqst *rqstp)
>  	module_put_and_exit(0);
>  }
(Continue reading)

Permalink | Reply | 0 comments |
headers
Roger Willcocks | 1 Dec 2007 12:36
Picon
Favicon

Re: [NFS] nfsd bug: create file with specific uid/gid

J. Bruce Fields wrote:

> On Fri, Nov 30, 2007 at 05:06:03PM +0000, Roger Willcocks wrote:
>> nfsd/vfs.c:nfsd_create (the v2 version of create) says:
>>
>> "Set file attributes. Mode has already been set and
>> setting uid/gid works only for root"
>>
>> but it doesn't actually test for root-ness
...
> Assignments (especially with things like &=) inside of conditionals
> always make my head hurt for some reason.  So maybe something like the
> below?

The patch looks fine to me, note that nfsd_create_v3 needs fixing too.

>
> Thanks for the bug report!  (And, by the way, how did you run across
> this?)
>

I'm working on an NFSp-like server for our clustered file system and my data 
file creates were not working as expected.

--
Roger

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kamalesh Babulal | 2 Dec 2007 16:55
Picon

Re: [NFS] [BUG] 2.6.24-rc3-mm2 kernel bug on nfs & cifs mounted partitions

Jan Kara wrote:
> On Thu 29-11-07 17:27:08, Kamalesh Babulal wrote:
>> Andrew Morton wrote:
>>> On Thu, 29 Nov 2007 14:30:14 +0530 Kamalesh Babulal
<kamalesh@...> wrote:
>>>
>>>> Hi Andrew,
>>>>
>>>> While running file system stress on nfs and cifs mounted partitions, the machine
>>>> drops to xmon
>>>>
>>>> 1:mon> e
>>>> cpu 0x1: Vector: 300 (Data Access) at [c000000080a9f880]
>>>>     pc: c0000000001392c8: .inotify_inode_queue_event+0x50/0x158
>>>>     lr: c0000000001074d0: .vfs_link+0x204/0x298
>>>>     sp: c000000080a9fb00
>>>>    msr: 8000000000009032
>>>>    dar: 280 
>>>>  dsisr: 40010000
>>>>   current = 0xc0000000c8e6f670
>>>>   paca    = 0xc000000000512c00
>>>>     pid   = 2848, comm = fsstress
>>>> 1:mon> t
>>>> [c000000080a9fbd0] c0000000001074d0 .vfs_link+0x204/0x298
>>>> [c000000080a9fc70] c00000000010b6e0 .sys_linkat+0x134/0x1b4
>>>> [c000000080a9fe30] c00000000000872c syscall_exit+0x0/0x40
>>>> --- Exception: c00 (System Call) at 000000000ff1bdfc
>>>> SP (ffeaed10) is in userspace
>>>> 1:mon> r
>>>> R00 = c0000000001074d0   R16 = 0000000000000000
(Continue reading)

Permalink | Reply | 0 comments |
headers
Neil Brown | 3 Dec 2007 02:26
X-Face
Picon
Gravatar

linux-nfs@...


This is just a gentle reminder to all those who are still subscribed
to 
   nfs@...
to please remove that subscription and subscribe to
linux-nfs@... instead.

To subscribe, send an email to

   majordomo@...
with
   subscribe linux-nfs

in the body of the message.

Current nfs@... subscriptions:
    595

Current linux-nfs@... subscriptions:
     66

We have a way to go yet....

Thanks,
NeilBrown

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
(Continue reading)

Permalink | Reply | 0 comments |
headers
J. Bruce Fields | 3 Dec 2007 17:17

Re: [NFS] nfsd bug: create file with specific uid/gid

On Sat, Dec 01, 2007 at 11:36:18AM -0000, Roger Willcocks wrote:
> J. Bruce Fields wrote:
>
>> On Fri, Nov 30, 2007 at 05:06:03PM +0000, Roger Willcocks wrote:
>>> nfsd/vfs.c:nfsd_create (the v2 version of create) says:
>>>
>>> "Set file attributes. Mode has already been set and
>>> setting uid/gid works only for root"
>>>
>>> but it doesn't actually test for root-ness
> ...
>> Assignments (especially with things like &=) inside of conditionals
>> always make my head hurt for some reason.  So maybe something like the
>> below?
>
> The patch looks fine to me, note that nfsd_create_v3 needs fixing too.

Whoops.  OK, in that case we should be call the same logic from both
places.  New (compile-tested only) patch appended.

>> Thanks for the bug report!  (And, by the way, how did you run across
>> this?)
>>
>
> I'm working on an NFSp-like server for our clustered file system and my 
> data file creates were not working as expected.

OK, thanks.  (Might be interesting to hear more about the architecture
if there's a description published someplace.)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chuck Lever | 3 Dec 2007 17:44
Picon
Favicon

Re: [RFC,PATCH 34/38] svc: Add /proc/sys/sunrpc/transport files

On Nov 29, 2007, at 5:41 PM, Tom Tucker wrote:
> Add a file that when read lists the set of registered svc
> transports.
>
> Signed-off-by: Tom Tucker <tom@...>
> ---
>
>  include/linux/sunrpc/svc_xprt.h |    2 ++
>  net/sunrpc/svc_xprt.c           |   28 ++++++++++++++++++++++++++++
>  net/sunrpc/sysctl.c             |   31 ++++++++++++++++++++++++++++ 
> +++
>  3 files changed, 61 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/sunrpc/svc_xprt.h b/include/linux/sunrpc/ 
> svc_xprt.h
> index 36f8b09..c2fa41d 100644
> --- a/include/linux/sunrpc/svc_xprt.h
> +++ b/include/linux/sunrpc/svc_xprt.h
>  <at>  <at>  -79,11 +79,13  <at>  <at>  void	svc_xprt_copy_addrs(struct svc_rqst  
> *rqstp, struct svc_xprt *xprt);
>  void	svc_xprt_enqueue(struct svc_xprt *xprt);
>  int	svc_port_is_privileged(struct sockaddr *sin);
>  void	svc_delete_xprt(struct svc_xprt *xprt);
> +int	svc_print_xprts(char *buf, int maxlen);
>
>  static inline void svc_xprt_get(struct svc_xprt *xprt)
>  {
>  	kref_get(&xprt->xpt_ref);
>  }
> +
(Continue reading)

Permalink | Reply | 6 comments |
headers
J. Bruce Fields | 3 Dec 2007 17:58

Re: [RFC,PATCH 34/38] svc: Add /proc/sys/sunrpc/transport files

On Mon, Dec 03, 2007 at 11:44:15AM -0500, Chuck Lever wrote:
> One last one, then I will crawl back into my hole.

By the way, based on who I recall making a lot of comments, I'm planning
on just adding:

	Acked-by: Neil Brown <neilb@...>
	Reviewed-by: Chuck Lever <chuck.lever@...>
	Reviewed-by: Greg Banks <gnb@...>

to all of the server transport-switch and rdma patches.  Does that sound
right?

And I'm assuming there are no objections to submitting this come the
next merge window.

--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 5 comments |
headers
Chuck Lever | 3 Dec 2007 18:00
Picon
Favicon

Re: [RFC,PATCH 7/8] rdma: makefile

On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> Add the NFSD_RDMA module to the sunrpc makefile.

General question about how the RPC level RDMA code is organized:  The  
client-side RDMA service provider lives in its own subdirectory of  
net/sunrpc.  Should the server side provider also live in that  
directory?  Should these two be glued together into a single module?

> Signed-off-by: Tom Tucker <tom@...>
> ---
>
>  net/sunrpc/Makefile |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> index 92e1dbe..6d03dbf 100644
> --- a/net/sunrpc/Makefile
> +++ b/net/sunrpc/Makefile
>  <at>  <at>  -15,3 +15,7  <at>  <at>  sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o  
> sched.o \
>  	    svc_xprt.o
>  sunrpc-$(CONFIG_PROC_FS) += stats.o
>  sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> +
> +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> +	svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o

--
Chuck Lever
(Continue reading)

Permalink | Reply | 3 comments |
headers
Chuck Lever | 3 Dec 2007 18:08
Picon
Favicon

Re: [RFC,PATCH 7/8] rdma: makefile (second thread)

On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> Add the NFSD_RDMA module to the sunrpc makefile.
>
> Signed-off-by: Tom Tucker <tom@...>
> ---
>
>  net/sunrpc/Makefile |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> index 92e1dbe..6d03dbf 100644
> --- a/net/sunrpc/Makefile
> +++ b/net/sunrpc/Makefile
>  <at>  <at>  -15,3 +15,7  <at>  <at>  sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o  
> sched.o \
>  	    svc_xprt.o
>  sunrpc-$(CONFIG_PROC_FS) += stats.o
>  sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> +
> +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> +	svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o

Maybe it would be better to enable server-side RPC RDMA provider  
support with a separate config option, like the client side does it,  
then build the NFS server dependency on that, instead of adding it  
here in the RPC makefile.

If the client-side and server-side providers are merged, then they  
could both be enabled via CONFIG_SUNRPC_XPRT_RDMA.
(Continue reading)

Permalink | Reply | 6 comments |
headers
Tom Tucker | 3 Dec 2007 18:24

Re: [RFC,PATCH 7/8] rdma: makefile

I don't know that it adds much, but perhaps for consistency? In fact, if
we were to move it, would we move it to the same directory as the
client?

On Mon, 2007-12-03 at 12:00 -0500, Chuck Lever wrote:
> On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> > Add the NFSD_RDMA module to the sunrpc makefile.
> 
> General question about how the RPC level RDMA code is organized:  The  
> client-side RDMA service provider lives in its own subdirectory of  
> net/sunrpc.  Should the server side provider also live in that  
> directory?  Should these two be glued together into a single module?
> 
> > Signed-off-by: Tom Tucker <tom@...>
> > ---
> >
> >  net/sunrpc/Makefile |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> > index 92e1dbe..6d03dbf 100644
> > --- a/net/sunrpc/Makefile
> > +++ b/net/sunrpc/Makefile
> >  <at>  <at>  -15,3 +15,7  <at>  <at>  sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o  
> > sched.o \
> >  	    svc_xprt.o
> >  sunrpc-$(CONFIG_PROC_FS) += stats.o
> >  sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> > +
> > +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
(Continue reading)

Permalink | Reply | 1 comment |

Gmane