Use and development of the Network File System (NFS) components of Linux ()

Boaz Harrosh | 25 May 12:12

BUG: At key_instantiate_and_link+0x2e/0xa0

I got the below on a 3.4-rc7 based Benny's pnfs tree.

During normal nfs4 only operations. (Just my development trees mounted on client machine)

If it will happen again I will investigate. I'll leave it off for now (busy with other stuff)

Just wanted to know if it might have already been fix or seen by someone else

[ 3830.441139] BUG: unable to handle kernel NULL pointer dereference at 0000000000000078
[ 3830.442024] IP: [<ffffffff812894ce>] key_instantiate_and_link+0x2e/0xa0
[ 3830.442024] PGD 0 
[ 3830.442024] Oops: 0000 [#1] SMP 
[ 3830.442024] CPU 1 
[ 3830.442024] Modules linked in: osd libosd nfsd nfs lockd fscache auth_rpcgss nfs_acl sunrpc
ip6t_REJECT be2iscsi nf_conntrack_ipv6 nf_defrag_ipv6 iscsi_boot_sysfs xt_state bnx2i
nf_conntrack cnic uio cxgb3i libcxgbi cxgb3 mdio ip6table_filter ib_iser rdma_cm ib_cm iw_cm ib_sa
ib_mad ib_core ib_addr ip6_tables iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi joydev
virtio_balloon i2c_piix4 i2c_core pcspkr virtio_net microcode floppy virtio_blk [last unloaded: libosd]
[ 3830.442024] 
[ 3830.442024] Pid: 1288, comm: rpc.idmapd Not tainted 3.4.0-rc7-pnfs+ #50 Bochs Bochs
[ 3830.442024] RIP: 0010:[<ffffffff812894ce>]  [<ffffffff812894ce>] key_instantiate_and_link+0x2e/0xa0
[ 3830.442024] RSP: 0018:ffff88003a327d98  EFLAGS: 00010286
[ 3830.442024] RAX: 0000000000000002 RBX: 0000000000000000 RCX: ffff8800378579c0
[ 3830.442024] RDX: 0000000000000003 RSI: ffff88003a327e75 RDI: 0000000000000000
[ 3830.442024] RBP: ffff88003a327dd8 R08: ffff88003a26a9c0 R09: 000000000000fffd
[ 3830.442024] R10: 000000000000000a R11: 0000000000000246 R12: ffff8800378579c0
[ 3830.442024] R13: 0000000000000003 R14: ffff88003a327e75 R15: ffff88003a26a9c0
[ 3830.442024] FS:  00007f8c539d1720(0000) GS:ffff88003e500000(0000) knlGS:0000000000000000
[ 3830.442024] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 3830.442024] CR2: 0000000000000078 CR3: 00000000379fe000 CR4: 00000000000006e0

(Continue reading)

Michael Tokarev | 25 May 08:53

Picon

3.0+ NFS issues

Hello.

I updated my nfs server machine to kernel 3.0, and
noticed that its main usage become, well, problematic.

While trying to dig deeper, I also found a few other
interesting issues, which are mentioned below.

But first thing first: nfs.

i686pae kernel, lots of RAM, Atom-based (cedar trail)
machine with usual rtl8169 NIC.  3.0 or 3.2 kernel
(I will try current 3.4 but I don't have much hopes
there).  NFSv4.

When a client machine (also 3.0 kernel) does some reading,
the process often stalls somewhere in the read syscall,
or, rarer, during close, for up to two MINUTES.  During
this time, the client (kernel) reports "NFS server <foo>
does not respond" several times, and finally "NFS server
<foo> ok", client process "unstucks" from the read(2),
and is able to perform a few more reads till the whole
thing repeats.

While this happens, ie, while the client process is stuck,
any access to the mounted filesystem results in an
uninterruptible sleep - all processes including the
initial client are unkillable.  This is very annoying,
but I was never able to fix this, including the real
case when the server becomes unreachable - "intr" mount

(Continue reading)

Weston Andros Adamson | 24 May 23:19

Picon

[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation

This patch adds the BIND_CONN_TO_SESSION operation which is needed for
upcoming SP4_MACH_CRED work and useful for recovering from broken connections
without destroying the session.

Signed-off-by: Weston Andros Adamson <dros@...>
---
Updated with comment from Trond

 fs/nfs/nfs4_fs.h        |    1 +
 fs/nfs/nfs4proc.c       |   54 ++++++++++++++++++++++++++
 fs/nfs/nfs4xdr.c        |   95 +++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/nfs4.h    |    5 ++
 include/linux/nfs_xdr.h |    6 +++
 5 files changed, 161 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index edeef71..ad90bc7 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -215,6 +215,7 @@ struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *,
 extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct
nfs4_setclientid_res *);
 extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct nfs4_setclientid_res *arg,
struct rpc_cred *);
 extern int nfs4_proc_get_rootfh(struct nfs_server *, struct nfs_fh *, struct nfs_fsinfo *);
+extern int nfs4_proc_bind_conn_to_session(struct nfs_client *);
 extern int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred);
 extern int nfs4_init_clientid(struct nfs_client *, struct rpc_cred *);
 extern int nfs41_init_clientid(struct nfs_client *, struct rpc_cred *);
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c

(Continue reading)

Weston Andros Adamson | 24 May 21:42

Picon

[PATCH 1/2] nfsd: add fault injection for CB_PATH_DOWN

This fault injection hook causes all SEQUENCE operation replies to have the
SEQ4_STATUS_CB_PATH_DOWN flag set until the client calls BIND_CONN_TO_SESSION
or creates a new session.

Signed-off-by: Weston Andros Adamson <dros@...>
---
 fs/nfsd/fault_inject.c |    4 ++++
 fs/nfsd/fault_inject.h |    2 ++
 fs/nfsd/nfs4state.c    |   20 ++++++++++++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
index e6c3815..ab81144 100644
--- a/fs/nfsd/fault_inject.c
+++ b/fs/nfsd/fault_inject.c
@@ -38,6 +38,10 @@ static struct nfsd_fault_inject_op inject_ops[] = {
 		.file   = "recall_delegations",
 		.func   = nfsd_recall_delegations,
 	},
+	{
+		.file   = "kill_backchannel",
+		.func   = nfsd_kill_backchannel,
+	},
 };

 static long int NUM_INJECT_OPS = sizeof(inject_ops) / sizeof(struct nfsd_fault_inject_op);
diff --git a/fs/nfsd/fault_inject.h b/fs/nfsd/fault_inject.h
index 90bd057..b058e03 100644
--- a/fs/nfsd/fault_inject.h
+++ b/fs/nfsd/fault_inject.h

(Continue reading)

Chuck Lever | 24 May 21:29

Picon

[PATCH] NFSD: TEST_STATEID should not return NFS4ERR_STALE_STATEID

The error values that TEST_STATEID is allowed to return does not
include NFS4ERR_STALE_STATEID.  In addition, RFC 5661 says:

15.1.16.5.  NFS4ERR_STALE_STATEID (Error Code 10023)

   A stateid generated by an earlier server instance was used.  This
   error is moot in NFSv4.1 because all operations that take a stateid
   MUST be preceded by the SEQUENCE operation, and the earlier server
   instance is detected by the session infrastructure that supports
   SEQUENCE.

I triggered the NFS4ERR_STALE_STATEID during nograce recovery testing.
My client had updated its boot verifier, so the server instance hadn't
changed, but the client instance had.  Thus the server allowed the
SEQUENCE operation, but returned NFS4ERR_STALE_STATEID on the
TEST_STATEID operation.

After a client's lease expires, TEST_STATEID should report
NFS4ERR_EXPIRED for state IDs that the client tries to recover.  I
don't see a way to make that happen, though.

Finally, RFC 5661, section 18.48.3 has this:

 o  Special stateids are always considered invalid (they result in the
    error code NFS4ERR_BAD_STATEID).

Signed-off-by: Chuck Lever <chuck.lever@...>
---

Bruce, would you consider taking something like this?

(Continue reading)

Weston Andros Adamson | 24 May 19:22

Picon

[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation

This patch adds the BIND_CONN_TO_SESSION operation which is needed for
upcoming SP4_MACH_CRED work and useful for recovering from broken connections
without destroying the session.

Signed-off-by: Weston Andros Adamson <dros@...>
---
Reposted with changes addressing Chuck's comments.

 fs/nfs/nfs4_fs.h        |    1 +
 fs/nfs/nfs4proc.c       |   54 ++++++++++++++++++++++++++
 fs/nfs/nfs4xdr.c        |   95 +++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/nfs4.h    |    5 ++
 include/linux/nfs_xdr.h |    6 +++
 5 files changed, 161 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index edeef71..ad90bc7 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -215,6 +215,7 @@ struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *,
 extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct
nfs4_setclientid_res *);
 extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct nfs4_setclientid_res *arg,
struct rpc_cred *);
 extern int nfs4_proc_get_rootfh(struct nfs_server *, struct nfs_fh *, struct nfs_fsinfo *);
+extern int nfs4_proc_bind_conn_to_session(struct nfs_client *);
 extern int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred);
 extern int nfs4_init_clientid(struct nfs_client *, struct rpc_cred *);
 extern int nfs41_init_clientid(struct nfs_client *, struct rpc_cred *);
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c

(Continue reading)

andros | 24 May 19:13

Picon

[PATCH 0/4] NFSv4.1 add nfs_inode book keeping for mdsthreshold

From: Andy Adamson <andros@...>

Only resending NFSv4.1 add nfs_inode book keeping for mdsthreshold. 
Responded to Trond's comments.
I have not tested the directio nor the memmap io cases. The regular file
i/o works as intended.

Andy Adamson (4):
  NFSv4.1 mdsthreshold attribute xdr
  NFSv4.1 cache mdsthreshold values on OPEN
  NFSv4.1 add nfs_inode book keeping for mdsthreshold
  NFSv4.1 test the mdsthreshold hint parameters

 fs/nfs/direct.c         |    2 +
 fs/nfs/file.c           |    1 +
 fs/nfs/inode.c          |    4 ++
 fs/nfs/nfs4proc.c       |   38 ++++++++++++--
 fs/nfs/nfs4xdr.c        |  125 ++++++++++++++++++++++++++++++++++++++++++++++-
 fs/nfs/pnfs.c           |   94 +++++++++++++++++++++++++++++++++++
 fs/nfs/pnfs.h           |   21 ++++++++
 fs/nfs/read.c           |    2 +
 include/linux/nfs4.h    |    7 +++
 include/linux/nfs_fs.h  |    4 ++
 include/linux/nfs_xdr.h |   10 ++++
 11 files changed, 301 insertions(+), 7 deletions(-)

--

-- 
1.7.7.6

--

(Continue reading)

Weston Andros Adamson | 24 May 18:26

Picon

[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation

This patch adds the BIND_CONN_TO_SESSION operation which is needed for
upcoming SP4_MACH_CRED work and useful for recovering from broken connections
without destroying the session.

Signed-off-by: Weston Andros Adamson <dros@...>
---
 fs/nfs/nfs4_fs.h        |    1 +
 fs/nfs/nfs4proc.c       |   54 ++++++++++++++++++++++++++++
 fs/nfs/nfs4xdr.c        |   90 +++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/nfs4.h    |    5 +++
 include/linux/nfs_xdr.h |    6 +++
 5 files changed, 156 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index edeef71..ad90bc7 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -215,6 +215,7 @@ struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *,
 extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct
nfs4_setclientid_res *);
 extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct nfs4_setclientid_res *arg,
struct rpc_cred *);
 extern int nfs4_proc_get_rootfh(struct nfs_server *, struct nfs_fh *, struct nfs_fsinfo *);
+extern int nfs4_proc_bind_conn_to_session(struct nfs_client *);
 extern int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred);
 extern int nfs4_init_clientid(struct nfs_client *, struct rpc_cred *);
 extern int nfs41_init_clientid(struct nfs_client *, struct rpc_cred *);
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 78784e5..7a4b320 100644
--- a/fs/nfs/nfs4proc.c

(Continue reading)

Steve Dickson | 24 May 12:56

Picon

Linux pNFS status meeting 05/24/12

Time: 9:30 AM PST (12:30 PM EST)

The call in numbers are:
U.S. and Canada: (800) 451-8679
International dial-in number: (212) 729-5016
Israel Toll-Free: 1-809-462-557
Conference code: 564.272.1552
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Stanislav Kinsbursky | 24 May 12:15

[PATCH v2] NFSd: set nfsd_serv to NULL after service destruction

v2:
1) Set global nfsd_serv pointer to NULL only if no running threads left.

Otherwise we will get NULL pointer dereference.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@...>
---
 fs/nfsd/nfsctl.c |    8 ++------
 fs/nfsd/nfsd.h   |   11 +++++++++++
 fs/nfsd/nfssvc.c |   24 ++++++++----------------
 3 files changed, 21 insertions(+), 22 deletions(-)

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index c55298e..fa49cff 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -673,9 +673,7 @@ static ssize_t __write_ports_addfd(char *buf)

 	err = svc_addsock(nfsd_serv, fd, buf, SIMPLE_TRANSACTION_LIMIT);
 	if (err < 0) {
-		if (nfsd_serv->sv_nrthreads == 1)
-			svc_shutdown_net(nfsd_serv, net);
-		svc_destroy(nfsd_serv);
+		nfsd_destroy(net);
 		return err;
 	}

@@ -744,9 +742,7 @@ out_close:
 		svc_xprt_put(xprt);
 	}

(Continue reading)

Boaz Harrosh | 24 May 02:16

Does our Kernel PNFSD-Server supports recurring layout_get with open_state_id


Benny hi

If I remember/understand correctly, there is a mode in the RFC errata
about the layout forgetful-model and a client sending a layout_get with
an open_state_id after he already had previous state (layouts) on the file.

As I understood this is an indication to the server that client has
"forgotten" all it's layouts on a file, and Server can assume their
return.

Is my understanding correct?

If Yes:
	Did we implement the internal return of all layouts, if above
	open_state_id is encountered?
	I thought we did but I can't find this code.

Currently, I always set ROC so there is no leak. But theoretically
ROC does not have to be set. I'm doing some heavy lifting of
layout_return, and I want to make sure I have not missed a spot.

If I'm correct that it is needed, and it's missing:
My suggestion for now is that we always set ROC, disregarding FS so not to
leak layouts and therefor inode-refs, until such time that we implement it.

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in

(Continue reading)

Group

gmane.linux.nfs.

Project Web Page

Use and development of the Network File System (NFS) components of Linux ()

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11

May 2012

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

BUG: At key_instantiate_and_link+0x2e/0xa0 (25 May 12:12)
3.0+ NFS issues (25 May 08:53)
[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation (24 May 23:19)
[PATCH 1/2] nfsd: add fault injection for CB_PATH_DOWN (24 May 21:42)
[PATCH] NFSD: TEST_STATEID should not return NFS4ERR_STALE_STATEID (24 May 21:29)
[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation (24 May 19:22)
[PATCH 0/4] NFSv4.1 add nfs_inode book keeping for mdsthreshold (24 May 19:13)
[PATCH 1/2] nfs4.1: add BIND_CONN_TO_SESSION operation (24 May 18:26)
Linux pNFS status meeting 05/24/12 (24 May 12:56)
[PATCH v2] NFSd: set nfsd_serv to NULL after service destruction (24 May 12:15)
Does our Kernel PNFSD-Server supports recurring layout_get with open_s (24 May 02:16)
mainly setclientid/confirm cleanup (23 May 23:40)
[PATCH 1/3] NFSv4.1: Fix session initialisation races (23 May 19:32)
[PATCH 1/4] NFSv4.1 mdsthreshold attribute xdr (23 May 11:02)
[PATCH] nfsidmap: Allow verbosity level to be set in the config file. (22 May 21:38)
Help with NFS over 10GbE performance - possible NFS client to TCP bott (22 May 18:21)
[PATCH 1/4] NFSv4.1 just use nfs_put_client in filelayout release (22 May 14:09)
[PATCH v2 00/15] vfs: add the ability to retry on ESTALE to several sy (22 May 16:12)
[PATCH v2] NFS: Fix compiler warnings (22 May 16:10)
[PATCH] NFS: init client before declaration (22 May 14:40)
[PATCH v4] statd: drop all capabilities from the bounding set as well (22 May 12:41)

Archives

645	May 2012
729	April 2012
871	March 2012
657	February 2012
543	January 2012
518	December 2011
625	November 2011
408	October 2011
596	September 2011
537	August 2011
659	July 2011
828	June 2011
757	May 2011
410	April 2011
631	March 2011
529	February 2011
557	January 2011
703	December 2010
526	November 2010
704	October 2010
894	September 2010
691	August 2010
526	July 2010
680	June 2010
623	May 2010
508	April 2010
392	March 2010
351	February 2010
493	January 2010
370	December 2009
328	November 2009
274	October 2009
439	September 2009
655	August 2009
242	July 2009
716	June 2009
484	May 2009
866	April 2009
868	March 2009
262	February 2009
497	January 2009
494	December 2008
542	November 2008
470	October 2008
448	September 2008
445	August 2008
345	July 2008
650	June 2008
470	May 2008
541	April 2008
356	March 2008
483	February 2008
781	January 2008
382	December 2007
571	November 2007
551	October 2007
594	September 2007
610	August 2007
454	July 2007
234	June 2007
442	May 2007
395	April 2007
429	March 2007
246	February 2007
223	January 2007
251	December 2006
319	November 2006
274	October 2006
180	September 2006
292	August 2006
350	July 2006
227	June 2006
154	May 2006
173	April 2006
175	March 2006
149	February 2006
151	January 2006
175	December 2005
146	November 2005
176	October 2005
108	September 2005
77	August 2005
202	July 2005
179	June 2005
127	May 2005
151	April 2005
392	March 2005
213	February 2005
194	January 2005
194	December 2004
166	November 2004
176	October 2004
237	September 2004
244	August 2004
105	July 2004
136	June 2004
215	May 2004
180	April 2004
191	March 2004
231	February 2004
118	January 2004
109	December 2003
124	November 2003
133	October 2003
229	September 2003
175	August 2003
177	July 2003
214	June 2003
228	May 2003
150	April 2003
128	March 2003
146	February 2003
207	January 2003
108	December 2002
198	November 2002
367	October 2002
255	September 2002
303	August 2002
150	July 2002
93	June 2002
163	May 2002
192	April 2002
96	March 2002
2	December 1999

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template