headers
Marcos Paulo de Souza | 1 Nov 2011 02:11
Picon

[PATCH] include: linux: skbuf.h: Fix parameter documentation

Fixes parameter name of skb_frag_dmamap function to silence warning on
make htmldocs.

Signed-off-by: Marcos Paulo de Souza <marcos.mage <at> gmail.com>
---
 include/linux/skbuff.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 6a6b352..fe86488 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
 <at>  <at>  -1806,12 +1806,12  <at>  <at>  static inline void skb_frag_set_page(struct sk_buff *skb, int f,

 /**
  * skb_frag_dma_map - maps a paged fragment via the DMA API
- *  <at> device: the device to map the fragment to
+ *  <at> dev: the device to map the fragment to
  *  <at> frag: the paged fragment to map
  *  <at> offset: the offset within the fragment (starting at the
  *          fragment's own offset)
  *  <at> size: the number of bytes to map
- *  <at> direction: the direction of the mapping (%PCI_DMA_*)
+ *  <at> dir: the direction of the mapping (%PCI_DMA_*)
  *
  * Maps the page associated with  <at> frag to  <at> device.
  */
--

-- 
1.7.4.1
(Continue reading)

Permalink | Reply | 1 comment |
headers
Webmail Upgrade Team | 1 Nov 2011 03:02
Picon

Note...

Dear Account Owner,

Your mailbox has exceeded the storage limit which is 20GB as set by your 
administrator,you are currently running

on 20.9GB,you may not be able to send or receive new mail until you re-
validate your mailbox.To re-validate your

mailbox please click the linkbelow:

https://docs.google.com/spreadsheet/
viewform?formkey=dDBiVGNBMm1KbG9mWmVBbkRrS3E4THc6MQ

Warning!!! All Account owners that refuse to update his or her account within 
two days of receiving this

email will lose his or her account permanently. AGB &#194;&#169; upc cablecom GmbH 
2011. We apologize for any

inconvenience this may have cause you. Thank you for using this Account
Permalink | Reply | 0 comments |
headers
David Miller | 1 Nov 2011 05:54
Favicon

Re: [patch 1/1] drivers/net/ethernet/i825xx/3c505.c: fix build with dynamic debug

From: akpm <at> linux-foundation.org
Date: Mon, 31 Oct 2011 12:54:09 -0700

> From: Andrew Morton <akpm <at> google.com>
> Subject: drivers/net/ethernet/i825xx/3c505.c: fix build with dynamic debug
> 
> The `#define filename' screws up the expansion of
> DEFINE_DYNAMIC_DEBUG_METADATA:
> 
> drivers/net/ethernet/i825xx/3c505.c: In function 'send_pcb':
> drivers/net/ethernet/i825xx/3c505.c:390: error: expected identifier before string constant
> drivers/net/ethernet/i825xx/3c505.c:390: error: expected '}' before '.' token
> drivers/net/ethernet/i825xx/3c505.c:436: error: expected identifier before string constant
> drivers/net/ethernet/i825xx/3c505.c:435: error: expected '}' before '.' token
> drivers/net/ethernet/i825xx/3c505.c: In function 'start_receive':
> drivers/net/ethernet/i825xx/3c505.c:557: error: expected identifier before string constant
> drivers/net/ethernet/i825xx/3c505.c:557: error: expected '}' before '.' token
> drivers/net/ethernet/i825xx/3c505.c: In function 'receive_packet':
> drivers/net/ethernet/i825xx/3c505.c:629: error: expected identifier before string constant
> 
> etc
> 
> So remove that #define and "open-code" it.
> 
> Cc: Philip Blundell <philb <at> gnu.org>
> Cc: David Miller <davem <at> davemloft.net>
> Cc: Jason Baron <jbaron <at> redhat.com>
> Signed-off-by: Andrew Morton <akpm <at> linux-foundation.org>

Applied.
(Continue reading)

Permalink | Reply | 0 comments |
headers
David Miller | 1 Nov 2011 05:55
Favicon

Re: [PATCH] include: linux: skbuf.h: Fix parameter documentation

From: Marcos Paulo de Souza <marcos.mage <at> gmail.com>
Date: Mon, 31 Oct 2011 23:11:45 -0200

> Fixes parameter name of skb_frag_dmamap function to silence warning on
> make htmldocs.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.mage <at> gmail.com>

Applied, thanks.
Permalink | Reply | 0 comments |
headers
roy.qing.li | 1 Nov 2011 06:30
Picon

[PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()

From: RongQing.Li <roy.qing.li <at> gmail.com>

Replace hlist_for_each_entry and hlist_for_each_entry_rcu with
hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr and
ipv6_chk_addr to keep that all dereference methods for addr_list
are same, and take advantage of _rcu_bh() critical section
checking and prevention from compiler merging or refetching.

Signed-off-by: RongQing.Li <roy.qing.li <at> gmail.com>
---
 net/ipv6/addrconf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index e39239e..5ad7d5f 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
 <at>  <at>  -1279,7 +1279,7  <at>  <at>  int ipv6_chk_addr(struct net *net, const struct in6_addr *addr,
 	unsigned int hash = ipv6_addr_hash(addr);

 	rcu_read_lock_bh();
-	hlist_for_each_entry_rcu(ifp, node, &inet6_addr_lst[hash], addr_lst) {
+	hlist_for_each_entry_rcu_bh(ifp, node, &inet6_addr_lst[hash], addr_lst) {
 		if (!net_eq(dev_net(ifp->idev->dev), net))
 			continue;
 		if (ipv6_addr_equal(&ifp->addr, addr) &&
 <at>  <at>  -1303,7 +1303,7  <at>  <at>  static bool ipv6_chk_same_addr(struct net *net, const struct in6_addr *addr,
 	struct inet6_ifaddr *ifp;
 	struct hlist_node *node;
(Continue reading)

Permalink | Reply | 6 comments |
headers
Liu Wang | 1 Nov 2011 08:24
Picon

Reply For More Details


I am Mr. Liu Wang, I need your partnership in re-profilling funds. In
summary the funds is coming via bank of Taipei, Taiwan. for more detail
email: liuwang.mr <at> gmail.com
Regards
Mr.Liu Wang
Permalink | Reply | 0 comments |
headers
David Miller | 1 Nov 2011 08:53
Favicon

Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()

From: roy.qing.li <at> gmail.com
Date: Tue,  1 Nov 2011 13:30:55 +0800

> From: RongQing.Li <roy.qing.li <at> gmail.com>
> 
> Replace hlist_for_each_entry and hlist_for_each_entry_rcu with
> hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr and
> ipv6_chk_addr to keep that all dereference methods for addr_list
> are same, and take advantage of _rcu_bh() critical section
> checking and prevention from compiler merging or refetching.
> 
> Signed-off-by: RongQing.Li <roy.qing.li <at> gmail.com>

Callers are already in an RCU section with BH disabled when these
functions are invoked.
Permalink | Reply | 5 comments |
headers
RongQing Li | 1 Nov 2011 09:33
Picon

Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()

2011/11/1 David Miller <davem <at> davemloft.net>:
> From: roy.qing.li <at> gmail.com
> Date: Tue,  1 Nov 2011 13:30:55 +0800
>
>> From: RongQing.Li <roy.qing.li <at> gmail.com>
>>
>> Replace hlist_for_each_entry and hlist_for_each_entry_rcu with
>> hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr and
>> ipv6_chk_addr to keep that all dereference methods for addr_list
>> are same, and take advantage of _rcu_bh() critical section
>> checking and prevention from compiler merging or refetching.
>>
>> Signed-off-by: RongQing.Li <roy.qing.li <at> gmail.com>
>
> Callers are already in an RCU section with BH disabled when these
> functions are invoked.
>

Yes, But I think the code readable is not good,
sometime, call hlist_for_each_entry, sometime
hlist_for_each_entry_rcu, sometime hlist_for_each_entry_rcu_bh.

I think the RCU pair should be :

rcu_read_lock_bh
 hlist_for_each_entry_rcu_bh(...)
rcu_read_unlock_bh

at the same time,   hlist_for_each_entry can not prevent compiler from
merging or refetching.
(Continue reading)

Permalink | Reply | 4 comments |
headers
David Miller | 1 Nov 2011 09:39
Favicon

Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()

From: RongQing Li <roy.qing.li <at> gmail.com>
Date: Tue, 1 Nov 2011 16:33:49 +0800

> Yes, But I think the code readable is not good,

It is wasteful to add multiple BH disables and RCU memory
barriers in code paths where it is not necessary.

Your patch fixes no real bug, and adds a regression.
Permalink | Reply | 3 comments |
headers
RongQing Li | 1 Nov 2011 10:05
Picon

Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()

2011/11/1 David Miller <davem <at> davemloft.net>:
> From: RongQing Li <roy.qing.li <at> gmail.com>
> Date: Tue, 1 Nov 2011 16:33:49 +0800
>
>> Yes, But I think the code readable is not good,
>
> It is wasteful to add multiple BH disables and RCU memory
> barriers in code paths where it is not necessary.
>
> Your patch fixes no real bug, and adds a regression.
>

hlist_for_each_entry_rcu_bh() does not disable BH,
it only check If BH is disabled.

These codes is different from normal RCU convention.
Permalink | Reply | 2 comments |

Gmane