Linux network development

Jeff Kirsher | 1 Oct 2010 01:00

Picon

Re: [net-next-2.6 PATCH 2/3] e1000e: reset PHY after errors detected on 82574 Si

On Thu, Sep 30, 2010 at 00:39, Jeff Kirsher <jeffrey.t.kirsher <at> intel.com> wrote:
> From: Carolyn Wyborny <carolyn.wyborny <at> intel.com>
>
> Some errors can be induced in the PHY via environmental testing
> (specifically extreme temperature changes and electro static
> discharge testing), and in the case of the PHY hanging due to
> this input, this detects the problem and resets to continue.
> This issue only applies to 82574 silicon.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg <at> intel.com>
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny <at> intel.com>
> Tested-by: Jeff Pieper <jeffrey.e.pieper <at> intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>
> ---
>
>  drivers/net/e1000e/82571.c  |   40 +++++++++++++++++++++++++++++++++++++++-
>  drivers/net/e1000e/e1000.h  |    3 +++
>  drivers/net/e1000e/netdev.c |   25 +++++++++++++++++++++++++
>  3 files changed, 67 insertions(+), 1 deletions(-)
>

Dave - please ignore this patch.  An issue was found with this patch.

--

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Vasanthy Kolluri | 1 Oct 2010 01:34

Picon

[net-next-2.6 PATCH 0/3] enic: updates to version 1.4.1.2a

The following patch series implements enic driver updates:

1/3 - Remove dead code
2/3 - Make local functions static
3/3 - Update MAINTAINERS

Signed-off-by: Stephen Hemminger <shemminger <at> vyatta.com>
Signed-off-by: Vasanthy Kolluri <vkolluri <at> cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu <at> cisco.com>
Signed-off-by: David Wang <dwang2 <at> cisco.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Vasanthy Kolluri | 1 Oct 2010 01:35

Picon

[net-next-2.6 PATCH 1/3] enic: Remove dead code

From: Vasanthy Kolluri <vkolluri <at> cisco.com>

Removed code that is unused

Signed-off-by: Stephen Hemminger <shemminger <at> vyatta.com>
Signed-off-by: Vasanthy Kolluri <vkolluri <at> cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu <at> cisco.com>
Signed-off-by: David Wang <dwang2 <at> cisco.com>
---
 drivers/net/enic/enic.h      |    3 -
 drivers/net/enic/enic_res.c  |   17 -------
 drivers/net/enic/enic_res.h  |    2 -
 drivers/net/enic/vnic_dev.c  |  104 ------------------------------------------
 drivers/net/enic/vnic_dev.h  |   12 -----
 drivers/net/enic/vnic_intr.c |    5 --
 drivers/net/enic/vnic_rss.h  |   45 ------------------
 7 files changed, 1 insertions(+), 187 deletions(-)
 delete mode 100644 drivers/net/enic/vnic_rss.h

diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 75869ed..ae62320 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
 <at>  <at>  -28,11 +28,10  <at>  <at> 
 #include "vnic_intr.h"
 #include "vnic_stats.h"
 #include "vnic_nic.h"
-#include "vnic_rss.h"

 #define DRV_NAME		"enic"

(Continue reading)

Vasanthy Kolluri | 1 Oct 2010 01:35

Picon

[net-next-2.6 PATCH 2/3] enic: Make local functions static

From: Vasanthy Kolluri <vkolluri <at> cisco.com>

Make functions used locally in a file as static

Signed-off-by: Stephen Hemminger <shemminger <at> vyatta.com>
Signed-off-by: Vasanthy Kolluri <vkolluri <at> cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu <at> cisco.com>
Signed-off-by: David Wang <dwang2 <at> cisco.com>
---
 drivers/net/enic/enic_main.c |    6 +++---
 drivers/net/enic/vnic_dev.c  |   10 +++++-----
 drivers/net/enic/vnic_dev.h  |    7 -------
 drivers/net/enic/vnic_rq.c   |    2 +-
 drivers/net/enic/vnic_rq.h   |    4 ----
 drivers/net/enic/vnic_wq.c   |    2 +-
 drivers/net/enic/vnic_wq.h   |    4 ----
 7 files changed, 10 insertions(+), 25 deletions(-)

diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 711077a..a1f92f1 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
 <at>  <at>  -1972,7 +1972,7  <at>  <at>  static int enic_dev_hang_notify(struct enic *enic)
 	return err;
 }

-int enic_dev_set_ig_vlan_rewrite_mode(struct enic *enic)
+static int enic_dev_set_ig_vlan_rewrite_mode(struct enic *enic)
 {
 	int err;

(Continue reading)

Vasanthy Kolluri | 1 Oct 2010 01:36

Picon

[net-next-2.6 PATCH 3/3] enic: Update MAINTAINERS

From: Vasanthy Kolluri <vkolluri <at> cisco.com>

Update MAINTAINERS list

Signed-off-by: Vasanthy Kolluri <vkolluri <at> cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu <at> cisco.com>
Signed-off-by: David Wang <dwang2 <at> cisco.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3168d0c..9ddb5ac 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
 <at>  <at>  -1567,9 +1567,9  <at>  <at>  S:	Supported
 F:	scripts/checkpatch.pl

 CISCO VIC ETHERNET NIC DRIVER
-M:	Scott Feldman <scofeldm <at> cisco.com>
 M:	Vasanthy Kolluri <vkolluri <at> cisco.com>
 M:	Roopa Prabhu <roprabhu <at> cisco.com>
+M:	David Wang <dwang2 <at> cisco.com>
 S:	Supported
 F:	drivers/net/enic/
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org

(Continue reading)

Sami Farin | 1 Oct 2010 01:39

Picon

Re: [E1000-devel] Something wrong with tx/rx/sg/gso with dhclient etc (Was: Linux 2.6.35.6/e1000e does not receive replies from DHCP server, 2.6.33 works)

On Thu, Sep 30, 2010 at 12:44:17 +0300, Sami Farin wrote:
> On Wed, Sep 29, 2010 at 17:40:08 -0600, Tantilov, Emil S wrote:
> > Sami Farin wrote:
> > > False alarm, 2.6.35.6+latest git e1000e does not work any better.
> > > I was just lucky.
> > 
> > Is your `latest git` from Linus or net-next tree? 
> 
> Linus.
> 
> >All of our latest patches go into net-next, so if you haven't already - give it a try and see if it resolves
your issue.
> 
> Maybe later =)

I now tried net-next 6d0722a2cec2c23db3b0855ff8bb433175a16b44, it works fine,
with ethtool -K tx/rx on and off.
I used the same .config as with 2.6.35.6 (make oldconfig).
I retested 2.6.33.7, it's still okay.

And unfortunately 2.6.35.6 did not work very well after rebooting,
I had to waste a lot of time playing with -K tx off rx off, -K tx on rx on, etc.
Before it started working, eth0 had interrupts occurring only on CPU0.
CPU1 started getting some usage only after dhclient started working..
Probably irrelevant, but I am running out of ideas.
I have tried e1000e param IntMode 0, 1, 2, no luck.

--

-- 
Do what you love because life is too short for anything else.

(Continue reading)

David Miller | 1 Oct 2010 01:57

Re: [net-next-2.6 PATCH 2/3] e1000e: reset PHY after errors detected on 82574 Si

From: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>
Date: Thu, 30 Sep 2010 16:00:47 -0700

> Dave - please ignore this patch.  An issue was found with this patch.

Ok.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller | 1 Oct 2010 02:23

Re: [PATCH 1/2] net-next-2.6: SYN retransmits: Rename threshold variable


Damian please don't do things like this.

When we make a change in net-2.6, that change is going to propagate into
net-next-2.6 the next time I do a merge.

And in this case here, the addition of the "syn_set" boolean argument to
retransmits_timed_out() will happen at that point.

So if anything, you should build on top of the bug fix we put into
net-2.6 instead of duplicating the change.

Adding the same change in two different ways to net-2.6 and net-next-2.6
makes the merge a pain in the neck for me and just makes things look
real confusing.

I'm not applying these two patches, please ask me to merge net-2.6 into
net-next-2.6 and this way you can code them relative to that.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David L Stevens | 1 Oct 2010 02:29

Picon

[PATCH] correct IGMP behavior on v3 query during v2-compatibility mode

A recent patch to allow IGMPv2 responses to IGMPv3 queries
bypasses length checks for valid query lengths, incorrectly
resets the v2_seen timer, and does not support IGMPv1.

The following patch responds with a v2 report as required
by IGMPv2 while correcting the other problems introduced
by the patch.

Signed-Off-By: David L Stevens <dlstevens <at> us.ibm.com>

--- linux-2.6.36-rc5/net/ipv4/igmp.c	2010-09-20 16:56:53.000000000 -0700
+++ linux-2.6.36-rc5-dls/net/ipv4/igmp.c	2010-09-28 12:09:03.000000000 -0700
 <at>  <at>  -834,7 +834,7  <at>  <at>  static void igmp_heard_query(struct in_d
 	int			mark = 0;

 
-	if (len == 8 || IGMP_V2_SEEN(in_dev)) {
+	if (len == 8) {
 		if (ih->code == 0) {
 			/* Alas, old v1 router presents here. */

 <at>  <at>  -856,6 +856,18  <at>  <at>  static void igmp_heard_query(struct in_d
 		igmpv3_clear_delrec(in_dev);
 	} else if (len < 12) {
 		return;	/* ignore bogus packet; freed by caller */
+	} else if (IGMP_V1_SEEN(in_dev)) {
+		/* This is a v3 query with v1 queriers present */
+		max_delay = IGMP_Query_Response_Interval;
+		group = 0;
+	} else if (IGMP_V2_SEEN(in_dev)) {

(Continue reading)

Tilman Schmidt | 1 Oct 2010 01:34

[PATCH 2/9] isdn/gigaset: fix bas_gigaset AT read error handling

Rework the handling of USB errors in AT response reads
to fix a possible infinite retry loop and a memory leak,
and silence a few overly verbose kernel messages.

Signed-off-by: Tilman Schmidt <tilman <at> imap.cc>
CC: stable <stable <at> kernel.org>
---
 drivers/isdn/gigaset/bas-gigaset.c |   83 ++++++++++++++---------------------
 1 files changed, 33 insertions(+), 50 deletions(-)

diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index e143050..131976d 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
 <at>  <at>  -438,23 +438,27  <at>  <at>  static void cmd_in_timeout(unsigned long data)
 		return;
 	}

-	if (ucs->retry_cmd_in++ < BAS_RETRY) {
-		dev_notice(cs->dev, "control read: timeout, retry %d\n",
-			   ucs->retry_cmd_in);
-		rc = atread_submit(cs, BAS_TIMEOUT);
-		if (rc >= 0 || rc == -ENODEV)
-			/* resubmitted or disconnected */
-			/* - bypass regular exit block */
-			return;
-	} else {
+	if (ucs->retry_cmd_in++ >= BAS_RETRY) {
 		dev_err(cs->dev,
 			"control read: timeout, giving up after %d tries\n",

(Continue reading)

Group

gmane.linux.network.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 235

Articles in period: 2346

October 2010

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Regarding processing IGMPv2 reports from a snooping switch (24 May 2013)
[ PATCH iproute2] ss: replace bfp with bpf in usage(). (24 May 2013)
[PATCH net-next 00/12] qlcnic: Enhancements and cleanup (24 May 2013)
[PATCH net-next v5 0/2] MPLS: Add limited GSO support (24 May 2013)
[PATCH v2.30] datapath: Add basic MPLS support to kernel (24 May 2013)
[PATCH] iptuntap: allow creation of multi-queue tun/tap device (24 May 2013)
[PATCH net-next 0/6] tg3: Misc cleanups and refactoring (23 May 2013)
[RFC PATCH 0/2] Fix the SELinux dynamic network access controls (23 May 2013)
[PATCH] Ethtool: Beautify private flags print (23 May 2013)
[PATCH] tcp: xps: fix reordering issues (23 May 2013)
(unknown) (23 May 2013)
(unknown) (23 May 2013)
(unknown) (23 May 2013)
(unknown) (23 May 2013)
[PATCH RFC] net/ipv4: Use next hop exceptions also for input routes (23 May 2013)
[net-next PATCH v2 0/6] Adding pinctrl PM support for CPSW and MDIO (23 May 2013)
napi layer and packet throttling (23 May 2013)
[PATCH 0/3 v3] phy: allow flagging PHY devices as internal (23 May 2013)
[PATCH] net: ethernet: use platform_{get,set}_drvdata() (23 May 2013)
[PATCH] ptp_pch: fix error handling in pch_probe() (23 May 2013)
[PATCH] qlge: add missing free_netdev() on error in qlge_probe() (23 May 2013)

Archives

1452	May 2013
2842	April 2013
2616	March 2013
2164	February 2013
2756	January 2013
1940	December 2012
2225	November 2012
2209	October 2012
1973	September 2012
1825	August 2012
2525	July 2012
2163	June 2012
1979	May 2012
2392	April 2012
1830	March 2012
1919	February 2012
1711	January 2012
1901	December 2011
2193	November 2011
1737	October 2011
1383	September 2011
1918	August 2011
2079	July 2011
2289	June 2011
2027	May 2011
2429	April 2011
2444	March 2011
1638	February 2011
1837	January 2011
1946	December 2010
2033	November 2010
2346	October 2010
2017	September 2010
2052	August 2010
1811	July 2010
2016	June 2010
2135	May 2010
2489	April 2010
2291	March 2010
2098	February 2010
1898	January 2010
1933	December 2009
2591	November 2009
2335	October 2009
2127	September 2009
2575	August 2009
2058	July 2009
2508	June 2009
2277	May 2009
2778	April 2009
3130	March 2009
2417	February 2009
3315	January 2009
2346	December 2008
2956	November 2008
2830	October 2008
2687	September 2008
2933	August 2008
3430	July 2008
2833	June 2008
2641	May 2008
2987	April 2008
2315	March 2008
2401	February 2008
2783	January 2008
2798	December 2007
2854	November 2007
3260	October 2007
2471	September 2007
2731	August 2007
2607	July 2007
2076	June 2007
2448	May 2007
1840	April 2007
2524	March 2007
1996	February 2007
1746	January 2007
1887	December 2006
2076	November 2006
1988	October 2006
2291	September 2006
3767	August 2006
2005	July 2006
2401	June 2006
1555	May 2006
1244	April 2006
616	March 2006
416	February 2006
571	January 2006
557	December 2005
479	November 2005
369	October 2005
593	September 2005
385	August 2005
407	July 2005
727	June 2005
1351	May 2005
1247	April 2005
1912	March 2005
1020	February 2005
1482	January 2005
961	December 2004
1052	November 2004
1519	October 2004
1455	September 2004
897	August 2004
835	July 2004
864	June 2004
529	May 2004
533	April 2004
676	March 2004
743	February 2004
720	January 2004
408	December 2003
625	November 2003
740	October 2003
932	September 2003
999	August 2003
714	July 2003
886	June 2003
420	May 2003
264	April 2003
270	March 2003
186	February 2003
198	January 2003
143	December 2002
214	November 2002
566	October 2002
373	September 2002
157	August 2002
112	July 2002
159	June 2002
91	May 2002
184	April 2002
4	March 2002
2	September 2001
1	January 2000
1	January 1997
1	January 1990

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template