Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 6/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 6/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 Kconfig      |   15 +++++++++++++++
 Makefile     |    1 +
 bna/Makefile |   17 +++++++++++++++++
 3 files changed, 33 insertions(+)

diff -ruP net-next-2.6-orig/drivers/net/Kconfig net-next-2.6-mod/drivers/net/Kconfig
--- net-next-2.6-orig/drivers/net/Kconfig	2009-10-31 00:44:29.000000000 -0700
+++ net-next-2.6-mod/drivers/net/Kconfig	2009-10-31 21:40:54.515921000 -0700
 <at>  <at>  -2757,6 +2757,21  <at>  <at> 
 	  To compile this driver as a module, choose M here: the module
 	  will be called qlge.

+config BNA
+        tristate "Brocade 1010/1020 10Gb Ethernet Driver support"
+        depends on PCI
+        ---help---
+          This driver supports Brocade 1010/1020 10Gb CEE capable Ethernet
+          cards.
+
(Continue reading)

Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 3/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 3/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 bfa_cee.c     |  463 +++++++++++
 bfa_csdebug.c |   62 +
 bfa_ioc.c     | 2273 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 bfa_sm.c      |   45 +
 bna_if.c      |  588 +++++++++++++++
 bna_iocll.h   |   66 +
 bna_os.h      |  182 ++++
 bna_priv.h    |  490 ++++++++++++
 bnad_compat.h |   96 ++
 bnad_defs.h   |   36 
 cna.h         |   32 
 11 files changed, 4333 insertions(+)

diff -ruP net-next-2.6-orig/drivers/net/bna/bfa_cee.c net-next-2.6-mod/drivers/net/bna/bfa_cee.c
--- net-next-2.6-orig/drivers/net/bna/bfa_cee.c	1969-12-31 16:00:00.000000000 -0800
+++ net-next-2.6-mod/drivers/net/bna/bfa_cee.c	2009-10-31 21:34:47.836534000 -0700
 <at>  <at>  -0,0 +1,463  <at>  <at> 
+/*
+ * Copyright (c) 2005-2009 Brocade Communications Systems, Inc.
(Continue reading)

Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 2/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 bfa_timer.c    |   97 ++
 bfad_fwimg.c   |  102 ++
 bna_fn.c       | 1982 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 bna_queue.c    |  496 ++++++++++++++
 bnad_ethtool.c | 1094 +++++++++++++++++++++++++++++++
 5 files changed, 3771 insertions(+)

diff -ruP net-next-2.6-orig/drivers/net/bna/bfa_timer.c net-next-2.6-mod/drivers/net/bna/bfa_timer.c
--- net-next-2.6-orig/drivers/net/bna/bfa_timer.c	1969-12-31 16:00:00.000000000 -0800
+++ net-next-2.6-mod/drivers/net/bna/bfa_timer.c	2009-10-31 21:34:47.660532000 -0700
 <at>  <at>  -0,0 +1,97  <at>  <at> 
+/*
+ * Copyright (c) 2005-2009 Brocade Communications Systems, Inc.
+ * All rights reserved
+ * www.brocade.com
+ *
+ * Linux network driver for Brocade Converged Network Adapter.
+ *
+ * This program is free software; you can redistribute it and/or modify it
(Continue reading)

Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 1/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 bnad.c | 3515 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 bnad.h |  370 ++++++
 2 files changed, 3885 insertions(+)

diff -ruP net-next-2.6-orig/drivers/net/bna/bnad.c net-next-2.6-mod/drivers/net/bna/bnad.c
--- net-next-2.6-orig/drivers/net/bna/bnad.c	1969-12-31 16:00:00.000000000 -0800
+++ net-next-2.6-mod/drivers/net/bna/bnad.c	2009-10-31 21:34:47.559538000 -0700
 <at>  <at>  -0,0 +1,3515  <at>  <at> 
+/*
+ * Copyright (c) 2005-2009 Brocade Communications Systems, Inc.
+ * All rights reserved
+ * www.brocade.com
+ *
+ * Linux network driver for Brocade Converged Network Adapter.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License (GPL) Version 2 as
+ * published by the Free Software Foundation
+ *
(Continue reading)

Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 5/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 5/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 bfa_callback_priv.h               |   64 +++
 bfa_fwimg_priv.h                  |   38 ++
 include/bfi/bfi.h                 |  181 +++++++++++
 include/bfi/bfi_boot.h            |   41 ++
 include/bfi/bfi_cee.h             |  119 +++++++
 include/bfi/bfi_ctreg.h           |  611 ++++++++++++++++++++++++++++++++++++++
 include/bfi/bfi_ioc.h             |  209 ++++++++++++
 include/bfi/bfi_ll.h              |  443 +++++++++++++++++++++++++++
 include/cee/bfa_cee.h             |   82 +++++
 include/cna/pstats/ethport_defs.h |   43 ++
 include/cna/pstats/phyport_defs.h |  225 +++++++++++++
 include/cs/bfa_debug.h            |   51 +++
 include/cs/bfa_q.h                |   88 +++++
 include/cs/bfa_sm.h               |   76 ++++
 include/cs/bfa_trc.h              |   67 ++++
 include/defs/bfa_defs_adapter.h   |   89 +++++
 include/defs/bfa_defs_cee.h       |  165 ++++++++++
 include/defs/bfa_defs_ioc.h       |  158 +++++++++
 include/defs/bfa_defs_mfg.h       |   65 ++++
(Continue reading)

Rasesh Mody | 1 Nov 06:03 2009

Subject: [PATCH 4/6] bna: Brocade 10Gb Ethernet device driver

From: Rasesh Mody <rmody <at> brocade.com>

This is patch 4/6 which contains linux driver source for
Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
Re-based source against net-next-2.6 and re-submitting the
patch with few fixes.

We wish this patch to be considered for inclusion in net-next-2.6

Signed-off-by: Rasesh Mody <rmody <at> brocade.com>
---
 bfa_ioc.h    |  266 ++++++
 bfa_os_inc.h |  210 +++++
 bfa_timer.h  |   60 +
 bna.h        | 2300 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 bna_hwreg.h  | 1004 +++++++++++++++++++++++++
 bna_intr.h   |   96 ++
 6 files changed, 3936 insertions(+)

diff -ruP net-next-2.6-orig/drivers/net/bna/bfa_ioc.h net-next-2.6-mod/drivers/net/bna/bfa_ioc.h
--- net-next-2.6-orig/drivers/net/bna/bfa_ioc.h	1969-12-31 16:00:00.000000000 -0800
+++ net-next-2.6-mod/drivers/net/bna/bfa_ioc.h	2009-10-31 21:34:48.184532000 -0700
 <at>  <at>  -0,0 +1,266  <at>  <at> 
+/*
+ * Copyright (c) 2005-2009 Brocade Communications Systems, Inc.
+ * All rights reserved
+ * www.brocade.com
+ *
+ * Linux network driver for Brocade Converged Network Adapter.
+ *
(Continue reading)

Joe Perches | 1 Nov 06:23 2009

Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

There are an awful lot of non linux standard
uses in this code set.

Perhaps staging would be a good place to start?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Eric Dumazet | 1 Nov 09:02 2009
Picon

Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

Rasesh Mody a écrit :
> From: Rasesh Mody <rmody <at> brocade.com>
> 
> This is patch 1/6 which contains linux driver source for
> Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
> Re-based source against net-next-2.6 and re-submitting the
> patch with few fixes.
> 
> We wish this patch to be considered for inclusion in net-next-2.6

bnad->netdev->last_rx = jiffies

and

netdev->trans_start = jiffies;

are not necessary, core network handles last_rx/trans_start itself 
and more efficently nowadays.

void bnad_reset_stats(struct net_device *netdev) seems defined but not used.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Wolfgang Grandegger | 1 Nov 10:31 2009

Re: [PATCH net-next-2.6] Driver for the Microchip MCP251x SPI CAN controllers

Hi Christian,

we already discusses various driver issues on the Socket-CAN ML. Still,
there are a few. In general, please check the usage of {} for if
statements and check if "if (ret)" should be used instead of "if (ret <
0)" if 0 means success and !0 failure. I don't have a MCP251x hardware
at hand, but maybe Paul (on CC now) has a chance to test it. More
comments inline...

Christian Pellegrin wrote:
> Signed-off-by: Christian Pellegrin <chripell@...>

Please use the subject prefix "can: Driver for the..."

> ---
>  drivers/net/can/Kconfig              |    6 +
>  drivers/net/can/Makefile             |    1 +
>  drivers/net/can/mcp251x.c            | 1182 ++++++++++++++++++++++++++++++++++
>  include/linux/can/platform/mcp251x.h |   34 +
>  4 files changed, 1223 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/can/mcp251x.c
>  create mode 100644 include/linux/can/platform/mcp251x.h
> 
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index 26d77cc..e987526 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
>  <at>  <at>  -102,6 +102,12  <at>  <at>  config CAN_TI_HECC
>  	  Driver for TI HECC (High End CAN Controller) module found on many
>  	  TI devices. The device specifications are available from www.ti.com
(Continue reading)

Takashi Iwai | 1 Nov 11:26 2009
Picon

Re: [PATCH 2/8] param: use ops in struct kernel_param, rather than get and set fns directly

At Fri, 30 Oct 2009 21:43:39 +1030,
Rusty Russell wrote:
> 
> On Fri, 30 Oct 2009 08:48:12 pm Takashi Iwai wrote:
> > At Fri, 23 Oct 2009 00:51:28 +1030,
> > Rusty Russell wrote:
> > > 
> > > This is more kernel-ish, saves some space, and also allows us to
> > > expand the ops without breaking all the callers who are happy for the
> > > new members to be NULL.
> > > 
> > > The few places which defined their own param types are changed to the
> > > new scheme.
> > > 
> > > Since we're touching them anyway, we change get and set to take a
> > > const struct kernel_param (which they were, and will be again).
> > > 
> > > To reduce churn, module_param_call creates the ops struct so the callers
> > > don't have to change (and casts the functions to reduce warnings).
> > > The modern version which takes an ops struct is called module_param_cb.
> > 
> > This is nice, as it also reduces the size of struct kernel_param, so
> > each parameter uses less footprint (who cares, though?) :)
> > 
> > But, just wondering whether we still need to export get/set
> > functions.  They can be called from ops now, so if any, it can be
> > defined even as an inlinefunction or a macro.
> 
> My thought too, so I tried that, but many are still used like so:
> 
(Continue reading)


Gmane