headers
Herbert Xu | 1 Sep 2007 03:13
Picon
Picon

[SKBUFF]: Fix up csum_start when head room changes

Hi Dave:

[SKBUFF]: Fix up csum_start when head room changes

Thanks for noticing the bug where csum_start is not updated
when the head room changes.

This patch fixes that.  It also moves the csum/ip_summed
copying into copy_skb_header so that skb_copy_expand gets
it too.  I've checked its callers and no one should be upset
by this.

Signed-off-by: Herbert Xu <herbert <at> gondor.apana.org.au>

Cheers,
--

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert <at> gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 35021eb..944189d 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
 <at>  <at>  -472,6 +472,9  <at>  <at>  static void copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
 #ifdef CONFIG_INET
 	new->sp		= secpath_get(old->sp);
 #endif
+	new->csum_start = old->csum_start;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Ramkrishna Vepa | 1 Sep 2007 03:43
Favicon

RE: [PATCH 2.6.24 4/5]S2io: Check for CARD_DOWN before handling traffic

Jeff,
> > - Added check to return from the traffic handling function, if the
card
> status
> >   is DOWN.
> >
> > Signed-off-by: Sivakumar Subramani
<sivakumar.subramani <at> neterion.com>
> > Signed-off-by: Santosh Rastapur <santosh.rastapur <at> neterion.com>
> > Signed-off-by: Ramkrishna Vepa <ram.vepa <at> neterion.com>
> > ---
> > diff -Nurp patch3/drivers/net/s2io.c patch4/drivers/net/s2io.c
> > --- patch3/drivers/net/s2io.c	2007-08-15 08:57:32.000000000
-0700
> > +++ patch4/drivers/net/s2io.c	2007-08-15 08:42:14.000000000
-0700
> >  <at>  <at>  -2927,6 +2927,11  <at>  <at>  static int s2io_poll(struct net_device *
> >  	int i;
> >
> >  	atomic_inc(&nic->isr_cnt);
> > +	if (unlikely(atomic_read(&nic->card_state) == CARD_DOWN)) {
> > +		atomic_dec(&nic->isr_cnt);
> > +		return IRQ_NONE;
> > +	}
> > +
> >  	mac_control = &nic->mac_control;
> >  	config = &nic->config;
> >
> 
> invalid return value, for this function
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nick Kossifidis | 1 Sep 2007 05:12
Picon

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007/8/30, John W. Linville <linville@...>:
> On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote:
> > 2007/8/28, Christoph Hellwig <hch@...>:
>
> > > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
> > > most drivers and ath5k_hw_inivals.o mights aswell be something like
> > > ath5k_init.o
>
> > If you check out the code you'll see i'm using the same convention
> > inside them, ath5k_hw* files contain hw related functions
> > (ath5k_hw_≤name>) while driver code has ath5k_<name>. Also ath5k_init
> > is misleading, file acually includes initial register settings for
>
> I have to agree w/ Christoph -- the extra "_hw" in the names is just
> a bit unwieldy.
>
> John
>
> P.S.  "ath5k_initvals.c" seems acceptable to me.

ACK, i'll remove _hw ;-)

--

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
Permalink | Reply | 0 comments |
headers
Daniel Drake | 1 Sep 2007 05:21
Picon
Favicon

Re: zd1211rw regression, device does not enumerate

Oliver Neukum wrote:
> after bisection it boils down to this patch:
> 
> oliver <at> oenone:/home/olli2/Trees/linux-2.6> git bisect bad
> 74553aedd46b3a2cae986f909cf2a3f99369decc is first bad commit
> commit 74553aedd46b3a2cae986f909cf2a3f99369decc
> Author: Daniel Drake <dsd <at> gentoo.org>
> Date:   Sun Jul 1 18:22:32 2007 +0100
> 
>     [PATCH] zd1211rw: Defer firmware load until first ifup
> 
> that plugging in my device I get an error:
> Aug 16 13:17:11 oenone kernel: zd1211rw 3-4.3:1.0: zd1211b chip 0ace:1215 v4810 high 00-02-72
AL2230_RF pa0 g--NS
> Aug 16 13:17:12 oenone ifup: Cannot enable interface eth2.

Can you enable CONFIG_ZD1211RW_DEBUG and post new logs?

Would also be nice to have a bug on the kernel bugzilla to track this.

Thanks,
Daniel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
linux-usb-devel <at> lists.sourceforge.net
(Continue reading)

Permalink | Reply | 4 comments |
headers
Andrew Morton | 1 Sep 2007 06:16

borkage in 2.6.23-rc4-mm1


Am seeing random crap like this:

Aug 31 20:57:46 sony dhclient: DHCPREQUEST on eth1 to 255.255.255.255 port 67
Aug 31 20:57:51 sony dhclient: DHCPREQUEST on eth1 to 255.255.255.255 port 67
Aug 31 20:57:56 sony dhclient: dhclient(4537) is already running - exiting. 
Aug 31 20:57:56 sony dhclient: exiting.
Aug 31 20:58:05 sony dhclient: DHCPDISCOVER on eth1 to 255.255.255.255 port 67 interval 4
Aug 31 20:58:07 sony kernel: ipw2200: Firmware error detected.  Restarting.
Aug 31 20:58:09 sony dhclient: DHCPDISCOVER on eth1 to 255.255.255.255 port 67 interval 7
Aug 31 20:58:16 sony dhclient: DHCPDISCOVER on eth1 to 255.255.255.255 port 67 interval 14
Aug 31 20:58:16 sony dhclient: DHCPOFFER from 192.168.2.1
Aug 31 20:58:16 sony dhclient: DHCPREQUEST on eth1 to 255.255.255.255 port 67
Aug 31 20:58:20 sony dhclient: DHCPREQUEST on eth1 to 255.255.255.255 port 67
Aug 31 20:58:20 sony dhclient: DHCPACK from 192.168.2.1
Aug 31 20:58:20 sony NET[4946]: /sbin/dhclient-script : updated /etc/resolv.conf
Aug 31 20:58:20 sony dhclient: bound to 192.168.2.5 -- renewal in 125513 seconds.
Aug 31 20:59:45 sony ntpd[2059]: sendto(192.36.143.234): Invalid argument
Aug 31 20:59:51 sony ntpd[2059]: sendto(193.225.14.163): Invalid argument
Aug 31 20:59:52 sony ntpd[2059]: sendto(193.60.199.78): Invalid argument
Aug 31 21:01:31 sony kernel: ipw2200: Firmware error detected.  Restarting.
Aug 31 21:01:54 sony ntpd[2059]: sendto(192.36.143.234): Invalid argument
Aug 31 21:01:59 sony ntpd[2059]: sendto(193.225.14.163): Invalid argument
Aug 31 21:02:02 sony ntpd[2059]: sendto(193.60.199.78): Invalid argument
Aug 31 21:04:04 sony ntpd[2059]: sendto(192.36.143.234): Invalid argument
Aug 31 21:04:05 sony kernel: ipw2200: Firmware error detected.  Restarting.
Aug 31 21:04:07 sony ntpd[2059]: sendto(193.225.14.163): Invalid argument
Aug 31 21:04:12 sony ntpd[2059]: sendto(193.60.199.78): Invalid argument
Aug 31 21:05:21 sony kernel: ipw2200: Firmware error detected.  Restarting.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Patrick McHardy | 1 Sep 2007 07:28
Favicon

Re: ipv4_get_l4proto: Frag of proto 17

Meelis Roos wrote:
>>> Yesterdays git snapsot on a normal home PC spams dmesg with the following
>>> line:
>>> ipv4_get_l4proto: Frag of proto 17
>> In what situation does this happen?
> 
> It happens some times every hour on the average. Seems to be some UDP 
> traffic. Firewall allows in any UDP that is ESTABLISHEFD,RELATED, DHCP 
> (some more UDP rules with counter 0 so not important). Additionally 
> there is internal netowkr that sometimes has a laptop but usually not 
> and the messages have appeared also when there is nothin in the internal 
> network.
> 
> Locally mldonkey is probably using UDP, and lsof -i | grep UDP tells 
> that named, avahi-daemon, dhcpd, chronyd, nmbd and cupsd are listening 
> on UDP sockets (most of them on internal network).
> 
> But I have no idea what application is causing the messages.

I'm guessing that its ICMP errors containing UDP fragments.

Could you add a WARN_ON(1) to ipv4_get_l4proto() in
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c to verify
this?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nick Kossifidis | 1 Sep 2007 07:58
Picon

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007/8/31, Nick Kossifidis <mickflemm@...>:
> 2007/8/30, John W. Linville <linville@...>:
> > On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote:
> > > 2007/8/28, Christoph Hellwig <hch@...>:
> >
> > > > Also this whole patch seems rather pointless.  It saves only
> > > > very little and turns the driver into a complete ifdef maze.
> >
> > > Also most
> > > people will use 5212 code only, 5211 cards are on some old laptops and
> > > 5210, well i couldn't even find  a 5210 for actual testing :P
> >
> > FWIW, I'd bet dollars to donuts that distros will enable them all
> > together.
> >
> > Is saving code space the only reason to turn these off?  How much
> > space do you save?
> >
> > Is there some way you can isolate and/or limit the number of ifdef
> > blocks further?  If so, we might consider a version of this patch
> > that depends on EMBEDDED or somesuch...?
> >
> > John
>
> O.K. as a first step i'll limit 5210 code only then, just an option
> like "support older 5210 chipsets" which is going to be off by default
> instead of 3 options. It's not just saving space, it's also saving
> some runtime checks. It's not really a gain in performance though,
> most checks are done during initialization and dfs setup, i just
> thought it would be usefull to save as much cpu as possible.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mariusz Kozlowski | 1 Sep 2007 08:10
Picon

[PATCH] skge: unbalanced parenthesis fix

Hello,

	This patch fixes unbalanced parenthesis.

Signed-off-by: Mariusz Kozlowski <m.kozlowski <at> tuxland.pl>

 drivers/net/skge.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h	2007-09-01 07:23:52.000000000 +0200
+++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h	2007-09-01 07:37:55.000000000 +0200
 <at>  <at>  -1351,7 +1351,7  <at>  <at>  enum {
 	PHY_M_PC_EN_DET_PLUS	= 3<<8, /* Energy Detect Plus (Mode 2) */
 };

-#define PHY_M_PC_MDI_XMODE(x)	((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
+#define PHY_M_PC_MDI_XMODE(x)	(((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)

 enum {
 	PHY_M_PC_MAN_MDI	= 0, /* 00 = Manual MDI configuration */
Permalink | Reply | 0 comments |
headers
Andrew Morton | 1 Sep 2007 08:58

Re: 2.6.23-rc4-mm1

> On Sat, 1 Sep 2007 15:53:53 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu <at> jp.fujitsu.com> wrote:
> I met 2 troubles while I compiled rc4-mm1 on x86/UP system,
> 
> One on pcnet32.c (patch is attaced below).
> One on crypto CONFIG.
> 
> == compile log ==
> drivers/net/pcnet32.c: In function 'pcnet32_netif_stop':
> drivers/net/pcnet32.c:445: warning: unused variable 'lp'
> drivers/net/pcnet32.c: In function 'pcnet32_netif_start':
> drivers/net/pcnet32.c:455: warning: unused variable 'lp'
> drivers/net/pcnet32.c: In function 'pcnet32_interrupt':
> drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 'napi'

Only git-net touches pcnet32.c

> crypto/built-in.o: In function `update2':
> digest.c:(.text+0x94a): undefined reference to `crypto_km_types'
> digest.c:(.text+0x9bf): undefined reference to `crypto_km_types'
> 
> digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI)
> I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y.

cc herbert..

> Regards,
> -Kame.
> == cut from here ==
> 
>  tiny bug fix for pcnet32.c (maybe works well. please confirm.)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Patrick McHardy | 1 Sep 2007 09:09
Favicon

Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

Jesper Dangaard Brouer wrote:
> commit 6fdc0f061be94f5e297650961360fb7a9d1cc85d
> Author: Jesper Dangaard Brouer <hawk <at> comx.dk>
> Date:   Thu Aug 30 17:53:42 2007 +0200
> 
>     [NET_SCHED]: Make all rate based scheduler work with TSO.
>     
>      Change L2T (length to time) macros, in all rate based schedulers, to
>      call a common function qdisc_l2t() that does the rate table lookup.
>      This function handles if the packet size lookup is larger than the
>      rate table, which often occurs with TSO enabled.

It still won't work properly with TSO (TBF for example already drops
oversized packets during ->enqueue), but its a good cleanup anyway.

 > +#define L2T(p,L)   ((p)->tcfp_R_tab, L)
 > +#define L2T_P(p,L) ((p)->tcfp_P_tab, L)

I'd prefer to get rid of these L2T macros completely.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 6 comments |

Gmane