Francois Romieu | 1 Dec 01:02 2006

Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction

Don Fry <brazilnut <at> us.ibm.com> :
> NetXen: 1G/10G Ethernet Driver updates
> 	- Temparature monitoring and device control
> 	- Memory footprint reduction
> 	- Driver changes to support newer version of firmware
> 
> Signed-off-by: Amit S. Kale <amitkale <at> netxen.com>
> Signed-off-by: Don Fry <brazilnut <at> us.ibm.com>
> 
> diff -Nupr netdev-2.6/drivers/net/netxen.one/netxen_nic_ethtool.c netdev-2.6/drivers/net/netxen/netxen_nic_ethtool.c
> --- netdev-2.6/drivers/net/netxen.one/netxen_nic_ethtool.c	2006-11-30 09:16:23.000000000 -0800
> +++ netdev-2.6/drivers/net/netxen/netxen_nic_ethtool.c	2006-11-30 09:22:41.000000000 -0800
>  <at>  <at>  -53,6 +53,9  <at>  <at>  struct netxen_nic_stats {
>  #define NETXEN_NIC_STAT(m) sizeof(((struct netxen_port *)0)->m), \
>  			offsetof(struct netxen_port, m)
>  
> +#define NETXEN_NIC_PORT_WINDOW 0x10000
> +#define NETXEN_NIC_INVALID_DATA 0xDEADBEEF
> +
>  static const struct netxen_nic_stats netxen_nic_gstrings_stats[] = {
>  	{"rcvd_bad_skb", NETXEN_NIC_STAT(stats.rcvdbadskb)},
>  	{"xmit_called", NETXEN_NIC_STAT(stats.xmitcalled)},
>  <at>  <at>  -111,9 +114,9  <at>  <at>  netxen_nic_get_drvinfo(struct net_device
>  {
>  	struct netxen_port *port = netdev_priv(dev);
>  	struct netxen_adapter *adapter = port->adapter;
> -	uint32_t fw_major = 0;
> -	uint32_t fw_minor = 0;
> -	uint32_t fw_build = 0;
> +	u32 fw_major = 0;
(Continue reading)

James Morris | 1 Dec 01:03 2006

Re: [PATCH 1/1] additional ipsec audit patch

On Thu, 30 Nov 2006, Joy Latten wrote:

> I ran a stress test overnight using labeled ipsec on a patched lspp55 kernel 
> using racoon last week.
> 
> The additional patch to xfrm_state.c was my fault when rebasing to
> 2.6.19-rc6 to send upstream. I plan to run an ipv4 and ipv6 stress test
> tonight and tomorrow using labeled ipsec with auditing enabled on the
> lspp56 kernel, which contains ipsec audit patch, to ensure no regression
> has occurred. I can also run an ipv4 and ipv6 stress tests
> with regular ipsec over the weekend for further ensurance.   
> 
> I compiled and did unit test with SELINUX disabled, AUDITSYSCALL
> disabled, and with both enabled. 

Thanks, applied to 

git://git.infradead.org/~jmorris/selinux-net-2.6.20#for-akpm

might be worth having it in -mm for a bit.

--

-- 
James Morris
<jmorris <at> namei.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Jeff Garzik | 1 Dec 01:15 2006

Re: [PATCH 0/5 addendum] NetXen

Don Fry wrote:
> The NetXen patches fix many problems in the current #upstream version of
> the driver.  It has warts and probably lots of bugs still, but it is
> better than what is queued for mainline inclusion at this time.  Please
> apply to 2.6.20.

Please resync with netdev#upstream, and update for comments on netdev...

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Don Fry | 1 Dec 01:27 2006
Picon

Re: [PATCH 0/5 addendum] NetXen

On Thu, Nov 30, 2006 at 07:15:50PM -0500, Jeff Garzik wrote:
> Don Fry wrote:
> >The NetXen patches fix many problems in the current #upstream version of
> >the driver.  It has warts and probably lots of bugs still, but it is
> >better than what is queued for mainline inclusion at this time.  Please
> >apply to 2.6.20.
> 
> Please resync with netdev#upstream, and update for comments on netdev...
> 
> 	Jeff

I think I am up to date with netdev#upstream.  Maybe I am pointed at the
wrong place.  Is the correct git tree at?
http://www.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git/

and then to get to the upstream branch I do
git-checkout upstream

--

-- 
Don Fry
brazilnut <at> us.ibm.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller | 1 Dec 01:39 2006
Picon

Re: [PATCH][IPSEC][1/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori <at> miyazawa.org>
Date: Fri, 24 Nov 2006 14:38:07 +0900

> This patch adds encapsulation family.
> 
> Signed-off-by: Miika Komu <miika <at> iki.fi>
> Signed-off-by: Diego Beltrami <Diego.Beltrami <at> hiit.fi>
> Signed-off-by: Kazunori Miyazawa <miyazawa <at> linux-ipv6.org>

Applied to net-2.6.20, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller | 1 Dec 01:41 2006
Picon

Re: [PATCH][IPSEC][2/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori <at> miyazawa.org>
Date: Fri, 24 Nov 2006 14:38:17 +0900

> This patch adds netlink interface of the family
> 
> Signed-off-by: Miika Komu <miika <at> iki.fi>
> Signed-off-by: Diego Beltrami <Diego.Beltrami <at> hiit.fi>
> Signed-off-by: Kazunori Miyazawa <miyazawa <at> linux-ipv6.org>

Applied to net-2.6.20, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller | 1 Dec 01:42 2006
Picon

Re: [PATCH][IPSEC][3/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori <at> miyazawa.org>
Date: Thu, 30 Nov 2006 10:54:26 +0900

> Hello,
> 
> I found a bug in my previous patch for af_key.
> The patch breaks transport mode.
> This is a fixed version.
> 
> Signed-off-by: Miika Komu <miika <at> iki.fi>
> Signed-off-by: Diego Beltrami <Diego.Beltrami <at> hiit.fi>
> Signed-off-by: Kazunori Miyazawa <miyazawa <at> linux-ipv6.org>

Applied to net-2.6.20, thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller | 1 Dec 01:48 2006
Picon

Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori <at> miyazawa.org>
Date: Fri, 24 Nov 2006 14:38:39 +0900

What is going on here?

> +			/* Without this, the atomic inc below segfaults */
> +			if (encap_family == AF_INET6) {
> +				rt->peer = NULL;
> +				rt_bind_peer(rt,1);
> +			}
 ...
> -		dst_prev->output	= xfrm4_output;
> +		if (dst_prev->xfrm->props.family == AF_INET)
> +			dst_prev->output = xfrm4_output;
> +#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
> +		else
> +			dst_prev->output = xfrm6_output;
> +#endif
>  		if (rt->peer)
>  			atomic_inc(&rt->peer->refcnt);

If it's non-NULL and you get a segfault for atomic_inc() that
means there is garbage here, and it seems that if you're
setting it to NULL explicitly then it's just a workaround
for whatever problem is causing it to be non-NULL to begin
with.

What is putting a non-valid pointer value there?  Is this an IPV6 or
IPSEC dst route by chance?  If so, that makes this change really
wrong, and we are corrupting the route by running rt_bind_peer() on
(Continue reading)

David Miller | 1 Dec 01:49 2006
Picon

Re: [PATCH][IPSEC][5/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori <at> miyazawa.org>
Date: Fri, 24 Nov 2006 14:38:52 +0900

> +static inline void ip6ip_ecn_decapsulate(struct sk_buff *skb)
> +{
> +	if (INET_ECN_is_ce(ipv6_get_dsfield(skb->nh.ipv6h)))
> +			IP_ECN_set_ce(skb->h.ipiph);
> +}
> +

Please fix this extra tab indentation :-)

Thank you.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Daniel Drake | 1 Dec 01:56 2006
Picon

[PATCH] zd1211rw: zd_mac_rx isn't always called in IRQ context

e.g.

usb 1-7: rx_urb_complete() *** first fragment ***
usb 1-7: rx_urb_complete() *** second fragment ***
drivers/net/wireless/zd1211rw/zd_mac.c:1063 ASSERT
(((current_thread_info()->preempt_count) & (((1UL << (12))-1) << ((0 +
8) + 8)))) VIOLATED!
 [<f0299448>] zd_mac_rx+0x3e7/0x47a [zd1211rw]
 [<f029badc>] rx_urb_complete+0x22d/0x24a [zd1211rw]
 [<b028a22f>] urb_destroy+0x0/0x5
 [<b01f0930>] kref_put+0x65/0x72
 [<b0288cdf>] usb_hcd_giveback_urb+0x28/0x57
 [<b02950c4>] qh_completions+0x296/0x2f6
 [<b0294b21>] ehci_urb_done+0x70/0x7a
 [<b0294ea1>] qh_completions+0x73/0x2f6
 [<b02951bc>] ehci_work+0x98/0x538

Remove the bogus assertion, and use dev_kfree_skb_any as pointed out by
Ulrich Kunitz.

Signed-off-by: Daniel Drake <dsd <at> gentoo.org>

Index: linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/zd1211rw/zd_mac.c
+++ linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c
 <at>  <at>  -1059,10 +1059,8  <at>  <at>  int zd_mac_rx(struct zd_mac *mac, const 
 	memcpy(skb_put(skb, length), buffer, length);

 	r = ieee80211_rx(ieee, skb, &stats);
(Continue reading)


Gmane