headers
Tom Tucker | 1 Jul 2006 01:01

Re: RDMA will be reverted

On Fri, 2006-06-30 at 14:16 -0700, David Miller wrote:

> The TOE folks have tried to submit their hooks and drivers
> on several occaisions, and we've rejected it every time.

iWARP != TOE

> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 52 comments |
headers
Thomas Graf | 1 Jul 2006 01:22
Picon

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

This is boring, I reversed everything to not change any semantics and
you still complain.

* jamal <hadi <at> cyberus.ca> 2006-06-30 17:35
> On Fri, 2006-30-06 at 23:20 +0200, Thomas Graf wrote:
> > * jamal <hadi <at> cyberus.ca> 2006-06-30 17:09
> > > the ref inside the else below after changing input_dev 
> > 
> > A non-existant iif is already equivalent to !iif since it jumps
> > into the same branch. 
> 
> I thought 0 was a valid iif as Ben G was pointing - if it is not, you
> are right. 

No, 1 ist the first valid ifindex, see dev_new_index().

> > Grabing a reference is completely pointless,
> > the netdevice represented by skb->iif is at this point until the
> > packet gets queued covered by a reference taken in netif_rx().
> 
> You have to consider that this could happen at both ingress and egress.

Just think for a second, do you expect the device the packet will
be leaving at to disappear?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 3 comments |
headers
Randy.Dunlap | 1 Jul 2006 01:28

[PATCH] IOAT: fix header file kernel-doc

From: Randy Dunlap <rdunlap <at> xenotime.net>

Fix kernel-doc problems in include/linux/dmaengine.h:
- add some fields/parameters
- expand some descriptions
- fix typos

Signed-off-by: Randy Dunlap <rdunlap <at> xenotime.net>
---
 include/linux/dmaengine.h |   43 +++++++++++++++++++++++++------------------
 1 files changed, 25 insertions(+), 18 deletions(-)

--- linux-2617-g13.orig/include/linux/dmaengine.h
+++ linux-2617-g13/include/linux/dmaengine.h
 <at>  <at>  -44,7 +44,7  <at>  <at>  enum dma_event {
 };

 /**
- * typedef dma_cookie_t
+ * typedef dma_cookie_t - an opaque DMA cookie
  *
  * if dma_cookie_t is >0 it's a DMA request cookie, <0 it's an error code
  */
 <at>  <at>  -80,14 +80,14  <at>  <at>  struct dma_chan_percpu {

 /**
  * struct dma_chan - devices supply DMA channels, clients use them
- *  <at> client: ptr to the client user of this chan, will be NULL when unused
- *  <at> device: ptr to the dma device who supplies this channel, always !NULL
+ *  <at> client: ptr to the client user of this chan, will be %NULL when unused
(Continue reading)

Permalink | Reply | 1 comment |
headers
Michael Chan | 1 Jul 2006 01:35
Favicon

[PATCH] tg3: Add ipv6 TSO feature

Enable ipv6 TSO feature on chips that support it.

Update version to 3.61.

Signed-off-by: Michael Chan <mchan <at> broadcom.com>

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 47c96fc..b992c0a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
 <at>  <at>  -69,8 +69,8  <at>  <at> 

 #define DRV_MODULE_NAME		"tg3"
 #define PFX DRV_MODULE_NAME	": "
-#define DRV_MODULE_VERSION	"3.61"
-#define DRV_MODULE_RELDATE	"June 29, 2006"
+#define DRV_MODULE_VERSION	"3.62"
+#define DRV_MODULE_RELDATE	"June 30, 2006"

 #define TG3_DEF_MAC_MODE	0
 #define TG3_DEF_RX_MODE		0
 <at>  <at>  -3799,18 +3799,24  <at>  <at>  static int tg3_start_xmit(struct sk_buff
 			goto out_unlock;
 		}

-		tcp_opt_len = ((skb->h.th->doff - 5) * 4);
-		ip_tcp_len = (skb->nh.iph->ihl * 4) + sizeof(struct tcphdr);
+		if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6)
+			mss |= (skb_headlen(skb) - ETH_HLEN) << 9;
+		else {
(Continue reading)

Permalink | Reply | 1 comment |
headers
Chris Friesen | 1 Jul 2006 01:35
Favicon

Re: jumbo frames and memory fragmentation

Evgeniy Polyakov wrote:

> It definitely will.
> Packet split in hardware means separating data and headers into
> different pages in different reads, while software page split means that 
> skb has a list of fragments where part of the packet will be DMAed, so
> jumbo frame will be converted into several pages.

Maybe I'm looking at the wrong code then.  Can you point me to where 
this "software page split" is handled?

Chris
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 2 comments |
headers
Thomas Graf | 1 Jul 2006 01:45
Picon

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

* jamal <hadi <at> cyberus.ca> 2006-06-30 17:31
> Better to explain the reason for ifb first:
> ifb exists initially as a replacement for IMQ. 
> 1) qdiscs/policies that are per device as opposed to system wide.
> This now allows for sharing.
> 
> 2) Allows for queueing incoming traffic for shaping instead of
> dropping.
> 
> In other wise, the main use is for multiple devices to redirect to it.
> Main desire is not for it to redirect to any other ifb device or eth
> devices. I actually tried to get it to do that, but run into issues
> of complexity and and came up with decision to drop instead of killing
> the machine.
> Other than that, it can redirect to any other devices - but may still
> not be meaningful.

Last time I'm asking. Why are packets dropped? You mentioned tc_verd
is set to 0 leading to a invalid from verdict. Fact is that the
from verdict is set to a meaningful value again at dev_queue_xmit()
or ing_filter() so ifb_xmit() only sees valid values. tx locks of
individual ifb devices are independant, why would it deadlock? Where
is the packet exactly dropped?

> I have been thinking of Herberts change of qdisc_is_running and this may
> help actually.

Help on what?

-
(Continue reading)

Permalink | Reply | 16 comments |
headers
Ananda Raju | 1 Jul 2006 01:44
Favicon

RE: [1/4] [IPV6]: Remove redundant length check on input

Hi, 

I tested the patch, and TSO over ipv6 is working fine. But TSO disable
not working for IPv6. 

I tried the from tree /pub/scm/linux/kernel/git/davem/net-2.6

Ananda 

-----Original Message-----
From: David Miller [mailto:davem <at> davemloft.net] 
Sent: Friday, June 30, 2006 2:20 PM
To: herbert <at> gondor.apana.org.au
Cc: Ananda Raju; netdev <at> vger.kernel.org
Subject: Re: [1/4] [IPV6]: Remove redundant length check on input

From: Herbert Xu <herbert <at> gondor.apana.org.au>
Date: Fri, 30 Jun 2006 15:42:09 +1000

> I've added GSO for TCPv6 and updated Ananda's patch.  Please note that
> the following patches have only been compile-tested.

I applied this and pushed it to Linus, let's cross our fingers :)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 5 comments |
headers
Michael Chan | 1 Jul 2006 01:52
Favicon

RE: [1/4] [IPV6]: Remove redundant length check on input

On Fri, 2006-06-30 at 19:44 -0400, Ananda Raju wrote:
> Hi, 
> 
> I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> not working for IPv6. 
> 
You need to clear NETIF_F_TSO6 in dev->features to disable ipv6 TSO.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Ananda Raju | 1 Jul 2006 01:55
Favicon

RE: [1/4] [IPV6]: Remove redundant length check on input

True, I am referring to "ethtool -K ethX tso off"
ethtool_op_set_tso() won't clear NETIF_F_TSO6 for ethtool -K ethX tso
off

Ananda 
-----Original Message-----
From: Michael Chan [mailto:mchan <at> broadcom.com] 
Sent: Friday, June 30, 2006 4:53 PM
To: Ananda Raju
Cc: David Miller; herbert <at> gondor.apana.org.au; netdev <at> vger.kernel.org
Subject: RE: [1/4] [IPV6]: Remove redundant length check on input

On Fri, 2006-06-30 at 19:44 -0400, Ananda Raju wrote:
> Hi, 
> 
> I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> not working for IPv6. 
> 
You need to clear NETIF_F_TSO6 in dev->features to disable ipv6 TSO.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Randy.Dunlap | 1 Jul 2006 02:01

[PATCH] IOAT: fix kernel-doc in source files

From: Randy Dunlap <rdunlap <at> xenotime.net>

Fix kernel-doc warnings in drivers/dma/:
- use correct function & parameter names
- add descriptions where omitted

Signed-off-by: Randy Dunlap <rdunlap <at> xenotime.net>
---
 drivers/dma/dmaengine.c |   20 ++++++++++++--------
 drivers/dma/ioatdma.c   |    8 +++++---
 2 files changed, 17 insertions(+), 11 deletions(-)

--- linux-2617-g13.orig/drivers/dma/dmaengine.c
+++ linux-2617-g13/drivers/dma/dmaengine.c
 <at>  <at>  -166,8 +166,8  <at>  <at>  static struct dma_chan *dma_client_chan_
 }

 /**
- * dma_client_chan_free - release a DMA channel
- *  <at> chan: &dma_chan
+ * dma_chan_cleanup - release a DMA channel's resources
+ *  <at> kref: kernel reference structure that contains the DMA channel device
  */
 void dma_chan_cleanup(struct kref *kref)
 {
 <at>  <at>  -199,7 +199,7  <at>  <at>  static void dma_client_chan_free(struct 
  * dma_chans_rebalance - reallocate channels to clients
  *
  * When the number of DMA channel in the system changes,
- * channels need to be rebalanced among clients
(Continue reading)

Permalink | Reply | 1 comment |

Gmane