headers
Larry Finger | 10 Feb 01:19
Favicon

[PATCH v3] rtlwifi: rtl8192se firmware load can overflow target buffer

From: Tim Gardner <tim.gardner <at> canonical.com>

Define RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE which represents the
maximimum possible firmware file size. Use it in the definition
of the buffer which receives the firmware file data.

Set RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE closer to the actual size of
the firmware file, e.g., 90000 (down from hard coded 164000). The current
size of rtlwifi/rtl8192sefw.bin is 88856.

Set max_fw_size to RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE for the size limit
check. Fix the error case where max_fw_size is not cleared if the size
limit check fails.

Cc: Chaoming Li <chaoming_li <at> realsil.com.cn>
Cc: linux-wireless <at> vger.kernel.org
Cc: netdev <at> vger.kernel.org
Cc: linux-kernel <at> vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner <at> canonical.com>
Signed-off-by: Larry Finger <Larry.Finger <at> lwfinger.net>
---
 drivers/net/wireless/rtlwifi/rtl8192se/fw.h |    3 ++-
 drivers/net/wireless/rtlwifi/rtl8192se/sw.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/fw.h b/drivers/net/wireless/rtlwifi/rtl8192se/fw.h
index babe85d..b4afff6 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192se/fw.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/fw.h
@@ -30,6 +30,7 @@
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ben Greear | 9 Feb 23:20
Favicon

r8169 crash (probably my fault) in 3.3.0-rc1+ (net-next)

I am hacking on the 8169 code, (adding RX-ALL and RX-FCS support on top of
my previously posted patches) so this could easily be my
fault..but just in case someone else has seen it, please
let me know....

BUG: unable to handle kernel NULL pointer dereference at 00000c9c
IP: [<c07083f6>] skb_gro_reset_offset+0x3a/0x73
*pde = 00000000
Oops: 0000 [#1] SMP
Modules linked in: bridge 8021q garp stp llc ip_gre gre veth fuse macvlan pktgen coretemp hwmon nfs lockd]

Pid: 7659, comm: tshark Not tainted 3.3.0-rc1+ #25 To Be Filled By O.E.M. To Be Filled By O.E.M./To be fi.
EIP: 0060:[<c07083f6>] EFLAGS: 00210246 CPU: 0
EIP is at skb_gro_reset_offset+0x3a/0x73
EAX: 00000c9c EBX: f16353c0 ECX: f175d030 EDX: f16353c0
ESI: f16353d8 EDI: f4e47c68 EBP: f580bf48 ESP: f580bf3c
  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process tshark (pid: 7659, ti=f580a000 task=f14ede60 task.ti=f1444000)
Stack:
  f16353c0 f4d184cc f4e47c40 f580bf58 c070c1ad f4d18000 00000002 f580bfb0
  f88fff68 f4d18bb4 3148c000 00000003 f5959060 00000040 0003dc40 f4d18b88
  00000040 803fbf8c f4d18000 f4d184c0 00000003 f4d184cc 00000000 f16353c0
Call Trace:
  [<c070c1ad>] napi_gro_receive+0x10/0x24
  [<f88fff68>] rtl8169_poll+0x2d6/0x443 [r8169]
  [<c070c2ba>] net_rx_action+0x92/0x1a2
  [<c042ad54>] __do_softirq+0x6d/0xfa
  [<c042ace7>] ? irq_enter+0x4d/0x4d
  <IRQ>
  [<c042aba4>] ? irq_exit+0x32/0x93
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jeff Kirsher | 9 Feb 22:21
Picon
Favicon

[iproute2] iproute2: Add VF spoofchk command description to ip-link.8 man page

From: Greg Rose <gregory.v.rose <at> intel.com>

Add documentation for the ip link set spoof checking option.  The
expanded text section explaining the VF commands was missing this
text.

Signed-off-by: Greg Rose <gregory.v.rose <at> intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>
---
 man/man8/ip-link.8 |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/man/man8/ip-link.8 b/man/man8/ip-link.8
index e1eb948..8c63584 100644
--- a/man/man8/ip-link.8
+++ b/man/man8/ip-link.8
@@ -301,6 +301,10 @@ as 0 disables VLAN tagging and filtering for the VF.
 Setting this parameter to 0 disables rate limiting. The
 .B vf
 parameter must be specified.
+
+.sp
+.BI spoofchk " on|off"
+- turn packet spoof checking on or off for the specified VF.
 .in -8

 .TP
--

-- 
1.7.7.6
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jiri Benc | 9 Feb 20:34
Picon
Favicon
Gravatar

[PATCH 1/2 net-next] ipv6: helper function to get tclass

Implement helper inline function to get traffic class from IPv6 header.

Signed-off-by: Jiri Benc <jbenc <at> redhat.com>

---
 include/linux/ipv6.h |    5 +++++
 net/ipv6/datagram.c  |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

--- a/include/linux/ipv6.h
+++ b/include/linux/ipv6.h
@@ -233,6 +233,11 @@ static inline struct ipv6hdr *ipipv6_hdr
 	return (struct ipv6hdr *)skb_transport_header(skb);
 }

+static inline __u8 ipv6_tclass(const struct ipv6hdr *iph)
+{
+	return (ntohl(*(__be32 *)iph) >> 20) & 0xff;
+}
+
 /* 
    This structure contains results of exthdrs parsing
    as offsets from skb->nh.
--- a/net/ipv6/datagram.c
+++ b/net/ipv6/datagram.c
@@ -485,7 +485,7 @@ int datagram_recv_ctl(struct sock *sk, s
 	}

 	if (np->rxopt.bits.rxtclass) {
-		int tclass = (ntohl(*(__be32 *)ipv6_hdr(skb)) >> 20) & 0xff;
(Continue reading)

Permalink | Reply | 1 comment |
headers
boris | 9 Feb 16:59
Picon
Gravatar

Datacenter Colocation Service in Hong Kong

Dear All,

Our Data center:

Over 20,000ft Data Center in Hong Kong (Kowloon side) with Control Center

Holds Certificate of ISO/IEC 27001:2005

Standard of TIA-942 Tier 3+ Facilities

-          FM200 and HSSD ¡V strengthens fire resistance and limits potential damage

-          CRAC system ¡V maintains constant temperatures and relative humidity to minimize redundancy control

-          Diesel Power Generator ¡V provide full power outage support for entire data centre operation with
limitless diesel tank back up located in ground floor of building.

-          UPS ¡V offers N+1 full load configuration

 
Standard 1 Rack Package

-          1 Rack of Industrial Standard Rack

-          One 100Mbps Internet Connectivity Port

-          Shared Access to SunnyVision Internet backbone
 (BGP4 Peering to 2Gbps to Local (HKIX) + 300Mbps to Oversea Carrier (Singtel, NTT, Reach, ChinaNet)

-          Free 32 IPs Addresses Allocation and Basic Configuration
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael Tokarev | 9 Feb 18:02
Picon

3.0: unexpected route cache entry for wrong segment?

Hello.

I'm observing a situation when just one single IP
address from entirely different segment gets routed
locally as if it were in a directly-connected network.

Here's how.  The short version, to show the idea, first:

A host with single eth0 interface and single IP address
(not counting loopback interface):

$ ip addr
8: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP qlen 1000
    link/ether 52:54:c0:a8:b1:02 brd ff:ff:ff:ff:ff:ff
    inet 192.168.177.2/26 scope global eth0

$ ip route
default via 192.168.177.5 dev eth0
192.168.177.0/26 dev eth0  proto kernel  scope link  src 192.168.177.2

$ ip neigh
...
192.168.177.5 dev eth0 lladdr 00:90:27:30:6d:1c REACHABLE
192.168.177.33 dev eth0 lladdr 38:60:77:25:3f:95 REACHABLE
192.168.19.166 dev eth0  FAILED
192.168.177.21 dev eth0 lladdr 52:54:c0:a8:b1:15 REACHABLE

The address in question is this 192.168.19.166 -- it should
not be tried on locally connected ethernet segment, but instead
should go to the (default) gateway at 192.168.177.5.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Giuseppe CAVALLARO | 9 Feb 11:56
Favicon

[PATCH] stmmac: fix driver features

New GMAC chips can set the tx_coe and rx_csum
flags by looking at the HW cap register and this
happens during the open.
This patch fixes the stmmac_fix_feature function that
in some cases assumes that there is no HW csum
because no flags are passed through the platform.
As soon as the open method is called then the
stmmac_fix_feature could want to turn-on the NETIF_F_RXCSUM
or NETIF_F_ALL_CSUM.

Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro <at> st.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 36ee77f..e03a873 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1541,8 +1541,13 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev,

 	if (!priv->rx_coe)
 		features &= ~NETIF_F_RXCSUM;
+	else
+		features |= NETIF_F_RXCSUM;
+
 	if (!priv->plat->tx_coe)
 		features &= ~NETIF_F_ALL_CSUM;
+	else
+		features |= NETIF_F_ALL_CSUM;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Dan Carpenter | 9 Feb 11:49
Picon
Favicon
Gravatar

[patch] bna: fix error handling of bnad_get_flash_partition_by_offset()

The current error handling doesn't work because we flash_part is a u32
so the checks for negative error codes don't work.  I considered making
things signed but I don't know the hardware enough to say if that's a
problem.  Really, we don't use the error codes so just returning zero
for all problems is fine.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>

diff --git a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
index a27c601..ab753d7 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
@@ -946,7 +946,7 @@ bnad_get_flash_partition_by_offset(struct bnad *bnad, u32 offset,

 	flash_attr = kzalloc(sizeof(struct bfa_flash_attr), GFP_KERNEL);
 	if (!flash_attr)
-		return -ENOMEM;
+		return 0;

 	fcomp.bnad = bnad;
 	fcomp.comp_status = 0;
@@ -958,7 +958,7 @@ bnad_get_flash_partition_by_offset(struct bnad *bnad, u32 offset,
 	if (ret != BFA_STATUS_OK) {
 		spin_unlock_irqrestore(&bnad->bna_lock, flags);
 		kfree(flash_attr);
-		goto out_err;
+		return 0;
 	}
 	spin_unlock_irqrestore(&bnad->bna_lock, flags);
 	wait_for_completion(&fcomp.comp);
(Continue reading)

Permalink | Reply | 1 comment |
headers
Dan Carpenter | 9 Feb 11:46
Picon
Favicon
Gravatar

[patch] isdn: type bug in isdn_net_header()

We use len to store the return value from eth_header().  eth_header()
can return -ETH_HLEN (-14).  We want to pass this back instead of
truncating it to 65522 and returning that.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>
---
WARNING: Compile tested only.  I don't have this hardware.  Please check
that I am on the right track.

diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
index 2339d73..802ab87 100644
--- a/drivers/isdn/i4l/isdn_net.c
+++ b/drivers/isdn/i4l/isdn_net.c
@@ -1901,7 +1901,7 @@ static int isdn_net_header(struct sk_buff *skb, struct net_device *dev,
 {
 	isdn_net_local *lp = netdev_priv(dev);
 	unsigned char *p;
-	ushort len = 0;
+	int len = 0;

 	switch (lp->p_encap) {
 		case ISDN_NET_ENCAP_ETHER:
Permalink | Reply | 2 comments |
headers
Jeff Kirsher | 9 Feb 11:27
Picon
Favicon

[net-next 0/7][pull request] Intel Wired LAN Driver Updates

The following series contains updates to igb and e1000e.
Majority of the updates are to e1000e and do the following:
 - several cleanups which remove unnecessary () and returns from void
   functions
 - remove test that is always false
 - use 'true' instead of '1' for boolean
The one igb fix resolves warning about unused function.

The following are changes since commit a584b7ae4ef01425f6827657abdc3e4db49b3578:
  netxen_nic: signedness bug in netxen_md_entry_err_chk()
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Bruce Allan (6):
  e1000e: remove test that is always false
  e1000e: remove unnecessary returns from void functions
  e1000e: remove unnecessary parentheses
  e1000e: use true/false for bool autoneg_false
  e1000e: pass pointer to hw struct for e1000_init_mac_params_XXX()
  e1000e: replace '1' with 'true' for boolean get_link_status

Emil Tantilov (1):
  igb: fix warning about unused function

 drivers/net/ethernet/intel/e1000e/80003es2lan.c |    7 ++---
 drivers/net/ethernet/intel/e1000e/82571.c       |    9 +++---
 drivers/net/ethernet/intel/e1000e/ethtool.c     |    4 +-
 drivers/net/ethernet/intel/e1000e/ich8lan.c     |    8 +----
 drivers/net/ethernet/intel/e1000e/mac.c         |   32 ++++++++++-------------
 drivers/net/ethernet/intel/e1000e/manage.c      |    2 +-
(Continue reading)

Permalink | Reply | 12 comments |
headers
Jeff Kirsher | 9 Feb 10:34
Picon
Favicon

[net v2 0/8][pull request] Intel Wired LAN Driver Updates

The following series contains fixes to e1000, igb and ixgbe.
The e1000 fix comes from Red Hat, where a previous commit removed
code which broke WoL and this patch rectifies that. The igb patch
fixes an issue with VF lookup.  The remaining patches in the series
are against ixgbe and fix the following:
 - VF lookup and Tx hang with 32 VFs
 - broken dependency on MAX_SKB_FRAGS
 - ethtool buffer overrun in stats
 - DCB fix for up2tc mapping being lost on disable/enable

v2- fix the formatting in the "ixgbe: fix vf lookup" patch.

The following are changes since commit 64db880e7488a6d31363ad17c4c0590f27fd48e5:
  Merge branch 'for-davem' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net master

Alexander Duyck (1):
  ixgbe: Fix broken dependency on MAX_SKB_FRAGS being related to page
    size

Dean Nelson (1):
  e1000: add dropped DMA receive enable back in for WoL

Greg Rose (3):
  igb: fix vf lookup
  ixgbe: fix vf lookup
  ixgbe: Fix case of Tx Hang in PF with 32 VFs

John Fastabend (2):
(Continue reading)

Permalink | Reply | 10 comments |

Gmane