headers
Wanlong Gao | 1 Feb 2012 01:34
Favicon
Gravatar

Re: [PATCH v2 0/5] hugemmap: coding style cleanups

On 01/30/2012 11:30 AM, Wanlong Gao wrote:

> Hi :
> This is the V2 of this cleanups, thanks for Casper's comments.

Ping, commit this set first?

> 
> Thanks
> -Wanlong Gao
> 
> 
> Wanlong Gao (5):
>   hugemmap01: coding style cleanups
>   hugemmap02: coding style cleanups
>   hugemmap03: coding style cleanups
>   hugemmap04: coding style cleanups
>   hugemmap05: coding style cleanups
> 
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap01.c |  158 ++++++++----------
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap02.c |  182 +++++++++-----------
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c |  125 ++++++-------
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c |  178 +++++++++----------
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c |   22 ++-
>  5 files changed, 308 insertions(+), 357 deletions(-)
> 

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jin Li | 1 Feb 2012 08:24
Favicon

[PATCH] Fix for msgctl test case msgctl11 on the target with more than 4G memory

The test msgctl11 will fail with log as follows once it is on the
target with more than 4G memory and use default maximum pid value 32768.
Because in this case, the maxnkids is always 0 which will cause fail
and exit.

maxnkids = ((free_pids / 4) / MSGMNI);

The fix will update the maximum pid value to meet the basic need of
free pids on the target with more than 4G memory.

Test msgctl11 fail log

"msgctl11    1  TBROK  :  Not enough free pids"
---
 lib/system_specific_process_info.c              |   27 ++++++++++++++++++++++
 testcases/kernel/syscalls/ipc/msgctl/msgctl11.c |   28 +++++++++++++++++++++-
 2 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/lib/system_specific_process_info.c b/lib/system_specific_process_info.c
index d3c9638..aaa7f8b 100644
--- a/lib/system_specific_process_info.c
+++ b/lib/system_specific_process_info.c
 <at>  <at>  -59,6 +59,33  <at>  <at>  int get_max_pids(void)
 }

 
+int set_max_pids(int pids_max)
+{
+#ifdef __linux__
+
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jin Li | 1 Feb 2012 08:28
Favicon

Fix for msgctl test case msgctl11 on the target with more than 4G memory


Hi all 

Please ignore the last email which miss the  signiture 

Thanks

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
Permalink | Reply | 2 comments |
headers
Jin Li | 1 Feb 2012 08:28
Favicon

[PATCH] Fix for msgctl test case msgctl11 on the target with more than 4G memory

The test msgctl11 will fail with log as follows once it is on the
target with more than 4G memory and use default maximum pid value 32768.
Because in this case, the maxnkids is always 0 which will cause fail
and exit.

maxnkids = ((free_pids / 4) / MSGMNI);

The fix will update the maximum pid value to meet the basic need of
free pids on the target with more than 4G memory.

Test msgctl11 fail log

"msgctl11    1  TBROK  :  Not enough free pids"

Signed-off-by: Jin Li <jin.li@...>
---
 lib/system_specific_process_info.c              |   27 ++++++++++++++++++++++
 testcases/kernel/syscalls/ipc/msgctl/msgctl11.c |   28 +++++++++++++++++++++-
 2 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/lib/system_specific_process_info.c b/lib/system_specific_process_info.c
index d3c9638..aaa7f8b 100644
--- a/lib/system_specific_process_info.c
+++ b/lib/system_specific_process_info.c
 <at>  <at>  -59,6 +59,33  <at>  <at>  int get_max_pids(void)
 }

 
+int set_max_pids(int pids_max)
+{
(Continue reading)

Permalink | Reply | 1 comment |
headers
Kang Kai | 1 Feb 2012 10:54
Favicon

[PATCH] sigaction/16-1.c: make build pass on mips arch

There is no signal SIGTLKFLT on mips architecture. Remove SIGTLKFLT from
signal set when test on mips arch.

Signed-off-by: Kang Kai <kai.kang@...>
---
 .../conformance/interfaces/sigaction/16-1.c        |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
index 1eda711..213bda0 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
 <at>  <at>  -67,7 +67,9  <at>  <at>  static struct sig_info sigs[] = {
 	{SIGPIPE, "SIGPIPE", 0},
 	{SIGALRM, "SIGALRM", 0},
 	{SIGTERM, "SIGTERM", 0},
+#ifndef __mips__
 	{SIGSTKFLT, "SIGSTKFLT", 0},
+#endif
 	{SIGCHLD, "SIGCHLD", 0},
 	{SIGCONT, "SIGCONT", 0},
 	{SIGTSTP, "SIGTSTP", 0},
--

-- 
1.7.5.4

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
(Continue reading)

Permalink | Reply | 3 comments |
headers
Wanlong Gao | 1 Feb 2012 10:57
Favicon
Gravatar

Re: [PATCH v3 2/2] aio_suspend-8-1: use aio_error to check completion instead

Hi Cyril:
This is the latest version.
Any further comments on this?

Thanks
-Wanlong Gao

> aio_suspend() may be interrupted by IO request's completion signal, so we
> should use aio_error() instead of signal hander to check whether this request
> has complete.
> v2->v3: remove the aio submmit loop but add the aio waiting loop.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@...>
> ---
>  .../conformance/interfaces/aio_suspend/8-1.c       |   41 +++-----------------
>  1 files changed, 6 insertions(+), 35 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/8-1.c
> index 9af9463..0f0e211 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/8-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/8-1.c
>  <at>  <at>  -51,13 +51,6  <at>  <at>  int received_all	= 0;
>  void
>  sigrt1_handler(int signum, siginfo_t *info, void *context)
>  {
> -	if (info->si_value.sival_int == WAIT_FOR_AIOCB)
> -		received_selected = 1;
> -}
> -
> -void
(Continue reading)

Permalink | Reply | 0 comments |
headers
Cyril Hrubis | 1 Feb 2012 12:28
Picon

Re: [PATCH] sigaction/16-1.c: make build pass on mips arch

Hi!
> Signed-off-by: Kang Kai <kai.kang@...>
> ---
>  .../conformance/interfaces/sigaction/16-1.c        |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
> index 1eda711..213bda0 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/16-1.c
>  <at>  <at>  -67,7 +67,9  <at>  <at>  static struct sig_info sigs[] = {
>  	{SIGPIPE, "SIGPIPE", 0},
>  	{SIGALRM, "SIGALRM", 0},
>  	{SIGTERM, "SIGTERM", 0},
> +#ifndef __mips__
>  	{SIGSTKFLT, "SIGSTKFLT", 0},
> +#endif
>  	{SIGCHLD, "SIGCHLD", 0},
>  	{SIGCONT, "SIGCONT", 0},
>  	{SIGTSTP, "SIGTSTP", 0},

What about?

#ifdef SIGSTKFLT
  	{SIGSTKFLT, "SIGSTKFLT", 0},
#endif

Which should fix all possible systems without this signal.

--

--
(Continue reading)

Permalink | Reply | 2 comments |
headers
Cyril Hrubis | 1 Feb 2012 12:46
Picon

Re: [PATCH] mm/vma03: new testcase

Hi!
> diff --git a/testcases/kernel/mem/vma/vma03.c b/testcases/kernel/mem/vma/vma03.c
> new file mode 100644
> index 0000000..4fb321c
> --- /dev/null
> +++ b/testcases/kernel/mem/vma/vma03.c

You are missing runtest entry.

>  <at>  <at>  -0,0 +1,148  <at>  <at> 
> +/*
> + * Copyright (C) 2012 Red Hat, Inc.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of version 2 of the GNU General Public
> + * License as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> + *
> + * Further, this software is distributed without any warranty that it
> + * is free of the rightful claim of any third person regarding
> + * infringement or the like.  Any license provided herein, whether
> + * implied or otherwise, applies only to this software file.  Patent
> + * licenses, if any, provided herein do not apply to combinations of
> + * this program with other software, or any other product whatsoever.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write the Free Software
(Continue reading)

Permalink | Reply | 1 comment |
headers
Salvatore CRO' | 1 Feb 2012 12:56

Re: [PATCH] syscalls: fix creat07 setup and argv to execve

On 1/30/2012 4:45 PM, Carmelo AMOROSO wrote:
> On 25/01/2012 13.27, Salvatore CRO' wrote:
>> On 1/25/2012 1:00 PM, Carmelo AMOROSO wrote:
>>> On 25/01/2012 9.55, Salvatore CRO' wrote:
>>>> Fix test_path variable logic in setup function.
>>>> Also use a new argv variable to be passed to execve.
>>>>
>>>> Signed-off-by: Salvatore Cro<salvatore.cro@...>
>>>> ---
>>>>    testcases/kernel/syscalls/creat/creat07.c |   12 ++++++------
>>>>    1 files changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/testcases/kernel/syscalls/creat/creat07.c b/testcases/kernel/syscalls/creat/creat07.c
>>>> index 4ed2c22..43a6030 100644
>>>> --- a/testcases/kernel/syscalls/creat/creat07.c
>>>> +++ b/testcases/kernel/syscalls/creat/creat07.c
>>>>  <at>  <at>  -90,9 +90,8  <at>  <at>  int main(int ac, char **av)
>>>>    			tst_brkm(TBROK|TERRNO, cleanup, "fork #1 failed");
>>>>
>>>>    		if (pid == 0) {
>>>> -			char *av[1];
>>>> -			av[0] = basename(test_app);
>>>> -			(void)execve(test_app, av, NULL);
>>>> +			char *argv[] = { test_app, NULL };
>>>> +			(void)execve(test_app, argv, NULL);
>>>>    			perror("execve failed");
>>>>    			exit(1);
>>>>    		}
>>>>  <at>  <at>  -138,14 +137,15  <at>  <at>  void setup(char *app)
>>>>    	char *cmd, *pwd = NULL;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Salvatore CRO' | 1 Feb 2012 12:51

[PATCH] syscalls: fix creat07 setup and arg to execve

Fix typo in setup function as app[0] should be
checked instead of test_app[0].
Fix test_path concatenating the absolute
path to test_app when required (app[0] == '/').
Finally fix execve (returning Bad address - EFAULT)
argument av[1] as it requires argument
array to be terminated by a null pointer.

Signed-off-by: Salvatore Cro <salvatore.cro@...>
---
 testcases/kernel/syscalls/creat/creat07.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/creat/creat07.c b/testcases/kernel/syscalls/creat/creat07.c
index 4ed2c22..edaa182 100644
--- a/testcases/kernel/syscalls/creat/creat07.c
+++ b/testcases/kernel/syscalls/creat/creat07.c
 <at>  <at>  -92,6 +92,7  <at>  <at>  int main(int ac, char **av)
 		if (pid == 0) {
 			char *av[1];
 			av[0] = basename(test_app);
+			av[1] = NULL;
 			(void)execve(test_app, av, NULL);
 			perror("execve failed");
 			exit(1);
 <at>  <at>  -138,8 +139,9  <at>  <at>  void setup(char *app)
 	char *cmd, *pwd = NULL;
 	char test_path[MAXPATHLEN];

-	if (test_app[0] == '/')
(Continue reading)

Permalink | Reply | 3 comments |

Gmane