test message
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
Carmelo Amoroso wrote: > Hi All, > while I was running LTP I encountered some problems with mmap1.c. > Doing further investigation I found that the test contains some errors > making it really broken (in my opinion). > > - The "map_write_unmap" thread writes 'a' char into the mmapped memory > region pointed by the global variable map_address while the "read_mem" > thread read checks for the 'a' char into another malloced memory region > pointed by mem_content, so the check will always fail > > - Even if the malloc of mem_content is pointless in my opinion, the call is wrong > because it does a malloc(0) > > mem_content = malloc(sizeof(char) * rd_index); > > where rd_index is 0. > Again, while glibc may returns a valid pointer, other libs may not (i.e. uClibc) > so it's not reliable. > > - Each call of pthread_exit passes '&exit_value' while should pass 'exit_value' > > - The command line parsing is broken due to a missing break statement in the case 'v' > > - In the 'main' function the check for the exit status of the threads should be > if(status[trd_ndx]) instead of if(!status[trd_ndx]) > > Now, my bigger concern is about the use of the mem_content pointer for the check of the > memory content: is it a really broken code or I'm missing something ? > > When I will successfully run the test on my target I'll post a complete patch for this test. > > Regards, > Carmelo > > Hi, we found another issue regarding thread synchronization by means of the usleep use: the reader thread accessed a memory region not longer mmapped and during the last loop it caught a SIGSEV. The proposed patch rework the test according to my previuos comments and now runs successfully both with glibc and uClibc. Any comments are welcome Regards, Carmelo
--- ltp-orig/testcases/kernel/mem/mtest06/mmap1.c 2006-02-11 05:55:58.000000000 +0100
+++ ltp-full-20070228/testcases/kernel/mem/mtest06/mmap1.c 2007-05-02 16:41:15.241233000 +0200
<at> <at> -349,7 +349,7 <at> <at> map_write_unmap(void *args) /* file desc
{
perror("map_write_unmap(): mmap()");
exit_val = MWU_FAIL;
- pthread_exit((void *)&exit_val);
+ pthread_exit((void *)exit_val);
}
if(verbose_print)
<at> <at> -368,11 +368,11 <at> <at> map_write_unmap(void *args) /* file desc
{
perror("map_write_unmap(): mmap()");
exit_val = MWU_FAIL;
- pthread_exit((void *)&exit_val);
+ pthread_exit((void *)exit_val);
}
}
exit_val = M_SUCCESS;
- pthread_exit((void *)&exit_val);
+ pthread_exit((void *)exit_val);
}
<at> <at> -395,7 +395,6 <at> <at> read_mem(void *args) /* number of reads
{
static int rd_index = 0; /* index to the number of reads performed. */
long *rmargs = args; /* local pointer to the arguments */
- char *mem_content; /* content of memory read */
volatile int exit_val = 0; /* pthread exit value */
if (verbose_print)
<at> <at> -405,7 +404,6 <at> <at> read_mem(void *args) /* number of reads
"read from address %p\n",
(int)rmargs[2], (long *)map_address);
- mem_content = malloc(sizeof(char) * rd_index);
while (rd_index++ < (int)rmargs[2])
{
fprintf(stdout, "pid[%d] - read contents of memory %p %ld times\n",
<at> <at> -414,7 +412,6 <at> <at> read_mem(void *args) /* number of reads
fprintf(stdout,
"read_mem() in while loop %d times to go %ld times\n",
rd_index, rmargs[2]);
- usleep(1);
if (setjmp(jmpbuf) == 1)
{
<at> <at> -428,16 +425,17 <at> <at> read_mem(void *args) /* number of reads
if (verbose_print)
fprintf(stdout,
"read_mem(): content of memory: %s\n", (char *)map_address);
- if (strncmp(mem_content, "a", 1) != 0)
+ if (strncmp((char *)map_address, "a", 1) != 0)
{
exit_val = -1;
- pthread_exit((void *)&exit_val);
+ pthread_exit((void *)exit_val);
}
+ usleep(1);
}
}
exit_val = M_SUCCESS;
- pthread_exit((void *)&exit_val);
+ pthread_exit((void *)exit_val);
}
<at> <at> -530,7 +528,7 <at> <at> main(int argc, /* number of input para
num_iter = 1000;
exec_time = 24;
- while ((c = getopt(argc, argv, "h:l:s:x:")) != -1)
+ while ((c = getopt(argc, argv, "hvl:s:x:")) != -1)
{
switch(c)
{
<at> <at> -551,6 +549,7 <at> <at> main(int argc, /* number of input para
break;
case 'v':
verbose_print = TRUE;
+ break;
case 'x':
if ((exec_time = atoi(optarg)) == (int)NULL)
exec_time = 24;
<at> <at> -642,7 +641,7 <at> <at> main(int argc, /* number of input para
}
else
{
- if (!status[thrd_ndx])
+ if (status[thrd_ndx])
{
fprintf(stderr,
"thread [%ld] - process exited with errors %d\n",
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
setup script which is part of kdump tests in ltp has few config variables which are no longer used. This patch removes those variables. Please review. Thanks -Sachin
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
Michael Reed wrote: > The Linux Test Project test suite <http://www.linuxtestproject.org> has > been released for the month of April 2007. The latest version of the > testsuite > contains 2900+ tests for the Linux OS. Our web site also contains other > information such as: > - A Linux test tools matrix > - Technical papers > - How To's on Linux testing > - Code coverage analysis tool. > > We encourage the community to post results to ltp-results@..., > and patches, new tests, or comments/questions to ltp-list@... Hi, It looks like the web site has not been updated yet and still points to the March release. It looks like I was able to get the April release with this URL: http://prdownloads.sourceforge.net/ltp/ltp-full-20070430.tgz?download > > See ChangeLog Below > > LTP-20070430 > > -Integration of UTS Namespace Testcases to LTP as submitted by > <risrajak@...> > ltp/README > ltp/runtest/containers > ltp/runltp > ltp/testcases/kernel/Makefile > ltp/testcases/kernel/containers/Makefile > ltp/testcases/kernel/containers/README > ltp/testcases/kernel/containers/container_test.sh > ltp/testcases/kernel/containers/libclone/Makefile > ltp/testcases/kernel/containers/libclone/libclone.c > ltp/testcases/kernel/containers/libclone/libclone.h > ltp/testcases/kernel/containers/utsname/Makefile > ltp/testcases/kernel/containers/utsname/README > ltp/testcases/kernel/containers/utsname/check_utsns_enabled.c > ltp/testcases/kernel/containers/utsname/runtests_noltp.sh > ltp/testcases/kernel/containers/utsname/runutstest.sh > ltp/testcases/kernel/containers/utsname/utstest.c > ltp/testscripts/test_containers.sh > > -Integrating "KDUMP" testcases to LTP Test Suite as Submitted by > <sachinp@...> > ltp/README > ltp/testcases/Makefile > ltp/testcases/kdump/README > ltp/testcases/kdump/crash_cmds > ltp/testcases/kdump/distro > ltp/testcases/kdump/master > ltp/testcases/kdump/setup > ltp/testcases/kdump/sysinfo > ltp/testcases/kdump/test > ltp/testcases/kdump/tests > ltp/testcases/kdump/verify > ltp/testcases/kdump/rhtools/Makefile > ltp/testcases/kdump/rhtools/OO_Descriptions.txt > ltp/testcases/kdump/rhtools/crasher_mod/Makefile > ltp/testcases/kdump/rhtools/crasher_mod/crasher.c > ltp/testcases/kdump/rhtools/lkdtm_mod/Makefile > ltp/testcases/kdump/rhtools/lkdtm_mod/lkdtm.c > ltp/testcases/kdump/susetools/Makefile > ltp/testcases/kdump/susetools/Attic/OO_Description.txt > ltp/testcases/kdump/susetools/crasher_mod/Makefile > ltp/testcases/kdump/susetools/crasher_mod/crasher.c > ltp/testcases/kdump/testlists/crasher > ltp/testcases/kdump/testlists/Attic/i386-basic > ltp/testcases/kdump/testlists/Attic/i386-lkdtt > ltp/testcases/kdump/testlists/Attic/i386-manual > ltp/testcases/kdump/testlists/lkdtm.orig > ltp/testcases/kdump/testlists/Attic/ppc64-basic > ltp/testcases/kdump/testlists/Attic/ppc64-lkdtt > ltp/testcases/kdump/testlists/Attic/ppc64-manual > ltp/testcases/kdump/testlists/Attic/x86_64-basic > ltp/testcases/kdump/testlists/Attic/x86_64-lkdtt > ltp/testcases/kdump/testlists/Attic/x86_64-manual > > - <sachinp@...> removed unwanted files from > ltp/testcases/kdump/testlists directory > ltp/testcases/kdump/testlists/Attic/i386-basic > ltp/testcases/kdump/testlists/Attic/ppc64-basic > ltp/testcases/kdump/testlists/Attic/x86_64-basic > > -Patch Submitted by <sachinp@...> which removes the lkdtt > code and adds lkdtm code > ltp/testcases/kdump/test > ltp/testcases/kdump/susetools/Makefile > ltp/testcases/kdump/susetools/Attic/OO_Description.txt > ltp/testcases/kdump/susetools/OO_Descriptions.txt > ltp/testcases/kdump/susetools/lkdtm_mod/Makefile > ltp/testcases/kdump/susetools/lkdtm_mod/lkdtm.c > ltp/testcases/kdump/testlists/Attic/i386-lkdtt > ltp/testcases/kdump/testlists/Attic/i386-manual > ltp/testcases/kdump/testlists/Attic/ppc64-lkdtt > ltp/testcases/kdump/testlists/Attic/ppc64-manual > ltp/testcases/kdump/testlists/Attic/x86_64-lkdtt > ltp/testcases/kdump/testlists/Attic/x86_64-manual > > -Patch Submitted by <sachinp@...> for some configuration > settings as pointed out by <jburke@...> > -<sachinp@...> added options to select/run crasher/lkdtt tests on > SLES > -Patch Submitted by <sachinp@...> which removes the lkdtt > code and adds lkdtm code > ltp/testcases/kdump/setup > > - Patch Applied as submitted by <jburke@...> for 1)Changed the way > runltp makes the temp directory, and 2) removing LOCTMP and adding in the > LTPTMP in its place and clean up files when it is done > ltp/runltp > ltp/testcases/commands/tar/tar_tests.sh > > -Applied Patch submitted by "elliot_lee", against bug no. "[ 1697311 ] > Compile error of 'lib/parse_opts.c' " > ltp/ > > -Fix for Bug no. 1671695, Check return codes everywhere, as pointed out by > 'Markus Elfring' > ltp/lib/tst_tmpdir.c > > -Modifications to prevent Warnings during compilation > ltp/lib/write_log.c > > -Changes to include 'egrep' as pointed out by 'kmaffey' [LTP Bug no. > 1701305, logrotate_tests.sh fails on CentOS 4.4] > ltp/testcases/commands/logrotate/logrotate_tests.sh > > -Patch Submitted by <sachinp@...> for some configuration > settings as pointed out by <jburke@...> > ltp/testcases/kdump/README > > -Fix for Bug No 1592647, incorrect testcase diotest4-4, as pointed out by > "Vagin Andrey" > ltp/testcases/kernel/io/direct_io/diotest4.c > > -remove silly reliance on -DLINUX > ltp/testcases/kernel/mem/vmtests/Makefile > ltp/testcases/kernel/mem/vmtests/data_space.c > ltp/testcases/kernel/mem/vmtests/stack_space.c > > -Applied Patch to change the way shmat() operates, pointed out/submitted > by YI XU<yxu@...> > ltp/testcases/kernel/sched/process_stress/process.c > > -Fix for BUG no. "[1607899]" exit02 uses strcmp() on unterminated string, > as pointed out by "ndade" > -Fixed Bug No. ['1607881', "exit02 child does close() when description > says it does not"], as pointed out by <Nicolas Dade> > ltp/testcases/kernel/syscalls/exit/exit02.c > > -Fix for Bug no. '1221744' (fork12 race condition), as pointed by "Carl > van Schaik" > ltp/testcases/kernel/syscalls/fork/fork12.c > > -Applied Patch as submitted by "creese123" for bug no. ["1694484", semop01 > corrupting get_arr.array] > ltp/testcases/kernel/syscalls/ipc/semop/semop01.c > > -Fix for Bug no. "1687908"(raised by 'bdubbs'), patch submitted by > <doug.chapman@...> > ltp/testcases/kernel/syscalls/mincore/mincore01.c > > -Fix for BUG no. "[1608461]" pipe10 calls strcmp() on unterminated string, > as pointed out by "ndade" > ltp/testcases/kernel/syscalls/pipe/pipe10.c > > -Fix for BUG no. "[1608492]" read04 calls strcmp() on unterminated string > as submitted by "ndade" > ltp/testcases/kernel/syscalls/read/read04.c > > -Modifications to prevent Warnings during compilation > ltp/testcases/kernel/syscalls/rename/rename14.c > > -Fixing 'sysfs01' testcase to make it ask for File System Index of 'proc' > instead of 'ext2' as pointed out by <doug.chapman@...> > ltp/testcases/kernel/syscalls/sysfs/sysfs01.c > > -Addressing the Issue when RHOST can be an IP_ADDRESS, as pointed out by > "Ambar Seksena" <ambar.seksena@...> > ltp/testcases/network/rpc/rusers/rusers01 > > -Patch for S390-31/64 Architecture, submitted by "B. N. > Poornima"<bnpoorni@...> > ltp/testscripts/ltpstress.sh > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Ltp-list mailing list > Ltp-list@... > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
Hi Mike,
This has been updated now.
Regards & Thanks--
Subrata Modak,
====================================
====================================
Mike Gahagan
<mgahagan <at> redhat.
com> To
Sent by: Michael Reed <mreed10@...>
ltp-list-bounces <at> cc
lists.sourceforge ltp-list@...
.net Subject
Re: [LTP] [ANNOUNCE] The Linux
Test Project ltp-20070430 Released
05/03/07 08:26 PM
Michael Reed wrote:
> The Linux Test Project test suite <http://www.linuxtestproject.org> has
> been released for the month of April 2007. The latest version of the
> testsuite
> contains 2900+ tests for the Linux OS. Our web site also contains other
> information such as:
> - A Linux test tools matrix
> - Technical papers
> - How To's on Linux testing
> - Code coverage analysis tool.
>
> We encourage the community to post results to ltp-results@...,
> and patches, new tests, or comments/questions to ltp-list@...
Hi,
It looks like the web site has not been updated yet and still points to
the March release. It looks like I was able to get the April release
with this URL:
http://prdownloads.sourceforge.net/ltp/ltp-full-20070430.tgz?download
>
> See ChangeLog Below
>
> LTP-20070430
>
> -Integration of UTS Namespace Testcases to LTP as submitted by
> <risrajak@...>
> ltp/README
> ltp/runtest/containers
> ltp/runltp
> ltp/testcases/kernel/Makefile
> ltp/testcases/kernel/containers/Makefile
> ltp/testcases/kernel/containers/README
> ltp/testcases/kernel/containers/container_test.sh
> ltp/testcases/kernel/containers/libclone/Makefile
> ltp/testcases/kernel/containers/libclone/libclone.c
> ltp/testcases/kernel/containers/libclone/libclone.h
> ltp/testcases/kernel/containers/utsname/Makefile
> ltp/testcases/kernel/containers/utsname/README
> ltp/testcases/kernel/containers/utsname/check_utsns_enabled.c
> ltp/testcases/kernel/containers/utsname/runtests_noltp.sh
> ltp/testcases/kernel/containers/utsname/runutstest.sh
> ltp/testcases/kernel/containers/utsname/utstest.c
> ltp/testscripts/test_containers.sh
>
> -Integrating "KDUMP" testcases to LTP Test Suite as Submitted by
> <sachinp@...>
> ltp/README
> ltp/testcases/Makefile
> ltp/testcases/kdump/README
> ltp/testcases/kdump/crash_cmds
> ltp/testcases/kdump/distro
> ltp/testcases/kdump/master
> ltp/testcases/kdump/setup
> ltp/testcases/kdump/sysinfo
> ltp/testcases/kdump/test
> ltp/testcases/kdump/tests
> ltp/testcases/kdump/verify
> ltp/testcases/kdump/rhtools/Makefile
> ltp/testcases/kdump/rhtools/OO_Descriptions.txt
> ltp/testcases/kdump/rhtools/crasher_mod/Makefile
> ltp/testcases/kdump/rhtools/crasher_mod/crasher.c
> ltp/testcases/kdump/rhtools/lkdtm_mod/Makefile
> ltp/testcases/kdump/rhtools/lkdtm_mod/lkdtm.c
> ltp/testcases/kdump/susetools/Makefile
> ltp/testcases/kdump/susetools/Attic/OO_Description.txt
> ltp/testcases/kdump/susetools/crasher_mod/Makefile
> ltp/testcases/kdump/susetools/crasher_mod/crasher.c
> ltp/testcases/kdump/testlists/crasher
> ltp/testcases/kdump/testlists/Attic/i386-basic
> ltp/testcases/kdump/testlists/Attic/i386-lkdtt
> ltp/testcases/kdump/testlists/Attic/i386-manual
> ltp/testcases/kdump/testlists/lkdtm.orig
> ltp/testcases/kdump/testlists/Attic/ppc64-basic
> ltp/testcases/kdump/testlists/Attic/ppc64-lkdtt
> ltp/testcases/kdump/testlists/Attic/ppc64-manual
> ltp/testcases/kdump/testlists/Attic/x86_64-basic
> ltp/testcases/kdump/testlists/Attic/x86_64-lkdtt
> ltp/testcases/kdump/testlists/Attic/x86_64-manual
>
> - <sachinp@...> removed unwanted files from
> ltp/testcases/kdump/testlists directory
> ltp/testcases/kdump/testlists/Attic/i386-basic
> ltp/testcases/kdump/testlists/Attic/ppc64-basic
> ltp/testcases/kdump/testlists/Attic/x86_64-basic
>
> -Patch Submitted by <sachinp@...> which removes
the lkdtt
> code and adds lkdtm code
> ltp/testcases/kdump/test
> ltp/testcases/kdump/susetools/Makefile
> ltp/testcases/kdump/susetools/Attic/OO_Description.txt
> ltp/testcases/kdump/susetools/OO_Descriptions.txt
> ltp/testcases/kdump/susetools/lkdtm_mod/Makefile
> ltp/testcases/kdump/susetools/lkdtm_mod/lkdtm.c
> ltp/testcases/kdump/testlists/Attic/i386-lkdtt
> ltp/testcases/kdump/testlists/Attic/i386-manual
> ltp/testcases/kdump/testlists/Attic/ppc64-lkdtt
> ltp/testcases/kdump/testlists/Attic/ppc64-manual
> ltp/testcases/kdump/testlists/Attic/x86_64-lkdtt
> ltp/testcases/kdump/testlists/Attic/x86_64-manual
>
> -Patch Submitted by <sachinp@...> for some configuration
> settings as pointed out by <jburke@...>
> -<sachinp@...> added options to select/run crasher/lkdtt
tests on
> SLES
> -Patch Submitted by <sachinp@...> which removes
the lkdtt
> code and adds lkdtm code
> ltp/testcases/kdump/setup
>
> - Patch Applied as submitted by <jburke@...> for 1)Changed the way
> runltp makes the temp directory, and 2) removing LOCTMP and adding in the
> LTPTMP in its place and clean up files when it is done
> ltp/runltp
> ltp/testcases/commands/tar/tar_tests.sh
>
> -Applied Patch submitted by "elliot_lee", against bug no. "[ 1697311 ]
> Compile error of 'lib/parse_opts.c' "
> ltp/
>
> -Fix for Bug no. 1671695, Check return codes everywhere, as pointed out
by
> 'Markus Elfring'
> ltp/lib/tst_tmpdir.c
>
> -Modifications to prevent Warnings during compilation
> ltp/lib/write_log.c
>
> -Changes to include 'egrep' as pointed out by 'kmaffey' [LTP Bug no.
> 1701305, logrotate_tests.sh fails on CentOS 4.4]
> ltp/testcases/commands/logrotate/logrotate_tests.sh
>
> -Patch Submitted by <sachinp@...> for some configuration
> settings as pointed out by <jburke@...>
> ltp/testcases/kdump/README
>
> -Fix for Bug No 1592647, incorrect testcase diotest4-4, as pointed out by
> "Vagin Andrey"
> ltp/testcases/kernel/io/direct_io/diotest4.c
>
> -remove silly reliance on -DLINUX
> ltp/testcases/kernel/mem/vmtests/Makefile
> ltp/testcases/kernel/mem/vmtests/data_space.c
> ltp/testcases/kernel/mem/vmtests/stack_space.c
>
> -Applied Patch to change the way shmat() operates, pointed out/submitted
> by YI XU<yxu@...>
> ltp/testcases/kernel/sched/process_stress/process.c
>
> -Fix for BUG no. "[1607899]" exit02 uses strcmp() on unterminated string,
> as pointed out by "ndade"
> -Fixed Bug No. ['1607881', "exit02 child does close() when description
> says it does not"], as pointed out by <Nicolas Dade>
> ltp/testcases/kernel/syscalls/exit/exit02.c
>
> -Fix for Bug no. '1221744' (fork12 race condition), as pointed by "Carl
> van Schaik"
> ltp/testcases/kernel/syscalls/fork/fork12.c
>
> -Applied Patch as submitted by "creese123" for bug no. ["1694484",
semop01
> corrupting get_arr.array]
> ltp/testcases/kernel/syscalls/ipc/semop/semop01.c
>
> -Fix for Bug no. "1687908"(raised by 'bdubbs'), patch submitted by
> <doug.chapman@...>
> ltp/testcases/kernel/syscalls/mincore/mincore01.c
>
> -Fix for BUG no. "[1608461]" pipe10 calls strcmp() on unterminated
string,
> as pointed out by "ndade"
> ltp/testcases/kernel/syscalls/pipe/pipe10.c
>
> -Fix for BUG no. "[1608492]" read04 calls strcmp() on unterminated string
> as submitted by "ndade"
> ltp/testcases/kernel/syscalls/read/read04.c
>
> -Modifications to prevent Warnings during compilation
> ltp/testcases/kernel/syscalls/rename/rename14.c
>
> -Fixing 'sysfs01' testcase to make it ask for File System Index of 'proc'
> instead of 'ext2' as pointed out by <doug.chapman@...>
> ltp/testcases/kernel/syscalls/sysfs/sysfs01.c
>
> -Addressing the Issue when RHOST can be an IP_ADDRESS, as pointed out by
> "Ambar Seksena" <ambar.seksena@...>
> ltp/testcases/network/rpc/rusers/rusers01
>
> -Patch for S390-31/64 Architecture, submitted by "B. N.
> Poornima"<bnpoorni@...>
> ltp/testscripts/ltpstress.sh
>
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
Done Sachin, Regards-- Subrata Sachin P. Sant wrote: > setup script which is part of kdump tests in ltp has few > config variables which are no longer used. This patch removes > those variables. Please review. > > Thanks > -Sachin > > ------------------------------------------------------------------------ > > * Remove variables which are no longer needed > > Signed-off-by : <sachinp@...> Sachin Sant > --- > > diff -Naurp ltp/testcases/kdump/setup ltp-kdump/testcases/kdump/setup > --- ltp/testcases/kdump/setup 2007-05-03 16:34:38.000000000 +0530 > +++ ltp-kdump/testcases/kdump/setup 2007-05-03 16:45:13.000000000 +0530 > <at> <at> -209,17 +209,7 <at> <at> echo "SYSINFO_SCR=\$TEST_BASE_DIR/sysinf > > # Tools > echo "CRASHER_MOD=\$TEST_BASE_DIR/tools/crasher_mod/crasher.ko" >> $CONFIG_FILE > -if [ $DISTRO_SUSE -eq 1 ]; then > -echo "TTUTILS_BIN=\$TEST_BASE_DIR/tools/dtt_tools/ttutils" >> $CONFIG_FILE > -echo "MEMDRAIN_BIN=\$TEST_BASE_DIR/tools/dtt_tools/helper/memdrain" >> $CONFIG_FILE > -echo "SETUID_BIN=\$TEST_BASE_DIR/tools/dtt_tools/helper/setuid" >> $CONFIG_FILE > -echo "ALARM_BIN=\$TEST_BASE_DIR/tools/dtt_tools/helper/alarm" >> $CONFIG_FILE > -echo "BRK_BIN=\$TEST_BASE_DIR/tools/dtt_tools/helper/brk" >> $CONFIG_FILE > -fi > - > -if [ $DISTRO_RH -eq 1 ]; then > echo "LKDTM=\$TEST_BASE_DIR/tools/lkdtm_mod/lkdtm.ko" >> $CONFIG_FILE > -fi > > # > # Create the control file > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
I suspect there'll be more of these. The make _fails_ if the arch is not in the set preprocessed in the header. That means others cannot use LTP without changing it. Ideally, these tests would become noops if the arch wasn't there or the kernel did not have unshare. As it is, unshare is required for use of LTP. In my case, I reset TARGETS to empty and comment out the install target in the both of the Makefiles under testcases/kernel/containers. That's quick but, clearly, this solution is not patch material. I'm waiting for our kernel expert to get in to find out if we intend to support unshare in the near future. Mike Melendez Test Lead SiCortex Maynard, MA Subrata Modak wrote: > > > ------------------------------------------------------------------------ > > diff -Nuarp ltp-full-20070430/testcases/kernel/containers/libclone/libclone.h ltp-full-20070430.new/testcases/kernel/containers/libclone/libclone.h > --- ltp-full-20070430/testcases/kernel/containers/libclone/libclone.h 2007-05-05 05:07:22.000000000 -0400 > +++ ltp-full-20070430.new/testcases/kernel/containers/libclone/libclone.h 2007-05-05 05:06:10.000000000 -0400 > <at> <at> -26,7 +26,7 <at> <at> > #define SYS_unshare 1296 > #elif __x86_64__ > #define SYS_unshare 272 > -#elif __s390x__ > +#elif __s390x__ || __s390__ > #define SYS_unshare 303 > #elif __powerpc__ > #define SYS_unshare 282 ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
Hi Carmelo,
Applied your Patch Manually as it created some problems with the APRIL
version. The attached is the diff-ed patch that i generated against
APRIL release. Please verify it. I also found some page faults in my
machines when i ran the modified mmap1. Please see the attached tar
containing outputs and logs of the test results done on
"2.6.9-42.0.3.EL" and "2.6.18-1.2961.el5" kernels. But logs say that
tests passed.
Regards--
Subrata
Carmelo AMOROSO wrote:
> Carmelo Amoroso wrote:
>> Hi All,
>> while I was running LTP I encountered some problems with mmap1.c.
>> Doing further investigation I found that the test contains some errors
>> making it really broken (in my opinion).
>>
>> - The "map_write_unmap" thread writes 'a' char into the mmapped memory
>> region pointed by the global variable map_address while the "read_mem"
>> thread read checks for the 'a' char into another malloced memory region
>> pointed by mem_content, so the check will always fail
>>
>> - Even if the malloc of mem_content is pointless in my opinion, the
>> call is wrong
>> because it does a malloc(0)
>>
>> mem_content = malloc(sizeof(char) * rd_index);
>>
>> where rd_index is 0.
>> Again, while glibc may returns a valid pointer, other libs may not
>> (i.e. uClibc)
>> so it's not reliable.
>>
>> - Each call of pthread_exit passes '&exit_value' while should pass
>> 'exit_value'
>>
>> - The command line parsing is broken due to a missing break statement
>> in the case 'v'
>>
>> - In the 'main' function the check for the exit status of the threads
>> should be
>> if(status[trd_ndx]) instead of if(!status[trd_ndx])
>>
>> Now, my bigger concern is about the use of the mem_content pointer
>> for the check of the
>> memory content: is it a really broken code or I'm missing something ?
>>
>> When I will successfully run the test on my target I'll post a
>> complete patch for this test.
>>
>> Regards,
>> Carmelo
>>
>>
> Hi,
> we found another issue regarding thread synchronization by means of
> the usleep use:
> the reader thread accessed a memory region not longer mmapped and
> during the last
> loop it caught a SIGSEV.
> The proposed patch rework the test according to my previuos comments
> and now runs
> successfully both with glibc and uClibc.
>
> Any comments are welcome
>
> Regards,
> Carmelo
> ------------------------------------------------------------------------
>
> --- ltp-orig/testcases/kernel/mem/mtest06/mmap1.c 2006-02-11 05:55:58.000000000 +0100
> +++ ltp-full-20070228/testcases/kernel/mem/mtest06/mmap1.c 2007-05-02 16:41:15.241233000 +0200
> <at> <at> -349,7 +349,7 <at> <at> map_write_unmap(void *args) /* file desc
> {
> perror("map_write_unmap(): mmap()");
> exit_val = MWU_FAIL;
> - pthread_exit((void *)&exit_val);
> + pthread_exit((void *)exit_val);
> }
>
> if(verbose_print)
> <at> <at> -368,11 +368,11 <at> <at> map_write_unmap(void *args) /* file desc
> {
> perror("map_write_unmap(): mmap()");
> exit_val = MWU_FAIL;
> - pthread_exit((void *)&exit_val);
> + pthread_exit((void *)exit_val);
> }
> }
> exit_val = M_SUCCESS;
> - pthread_exit((void *)&exit_val);
> + pthread_exit((void *)exit_val);
> }
>
>
> <at> <at> -395,7 +395,6 <at> <at> read_mem(void *args) /* number of reads
> {
> static int rd_index = 0; /* index to the number of reads performed. */
> long *rmargs = args; /* local pointer to the arguments */
> - char *mem_content; /* content of memory read */
> volatile int exit_val = 0; /* pthread exit value */
>
> if (verbose_print)
> <at> <at> -405,7 +404,6 <at> <at> read_mem(void *args) /* number of reads
> "read from address %p\n",
> (int)rmargs[2], (long *)map_address);
>
> - mem_content = malloc(sizeof(char) * rd_index);
> while (rd_index++ < (int)rmargs[2])
> {
> fprintf(stdout, "pid[%d] - read contents of memory %p %ld times\n",
> <at> <at> -414,7 +412,6 <at> <at> read_mem(void *args) /* number of reads
> fprintf(stdout,
> "read_mem() in while loop %d times to go %ld times\n",
> rd_index, rmargs[2]);
> - usleep(1);
>
> if (setjmp(jmpbuf) == 1)
> {
> <at> <at> -428,16 +425,17 <at> <at> read_mem(void *args) /* number of reads
> if (verbose_print)
> fprintf(stdout,
> "read_mem(): content of memory: %s\n", (char *)map_address);
> - if (strncmp(mem_content, "a", 1) != 0)
> + if (strncmp((char *)map_address, "a", 1) != 0)
> {
> exit_val = -1;
> - pthread_exit((void *)&exit_val);
> + pthread_exit((void *)exit_val);
> }
> + usleep(1);
> }
>
> }
> exit_val = M_SUCCESS;
> - pthread_exit((void *)&exit_val);
> + pthread_exit((void *)exit_val);
> }
>
>
> <at> <at> -530,7 +528,7 <at> <at> main(int argc, /* number of input para
> num_iter = 1000;
> exec_time = 24;
>
> - while ((c = getopt(argc, argv, "h:l:s:x:")) != -1)
> + while ((c = getopt(argc, argv, "hvl:s:x:")) != -1)
> {
> switch(c)
> {
> <at> <at> -551,6 +549,7 <at> <at> main(int argc, /* number of input para
> break;
> case 'v':
> verbose_print = TRUE;
> + break;
> case 'x':
> if ((exec_time = atoi(optarg)) == (int)NULL)
> exec_time = 24;
> <at> <at> -642,7 +641,7 <at> <at> main(int argc, /* number of input para
> }
> else
> {
> - if (!status[thrd_ndx])
> + if (status[thrd_ndx])
> {
> fprintf(stderr,
> "thread [%ld] - process exited with errors %d\n",
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
RSS Feed64 | |
|---|---|
220 | |
213 | |
157 | |
78 | |
96 | |
77 | |
79 | |
149 | |
52 | |
221 | |
155 | |
102 | |
136 | |
151 | |
202 | |
353 | |
343 | |
148 | |
116 | |
65 | |
125 | |
169 | |
89 | |
64 | |
70 | |
217 | |
168 | |
175 | |
262 | |
206 | |
294 | |
199 | |
161 | |
194 | |
141 | |
83 | |
119 | |
165 | |
242 | |
231 | |
313 | |
220 | |
271 | |
288 | |
228 | |
447 | |
513 | |
355 | |
280 | |
305 | |
369 | |
317 | |
396 | |
381 | |
368 | |
571 | |
334 | |
469 | |
288 | |
329 | |
416 | |
371 | |
285 | |
321 | |
277 | |
130 | |
137 | |
78 | |
87 | |
54 | |
90 | |
98 | |
141 | |
110 | |
99 | |
20 | |
14 | |
19 | |
11 | |
43 | |
55 | |
140 | |
24 | |
42 | |
50 | |
31 | |
24 | |
48 | |
23 | |
40 | |
27 | |
32 | |
49 | |
76 | |
61 | |
71 | |
29 | |
36 | |
48 | |
41 | |
53 | |
28 | |
23 | |
26 | |
27 | |
53 | |
39 | |
50 | |
50 | |
63 | |
18 | |
7 |
