Re: Configuring ltpstress.sh

Sorry for the delay in response...busy committing patches.  I added a "-n"
option to the ltpstress.sh to allow the testing to run without networking.
This will bypass the check for the networking daemons and not run the
networking stress.  The NFS tests will attempt to run, but fail...and I
added a message for anyone who enables logging that these tests should
fail.  The updated version is in our CVS tree and will be included in the
September release...scheduled for next week.

-Robbie
(Embedded image moved to file: pic09833.jpg)

                                                                           
             Kelly Lucas                                                   
             <lucaskeli <at> fastma                                             
             il.fm>                                                     To 
             Sent by:                  ltp-list@...      
             ltp-list-admin <at> li                                          cc 
             sts.sourceforge.n                                             
             et                                                    Subject 
                                       [LTP] Configuring ltpstress.sh      

             08/26/2005 07:42                                              
             PM                                                            

I would like to run ltpstress against some client machines; however,
these machines are restricted from running NFS daemons. Is there an easy
way to configure what type of testing is done during ltpstress? I'd like
to remove any of the NFS server tests.

cleanup compiler warnings

While building LTP I've noticed a number of compiler warnings.  Most of 
these seem to be due to one or more of the following:

   missing include files
   missing function prototypes
   missing or mismatched function return types
   missing return statements
   missing type casts
   unused or uninitialized variables

Although these are not usually critical, I have been trying to clean up 
the build as time permitted.  I am submitting a few patches (to follow) 
that eliminate some of these warnings.  If acceptable, please apply 
these to the CVS archive.

Thank you,

d.marlin

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

cleanup warnings in network/tcp_cmds/echo tests

The attached patch adds missing include files, function prototypes and 
returns, and removes unused variables to eliminate warning messages.

d.marlin

Index: testcases/network/tcp_cmds/echo/createfile.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/tcp_cmds/echo/createfile.c,v
retrieving revision 1.1
diff -u -r1.1 createfile.c
--- testcases/network/tcp_cmds/echo/createfile.c	27 Aug 2001 22:15:16 -0000	1.1
+++ testcases/network/tcp_cmds/echo/createfile.c	2 Sep 2005 06:16:59 -0000
 <at>  <at>  -8,26 +8,29  <at>  <at> 
  <at> ! # SPEC. EXEC. REQS:  This  program is used by ctatcdt3.c and ctatcet3.c
 */
 #include <stdio.h>
+#include <stdlib.h>
 #include <fcntl.h>
-main (int argc,char *argv[]) 
+#include <unistd.h>
+
+int main (int argc,char *argv[]) 
 {
 int	fd;
 int	fsize;
 int	count=0;
 int	n,remain;

cleanup warnings in kernel/syscalls/setfsuid tests

The attached patch adds missing include files and declares return types 
to eliminate warning messages.

d.marlin

Index: testcases/kernel/syscalls/setfsuid/setfsuid02.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setfsuid/setfsuid02.c,v
retrieving revision 1.1
diff -u -r1.1 setfsuid02.c
--- testcases/kernel/syscalls/setfsuid/setfsuid02.c	21 May 2004 14:56:41 -0000	1.1
+++ testcases/kernel/syscalls/setfsuid/setfsuid02.c	2 Sep 2005 06:16:43 -0000
 <at>  <at>  -49,6 +49,10  <at>  <at> 
  */
 #include <stdio.h>
 #include <unistd.h>
+#include <pwd.h>
+#ifdef __GLIBC__
+#include <sys/fsuid.h>
+#endif
 #include <sys/types.h>
 #include <errno.h>
 #include "test.h"
 <at>  <at>  -61,7 +65,7  <at>  <at> 
 int TST_TOTAL = 1;
 extern int Tst_count;

-main(int ac, char **av)

cleanup warnings in network/tcp_cmds/sendfile test

The attached patch adds missing include files, function types and 
returns, and removes unused variables to eliminate warning messages.

d.marlin

Index: testcases/network/tcp_cmds/sendfile/testsf_c.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/tcp_cmds/sendfile/testsf_c.c,v
retrieving revision 1.10
diff -u -r1.10 testsf_c.c
--- testcases/network/tcp_cmds/sendfile/testsf_c.c	18 Aug 2003 18:49:30 -0000	1.10
+++ testcases/network/tcp_cmds/sendfile/testsf_c.c	2 Sep 2005 06:17:27 -0000
 <at>  <at>  -8,6 +8,7  <at>  <at> 
 #include <stdlib.h>
 #include <string.h>
 #include <sys/file.h>
+#include <arpa/inet.h>
 #include <netinet/in.h>
 #include <sys/socket.h>
 #include <errno.h>
 <at>  <at>  -23,7 +24,7  <at>  <at> 
 int TST_TOTAL=1;
 extern int Tst_count;

-main(argc, argv)
+int main(argc, argv)
 int argc;
 char *argv[];

cleanup warnings in kernel/ipc/pipeio test

The attached patch initializes some uninitialized variables and adds a 
return statement (non-void function) to eliminate warning messages.

d.marlin

Index: testcases/kernel/ipc/pipeio/pipeio.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/ipc/pipeio/pipeio.c,v
retrieving revision 1.5
diff -u -r1.5 pipeio.c
--- testcases/kernel/ipc/pipeio/pipeio.c	1 Mar 2004 22:36:39 -0000	1.5
+++ testcases/kernel/ipc/pipeio/pipeio.c	2 Sep 2005 06:16:33 -0000
 <at>  <at>  -137,8 +137,8  <at>  <at> 
 	char *blk_type;		/* blocking i/o or not */
 	char *pipe_type;	/* type of pipe under test */
 	int fds[2];		/* un-named pipe fds */
-	int read_fd;
-	int write_fd;
+	int read_fd = 0;
+	int write_fd = 0;
 	int empty_read = 0;	/* counter for the number of empty reads */
 	time_t stime, ctime, dtime;	/* start time, current time, diff of times */
 	int *count_word;	/* holds address where to write writers count */
 <at>  <at>  -700,7 +700,7  <at>  <at> 
 			unlink(pname);
 	}

-	exit (error);

cleanup warnings in network/tcp_cmds/perf_lan/pingpong.c test

The attached patch adds missing include files, function prototypes and 
returns, and removes unused variables to eliminate warning messages.

d.marlin

Index: testcases/network/tcp_cmds/perf_lan/pingpong.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/tcp_cmds/perf_lan/pingpong.c,v
retrieving revision 1.4
diff -u -r1.4 pingpong.c
--- testcases/network/tcp_cmds/perf_lan/pingpong.c	6 Jun 2003 22:03:31 -0000	1.4
+++ testcases/network/tcp_cmds/perf_lan/pingpong.c	2 Sep 2005 06:17:03 -0000
 <at>  <at>  -42,6 +42,8  <at>  <at> 
 #include <sys/file.h>
 #include <sys/signal.h>

+#include <arpa/inet.h>
+
 #include <netinet/in_systm.h>
 #include <netinet/in.h>
 #include <netinet/ip.h>
 <at>  <at>  -88,19 +90,20  <at>  <at> 
 extern int Tst_count;

 
+u_short in_cksum(u_short *, int);
+int ck_packet(char *, int, struct sockaddr_in *);
+int echopkt(int, int);

cleanup warnings in network/nfs tests

The attached patch adds missing include files, function prototypes and 
returns, and removes unused variables to eliminate warning messages.
It also corrects some sprintf format warnings and replaces 'abortx' with 
a version that accepts a variable number of arguments.

d.marlin

Index: testcases/network/nfs/fsx-linux/fsx-linux.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/nfs/fsx-linux/fsx-linux.c,v
retrieving revision 1.3
diff -u -r1.3 fsx-linux.c
--- testcases/network/nfs/fsx-linux/fsx-linux.c	7 May 2003 17:33:55 -0000	1.3
+++ testcases/network/nfs/fsx-linux/fsx-linux.c	2 Sep 2005 06:16:55 -0000
 <at>  <at>  -50,6 +50,7  <at>  <at> 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <time.h>
 #include <unistd.h>
 #include <stdarg.h>
 #include <errno.h>
 <at>  <at>  -1055,10 +1056,10  <at>  <at> 
 		if (written != maxfilelen) {
 			if (written == -1) {
 				prterr(fname);
-		 		 		 		 fprintf(stderr, "main: error on write");
+				fprintf(stderr, "main: error on write");

Re: cleanup compiler warnings

On Friday 02 September 2005 02:58 pm, David A. Marlin wrote:
> While building LTP I've noticed a number of compiler warnings.

yeah ive sent a few like this to the list recently that havent been applied 
yet ... might want to make sure we dont waste time fixing the same bugs :)
-mike

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: cleanup compiler warnings

Mike Frysinger wrote:
> On Friday 02 September 2005 02:58 pm, David A. Marlin wrote:
> 
>>While building LTP I've noticed a number of compiler warnings.
> 
> yeah ive sent a few like this to the list recently that havent been applied 
> yet ... might want to make sure we dont waste time fixing the same bugs :)

Actually, I think many/most or your patches have now been applied.  I've 
been trying to work on files that didn't have pending patches so as not 
to duplicate effort.

Thank you for all your cleanup work.  It makes things much nicer for the 
rest of us.  I'll try to do my part and help with the cleanup effort.

d.marlin

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf