headers
Niels de Vos | 7 May 2008 15:55
Favicon
Gravatar

[PATCH] apm: make apm=power-off configurable like apm=realmode-power-off

On some systems (with broken BIOSes?) apm=power-off should be appended
as kernel parameter. apm=realmode-power-off is configurable during 
compile-time. apm=power-off should be configurable likewise.

On non-SMP systems apm=power-off is the default. For kernels with SMP
support it is not.

Signed-off-by: Niels de Vos <niels.devos <at> wincor-nixdorf.com>
--
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index bbcafaa..e051f38 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
 <at>  <at>  -1457,6 +1457,16  <at>  <at>  config APM_ALLOW_INTS
 	  many of the newer IBM Thinkpads.  If you experience hangs when you
 	  suspend, try setting this to Y.  Otherwise, say N.

+config APM_POWER_OFF
+	bool "Power off on shutdown"
+	depends on APM && SMP
+	help
+	  Force a power off on shutdown. Needed for some buggy BIOSes. If you
+	  run an SMP kernel on a non-SMP system with APM, you try turning on
+	  this option if your system does not power-off properly.
+
+	  Note: this option is equivalent to apm=power-off on the cmdline.
+
 config APM_REAL_MODE_POWER_OFF
 	bool "Use real mode APM BIOS call to power off"
 	help
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stephen Rothwell | 7 May 2008 16:46
Picon
Picon

Re: [PATCH] apm: make apm=power-off configurable like apm=realmode-power-off

Hi Neils,

On Wed, 07 May 2008 15:55:09 +0200 Niels de Vos <niels.devos <at> wincor-nixdorf.com> wrote:
>
> On some systems (with broken BIOSes?) apm=power-off should be appended
> as kernel parameter. apm=realmode-power-off is configurable during 
> compile-time. apm=power-off should be configurable likewise.
> 
> On non-SMP systems apm=power-off is the default. For kernels with SMP
> support it is not.

We had a similar compile time option that we removed in 2.3.26pre1 in
favour of the kernel parameter ...

--

-- 
Cheers,
Stephen Rothwell                    sfr <at> canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
Permalink | Reply | 0 comments |
headers
Stephen Rothwell | 7 May 2008 17:27
Picon
Picon

Re: [PATCH] apm: make apm=power-off configurable like apm=realmode-power-off

On Wed, 07 May 2008 17:06:41 +0200 Niels de Vos <niels.devos <at> wincor-nixdorf.com> wrote:
>
> Stephen Rothwell wrote:
> > Hi Neils,
> > 
> > On Wed, 07 May 2008 15:55:09 +0200 Niels de Vos <niels.devos <at> wincor-nixdorf.com> wrote:
> >> On some systems (with broken BIOSes?) apm=power-off should be appended
> >> as kernel parameter. apm=realmode-power-off is configurable during 
> >> compile-time. apm=power-off should be configurable likewise.
> >>
> >> On non-SMP systems apm=power-off is the default. For kernels with SMP
> >> support it is not.
> > 
> > We had a similar compile time option that we removed in 2.3.26pre1 in
> > favour of the kernel parameter ...
> 
> Okay, but why not have both options like apm=realmode-power-off?

It was a long time ago ... and APM must be almost dead my now, surely? :-)

Maybe I just never got around to removing the compile time config of real
mode power off.

--

-- 
Cheers,
Stephen Rothwell                    sfr <at> canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
Permalink | Reply | 0 comments |

Gmane