headers
Peter Chubb | 1 Jul 2011 01:10
X-Face
Picon
Favicon

Re: Acer Aspire One now hangs on reboot/shutdown

>>>>> "H" == H Peter Anvin <hpa <at> zytor.com> writes:

H> On 06/22/2011 04:50 PM, Peter Chubb wrote:
>>>>>>> "Matthew" == Matthew Garrett <mjg59 <at> srcf.ucam.org> writes:
>> 
Matthew> On Wed, Jun 22, 2011 at 08:38:08PM +1000, Peter Chubb wrote:
>>>> 
>>>> Hi Matthew, GIT commit 660e34cebf0a11d54f2d5dd8838607452355f321
>>>> x86: reorder reboot method preferences causes my Acer Aspire One
>>>> to hang on shutdown/reboot.
>> 
Matthew> Also, shutdown? Really?
>> 
>> Sorry, shutdown -r (which is reboot really).
>> 
>> 
>> Writing the reset value `6' to the reset port 3321 in single user
>> mode makes the screen go blank, and the machine to become totally
>> unresponsive.  The power light remains on.  But the machine does
>> *not* reboot.
>> 
>> I've put up the ACPI tables at
>> http://www.cse.unsw.edu.au/~peterc/AspireOneACPI
>> 
>> The relevant part of the FADT is: [074h 0116 12] Reset Register :
>> <Generic Address Structure> [074h 0116 1] Space ID : 01 (SystemIO)
>> [075h 0117 1] Bit Width : 08 [076h 0118 1] Bit Offset : 00 [077h
>> 0119 1] Access Width : 01 [078h 0120 8] Address : 0000000000000CF9
>> 
>> [080h 0128 1] Value to cause reset : 06
(Continue reading)

Permalink | Reply | 7 comments |
headers
Ryan Mallon | 1 Jul 2011 01:24
Picon

Re: [PATCH 1/3] PWM: add pwm framework support

On 01/07/11 03:02, Sascha Hauer wrote:
> Bill,
>
> On Thu, Jun 30, 2011 at 11:17:54AM -0500, Bill Gatliff wrote:
>> Guys:
>>
>> On Thu, Jun 30, 2011 at 7:41 AM, Arnd Bergmann<arnd <at> arndb.de>  wrote:
>>
>>> A lot of people want to see a framework get merged, and I think it's
>>> great that Sascha has volunteered to do the work to push that
>>> through this time, especially since you have not been able to
>>> finish your work.
>> Sascha is wasting his time by reinventing the wheel.  He's traveling
>> over exactly the same path I have already covered.  In fact, some of
>> his reviewer comments are almost word-for-word the same as those I
>> have received and addressed in the past.
>>
>> My patches were always kept current in this mailing list and others,
>> and Sascha clearly has the skills necessary to make improvements and
>> corrections should he have chosen to do so.
> I think that you made the fundamental mistake to completly ignore the
> existing pwm API and its users. With a competing api we are basically
> stuck. We can't convert the existing hardware drivers to the new API
> because leds-pwm.c, pwm_bl.c and others still depend on the old API and
> boards using it would break.

I don't think this is really a blocker to Bill's patches. There are 
three (that I can see) pwm users currently:
drivers/video/backlight/pwm_bl.c
drivers/leds/leds-pwm.c
(Continue reading)

Permalink | Reply | 19 comments |
headers
KY Srinivasan | 1 Jul 2011 01:28
Picon
Favicon

RE: [PATCH 00/40] Staging: hv: Driver cleanup


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch <at> infradead.org]
> Sent: Thursday, June 30, 2011 3:34 PM
> To: KY Srinivasan
> Cc: gregkh <at> suse.de; linux-kernel <at> vger.kernel.org;
> devel <at> linuxdriverproject.org; virtualization <at> lists.osdl.org
> Subject: Re: [PATCH 00/40] Staging: hv: Driver cleanup
> 
> On Wed, Jun 29, 2011 at 07:38:21AM -0700, K. Y. Srinivasan wrote:
> > Further cleanup of the hv drivers:
> >
> > 	1) Cleanup the reference counting mess for both stor and net devices.
> 
> I really don't understand the need for reference counting on the storage
> side, especially now that you only have a SCSI driver.  The SCSI
> midlayer does proper counting on it's objects (Scsi_Host, scsi_device,
> scsi_cmnd), so you'll get that for free given that SCSI drivers just
> piggyback on the midlayer lifetime rules.

The reference counting allows us to properly deal with messages coming back from the host
to the guest with a racing remove of the device. I am told these messages could potentially be
not a response to a message sent from the guest.

> 
> For now your patches should probably go in as-is, but mid-term you
> should be able to completely remove that code on the storage side.
> 

Thanks. Sure, we will always try to simplify the code.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Greg Dietsche | 1 Jul 2011 01:42

[PATCH] gitignore: ignore debian build directory

Have git ignore the Debian directory created when running:
	make deb-pkg

Signed-off-by: Greg Dietsche <Gregory.Dietsche <at> cuw.edu>
---
 .gitignore |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index 9dacde0..dc243a6 100644
--- a/.gitignore
+++ b/.gitignore
 <at>  <at>  -46,6 +46,11  <at>  <at>  modules.builtin
 /Module.symvers

 #
+#Debian directory (make deb-pkg)
+#
+/debian/
+
+#
 # git files that we don't want to ignore even it they are dot-files
 #
 !.gitignore
--

-- 
1.7.2.5
Permalink | Reply | 1 comment |
headers
Ram Pai | 1 Jul 2011 01:47
Picon
Favicon

[PATCH 0/5 v2] PCI: fix cardbus and sriov regressions

The following patch-set fixes regressions caused by:

the commit "PCI: update bridge resources to get more big ranges when allocating space (again)"
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=da7822e5ad71ec9b745b412639f1e5e0ba795a20

patch 1/5: fix calculation of additional resource size for hotplug bridges
patch 2/5: ability to resize assigned pci-resource
patch 3/5: make SRIOV BARs resources optional
patch 4/5: make cardbus bridge resources optional
patch 5/5: code and terminology cleanup

The regression was caused on some platforms with limited i/o and memory
resources, the optional resources were allocated ahead of required resources,
thus starving the latter. The patchset ensures that all the required resources
are satisfied before any optional resources are satisfied.
Permalink | Reply | 15 comments |
headers
Ram Pai | 1 Jul 2011 01:47
Picon
Favicon

[PATCH 1/5 v2] PCI: honor child buses optional size in hot plug configuration

From: Yinghai Lu <yinghai <at> kernel.org>

git commit c8adf9a3e873eddaaec11ac410a99ef6b9656938
    "PCI: pre-allocate additional resources to devices only after
	successful allocation of essential resources."

fails to take into consideration the optional-resources needed by children
devices while calculating the optional-resource needed by the bridge.

This can be a problem on some setup. For example, if a hotplug bridge has 8
children hotplug bridges, the bridge should have enough resources to accomodate
the hotplug requirements for each of its children hotplug bridges.  Currently
this is not the case.

This patch fixes the problem.

Signed-off-by: Ram Pai <linuxram <at> us.ibm.com>
Signed-off-by: Yinghai Lu <yinghai <at> kernel.org>
---
 drivers/pci/setup-bus.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 1e9e5a5..e42b89a 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
 <at>  <at>  -536,6 +536,20  <at>  <at>  static resource_size_t calculate_memsize(resource_size_t size,
 	return size;
 }
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stephen Hemminger | 1 Jul 2011 01:48
Favicon

Re: [PATCH 00/40] Staging: hv: Driver cleanup

On Thu, 30 Jun 2011 23:32:34 +0000
KY Srinivasan <kys <at> microsoft.com> wrote:

> 
> > -----Original Message-----
> > From: Christoph Hellwig [mailto:hch <at> infradead.org]
> > Sent: Thursday, June 30, 2011 3:34 PM
> > To: KY Srinivasan
> > Cc: gregkh <at> suse.de; linux-kernel <at> vger.kernel.org;
> > devel <at> linuxdriverproject.org; virtualization <at> lists.osdl.org
> > Subject: Re: [PATCH 00/40] Staging: hv: Driver cleanup
> > 
> > On Wed, Jun 29, 2011 at 07:38:21AM -0700, K. Y. Srinivasan wrote:
> > > Further cleanup of the hv drivers:
> > >
> > > 	1) Cleanup the reference counting mess for both stor and net devices.
> > 
> > I really don't understand the need for reference counting on the storage
> > side, especially now that you only have a SCSI driver.  The SCSI
> > midlayer does proper counting on it's objects (Scsi_Host, scsi_device,
> > scsi_cmnd), so you'll get that for free given that SCSI drivers just
> > piggyback on the midlayer lifetime rules.
> > 
> > For now your patches should probably go in as-is, but mid-term you
> > should be able to completely remove that code on the storage side.
> > 
> 
> Greg,
> 
> I am thinking of  going back to my original implementation where I had one scsi host
(Continue reading)

Permalink | Reply | 3 comments |
headers
Ram Pai | 1 Jul 2011 01:47
Picon
Favicon

[PATCH 2/5 v2] PCI : ability to relocate assigned pci-resources

Currently pci-bridges are allocated enough resources to satisfy their immediate
requirements.  Any additional resource-requests fail if additional free space,
contiguous to the one already allocated, is not available. This behavior is not
reasonable since sufficient contiguous resources, that can satisfy the request,
are available at a different location.

This patch provides the ability to expand and relocate a allocated resource.

	Changelog: Fixed size calculation in pci_reassign_resource()

Signed-off-by: Ram Pai <linuxram <at> us.ibm.com>
---
 drivers/pci/setup-bus.c |   27 +++++---
 drivers/pci/setup-res.c |  152 +++++++++++++++++++++++++++++------------------
 include/linux/pci.h     |    1 +
 kernel/resource.c       |   98 ++++++++++++++++++++++++++++---
 4 files changed, 203 insertions(+), 75 deletions(-)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index e42b89a..9f2f15f 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
 <at>  <at>  -34,6 +34,7  <at>  <at>  struct resource_list_x {
 	resource_size_t start;
 	resource_size_t end;
 	resource_size_t add_size;
+	resource_size_t min_align;
 	unsigned long flags;
 };
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ram Pai | 1 Jul 2011 01:47
Picon
Favicon

[PATCH 3/5 v2] PCI: make SRIOV resources optional

From: Yinghai Lu <yinghai <at> kernel.org>

From: Yinghai Lu <yinghai <at> kernel.org>

Allocate resources to SRIOV BARs only after all other required
resource-requests are satisfied. Dont retry if resource allocation for SRIOV
BARs fail.

Signed-off-by: Ram Pai <linuxram <at> us.ibm.com>
Signed-off-by: Yinghai Lu <yinghai <at> kernel.org>
---
 drivers/pci/setup-bus.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 9f2f15f..a0555cb 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
 <at>  <at>  -669,6 +669,16  <at>  <at>  static int pbus_size_mem(struct pci_bus *bus, unsigned long mask,
 			if (r->parent || (r->flags & mask) != type)
 				continue;
 			r_size = resource_size(r);
+#ifdef CONFIG_PCI_IOV
+			/* put SRIOV requested res to the optional list */
+			if (add_head && i >= PCI_IOV_RESOURCES &&
+					i <= PCI_IOV_RESOURCE_END) {
+				r->end = r->start - 1;
+				add_to_list(add_head, dev, r, r_size, 1);
+				children_add_size += r_size;
+				continue;
(Continue reading)

Permalink | Reply | 3 comments |
headers
Ram Pai | 1 Jul 2011 01:47
Picon
Favicon

[PATCH 4/5 v2] PCI: make cardbus-bridge resources optional

Allocate resources to cardbus bridge only after all other genuine
resources requests are satisfied. Dont retry if resource allocation
for cardbus-bridges fail.

   Changelog: Fixed a alignment problem noticed on Oliver's setup.

Tested-by: Oliver Hartkopp <socketcan <at> hartkopp.net>
Signed-off-by: Ram Pai <linuxram <at> us.ibm.com>
---
 drivers/pci/pci.h       |    4 ++++
 drivers/pci/setup-bus.c |   41 ++++++++++++++++++++++++++++++++---------
 2 files changed, 36 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 731e202..ebaf0ed 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
 <at>  <at>  -283,6 +283,8  <at>  <at>  static inline int pci_iov_bus_range(struct pci_bus *bus)

 #endif /* CONFIG_PCI_IOV */

+extern unsigned long pci_cardbus_resource_alignment(struct resource *);
+
 static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,
 					 struct resource *res)
 {
 <at>  <at>  -292,6 +294,8  <at>  <at>  static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,
 	if (resno >= PCI_IOV_RESOURCES && resno <= PCI_IOV_RESOURCE_END)
 		return pci_sriov_resource_alignment(dev, resno);
 #endif
(Continue reading)

Permalink | Reply | 0 comments |

Gmane