headers
Armando Uribe | 1 Mar 2011 01:14
Picon
Favicon

[PATCH] omap:mailbox: resolve hang issue

From: Hari Kanigeri <h-kanigeri2 <at> ti.com>

omap4 interrupt disable bits is different. On rx kfifo full, the mbox rx
interrupts wasn't getting disabled, and this is causing the rcm stress tests
to hang.

Signed-off-by: Hari Kanigeri <h-kanigeri2 <at> ti.com>
Signed-off-by: Armando Uribe <x0095078 <at> ti.com>
---
 arch/arm/mach-omap2/mailbox.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 3d05ac8..2bfe8c6 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
 <at>  <at>  -207,7 +207,10  <at>  <at>  static void omap2_mbox_disable_irq(struct omap_mbox *mbox,
 	struct omap_mbox2_priv *p = mbox->priv;
 	u32 l, bit = (irq == IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 	l = mbox_read_reg(p->irqdisable);
-	l &= ~bit;
+	if (cpu_is_omap44xx())
+		l |= bit;
+	else
+		l &= ~bit;
 	mbox_write_reg(l, p->irqdisable);
 }

--

-- 
1.7.0.4
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stepan Moskovchenko | 1 Mar 2011 01:04

[PATCH 2/2] msm: iommu: Enable HTW L2 redirection on MSM8960

Allow the MSM8960 IOMMU to access its page tables directly
through the L2 cache.

Signed-off-by: Stepan Moskovchenko <stepanm <at> codeaurora.org>
---
 arch/arm/mach-msm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
index 997c5bd..1516896 100644
--- a/arch/arm/mach-msm/Kconfig
+++ b/arch/arm/mach-msm/Kconfig
 <at>  <at>  -162,7 +162,7  <at>  <at>  config MSM_IOMMU

 config IOMMU_PGTABLES_L2
 	def_bool y
-	depends on ARCH_MSM8X60 && MMU && SMP && CPU_DCACHE_DISABLE=n
+	depends on MSM_IOMMU && MMU && SMP && CPU_DCACHE_DISABLE=n

 config MSM_DEBUG_UART
 	int
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Permalink | Reply | 0 comments |
headers
Paul E. McKenney | 1 Mar 2011 01:13
Picon

Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirq to kthread

On Mon, Feb 28, 2011 at 10:47:17AM +0100, Peter Zijlstra wrote:
> On Mon, 2011-02-28 at 11:29 +0800, Lai Jiangshan wrote:
> > >>> +static int rcu_cpu_kthread_should_stop(int cpu)
> > >>> +{
> > >>> +   while (cpu_is_offline(cpu) || smp_processor_id() != cpu) {
> > >>> +           if (kthread_should_stop())
> > >>> +                   return 1;
> > >>> +           local_bh_enable();
> > >>> +           schedule_timeout_uninterruptible(1);
> > >>> +           if (smp_processor_id() != cpu)
> > >>> +                   set_cpus_allowed_ptr(current, cpumask_of(cpu));
> > >>
> > >> The current task is PF_THREAD_BOUND,
> > >> Why do "set_cpus_allowed_ptr(current, cpumask_of(cpu));" ?
> > > 
> > > Because I have seen CPU hotplug operations unbind PF_THREAD_BOUND threads.
> 
> Correct, but that's on unplug, the rest of the story seems about plug,
> so just detatch the thread on down/offline and let it die when its done.
> 
> > > In addition, I end up having to spawn the kthread at CPU_UP_PREPARE time,
> 
> Sure, that's a common time to create such treads :-), you can
> kthread_ceate()+kthread_bind() in UP_PREPARE, just don't wake them yet.

I am OK doing the sched_setscheduler_nocheck() in UP_PREPARE, correct?

But yes, I can have the CPU_STARTING notifier wake up any kthreads that
the current CPU might have caused to be created.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Nicholas A. Bellinger | 1 Mar 2011 01:17

[PATCH 1/5] target: add initial device backend context target_core_stat.c code

From: Nicholas Bellinger <nab <at> linux-iscsi.org>

This patch adds a target_core_mib.c statistics conversion for
backend context struct se_subsystem_dev + struct se_device config_group
based statistics in target_core_device.c using CONFIGFS_EATTR()
based struct config_item_types from target_core_stat.c code.

The conversion from backend /proc/scsi_target/mib/ context output to configfs
default groups+attributes include scsi_dev, scsi_lu, and scsi_tgt_dev output
from within individual:

	/sys/kernel/config/target/core/$HBA/DEV/

The legacy procfs output now appear as individual configfs attributes under:

*) $HBA/$DEV/statistics/scsi_dev:

|-- indx
|-- inst
|-- ports
`-- role

*) $HBA/$DEV/statistics/scsi_lu:

|-- creation_time
|-- dev
|-- dev_type
|-- full_stat
|-- hs_num_cmds
|-- indx
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicholas A. Bellinger | 1 Mar 2011 01:17

[PATCH 4/5] target: Add fabric_stat_group for fabric module statistics default_group

From: Nicholas Bellinger <nab <at> linux-iscsi.org>

This patch adds support for struct se_wwn->fabric_stat_group in
target_fabric_make_wwn() and target_fabric_drop_wwn() to allow fabric
modules to access fabric_stat_group->default_groups[] for dependent
/sys/kernel/config/target/$FABRIC_WWN/fabric_statistics groups.

It also adds support for struct se_node_acl->acl_fabric_stat_group
in target_fabric_make_nodeacl() to allow fabric modules to access
acl_fabric_stat_group->default_groups[] for fabric dependent fabric
groups as well.

ALso, this includes adding struct target_fabric_configfs_template->
tfc_wwn_fabric_stats_cit and ->tfc_tpg_nacl_stat_cit respectively for
use during target_core_fabric_configfs.c:target_fabric_setup_cits()

Signed-off-by: Nicholas A. Bellinger <nab <at> linux-iscsi.org>
---
 drivers/target/target_core_fabric_configfs.c |   47 +++++++++++++++++++++++++-
 include/target/target_core_base.h            |    5 ++-
 include/target/target_core_configfs.h        |    2 +
 3 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_configfs.c
index 7d58be3..07ab5a3 100644
--- a/drivers/target/target_core_fabric_configfs.c
+++ b/drivers/target/target_core_fabric_configfs.c
 <at>  <at>  -453,6 +453,15  <at>  <at>  TF_CIT_SETUP(tpg_nacl_base, &target_fabric_nacl_base_item_ops,

 /* End of tfc_tpg_nacl_base_cit */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicholas A. Bellinger | 1 Mar 2011 01:17

[PATCH 2/5] target: add initial fabric port context target_core_stat.c code

From: Nicholas Bellinger <nab <at> linux-iscsi.org>

This patch adds a target_core_mib.c statistics conversion for
TCM fabric port/LUN context struct se_lun + struct se_port config_group
based statistics in target_core_fabric_configfs.c using CONFIGFS_EATTR()
based struct config_item_types from existing generic target fabric
TF_CIT_SETUP() wrapper code in target_core_fabric_configfs.c.

The conversion from backend /proc/scsi_target/mib/ context output to configfs
default groups+attributes include scsi_port, scsi_tgt_port and scsi_transport
output from within individual:

	/sys/kernel/config/target/fabric/$WWN/tpgt_$TPGT/lun/lun_$LUN_ID/statistics/

The legacy procfs output now appear as individual configfs attributes under:

*) fabric/$WWN/tpgt_$TPGT/lun/lun_$LUN_ID/statistics/scsi_port

|-- busy_count
|-- dev
|-- indx
|-- inst
`-- role

*) fabric/$WWN/tpgt_$TPGT/lun/lun_$LUN_ID/statistics/scsi_tgt_port

|-- dev
|-- hs_in_cmds
|-- in_cmds
|-- indx
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicholas A. Bellinger | 1 Mar 2011 01:17

[PATCH 3/5] target: add initial fabric MappedLUN context target_core_stat.c code

From: Nicholas Bellinger <nab <at> linux-iscsi.org>

This patch adds a target_core_mib.c statistics conversion for
TCM MappedLUN/LunACL context struct se_lun_acl + struct se_dev_entry
config_group based statistics in target_core_fabric_configfs.c using
CONFIGFS_EATTR() based struct config_item_types from existing generic
target fabric TF_CIT_SETUP() wrapper code in target_core_fabric_configfs.c.

The conversion from backend /proc/scsi_target/mib/ context output to configfs
default groups+attributes include scsi_att_intr_port and scsi_auth_intr output
from within individual:

	/sys/kernel/config/target/fabric/$WWN/tpgt_$TPGT/acls/$INITIATOR_WWN/lun_$LUN_ID/statistics/

The legacy procfs output now appear as individual configfs attributes under:

*) acls/$INITIATOR_WWN/lun_$LUN_ID/statistics/scsi_att_intr_port

|-- dev
|-- indx
|-- inst
|-- port
|-- port_auth_indx
`-- port_ident

*) acls/$INITIATOR_WWN/lun_$LUN_ID/statistics/scsi_auth_intr

|-- att_count
|-- creation_time
|-- dev
(Continue reading)

Permalink | Reply | 0 comments |
headers
James Bottomley | 1 Mar 2011 01:19

Re: [PATCH 0/5] target updates for scsi-post-merge .39 (round one, v2)

On Mon, 2011-02-28 at 16:17 -0800, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab <at> linux-iscsi.org>
> 
> Hi James and Co,
> 
> The following is the first round (v2) of target patches intended for .39
> scsi-post-merge tree that introduces new target functionality and the
> first mainline TCM fabric module (TCM_Loop).

OK, what postmerge tree?  There haven't been any conflicts this merge
cycle that necessitate running one.  Do you mean you want these after
the merge window for some reason?

James
Permalink | Reply | 1 comment |
headers
Justin TerAvest | 1 Mar 2011 01:19
Picon
Favicon

RFC: default group_isolation to 1, remove option

Hi Vivek,

I'd like to propose removing the group_isolation setting and changing
the default to 1. Do we know if anyone is using group_isolation=0 to get
easy group separation between sequential readers and random readers?

Allowing group_isolation complicates implementing per-cgroup request
descriptor pools when a queue is moved to the root group. Specifically,
if we have pools per-cgroup, we would be forced to use request
descriptors from the pool for the "original" cgroup, while the requests
are actually being serviced by the root cgroup.

That might be acceptable, but I figured this would be a good opportunity
to revisit keeping queues within their original groups.

I know this discussion has come up before. I'm curious if we have a good
reason to keep it around right now. I'd be happy to do some investigation
to help make my case.

Thanks,
Justin
Permalink | Reply | 22 comments |
headers
Lin Ming | 1 Mar 2011 01:32
Picon
Favicon

Re: [PATCH v2 -tip] perf: x86, add SandyBridge support

On Mon, 2011-02-28 at 23:11 +0800, Peter Zijlstra wrote:
> On Mon, 2011-02-28 at 22:56 +0800, Lin Ming wrote:
> >  <at>  <at>  -740,13 +740,6  <at>  <at>  static void intel_ds_init(void)
> >                         printk(KERN_CONT "PEBS fmt1%c, ", pebs_type);
> >                         x86_pmu.pebs_record_size = sizeof(struct pebs_record_nhm);
> >                         x86_pmu.drain_pebs = intel_pmu_drain_pebs_nhm;
> > -                       switch (boot_cpu_data.x86_model) {
> > -                       case 42: /* SandyBridge */
> > -                               x86_pmu.pebs_constraints = intel_snb_pebs_events;
> > -                               break;
> > -                       default:
> > -                               x86_pmu.pebs_constraints = intel_nehalem_pebs_events;
> > -                       }
> >                         break; 
> 
> it looks like you lost the nhm table assignment

Ah, yes. Will update all in v3 patch.
Permalink | Reply | 0 comments |

Gmane