headers
Ben Dooks | 1 Apr 2009 01:01

Re: [patch 1/5] i2c: xtensa s6000 i2c driver

On Tue, Mar 31, 2009 at 11:52:58PM +0100, Ben Dooks wrote:
> On Mon, Mar 23, 2009 at 04:05:14PM +0100, Daniel Gl??ckner wrote:
> > From: Oskar Schirmer <os@...>
> > 
> > Support for the s6000 on-chip i2c controller.
> > 
> > Signed-off-by: Oskar Schirmer <os@...>
> > Signed-off-by: Daniel Gl??ckner <dg@...>
> 
> Not going to merge this on my first pull request to linus, there's
> a few things that I'd like to get answered before.

and a few other things i've just noticed:

> > ---
> >  drivers/i2c/busses/Kconfig     |   10 +
> >  drivers/i2c/busses/Makefile    |    1 +
> >  drivers/i2c/busses/i2c-s6000.c |  380 ++++++++++++++++++++++++++++++++++++++++
> >  drivers/i2c/busses/i2c-s6000.h |   79 +++++++++
> >  include/linux/i2c/s6000.h      |   10 +
> >  5 files changed, 480 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/i2c/busses/i2c-s6000.c
> >  create mode 100644 drivers/i2c/busses/i2c-s6000.h
> >  create mode 100644 include/linux/i2c/s6000.h
> > 
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index 7f95905..904def4 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> >  <at>  <at>  -461,6 +461,16  <at>  <at>  config I2C_S3C2410
(Continue reading)

Permalink | Reply | 2 comments |
headers
Larry Finger | 1 Apr 2009 01:01
Favicon

Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe

Oliver Neukum wrote:
> Am Dienstag 31 März 2009 20:45:49 schrieb Larry Finger:
>> On an SMP system, the following message is printed. The patch below gets
>> fixes the problem.
> 
> Are you sure it is never called with disabled interrupts?

I think not, but all I really know is that the change from spin_lock() to
spin_lock_irq() makes the errors go away.

I checked a number of drivers to see what their ndo_start_xmit routines do. Most
use spin_lock_irq(), but some do no locking.

I tried removing the locking, but that resulted in a stall even when I bypassed
the faulty router.

Larry
Permalink | Reply | 0 comments |
headers
Matthew Garrett | 1 Apr 2009 01:02
Favicon

Re: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices

Ok, can you try this and let me know what codes it generates (if it 
generates any)? It should go on top of the previous patches.

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 9fb4873..8552e1a 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
 <at>  <at>  -185,7 +185,6  <at>  <at>  static int write_acpi_int(const char *methodName, int val)
 	return (status == AE_OK);
 }

-#if 0
 static int read_acpi_int(const char *methodName, int *pVal)
 {
 	struct acpi_buffer results;
 <at>  <at>  -200,7 +199,6  <at>  <at>  static int read_acpi_int(const char *methodName, int *pVal)

 	return (status == AE_OK) && (out_objs[0].type == ACPI_TYPE_INTEGER);
 }
-#endif

 static const char *method_hci /*= 0*/ ;

 <at>  <at>  -802,6 +800,13  <at>  <at>  static void toshiba_acpi_notify(acpi_handle handle, u32 event, void **data)

 	if (event != 0x80)
 		return;
+
+	if (is_valid_acpi_path(TOSH_INTERFACE_2 SPFC_METHOD)) {
+		read_acpi_int(TOSH_INTERFACE_2 SPFC_METHOD, &value);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Oliver Neukum | 1 Apr 2009 01:06

Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe

Am Mittwoch 01 April 2009 00:10:28 schrieb David Miller:
> > Here you enable interrupts. Are you sure ndo_start_xmit is never
> > called with interrupts disabled?
>
> It must never be invoked that way, this would break so many
> drivers.
>
> On the other hand, all of these driver paths never execute
> in a real hardware interrupt context, the deepest it gets
> into is software interrupts.  So spin_*lock*_bh() might be
> more appropriate.

Thanks. The patch is good. I'll check the other USB network
drivers.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Chris Wright | 1 Apr 2009 01:10

[patch 00/45] 2.6.29.1 -stable review

This is the start of the stable review cycle for the 2.6.29.1 release.
There are 45 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let us know.  If anyone is a maintainer of the proper subsystem, and
wants to add a Signed-off-by: line to the patch, please respond with it.

These patches are sent out with a number of different people on the
Cc: line.  If you wish to be a reviewer, please email stable <at> kernel.org
to add your name to the list.  If you want to be off the reviewer list,
also email us.

Responses should be made by Thursday, April 2, 23:00 UTC.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.29.1-rc1.gz
and the diffstat can be found below.

thanks,
-chris

 Makefile                                 |    2 
 arch/arm/include/asm/elf.h               |    1 
 arch/arm/kernel/module.c                 |    9 
 arch/arm/mach-iop13xx/pci.c              |    5 
 arch/arm/mach-omap2/mmc-twl4030.c        |    1 
 arch/arm/mm/mmu.c                        |    2 
 arch/x86/kernel/check.c                  |    6 
 arch/x86/kernel/cpu/mtrr/generic.c       |   51 +--
 arch/x86/kernel/ptrace.c                 |    3
(Continue reading)

Permalink | Reply | 59 comments |
headers
Chris Wright | 1 Apr 2009 01:10

[patch 05/45] GRO: Disable GRO on legacy netif_rx path

-stable review patch.  If anyone has any objections, please let us know.
---------------------

From: Herbert Xu <herbert <at> gondor.apana.org.au>

[ Upstream commit 8f1ead2d1a626ed0c85b3d2c2046a49081d5933f ]

When I fixed the GRO crash in the legacy receive path I used
napi_complete to replace __napi_complete.  Unfortunately they're
not the same when NETPOLL is enabled, which may result in us
not calling __napi_complete at all.

What's more, we really do need to keep the __napi_complete call
within the IRQ-off section since in theory an IRQ can occur in
between and fill up the backlog to the maximum, causing us to
lock up.

Since we can't seem to find a fix that works properly right now,
this patch reverts all the GRO support from the netif_rx path.

Signed-off-by: Herbert Xu <herbert <at> gondor.apana.org.au>
Signed-off-by: David S. Miller <davem <at> davemloft.net>
Signed-off-by: Chris Wright <chrisw <at> sous-sol.org>
---
 net/core/dev.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

--- a/net/core/dev.c
+++ b/net/core/dev.c
 <at>  <at>  -2588,18 +2588,15  <at>  <at>  static int process_backlog(struct napi_s
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chris Wright | 1 Apr 2009 01:11

[patch 22/45] CIFS: Fix memory overwrite when saving nativeFileSystem field during mount

-stable review patch.  If anyone has any objections, please let us know.
---------------------

From: Steve French <sfrench <at> us.ibm.com>

upstream commit: b363b3304bcf68c4541683b2eff70b29f0446a5b

CIFS can allocate a few bytes to little for the nativeFileSystem field
during tree connect response processing during mount.  This can result
in a "Redzone overwritten" message to be logged.

Signed-off-by: Sridhar Vinay <vinaysridhar <at> in.ibm.com>
Acked-by: Shirish Pargaonkar <shirishp <at> us.ibm.com>
CC: Stable <stable <at> kernel.org>
Signed-off-by: Steve French <sfrench <at> us.ibm.com>
[chrisw: minor backport to CHANGES file]
Signed-off-by: Chris Wright <chrisw <at> sous-sol.org>
---
 fs/cifs/CHANGES   |    3 +++
 fs/cifs/connect.c |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

--- a/fs/cifs/CHANGES
+++ b/fs/cifs/CHANGES
 <at>  <at>  -7,6 +7,9  <at>  <at>  are authenticated as guest, as reconnect
 user's smb session.  This fix allows cifs to mount multiple times to the
 same server with different userids without risking invalidating earlier
 established security contexts.
+Fix "redzone overwritten" bug in cifs_put_tcon (CIFSTcon may allocate too
+little memory for the "nativeFileSystem" field returned by the server
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chris Wright | 1 Apr 2009 01:10

[patch 01/45] netfilter: nf_conntrack_tcp: fix unaligned memory access in tcp_sack

-stable review patch.  If anyone has any objections, please let us know.
---------------------

From: Mark H. Weaver <mhw <at> netris.org>

[ Upstream commit 534f81a5068799799e264fd162e9488a129f98d4 ]

This patch fixes an unaligned memory access in tcp_sack while reading
sequence numbers from TCP selective acknowledgement options.  Prior to
applying this patch, upstream linux-2.6.27.20 was occasionally
generating messages like this on my sparc64 system:

  [54678.532071] Kernel unaligned access at TPC[6b17d4] tcp_packet+0xcd4/0xd00

Acked-by: David S. Miller <davem <at> davemloft.net>
Signed-off-by: Patrick McHardy <kaber <at> trash.net>
Signed-off-by: Chris Wright <chrisw <at> sous-sol.org>
---
 net/netfilter/nf_conntrack_proto_tcp.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
 <at>  <at>  -15,6 +15,7  <at>  <at> 
 #include <linux/skbuff.h>
 #include <linux/ipv6.h>
 #include <net/ip6_checksum.h>
+#include <asm/unaligned.h>

 #include <net/tcp.h>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chris Wright | 1 Apr 2009 01:10

[patch 03/45] dnet: drivers/net/dnet.c needs <linux/io.h>

-stable review patch.  If anyone has any objections, please let us know.
---------------------

From: Geert Uytterhoeven <geert <at> linux-m68k.org>

[ Upstream commit 142071b83426674ef2dab98cf2a6627328d0988e ]

On m68k:
| drivers/net/dnet.c: In function 'dnet_readw_mac':
| drivers/net/dnet.c:36: error: implicit declaration of function 'writel'
| drivers/net/dnet.c:43: error: implicit declaration of function 'readl'
| drivers/net/dnet.c: In function 'dnet_probe':
| drivers/net/dnet.c:873: error: implicit declaration of function 'ioremap'
| drivers/net/dnet.c:873: warning: assignment makes pointer from integer without a cast
| drivers/net/dnet.c:939: error: implicit declaration of function 'iounmap'

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
Signed-off-by: David S. Miller <davem <at> davemloft.net>
Signed-off-by: Chris Wright <chrisw <at> sous-sol.org>
---
 drivers/net/dnet.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/net/dnet.c
+++ b/drivers/net/dnet.c
 <at>  <at>  -9,6 +9,7  <at>  <at> 
  * published by the Free Software Foundation.
  */
 #include <linux/version.h>
+#include <linux/io.h>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chris Wright | 1 Apr 2009 01:11

[patch 25/45] SCSI: sg: fix races during device removal

-stable review patch.  If anyone has any objections, please let us know.
---------------------

From: Tony Battersby <tonyb <at> cybernetics.com>

upstream commit: c6517b7942fad663cc1cf3235cbe4207cf769332

sg has the following problems related to device removal:

* opening a sg fd races with removing a device
* closing a sg fd races with removing a device
* /proc/scsi/sg/* access races with removing a device
* command completion races with removing a device
* command completion races with closing a sg fd
* can rmmod sg with active commands

These problems can cause kernel oopses, memory-use-after-free, or
double-free errors.  This patch fixes these problems by using krefs
to manage the lifetime of sg_device and sg_fd.

Each command submitted to the midlevel holds a reference to sg_fd
until the completion callback.  This ensures that sg_fd doesn't go
away if the fd is closed with commands still outstanding.

sg_fd gets the reference of sg_device (with scsi_device) and also
makes sure that the sg module doesn't go away.

/proc/scsi/sg/* functions don't play nicely with krefs because they
give information about sg_fds which have been closed but not yet
freed due to still having outstanding commands and sg_devices which
(Continue reading)

Permalink | Reply | 6 comments |

Gmane