headers
Miguel Botón | 1 Jan 2008 01:16
Picon

[PATCH 1/2] ssb: add 'ssb_pcihost_set_power_state' function

This patch adds the 'ssb_pcihost_set_power_state' function.

This function allows us to set the power state of a PCI device
(for example b44 ethernet device). 

Signed-off-by: Miguel Botón <mboton <at> gmail.com>

diff --git a/include/linux/ssb/ssb.h b/include/linux/ssb/ssb.h
index a21ab29..aa70fd0 100644
--- a/include/linux/ssb/ssb.h
+++ b/include/linux/ssb/ssb.h
 <at>  <at>  -349,6 +349,13  <at>  <at>  static inline void ssb_pcihost_unregister(struct pci_driver *driver)
 {
 	pci_unregister_driver(driver);
 }
+
+static inline
+void ssb_pcihost_set_power_state(struct ssb_device *sdev, pci_power_t state)
+{
+	if (sdev->bus->bustype == SSB_BUSTYPE_PCI)
+		pci_set_power_state(sdev->bus->host_pci, state);
+}
 #endif /* CONFIG_SSB_PCIHOST */

--

-- 
	Miguel Botón
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 2 comments |
headers
Miguel Botón | 1 Jan 2008 01:17
Picon

[PATCH 2/2] b44: power down PHY when interface down

This is just this patch (http://lkml.org/lkml/2007/7/1/51) but adapted
to the 'b44' ssb driver.

Signed-off-by: Miguel Botón <mboton <at> gmail.com>

diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 49e9172..ea2a2b5 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
 <at>  <at>  -128,6 +128,8  <at>  <at>  static void b44_init_rings(struct b44 *);
 #define B44_FULL_RESET		1
 #define B44_FULL_RESET_SKIP_PHY	2
 #define B44_PARTIAL_RESET	3
+#define B44_CHIP_RESET_FULL	4
+#define B44_CHIP_RESET_PARTIAL	5

 static void b44_init_hw(struct b44 *, int);

 <at>  <at>  -1259,7 +1261,7  <at>  <at>  static void b44_clear_stats(struct b44 *bp)
 }

 /* bp->lock is held. */
-static void b44_chip_reset(struct b44 *bp)
+static void b44_chip_reset(struct b44 *bp, int reset_kind)
 {
 	struct ssb_device *sdev = bp->sdev;

 <at>  <at>  -1281,6 +1283,13  <at>  <at>  static void b44_chip_reset(struct b44 *bp)
 	ssb_device_enable(bp->sdev, 0);
 	b44_clear_stats(bp);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Linda Walsh | 1 Jan 2008 01:19

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

Robert Hancock wrote:
>> Have you tried using a different block size to see how that effects 
>> the results? There might be some funny interaction there.
----
    There is some interaction with the large block size (but only on the 
SATA
disk).  Counts were adjusted to keep the read near 2G (~2x physical memory).
 From 1k-16k block sizes, I got into the low-mid 40MB/s on buffered SATA
(compared to 50-60MB/s on ATA & SCSI).  Starting at 32k-64k, the read
rate began falling and at 128k block-reads-at-a-time or larger, it drops 
below
20MB/s (again, only on buffered SATA).   It's hard to imagine what would
slow down buffered SATA reads but not ATA and SCSI reads of the same
size.  I'm using the 'cfq' scheduler with everything running at default
priorities, but again, why only SATA slowness?  It seems that at the driver
level, using direct reads, the SATA disk has the highest read rate (near
80MB/s). 

    It would certainly be perverse to have faster driver & device 
performance
equate to lower buffered I/O.
>
>> I wanted to use the newer pata support in the SATA lib, but
>> got frustrated "real fast" by the lack of disk-parameter support
>> in the new pata library (hdparm is mostly broken; and the SCSI
>> utils aren't really intended for ATA(or SATA?) disks using the
>> SCSI interface.
>
> It's somewhat intentional that some of the hdparm commands (like for 
> settting transfer modes, enable/disable DMA, etc.) don't work with
(Continue reading)

Permalink | Reply | 0 comments |
headers
Robert Hancock | 1 Jan 2008 01:32
Picon
Favicon

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

Linda Walsh wrote:
> Robert Hancock wrote:
>>> Have you tried using a different block size to see how that effects 
>>> the results? There might be some funny interaction there.
> ----
>    There is some interaction with the large block size (but only on the 
> SATA
> disk).  Counts were adjusted to keep the read near 2G (~2x physical 
> memory).
>  From 1k-16k block sizes, I got into the low-mid 40MB/s on buffered SATA
> (compared to 50-60MB/s on ATA & SCSI).  Starting at 32k-64k, the read
> rate began falling and at 128k block-reads-at-a-time or larger, it drops 
> below
> 20MB/s (again, only on buffered SATA).   It's hard to imagine what would
> slow down buffered SATA reads but not ATA and SCSI reads of the same
> size.  I'm using the 'cfq' scheduler with everything running at default
> priorities, but again, why only SATA slowness?  It seems that at the driver
> level, using direct reads, the SATA disk has the highest read rate (near
> 80MB/s).
>    It would certainly be perverse to have faster driver & device 
> performance
> equate to lower buffered I/O.

Not too sure on that one. I suspect one might have to trace the actual 
requests being received at the driver level somehow with buffered reads 
in order to diagnose what's going on there..

>>
>>> I wanted to use the newer pata support in the SATA lib, but
>>> got frustrated "real fast" by the lack of disk-parameter support
(Continue reading)

Permalink | Reply | 0 comments |
headers
Sam Ravnborg | 1 Jan 2008 01:49
Gravatar

Re: Recursive variable `KBUILD_CFLAGS' references itself (eventually).

On Mon, Dec 31, 2007 at 11:10:21AM -0500, Dave Jones wrote:
> On Mon, Dec 31, 2007 at 02:16:19PM +0100, Sam Ravnborg wrote:
> 
>  > > Trying to do a 32bit build on a 64bit machine.
>  > > I did..
>  > >   make ARCH=i386 oldconfig
>  > >   make ARCH=i386 arch/x86/
>  > 
>  > Walking through my mailbox I found this one.
>  > I did not get similar reports and I cannot reproduce it.
>  > Do you continue to see this or had it been fixed somehow?
> 
> Still happens for me with the latest tree from git.
> 
> $ make ARCH=i386 arch/x86/
>   HOSTCC  scripts/kconfig/conf.o
>   HOSTLD  scripts/kconfig/conf
> scripts/kconfig/conf -s arch/x86/Kconfig
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   UPD     include/linux/utsrelease.h
>   CALL    scripts/checksyscalls.sh
> /mnt/raid0/src/linux-2.6/arch/x86/Makefile_32:43: *** Recursive variable `KBUILD_CFLAGS'
references itself (eventually).  Stop.
> make: *** [arch/x86/] Error 2

Can reproduce it now. Will take a look tomorrow.

	Sam
--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael Buesch | 1 Jan 2008 01:50
Picon
Favicon

Re: [PATCH 1/2] ssb: add 'ssb_pcihost_set_power_state' function

On Tuesday 01 January 2008 01:16:46 Miguel Botón wrote:
> This patch adds the 'ssb_pcihost_set_power_state' function.
> 
> This function allows us to set the power state of a PCI device
> (for example b44 ethernet device). 
> 
> Signed-off-by: Miguel Botón <mboton@...>

Acked-by: Michael Buesch <mb@...>

> 
> diff --git a/include/linux/ssb/ssb.h b/include/linux/ssb/ssb.h
> index a21ab29..aa70fd0 100644
> --- a/include/linux/ssb/ssb.h
> +++ b/include/linux/ssb/ssb.h
>  <at>  <at>  -349,6 +349,13  <at>  <at>  static inline void ssb_pcihost_unregister(struct pci_driver *driver)
>  {
>  	pci_unregister_driver(driver);
>  }
> +
> +static inline
> +void ssb_pcihost_set_power_state(struct ssb_device *sdev, pci_power_t state)
> +{
> +	if (sdev->bus->bustype == SSB_BUSTYPE_PCI)
> +		pci_set_power_state(sdev->bus->host_pci, state);
> +}
>  #endif /* CONFIG_SSB_PCIHOST */
>  
>  
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Holger Hoffstaette | 1 Jan 2008 02:45
Picon

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

On Mon, 31 Dec 2007 16:19:26 -0800, Linda Walsh wrote:

> [snip]
>     Another new "problem" (not as important) -- even though SATA disks are
> called with "sdX", my ATA disks that *were* at hda-hdc are now at hde-hdg.
> Devices hda-hdd are not populated in my dev directory on bootup.  Of

I think this is because the Promise SATA card also has one or more PATA
channels, so if the card is activated it takes precedence over your old
controller. But it should only be one channel, not four?
As for the other problem - I plan on adding such a card to one of my
systems during the week and might be able to contribute some findings.

Holger

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Permalink | Reply | 0 comments |
headers
jacliburn | 1 Jan 2008 02:59

[PATCH 05/26] atl1: print debug info if rrd error

From: Jay Cliburn <jacliburn <at> bellsouth.net>

Add some debug dev_printks if we encounter a bad receive return descriptor.

Signed-off-by: Jay Cliburn <jacliburn <at> bellsouth.net>
---
 drivers/net/atlx/atl1.c |   21 ++++++++++++++++++++-
 1 files changed, 20 insertions(+), 1 deletions(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 239641f..262d3ca 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
 <at>  <at>  -1127,7 +1127,26  <at>  <at>  static void atl1_intr_rx(struct atl1_adapter *adapter)
 		if (likely(rrd->xsz.valid)) {	/* packet valid */
 chk_rrd:
 			/* check rrd status */
-			if (likely(rrd->num_buf == 1))
+			if (rrd->num_buf != 1) {
+				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
+					"rx_buf_len = %d\n",
+					adapter->rx_buffer_len);
+				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
+					"RRD num_buf = %d\n",
+					rrd->num_buf);
+				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
+					"RRD pkt_len = %d\n",
+					rrd->xsz.xsum_sz.pkt_size);
+				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
+					"RRD pkt_flg = 0x%08X\n",
(Continue reading)

Permalink | Reply | 1 comment |
headers
jacliburn | 1 Jan 2008 02:59

[PATCH 06/26] atl1: update initialization parameters

From: Jay Cliburn <jacliburn <at> bellsouth.net>

Update initialization parameters to match the current vendor driver
version 1.2.40.2.

Signed-off-by: Jay Cliburn <jacliburn <at> bellsouth.net>
---
 drivers/net/atlx/atl1.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 262d3ca..695dcbc 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
 <at>  <at>  -136,20 +136,20  <at>  <at>  static int __devinit atl1_sw_init(struct atl1_adapter *adapter)
 	hw->rfd_fetch_gap = 1;
 	hw->rx_jumbo_th = adapter->rx_buffer_len / 8;
 	hw->rx_jumbo_lkah = 1;
-	hw->rrd_ret_timer = 16;
-	hw->tpd_burst = 4;
+	hw->rrd_ret_timer = 4;	/* 8 us */
+	hw->tpd_burst = 8;
 	hw->tpd_fetch_th = 16;
-	hw->txf_burst = 0x100;
+	hw->txf_burst = 0x200;
 	hw->tx_jumbo_task_th = (hw->max_frame_size + 7) >> 3;
 	hw->tpd_fetch_gap = 1;
 	hw->rcb_value = atl1_rcb_64;
 	hw->dma_ord = atl1_dma_ord_enh;
-	hw->dmar_block = atl1_dma_req_256;
(Continue reading)

Permalink | Reply | 7 comments |
headers
jacliburn | 1 Jan 2008 02:59

[PATCH 02/26] atl1: move common functions to atlx files

From: Jay Cliburn <jacliburn <at> bellsouth.net>

The future atl2 driver and the existing atl1 driver can share certain
functions and definitions.  Move these shareable functions and definitions
out of atl1-specific files and into atlx.c and atlx.h.  Some transitory
hackery will be present until atl2 is merged.

Reduce the number of source files by moving ethtool, hw, and param
functions from separate files into atl1_main.c, then rename it to just
atl1.c.

Move all atl1-specific definitions from atl1_hw.h to atl1.h.

Finally, clean up to make checkpatch.pl happy.

Signed-off-by: Chris Snook <csnook <at> redhat.com>
Signed-off-by: Jay Cliburn <jacliburn <at> bellsouth.net>
---
 drivers/net/atlx/Makefile                |    1 -
 drivers/net/atlx/{atl1_main.c => atl1.c} | 1544 ++++++++++++++++++++++++------
 drivers/net/atlx/atl1.h                  |  603 +++++++++++-
 drivers/net/atlx/atl1_ethtool.c          |  505 ----------
 drivers/net/atlx/atl1_hw.c               |  720 --------------
 drivers/net/atlx/atl1_hw.h               |  946 ------------------
 drivers/net/atlx/atl1_param.c            |  203 ----
 drivers/net/atlx/atlx.c                  |  433 +++++++++
 drivers/net/atlx/atlx.h                  |  506 ++++++++++
 9 files changed, 2751 insertions(+), 2710 deletions(-)
 rename drivers/net/atlx/{atl1_main.c => atl1.c} (65%)
 delete mode 100644 drivers/net/atlx/atl1_ethtool.c
(Continue reading)

Permalink | Reply | 0 comments |

Gmane