Re: 2.6.12-rc3-mm1 (a-new-10gb-ethernet-driver-by-chelsio-communications.patch)

> --- /dev/null
> +++ 25-akpm/drivers/net/chelsio/common.h

> +#define DIMOF(x) (sizeof(x)/sizeof(x[0]))

ARRAY_SIZE in include/linux/kernel.h

> --- /dev/null
>+++ 25-akpm/drivers/net/chelsio/cpl5_cmd.h

> +struct cpl_tx_pkt {
> +	__u16 vlan;

__be16.

> +struct cpl_tx_pkt_lso {
> +	__u32 len;

__be32

> +	__u16 eth_type_mss;

__be16

> +struct cpl_rx_pkt {
> +	__u16 vlan;

Re: [PATCH] resource release cleanup in net/

On Sat, Apr 30, 2005 at 10:36:00PM +0200, Jesper Juhl wrote:
> Since Andrew merged the patch that makes calling crypto_free_tfm() with a 
> NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for 
> NULL before calling that function

>  drivers/net/wireless/hostap/hostap_crypt_ccmp.c |    5 -
>  drivers/net/wireless/hostap/hostap_crypt_tkip.c |   10 +-
>  drivers/net/wireless/hostap/hostap_crypt_wep.c  |    5 -
>  net/ieee80211/ieee80211_crypt_ccmp.c            |    5 -
>  net/ieee80211/ieee80211_crypt_tkip.c            |   10 +-
>  net/ieee80211/ieee80211_crypt_wep.c             |    5 -

I think I have a better one for these.

--- linux-2.6.12-rc3-mm1/drivers/net/wireless/hostap/hostap_crypt_ccmp.c	2005-05-01
01:53:50.000000000 +0000
+++ linux-2.6.12-rc3-mm1-hostap/drivers/net/wireless/hostap/hostap_crypt_ccmp.c	2005-05-01
02:21:10.000000000 +0000
 <at>  <at>  -102,17 +102,14  <at>  <at>  static void * hostap_ccmp_init(int key_i
 	if (priv->tfm == NULL) {
 		printk(KERN_DEBUG "hostap_crypt_ccmp: could not allocate "
 		       "crypto API aes\n");
-		goto fail;
+		goto fail_free;
 	}

 	return priv;

+fail_free:

Re: [PATCH] resource release cleanup in net/

On Sun, 1 May 2005, Alexey Dobriyan wrote:

> On Sat, Apr 30, 2005 at 10:36:00PM +0200, Jesper Juhl wrote:
> > Since Andrew merged the patch that makes calling crypto_free_tfm() with a 
> > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for 
> > NULL before calling that function
> >  drivers/net/wireless/hostap/hostap_crypt_ccmp.c |    5 -
> >  drivers/net/wireless/hostap/hostap_crypt_tkip.c |   10 +-
> >  drivers/net/wireless/hostap/hostap_crypt_wep.c  |    5 -
> >  net/ieee80211/ieee80211_crypt_ccmp.c            |    5 -
> >  net/ieee80211/ieee80211_crypt_tkip.c            |   10 +-
> >  net/ieee80211/ieee80211_crypt_wep.c             |    5 -
> I think I have a better one for these.
> 
> --- linux-2.6.12-rc3-mm1/drivers/net/wireless/hostap/hostap_crypt_ccmp.c	2005-05-01
01:53:50.000000000 +0000
> +++ linux-2.6.12-rc3-mm1-hostap/drivers/net/wireless/hostap/hostap_crypt_ccmp.c	2005-05-01
02:21:10.000000000 +0000
>  <at>  <at>  -102,17 +102,14  <at>  <at>  static void * hostap_ccmp_init(int key_i
>  	if (priv->tfm == NULL) {
>  		printk(KERN_DEBUG "hostap_crypt_ccmp: could not allocate "
>  		       "crypto API aes\n");
> -		goto fail;
> +		goto fail_free;
>  	}
>  
>  	return priv;
>  
> +fail_free:
> +	kfree(priv);

Re: [PATCH 2/4] resource release cleanup in net/ (take 2)

On Sun, 1 May 2005, Jesper Juhl wrote:

> On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> 
> > On 4/30/05, Jesper Juhl <juhl-lkml <at> dif.dk> wrote:
> > > Hi David,
> > > 
> > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > > NULL before calling that function, and while I was at it I removed similar
> > > redundant checks before calls to kfree() and vfree() in the same files.
> > > There are also a few tiny whitespace cleanups in there.
> > 
> > Jesper, I'd suggest that you left whitespaces for a separate patch, it
> > is always,
> > IMHO, better to have as small a patch as possible for reviewing.
> > 
> Sure thing. I've split the patches, and I believe that me going through 
> them a second time did them good, there are a few tiny changes over the 
> first version.
> 
> I split the patch in 4 parts (will send as replies to this mail) : 
> 	1) crypto_free_tfm related changes
> 	2) kfree related changes
> 	3) vfree related changes
> 	4) whitespace changes
> The whitespace changes ended up fairly bigger than initially. I expanded 
> the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
> a lot better than the originals.
> 

[PATCH 1/4] resource release cleanup in net/ (take 2)

On Sun, 1 May 2005, Jesper Juhl wrote:

> On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> 
> > On 4/30/05, Jesper Juhl <juhl-lkml <at> dif.dk> wrote:
> > > Hi David,
> > > 
> > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > > NULL before calling that function, and while I was at it I removed similar
> > > redundant checks before calls to kfree() and vfree() in the same files.
> > > There are also a few tiny whitespace cleanups in there.
> > 
> > Jesper, I'd suggest that you left whitespaces for a separate patch, it
> > is always,
> > IMHO, better to have as small a patch as possible for reviewing.
> > 
> Sure thing. I've split the patches, and I believe that me going through 
> them a second time did them good, there are a few tiny changes over the 
> first version.
> 
> I split the patch in 4 parts (will send as replies to this mail) : 
> 	1) crypto_free_tfm related changes
> 	2) kfree related changes
> 	3) vfree related changes
> 	4) whitespace changes
> The whitespace changes ended up fairly bigger than initially. I expanded 
> the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
> a lot better than the originals.
> 

[PATCH 0/4] resource release cleanup in net/ (take 2)

On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:

> On 4/30/05, Jesper Juhl <juhl-lkml <at> dif.dk> wrote:
> > Hi David,
> > 
> > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > NULL before calling that function, and while I was at it I removed similar
> > redundant checks before calls to kfree() and vfree() in the same files.
> > There are also a few tiny whitespace cleanups in there.
> 
> Jesper, I'd suggest that you left whitespaces for a separate patch, it
> is always,
> IMHO, better to have as small a patch as possible for reviewing.
> 
Sure thing. I've split the patches, and I believe that me going through 
them a second time did them good, there are a few tiny changes over the 
first version.

I split the patch in 4 parts (will send as replies to this mail) : 
	1) crypto_free_tfm related changes
	2) kfree related changes
	3) vfree related changes
	4) whitespace changes
The whitespace changes ended up fairly bigger than initially. I expanded 
the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
a lot better than the originals.

--

-- 
Jesper

[PATCH 3/4] resource release cleanup in net/ (take 2)

On Sun, 1 May 2005, Jesper Juhl wrote:

> On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> 
> > On 4/30/05, Jesper Juhl <juhl-lkml <at> dif.dk> wrote:
> > > Hi David,
> > > 
> > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > > NULL before calling that function, and while I was at it I removed similar
> > > redundant checks before calls to kfree() and vfree() in the same files.
> > > There are also a few tiny whitespace cleanups in there.
> > 
> > Jesper, I'd suggest that you left whitespaces for a separate patch, it
> > is always,
> > IMHO, better to have as small a patch as possible for reviewing.
> > 
> Sure thing. I've split the patches, and I believe that me going through 
> them a second time did them good, there are a few tiny changes over the 
> first version.
> 
> I split the patch in 4 parts (will send as replies to this mail) : 
> 	1) crypto_free_tfm related changes
> 	2) kfree related changes
> 	3) vfree related changes
> 	4) whitespace changes
> The whitespace changes ended up fairly bigger than initially. I expanded 
> the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
> a lot better than the originals.
> 

[PATCH 4/4] resource release cleanup in net/ (take 2)

On Sun, 1 May 2005, Jesper Juhl wrote:

> On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> 
> > On 4/30/05, Jesper Juhl <juhl-lkml <at> dif.dk> wrote:
> > > Hi David,
> > > 
> > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > > NULL before calling that function, and while I was at it I removed similar
> > > redundant checks before calls to kfree() and vfree() in the same files.
> > > There are also a few tiny whitespace cleanups in there.
> > 
> > Jesper, I'd suggest that you left whitespaces for a separate patch, it
> > is always,
> > IMHO, better to have as small a patch as possible for reviewing.
> > 
> Sure thing. I've split the patches, and I believe that me going through 
> them a second time did them good, there are a few tiny changes over the 
> first version.
> 
> I split the patch in 4 parts (will send as replies to this mail) : 
> 	1) crypto_free_tfm related changes
> 	2) kfree related changes
> 	3) vfree related changes
> 	4) whitespace changes
> The whitespace changes ended up fairly bigger than initially. I expanded 
> the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
> a lot better than the originals.
> 

2.6.11-ck7

Small update from ck6 for wrong scsi patch merge

http://ck.kolivas.org/patches/2.6/2.6.11/2.6.11-ck7/patch-2.6.11-ck7.bz2
or
http://ck.kolivas.org/patches/2.6/2.6.11/2.6.11-ck7/patch-2.6.11-ck7-server.bz2

Changes since 2.6.11-ck6:
-scsi-dead-device.diff
+2.6.11-ck-scsifix.diff
Apply the _correct_ scsci fix.

-2611ck6-version.diff
+2611ck7-version.diff

Cheers,
Con

Small update from ck6 for wrong scsi patch merge

http://ck.kolivas.org/patches/2.6/2.6.11/2.6.11-ck7/patch-2.6.11-ck7.bz2
or
http://ck.kolivas.org/patches/2.6/2.6.11/2.6.11-ck7/patch-2.6.11-ck7-server.bz2

Changes since 2.6.11-ck6:
-scsi-dead-device.diff
+2.6.11-ck-scsifix.diff
Apply the _correct_ scsci fix.

-2611ck6-version.diff

2.6.12-rc3-mm2

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc3/2.6.12-rc3-mm2/

- Various fixes against 2.6.12-rc3-mm1.

Changes since 2.6.12-rc3-mm1:

-netlink-audit-warning-fix.patch
-ppc64-fix-32-bit-signal-frame-back-link.patch

 Merged

-preserve-arch-and-cross_compile-in-the-build-directory-generated-makefile.patch

 Dropped - Sam no likee.

+sis900-must-select-mii.patch

 Net driver Kconfig fix

+proc-pid-smaps-fix.patch

 Fix proc-pid-smaps.patch for arm

+x86-port-lockless-mce-implementation-fix-2.patch

 Fix x86-port-lockless-mce-preparation.patch

+x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree-fix.patch
+x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree-fix-2.patch