1 Jan 2005 01:01
Re: [KJ] Re: [PATCH] esp: Make driver SMP-correct
Gene Heskett <gene.heskett <at> verizon.net>
2005-01-01 00:01:50 GMT
2005-01-01 00:01:50 GMT
On Friday 31 December 2004 17:16, Jim Nelson wrote: >Russell King wrote: >> On Fri, Dec 31, 2004 at 10:00:37AM +0000, Russell King wrote: >>>On Fri, Dec 31, 2004 at 01:46:11AM -0800, Andrew Morton wrote: >>>>James Nelson <james4765 <at> verizon.net> wrote: >>>>>This is an attempt to make the esp serial driver SMP-correct. >>>>> It also removes some cruft left over from the serial_write() >>>>> conversion. >>>>> >>>>>>From a quick scan: >>>> >>>>- startup() does multiple sleeping allocations and request_irq() >>>> under spin_lock_irqsave(). Maybe fixed by this: >>> >>>However, can you guarantee that two threads won't enter startup() >>> at the same time? (that's what ASYNC_INITIALIZED is protecting >>> the function against, and the corresponding shutdown() as well.) >>> >>>It's probably better to port ESP to the serial_core structure >>> where this type of thing is already taken care of. >> >> For the record, Verizon appear to have adopted silly policies. >> >>>>From now on, I will be removing the CC: line containing any >>> verizon >> >> email address until further notice, or just plain ignoring mails >> containing such addresses. Why? To prevent the inevitable bounce >> caused by their misconfigured systems. None of the servers I have >> access to on several different ISPs can connect to Verizon's(Continue reading)
RSS Feed