headers
Luis R. Rodriguez | 1 Apr 2011 01:06
Favicon

Re: [PATCH] cfg80211: add a timer for invalid user reg hints

On Thu, Mar 31, 2011 at 3:31 PM, Luis R. Rodriguez
<lrodriguez@...> wrote:
> We have no other option but to inform userspace that we have
> queued up their regulatory hint request when we are given one
> given that nl80211 operates atomically on user requests. The
> best we can do is accept the request, and set a timer for processing
> it. If the timer is hit we restore the regulatory settings and
> ignore the user input.
>
> This fixes this reported bug:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=28112
>
> Reported-by: gregoryx.alagnou@...
> Signed-off-by: Luis R. Rodriguez <lrodriguez@...>

I'll respin using schedule_delayed_work() instead.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Luis R. Rodriguez | 1 Apr 2011 01:29
Favicon

[PATCH v2] cfg80211: add work for processing invalid user reg hints

We have no other option but to inform userspace that we
have queued up their regulatory hint request when we are
given one given that nl80211 operates atomically on user
requests. The best we can do is accept the request, and
add a delayed work item for processing failures and cancel it
if we succeeed. Upon failure we restore the regulatory
settings and ignore the supplied user input.

This fixes this reported bug:

https://bugzilla.kernel.org/show_bug.cgi?id=28112

Reported-by: gregoryx.alagnou@...
Signed-off-by: Luis R. Rodriguez <lrodriguez@...>
---

This simplifies the timer/work implementation by 9 lines :D

 net/wireless/reg.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 3332d5b..cb917de 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
 <at>  <at>  -106,6 +106,9  <at>  <at>  struct reg_beacon {
 static void reg_todo(struct work_struct *work);
 static DECLARE_WORK(reg_work, reg_todo);

+static void reg_timeout_work(struct work_struct *work);
(Continue reading)

Permalink | Reply | 2 comments |
headers
Bing Zhao | 1 Apr 2011 04:50
Favicon

[PATCH] mwifiex: remove unused macros in decl.h and main.h

These macros are leftover of previous cleanup patches.

Signed-off-by: Bing Zhao <bzhao@...>
---
 drivers/net/wireless/mwifiex/decl.h |   24 ------------------------
 drivers/net/wireless/mwifiex/main.h |    7 -------
 2 files changed, 0 insertions(+), 31 deletions(-)

diff --git a/drivers/net/wireless/mwifiex/decl.h b/drivers/net/wireless/mwifiex/decl.h
index 4e1f115..c3c15f9 100644
--- a/drivers/net/wireless/mwifiex/decl.h
+++ b/drivers/net/wireless/mwifiex/decl.h
 <at>  <at>  -51,7 +51,6  <at>  <at> 
 #define MWIFIEX_RATE_BITMAP_MCS127 159

 #define MWIFIEX_RX_DATA_BUF_SIZE     (4 * 1024)
-#define MWIFIEX_RX_CMD_BUF_SIZE      (2 * 1024)

 #define MWIFIEX_RTS_MIN_VALUE              (0)
 #define MWIFIEX_RTS_MAX_VALUE              (2347)
 <at>  <at>  -141,13 +140,6  <at>  <at>  struct mwifiex_bss_attr {
 	u32 bss_num;
 };

-enum mwifiex_cmd_result_e {
-	MWIFIEX_CMD_RESULT_SUCCESS = 0,
-	MWIFIEX_CMD_RESULT_FAILURE = 1,
-	MWIFIEX_CMD_RESULT_TIMEOUT = 2,
-	MWIFIEX_CMD_RESULT_INVALID_DATA = 3
-} __packed;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Thomas Pedersen | 1 Apr 2011 03:49

[PATCH] nl80211: report mesh capabilities

NL80211_CMD_GET_WIPHY now returns a flag NL80211_SUPPORT_MESH_AUTH if
the wiphy's mesh implementation supports routing of mesh auth frames to
userspace.  This is useful for forward compatibility between old kernels
and new userspace tools.

Signed-off-by: Thomas Pedersen <thomas@...>

Johannes, 

Thanks for your comments, I've tried to implement the necessary changes below.
wiphy->flags now gets a WIPHY_FLAG_MESH_AUTH flag in case the mesh
implementation supports routing of mesh auth frames to userspace. If you know
of a better place to put this (rdev maybe?), please let me know. Also, it would
be nice if all you have is the ifindex; not having to send a command to
nl80211, parse the response, then get the wiphy index so you can request
capabilities from the stack. I'd like to be able to get capabilities directly
from an interface, should this happen in CMD_GET_MESH_CONFIG,
CMD_GET_INTERFACE, or maybe somewhere else?

v2:

- return capabilities for a wiphy (Johannes)
- WIPHY_FLAG_MESH_AUTH is now set by the cfg80211 driver to indicate support
  for routing mesh auth frames to userspace (Johannes)
---
 include/linux/nl80211.h |    5 +++++
 include/net/cfg80211.h  |    3 +++
 net/mac80211/main.c     |    4 ++++
 net/wireless/nl80211.c  |    3 +++
 4 files changed, 15 insertions(+), 0 deletions(-)
(Continue reading)

Permalink | Reply | 1 comment |
headers
Realman Namingston | 1 Apr 2011 05:12
Picon

bad packets in monitor mode with ar9170 devices

ar9170-based devices record a fair amount of bad packets in monitor
mode both with the old ar9170usb and new carl9170 drivers. The packets
contain random BSSIDs, some measure of additional random data, and
seem to scale proportional to the amount of traffic occurring on the
observed channel. This behavior makes the devices rather unattractive
for use in Kismet and site survey applications.

I assume this is due to a shortcoming of the hardware.. but is there
any potential fix possible?

-r1776
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 5 comments |
headers
Stanislaw Gruszka | 1 Apr 2011 09:22
Picon
Favicon

Re: [PATCH 1/3] iwlwifi: fix enqueue hcmd race conditions

Hi Wey

> Do you have a bug# against this?
No, I was fixing problems happened on my local system.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 3 comments |
headers
Luciano Coelho | 1 Apr 2011 09:50
Picon
Favicon

Re: [PATCH] wl12xx: configure channel/band while FW is off

On Tue, 2011-03-22 at 10:07 +0200, Arik Nemtsov wrote:
> Initialize the channel and band from mac80211 conf even when the FW is
> not yet loaded. This mitigates a bug in AP-mode where the channel was
> never changed from its initial setting after FW boot and was therefore
> never configured to FW.
> 
> Reported-by: Alexander Boukaty <alexanderb@...>
> Signed-off-by: Arik Nemtsov <arik@...>
> ---

Applied, thank you.

--

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Christian Lamparter | 1 Apr 2011 09:51

Re: bad packets in monitor mode with ar9170 devices

On Friday 01 April 2011 05:12:45 Realman Namingston wrote:
> ar9170-based devices record a fair amount of bad packets in monitor
> mode both with the old ar9170usb and new carl9170 drivers. The packets
> contain random BSSIDs, some measure of additional random data, and
> seem to scale proportional to the amount of traffic occurring on the
> observed channel. This behavior makes the devices rather unattractive
> for use in Kismet and site survey applications.
> 
> I assume this is due to a shortcoming of the hardware.. but is there
> any potential fix possible?
no, you misunderstood that completely: it's a shortcoming of kismet!

quote:
"Usually the wireless adapter is unable to transmit in monitor mode and
is restricted to a single wireless channel, though this is dependent on
the wireless adapter's driver, its firmware, and its chip set's features.
Also, in monitor mode the adapter does not check to see if the cyclic
redundancy check (CRC) values are correct for packets captured, so some
captured packets may be corrupted."

http://en.wikipedia.org/wiki/Monitor_mode
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 4 comments |
headers
Luciano Coelho | 1 Apr 2011 09:53
Picon
Favicon

Re: [PATCH] wl12xx: rearrange some ELP wake_up/sleep calls

On Wed, 2011-03-23 at 22:22 +0200, Eliad Peller wrote:
> ELP (Extremely/Enhanced Low Power, or something like that ;)) refers to
> the powerstate of the 12xx chip, in which very low power is consumed,
> and no commands (from the host) can be issued until the chip is woken up.
> 
> Wakeup/sleep commands must be protected by a wl->mutex, so it's generally
> a good idea to call wakeup/sleep along with the mutex lock/unlock (where
> needed). However, in some places the wl12xx driver calls wakeup/sleep in
> some "inner" functions. This result in some "nested" wakeup/sleep calls
> which might end up letting the chip go to sleep prematurely (e.g. during
> event handling).
> 
> Fix it by rearranging the elp calls to come along with mutex_lock/unlock.
> 
> Signed-off-by: Eliad Peller <eliad@...>
> Signed-off-by: Ido Yariv <ido@...>
> ---

Applied, thanks!

--

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 0 comments |
headers
Johannes Berg | 1 Apr 2011 10:17
Favicon

Re: [PATCH v2] cfg80211: add work for processing invalid user reg hints

On Thu, 2011-03-31 at 16:29 -0700, Luis R. Rodriguez wrote:
>  
> +static void reg_timeout_work(struct work_struct *work)
> +{
> +	REG_DBG_PRINT("Timeout while waiting for CRDA to reply,"
> +		      "restoring regulatory settings");
> +	restore_regulatory_settings(true);
> +}

We have a queue of requests but you're timing out only the last one.
Wouldn't that still get another one stuck on the queue? TBH, I don't
quite understand why we have last _and_ a queue to start with.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |

Gmane