headers
Joerg Albert | 1 Aug 01:15
Picon
Picon

Re: [PATCH] compat-2.6: Makefile: fixed test expressions for target install

On 07/31/2009 08:56 PM, Pavel Roskin wrote:

> No, I didn't mean that.  I meant:
> 
> if [ -z "" ] && [ -z "" ]; then echo "both empty"; fi
> ...
> We should not rely on any bash features as /bin/sh may not be bash at
> all.

Agreed. Will repost the patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 3 comments |
headers
Joerg Albert | 1 Aug 01:21
Picon
Picon

[PATCH v2] compat-2.6: Makefile: fixed test expressions for target install

This removes the two errors of [ with target "install"

[: 9: missing ]
[: 9: missing ]

and works with sh as well.

Signed-off-by: Joerg Albert <jal2@...>
---
  Makefile |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 62eb5db..e1ad666 100644
--- a/Makefile
+++ b/Makefile
@@ -80,7 +80,7 @@ install-scripts:
         @install scripts/athload        $(DESTDIR)/usr/sbin/
         @install scripts/b43load        $(DESTDIR)/usr/sbin/
         @install scripts/iwl-load       $(DESTDIR)/usr/sbin/
-       @if [ ! -z $(MADWIFI) && -z "$(DESTDIR)" ]; then \
+       @if [ ! -z "$(MADWIFI)" ] && [ -z "$(DESTDIR)" ]; then \
                 echo ;\
                 echo -n "Note: madwifi detected, we're going to disable it. "  ;\
                 echo "If you would like to enable it later you can run:"  ;\
@@ -89,7 +89,7 @@ install-scripts:
                 echo Running athenable ath5k...;\
                 /usr/sbin/athenable ath5k ;\
         fi
-       @if [ ! -z $(OLD_IWL) && -z "$(DESTDIR)" ]; then \
(Continue reading)

Permalink | Reply | 0 comments |
headers
Luis R. Rodriguez | 1 Aug 01:22
Picon
Gravatar

Re: [PATCH] compat-2.6: Makefile: fixed test expressions for target install

On Fri, Jul 31, 2009 at 4:15 PM, Joerg Albert<jal2@...> wrote:
> On 07/31/2009 08:56 PM, Pavel Roskin wrote:
>
>> No, I didn't mean that.  I meant:
>>
>> if [ -z "" ] && [ -z "" ]; then echo "both empty"; fi
>> ...
>> We should not rely on any bash features as /bin/sh may not be bash at
>> all.
>
> Agreed. Will repost the patch.

Actually please do keep relying on /bin/bash, all the scripts on
compat-wireless do depend on /bin/bash, I don't expect users of
dash/etc to use compat-wireless.

If we want to make compat-wireless be shell agnostic we'd need to
address all the other scripts. I rather not deal with that now unless
we really think that is also a good idea and someone is up for the
task.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 2 comments |
headers
Luis R. Rodriguez | 1 Aug 01:36
Picon
Gravatar

Re: [Linux Wireless] Update of "en/users/Download" by ReinetteChatre

On Fri, Jul 31, 2009 at 2:19 PM, Roman Macko<rmacko72@...> wrote:
> Hi Luis,
>
> here is promised patch

Patch applied, thanks!

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Larry Finger | 1 Aug 03:28
Favicon

Re: Newbie question on 2.6.28-rc8-wl

Jayant Sane wrote:
> 
> Thank you.
> 
> Again pardon my ignorance here..
> 
> It seems that I can either get 2.6.28-wl or 2.6.28-rc8 per your suggestions below but not 2.6.28-rc8-wl
> 
> And I know it is possible to have the kernel version reported as 2.6.28-rc8-wl.  How can I get that?

In the main directory, create a file named localversion-wireless with
a line that says -wl

If you did the steps I told you earlier, you have the same as
2.6.28-rc8-wl, no matter what it says.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Bing Zhao | 1 Aug 05:02
Favicon

[PATCH] libertas: Fix WEP association failure with open source wpa_supplicant 0.5.10

From: Maithili Hinge <maithili@...>

From: Maithili Hinge <maithili@...>

Add code to handle IW_AUTH_PRIVACY_INVOKED and IW_AUTH_RX_UNENCRYPTED_EAPOL
cases in lbs_set_auth() function in libertas code.

Signed-off-by: Maithili Hinge <maithili@...>
Signed-off-by: Bing Zhao <bzhao@...>
---
 drivers/net/wireless/libertas/wext.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c
index e96451c..be837a0 100644
--- a/drivers/net/wireless/libertas/wext.c
+++ b/drivers/net/wireless/libertas/wext.c
@@ -1728,6 +1728,8 @@ static int lbs_set_auth(struct net_device *dev,
 	}

 	switch (dwrq->flags & IW_AUTH_INDEX) {
+	case IW_AUTH_PRIVACY_INVOKED:
+	case IW_AUTH_RX_UNENCRYPTED_EAPOL:
 	case IW_AUTH_TKIP_COUNTERMEASURES:
 	case IW_AUTH_CIPHER_PAIRWISE:
 	case IW_AUTH_CIPHER_GROUP:
--

-- 
1.5.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
(Continue reading)

Permalink | Reply | 1 comment |
headers
David Miller | 1 Aug 07:23
Favicon

Re: [PATCH] Fix SPARC64 unaligned access in zd_mac_rx

From: Johannes Berg <johannes@...>
Date: Fri, 31 Jul 2009 10:39:43 +0200

> On Fri, 2009-07-31 at 01:59 -0600, Patrick Simmons wrote:
>> I'm running zd1211rw on SPARC64 and was getting a lot of "unaligned 
>> access" messages in dmesg.  I tracked the problem down to this line, and 
>> changing the cast to a memcpy fixes the issue.
>>  
>> -       fc = *(__le16 *)buffer;
>> +       memcpy(&fc,buffer,sizeof(__le16));
>>         need_padding = ieee80211_is_data_qos(fc) ^ ieee80211_has_a4(fc);
> 
> Please use get_unaligned instead.

And, more specifically, one of the endian get_unaligned variants.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 8 comments |
headers
Mike Galbraith | 1 Aug 07:25
Picon
Picon

rt2800usb: memory corruption?

Greetings,

Fiddling with my box's builtin usb wireless adapter with the rt2x00
driver in .git.today to tinker with associate problem.

On Thu, 2009-07-30 at 14:12 +0200, Mike Galbraith wrote:

> This is nogo with rt2x00 driver fwiw.  Maybe some simple configuration
> thing, but I'm having no luck getting the bugger to work.
> 
> [   12.942335] phy0: Selected rate control algorithm 'minstrel'
> [   12.942440] Registered led device: rt2800usb-phy0::radio
> [   12.955279] Registered led device: rt2800usb-phy0::assoc
> [   12.968003] Registered led device: rt2800usb-phy0::quality
> [   12.981183] usbcore: registered new interface driver rt2800usb
> 
> [   33.032056] rt2800usb 1-5:1.0: firmware: requesting rt2870.bin
> [   33.161552] input: rt2800usb as /devices/pci0000:00/0000:00:1a.7/usb1/1-5/1-5:1.0/input/input4
> [   33.347130] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> [   34.513078] eth0: no IPv6 routers present
> [   35.935289] wlan0: authenticate with AP 00:1a:4f:9a:d0:12
> [   35.937306] wlan0: authenticated
> [   35.937309] wlan0: associate with AP 00:1a:4f:9a:d0:12
> [   35.942551] wlan0: RX AssocResp from 00:1a:4f:9a:d0:12 (capab=0x411 status=0 aid=1)
> [   35.942555] wlan0: associated
> [   35.950948] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> [   37.314470] mtrr: base(0xd0000000) is not aligned on a size(0xff00000) boundary
> [   39.937271] wlan0: deauthenticated (Reason: 1)
snip repeat forever...
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nick Kossifidis | 1 Aug 07:46
Favicon

Re: [PATCH 4/4] ath5k: Use SWI to trigger calibration

 * Get rid of calibration timer, instead use a software interrupt
   to schedule the calibration tasklet.

 a) We don't need a timer for this, there is no need for accuracy
    even with round_jiffies i think this is a waste of resources.
    Also we don't need to run calibration if we are idle (no
    interrupts).

 b) When we add ANI support we 'll just extend the poll function
    and calibration tasklet and handle all periodic phy calibration
    on one place (much cleaner).

 c) Having calibration on a tasklet is better since during calibration
    we can't transmit or receive (antennas are detached to measure
    noise floor), previously calibration could run in parallel with
    tx/rx and interfere (packet loss).

 v2: kill tasklet on stop_hw, stop/wake queues

 Signed-off-by: Nick Kossifidis <mickflemm@...>

---
 drivers/net/wireless/ath/ath5k/ath5k.h |   16 ++++++++++++++
 drivers/net/wireless/ath/ath5k/base.c  |   36 +++++++++++++++++++++++--------
 drivers/net/wireless/ath/ath5k/base.h  |    3 +-
 drivers/net/wireless/ath/ath5k/phy.c   |   20 +++++++++++++++++
 4 files changed, 64 insertions(+), 11 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h
index 1047a6c..76cf5b2 100644
(Continue reading)

Permalink | Reply | 18 comments |
headers
Johannes Berg | 1 Aug 09:11
Favicon

Re: wpa_test not used in wpa.c

On Fri, 2009-07-31 at 14:42 -0700, Ben Greear wrote:
> It seems to me that in this method (and others), wpa_test is not
> actually assigned a useful value, but it's still tested in code
> branches.

> 
> Any idea on how this is supposed to work?

It isn't really. It's some dead code that you can enable manually for
testing or so. It used to be possible to use a private ioctl or so to
set it, iirc, but that's long gone. I'd have no objections to just
removing it.

johannes
Permalink | Reply | 1 comment |

Gmane