headers
Forest Bond | 1 May 02:03
Gravatar

Re: [PATCH 7/8] vt6655: Replace net_device->priv accesses with netdev_priv calls.

Hi,

I haven't had a chance to test this on real hardware yet.  Sorry, I will try to
do this soon.

On Sat, Apr 25, 2009 at 10:32:35AM -0400, Forest Bond wrote:
> @@ -1226,11 +1227,6 @@ static BOOL device_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
>  
>      PSDevice p;
>      
> -    *ppDevice = kmalloc(sizeof(DEVICE_INFO),GFP_ATOMIC);
> -    
> -    if (*ppDevice == NULL)
> -        return FALSE;
> -        
>      memset(*ppDevice,0,sizeof(DEVICE_INFO));
>      
>      if (pDevice_Infos == NULL) {

I realized that I did not remove the corresponding kfree calls for this removed
kmalloc.  Should I resend, or is it better to send an additional patch to be
applied on top of the original patches?

Thanks,
Forest
--

-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stephen Rothwell | 1 May 07:21
Picon
Picon

linux-next: driver-core tree build warning

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'

Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
remove driver_data direct access of struct device").
--

-- 
Cheers,
Stephen Rothwell                    sfr <at> canb.auug.org.au
(Continue reading)

Permalink | Reply | 6 comments |
headers
Kalle Valo | 1 May 07:45
Picon
Picon
Favicon

Re: Chances of WPA with at76c505a-rfmd2958

Jamie Lentin <jm@...> writes:

> Hi,

Hello,

> I've got this chip within my OQO 01+, generally the driver seems very
> stable (thankyou for your work!), 

Which driver? There is at76c50x-usb (using mac80211) and at76_usb in
staging (which is going away sometime in the future). Because
at76c50x-usb is the path forward, I will omit at76_usb here.

> however when trying to use WPA with the chip the association
> conversation fails.

Yes, at76c50x-usb doesn't support WPA right now.

> Of course, I can provide the logs from both the device and hostapd on
> the other end, but suspect that the answer will fall into one of the
> categories:-
>
> (a) Be patient!  Test it once I've said the driver supports it.
>
> (b) Go off and try and implement x, y and z, see what happens.
>
> (c) Not a chance with this chip, sorry.  The firmware can't send x, so
> the association won't ever work.
>
> WPA would be very useful for me, so would be glad to help in any way.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Greg KH | 1 May 07:47
Gravatar

Re: linux-next: driver-core tree build warning

On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> 
> Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> remove driver_data direct access of struct device").

Ah crap, my bad.  I'll go fix this up, it passed my build tests, I
(Continue reading)

Permalink | Reply | 4 comments |
headers
Greg Kroah-Hartman | 1 May 08:02
Picon
Favicon
Gravatar

[PATCH v2] Wireless: remove driver_data direct access of struct device

From: Greg Kroah-Hartman <gregkh@...>

In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: John W. Linville <linville@...>
Cc: linux-wireless@...
Signed-off-by: Greg Kroah-Hartman <gregkh@...>
---
 drivers/net/wireless/atmel_cs.c             |    2 -
 drivers/net/wireless/ipw2x00/ipw2100.c      |    8 ++--
 drivers/net/wireless/ipw2x00/ipw2200.c      |   47 ++++++++++++++--------------
 drivers/net/wireless/iwlwifi/iwl-agn.c      |   20 +++++------
 drivers/net/wireless/iwlwifi/iwl3945-base.c |   26 ++++++++-------
 5 files changed, 53 insertions(+), 50 deletions(-)

--- a/drivers/net/wireless/atmel_cs.c
+++ b/drivers/net/wireless/atmel_cs.c
@@ -279,7 +279,7 @@ static int atmel_config(struct pcmcia_de
 	struct pcmcia_device_id *did;

 	dev = link->priv;
-	did = handle_to_dev(link).driver_data;
+	did = dev_get_drvdata(&handle_to_dev(link));

 	DEBUG(0, "atmel_config(0x%p)\n", link);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Greg KH | 1 May 08:11
Gravatar

Re: linux-next: driver-core tree build warning

On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> > drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata'
from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct
device **'
> > 
> > Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> > remove driver_data direct access of struct device").
>
(Continue reading)

Permalink | Reply | 2 comments |
headers
Stephen Rothwell | 1 May 09:11
Picon
Picon

Re: linux-next: driver-core tree build warning

Hi Greg,

On Thu, 30 Apr 2009 23:11:18 -0700 Greg KH <greg <at> kroah.com> wrote:
>
> On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> > Ah crap, my bad.  I'll go fix this up, it passed my build tests, I
> > wonder why this isn't an error, I missed the warning.

I assume it is actually valid C (just not good C :-)).

> I've sent an updated version of the patch that fixes this to John and
> the wireless mailing list and updated my tree as well.

Thanks.

--

-- 
Cheers,
Stephen Rothwell                    sfr <at> canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
Permalink | Reply | 0 comments |
headers
Alan Jenkins | 1 May 11:42

Re: rfkill rewrite

On 4/18/09, Johannes Berg <johannes@...> wrote:
> On Sat, 2009-04-18 at 10:43 +0100, Alan Jenkins wrote:
>
>> >> When I looked at the code earlier, I saw no obvious replacement for
>> >> rfkill_set_default().  So I tried disabling the wireless and rebooting
>> >> to see what happened.  It didn't like that :-).
>> >>
>> >
>> > Ok that wasn't too hard -- try this on top if you get a chance:
>> >
>>
>> Great, that fixes the crash.
>>
>>
>> 1) I think we need to add a resume method to eeepc-laptop.
>>
>> Without this, funny things happen when I hibernate, disable wireless in
>> the BIOS, and resume:
>>
>>     ath5k phy0: failed to wake up the MAC chip
>>
>> It's an really stupid thing to do, but it can happen.  It's bad from a
>> UI point of view.  E.g. in network-manager, you can see a "wlan0"
>> device, but it doesn't work.
>>
>> The EEE rfkill is unusual in that it hotplugs the PCI device, making
>> eeepc-laptop something like a custom pci hotplug driver.  With your
>> rewrite, eeepc-laptop doesn't notice the state change on resume.
>> Previously, the rfkill-core would restore the pre-hibernation state,
>> which would sort everything out.  I don't think anything else does this,
(Continue reading)

Permalink | Reply | 3 comments |
headers
Hauke Mehrtens | 1 May 13:12
Picon

[PATCH] Fixes compile error with CONFIG_PM=n

/drivers/net/wireless/p54/p54usb.c: In function 'p54u_probe':
/drivers/net/wireless/p54/p54usb.c:923: error: 'struct usb_device' has no member named 'reset_resume'

In the struct usb_device the reset_resume attribute is only available when CONFIG_PM is defined.

Signed-off-by: Hauke Mehrtens <hauke@...>
---
 drivers/net/wireless/p54/p54usb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
index ec6c954..f40c0f4 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -919,9 +919,11 @@ static int __devinit p54u_probe(struct usb_interface *intf,
 	priv->common.open = p54u_open;
 	priv->common.stop = p54u_stop;
 	if (recognized_pipes < P54U_PIPE_NUMBER) {
+#ifdef CONFIG_PM
 		/* ISL3887 needs a full reset on resume */
 		udev->reset_resume = 1;
 		err = p54u_device_reset(dev);
+#endif

 		priv->hw_type = P54U_3887;
 		dev->extra_tx_headroom += sizeof(struct lm87_tx_hdr);
--

-- 
1.6.2.1

--
(Continue reading)

Permalink | Reply | 1 comment |
headers
Maxim Levitsky | 1 May 14:00
Picon

[BUG] scans can still hang with -EBUSY on iwl3945

Don't know if this is new regression, or just exposed race condition,
but currently using rfkill, and/or s2disk sometimes leaves the card in
state in which it can't scan.

Tested with and without hardware scanning.

It just returns -EBUSY till I reload the driver.

I use iwlwifi.git, iwl3945

Best regards,
	Maxim Levitsky 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |

Gmane