headers
Bob Copeland | 1 Feb 01:43
Favicon

Re: [PATCH 4/5] ath5k: Update initvals

On Sat, Jan 31, 2009 at 04:30:07AM +0200, Nick Kossifidis wrote:
>  * Update initvals to match legacy and Sam's HAL
> 
>  Signed-Off-by: Nick Kossifidis <mickflemm@...>

I spot checked some of these, this is the only thing I saw:

> -	{ AR5K_BEACON_CNT_5211, 0x00000000 },	/* change */
> +	{ AR5K_FRAME_CTL_QOSM, 	0x000fc78f },

legacy-hal and Sam disagree on the top 12 bits (0xffffc78f vs
0x000fc78f), we have Sam's.

Rest looks good to me, feel free to add my Acked-by if you want.
--

-- 
Bob Copeland %% www.bobcopeland.com
Permalink | Reply | 2 comments |
headers
Nick Kossifidis | 1 Feb 04:50
Picon
Gravatar

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009/2/1 Bob Copeland <me@...>:
> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote:
>> > Heh, we should write a little tool to check the shifts and masks :)
>> >
>>
>> Yup :P
>
> I just wrote one, I can post it later :)   It also found:
>
> AR5K_PHY_SIGMA_DELTA_ADC_CLIP 0x01ff3000 13
>
> Should be 12 or a different mask...
>

13 is correct

0x01ff3000 -> 1111111111110000000000000

12 only counts the 3 zeros (3 * 4)

I've fixed all things mentioned so far, as soon as you find out why it
hangs on your pc we can move on ;-)

Again thanks a lot for the review ;-)

--

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
(Continue reading)

Permalink | Reply | 8 comments |
headers
Felix Fietkau | 1 Feb 05:05

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

Nick Kossifidis wrote:
> 2009/2/1 Bob Copeland <me@...>:
>> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote:
>>> > Heh, we should write a little tool to check the shifts and masks :)
>>> >
>>>
>>> Yup :P
>>
>> I just wrote one, I can post it later :)   It also found:
>>
>> AR5K_PHY_SIGMA_DELTA_ADC_CLIP 0x01ff3000 13
>>
>> Should be 12 or a different mask...
>>
> 
> 13 is correct
> 
> 0x01ff3000 -> 1111111111110000000000000
I think it's    1111111110011000000000000? :)

This mask makes 12 seem more likely.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 6 comments |
headers
Nick Kossifidis | 1 Feb 05:36
Picon
Gravatar

Re: [ath5k-devel] [PATCH 4/5] ath5k: Update initvals

2009/2/1 Bob Copeland <me@...>:
> On Sat, Jan 31, 2009 at 04:30:07AM +0200, Nick Kossifidis wrote:
>>  * Update initvals to match legacy and Sam's HAL
>>
>>  Signed-Off-by: Nick Kossifidis <mickflemm@...>
>
> I spot checked some of these, this is the only thing I saw:
>
>> -     { AR5K_BEACON_CNT_5211, 0x00000000 },   /* change */
>> +     { AR5K_FRAME_CTL_QOSM,  0x000fc78f },
>
> legacy-hal and Sam disagree on the top 12 bits (0xffffc78f vs
> 0x000fc78f), we have Sam's.
>

According to docs, this is the aes mute mask and upper bits are the
aes mute mask for TID (traffic identifier) field used in QoS. So Sam
disables the TID thing on his HAL and legacy HAL leaves it unmasked.
It seems they also disable it on ath9k (have i mentioned that we have
many things in common ? :P) so i go with Sam's choice.

from ath9k's initvals.h
{ 0x0000805c, 0x000fc78f }

> Rest looks good to me, feel free to add my Acked-by if you want.

--

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bob Copeland | 1 Feb 05:41
Favicon

Re: [PATCH 5/5] ath5k: Update reset code

On Sun, Feb 01, 2009 at 12:58:14AM +0200, Nick Kossifidis wrote:
> Are you all ok on the rest 4 patches ?

I skimmed the rest of the patches, all look good to me.

--

-- 
Bob Copeland %% www.bobcopeland.com
Permalink | Reply | 0 comments |
headers
Nick Kossifidis | 1 Feb 05:50
Picon
Gravatar

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009/2/1 Felix Fietkau <nbd@...>:
> Nick Kossifidis wrote:
>> 2009/2/1 Bob Copeland <me@...>:
>>> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote:
>>>> > Heh, we should write a little tool to check the shifts and masks :)
>>>> >
>>>>
>>>> Yup :P
>>>
>>> I just wrote one, I can post it later :)   It also found:
>>>
>>> AR5K_PHY_SIGMA_DELTA_ADC_CLIP 0x01ff3000 13
>>>
>>> Should be 12 or a different mask...
>>>
>>
>> 13 is correct
>>
>> 0x01ff3000 -> 1111111111110000000000000
> I think it's    1111111110011000000000000? :)
>
> This mask makes 12 seem more likely.
>
> - Felix
>

Maybe it's in big endian format (we don't know anything about this reg
anyway :P), both HALs have 13 plus it doesn't make sense to have a
field split.
(Continue reading)

Permalink | Reply | 4 comments |
headers
Felix Fietkau | 1 Feb 06:07

Re: [PATCH 5/5] ath5k: Update reset code

Nick Kossifidis wrote:
> 2009/2/1 Felix Fietkau <nbd@...>:
>> Nick Kossifidis wrote:
>>> 2009/2/1 Bob Copeland <me@...>:
>>>> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote:
>>>>> > Heh, we should write a little tool to check the shifts and masks :)
>>>>> >
>>>>>
>>>>> Yup :P
>>>>
>>>> I just wrote one, I can post it later :)   It also found:
>>>>
>>>> AR5K_PHY_SIGMA_DELTA_ADC_CLIP 0x01ff3000 13
>>>>
>>>> Should be 12 or a different mask...
>>>>
>>>
>>> 13 is correct
>>>
>>> 0x01ff3000 -> 1111111111110000000000000
>> I think it's    1111111110011000000000000? :)
>>
>> This mask makes 12 seem more likely.
>>
>> - Felix
>>
> 
> Maybe it's in big endian format (we don't know anything about this reg
> anyway :P), both HALs have 13 plus it doesn't make sense to have a
> field split.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Nick Kossifidis | 1 Feb 06:14
Picon
Gravatar

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009/2/1 Felix Fietkau <nbd@...>:
> Nick Kossifidis wrote:
>> 2009/2/1 Felix Fietkau <nbd@...>:
>>> Nick Kossifidis wrote:
>>>> 2009/2/1 Bob Copeland <me@...>:
>>>>> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote:
>>>>>> > Heh, we should write a little tool to check the shifts and masks :)
>>>>>> >
>>>>>>
>>>>>> Yup :P
>>>>>
>>>>> I just wrote one, I can post it later :)   It also found:
>>>>>
>>>>> AR5K_PHY_SIGMA_DELTA_ADC_CLIP 0x01ff3000 13
>>>>>
>>>>> Should be 12 or a different mask...
>>>>>
>>>>
>>>> 13 is correct
>>>>
>>>> 0x01ff3000 -> 1111111111110000000000000
>>> I think it's    1111111110011000000000000? :)
>>>
>>> This mask makes 12 seem more likely.
>>>
>>> - Felix
>>>
>>
>> Maybe it's in big endian format (we don't know anything about this reg
>> anyway :P), both HALs have 13 plus it doesn't make sense to have a
(Continue reading)

Permalink | Reply | 0 comments |
headers
pat-lkml | 1 Feb 22:52
Gravatar

[patch resend] crda: rename nl_handle to nl_sock for libnl-2.0

Upstream has renamed nl_handle to nl_sock.  Update crda to the new names
and add #define for libnl-1.1.

Signed-off-by: Pat Erley <pat-lkml@...>

---
resent fixing whitespace errors in last repost.

diff --git a/crda.c b/crda.c
index afc5df1..f2c471f 100644
--- a/crda.c
+++ b/crda.c
@@ -43,10 +43,11 @@ static inline int __genl_ctrl_alloc_cache(struct
nl_handle *h, struct nl_cache *
 }

 #define genl_ctrl_alloc_cache __genl_ctrl_alloc_cache
+#define nl_sock nl_handle
 #endif /* CONFIG_LIBNL20 */

 struct nl80211_state {
-	struct nl_handle *nl_handle;
+	struct nl_sock *nl_sock;
 	struct nl_cache *nl_cache;
 	struct genl_family *nl80211;
 };
@@ -55,22 +56,22 @@ static int nl80211_init(struct nl80211_state *state)
 {
 	int err;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Hin-Tak Leung | 2 Feb 02:09
Picon

Re: rtl8187 wireless issues

On Fri, Jan 30, 2009 at 10:04 PM, P.G. Richardson
<p.g.richardson@...> wrote:

> I am not that familiar with kernel makefiles but it would seem that the
> drivers/net/wireless line below is not recursive:
>
> obj-y := net/wireless/ net/mac80211/
> ifeq ($(ONLY_CORE),)
> obj-$(CONFIG_B44) += drivers/net/b44.o
> obj-y += drivers/ssb/ \
>        drivers/misc/eeprom/ \
>        drivers/net/usb/ \
>        drivers/net/wireless/
> endif

It is recursive - it runs Makefile in drivers/net/wireless/ . Your
list is very small - it should build and install 40+ kernel modules.
curious. some kernel config means the modules aren't built, but in
your case they are built but not installed... I wonder if it is
affected by blacklist.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 8 comments |

Gmane