headers
Tomas Winkler | 1 Oct 02:07
Picon

Re: [RFC v4] mac80211: re-enable aggregation on 2.6.27

On Tue, Sep 30, 2008 at 6:25 PM, Luis R. Rodriguez
<lrodriguez@...> wrote:
> A quick test indicates it works but the removal is still an issue.

I didn't implement it yet I just wanted a feedback if I'm in correct
direction with the starting part.

We also
> have to make lockdep happy -- one more complaint (even with your v3
> patch).

Strange I haven't seen one, can you post the log.

I have another patch I'm going to test now which tries to
> address removal correctly. It doesn't seem we ever del_timer()'d the
> addba_resp_timer in a addition to other cleanups.
>
> I'll condense the relevant sections of your reply.
>
> On Tue, Sep 30, 2008 at 01:18:46PM -0700, Tomas Winkler wrote:
>> On Tue, Sep 30, 2008 at 7:02 PM, Luis R. Rodriguez
>
> Note declrations:
>
>> > +void initiate_aggr_and_timer(struct sta_info *sta, u16 tid, u16 start_seq_num);
>> > +int __ieee80211_start_tx_ba_session(struct ieee80211_local *local,
>> > +                   struct sta_info *sta, u16 tid, u16 *start_seq_num);
>
>
> Note parts of the routine that use start_seq_num:
(Continue reading)

Permalink | Reply | 4 comments |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 2/5] wireless: remove NETWORK_EMPTY_ESSID flag

It is unnecessary and of questionable value.  Also remove
is_empty_ssid, as it is also unnecessary.

Signed-off-by: John W. Linville <linville@...>
---
 drivers/net/wireless/ipw2200.c |   23 +----------------------
 include/net/ieee80211.h        |    1 -
 include/net/lib80211.h         |   16 ----------------
 net/ieee80211/ieee80211_rx.c   |   15 ++-------------
 net/ieee80211/ieee80211_wx.c   |   12 +++---------
 net/wireless/lib80211.c        |    5 -----
 6 files changed, 6 insertions(+), 66 deletions(-)

diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index 41f9e46..e6f77dd 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -5443,16 +5443,6 @@ static int ipw_find_adhoc_network(struct ipw_priv *priv,
 		return 0;
 	}

-	/* If we do not have an ESSID for this AP, we can not associate with
-	 * it */
-	if (network->flags & NETWORK_EMPTY_ESSID) {
-		IPW_DEBUG_MERGE("Network '%s (%s)' excluded "
-				"because of hidden ESSID.\n",
-				escape_ssid(network->ssid, network->ssid_len),
-				print_mac(mac, network->bssid));
-		return 0;
-	}
(Continue reading)

Permalink | Reply | 3 comments |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 3/5] wireless: escape_ssid should handle non-printables

Also use common backslash sequences like \t, \n, \r, and \\ as well as \0.

Signed-off-by: John W. Linville <linville@...>
---
 net/wireless/lib80211.c |   25 +++++++++++++++++++------
 1 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/net/wireless/lib80211.c b/net/wireless/lib80211.c
index 872cc8d..b8e34d3 100644
--- a/net/wireless/lib80211.c
+++ b/net/wireless/lib80211.c
@@ -6,6 +6,7 @@
  */

 #include <linux/module.h>
+#include <linux/ctype.h>
 #include <linux/ieee80211.h>

 #include <net/lib80211.h>
@@ -20,19 +21,31 @@ MODULE_LICENSE("GPL");

 const char *escape_ssid(const char *ssid, u8 ssid_len)
 {
-	static char escaped[IEEE80211_MAX_SSID_LEN * 2 + 1];
+	static char escaped[IEEE80211_MAX_SSID_LEN * 4 + 1];
 	const char *s = ssid;
 	char *d = escaped;

 	ssid_len = min_t(u8, ssid_len, IEEE80211_MAX_SSID_LEN);
 	while (ssid_len--) {
(Continue reading)

Permalink | Reply | 2 comments |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 1/5] wireless: consolidate on a single escape_essid implementation

Signed-off-by: John W. Linville <linville@...>
---
 drivers/net/wireless/Kconfig                |    1 +
 drivers/net/wireless/ipw2100.c              |   10 +-
 drivers/net/wireless/ipw2200.c              |  126 +++++++++++++-------------
 drivers/net/wireless/ipw2200.h              |    1 +
 drivers/net/wireless/iwlwifi/Kconfig        |    2 +
 drivers/net/wireless/iwlwifi/iwl-scan.c     |   53 ++----------
 drivers/net/wireless/iwlwifi/iwl3945-base.c |   48 +---------
 drivers/net/wireless/libertas/assoc.c       |   14 ++--
 drivers/net/wireless/libertas/cmd.c         |    3 +-
 drivers/net/wireless/libertas/debugfs.c     |    3 +-
 drivers/net/wireless/libertas/decl.h        |    4 -
 drivers/net/wireless/libertas/main.c        |   27 ------
 drivers/net/wireless/libertas/scan.c        |   11 ++-
 drivers/net/wireless/libertas/wext.c        |    3 +-
 include/net/ieee80211.h                     |   20 ----
 include/net/lib80211.h                      |   31 +++++++
 net/ieee80211/Kconfig                       |    1 +
 net/ieee80211/ieee80211_module.c            |   26 ------
 net/ieee80211/ieee80211_rx.c                |   31 ++++---
 net/ieee80211/ieee80211_wx.c                |    6 +-
 net/wireless/Kconfig                        |   10 ++
 net/wireless/Makefile                       |    1 +
 net/wireless/lib80211.c                     |   58 ++++++++++++
 23 files changed, 223 insertions(+), 267 deletions(-)
 create mode 100644 include/net/lib80211.h
 create mode 100644 net/wireless/lib80211.c

diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
(Continue reading)

Permalink | Reply | 4 comments |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 5/5] wireless: avoid some net/ieee80211.h vs. linux/ieee80211.h conflicts

There is quite a lot of overlap in definitions between these headers...

Signed-off-by: John W. Linville <linville@...>
---
 drivers/net/wireless/hostap/hostap_common.h |   13 ---
 drivers/net/wireless/ipw2200.c              |   24 +++---
 include/net/ieee80211.h                     |  112 +--------------------------
 include/net/lib80211.h                      |    4 +-
 net/ieee80211/ieee80211_rx.c                |    2 +-
 5 files changed, 18 insertions(+), 137 deletions(-)

diff --git a/drivers/net/wireless/hostap/hostap_common.h b/drivers/net/wireless/hostap/hostap_common.h
index b470c74..90b64b0 100644
--- a/drivers/net/wireless/hostap/hostap_common.h
+++ b/drivers/net/wireless/hostap/hostap_common.h
@@ -6,19 +6,6 @@

 /* IEEE 802.11 defines */

-/* Information Element IDs */
-#define WLAN_EID_SSID 0
-#define WLAN_EID_SUPP_RATES 1
-#define WLAN_EID_FH_PARAMS 2
-#define WLAN_EID_DS_PARAMS 3
-#define WLAN_EID_CF_PARAMS 4
-#define WLAN_EID_TIM 5
-#define WLAN_EID_IBSS_PARAMS 6
-#define WLAN_EID_CHALLENGE 16
-#define WLAN_EID_RSN 48
-#define WLAN_EID_GENERIC 221
(Continue reading)

Permalink | Reply | 0 comments |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 4/5] wireless: use individual buffers for printing ssid values

Also change escape_ssid to print_ssid to match print_mac semantics.

Signed-off-by: John W. Linville <linville@...>
---
 drivers/net/wireless/ipw2100.c              |   19 +++-
 drivers/net/wireless/ipw2200.c              |  153 ++++++++++++++++-----------
 drivers/net/wireless/iwlwifi/iwl-scan.c     |    7 +-
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    9 +-
 drivers/net/wireless/libertas/assoc.c       |   17 ++-
 drivers/net/wireless/libertas/cmd.c         |    3 +-
 drivers/net/wireless/libertas/debugfs.c     |    4 +-
 drivers/net/wireless/libertas/scan.c        |   12 ++-
 drivers/net/wireless/libertas/wext.c        |    3 +-
 include/linux/ieee80211.h                   |    6 +-
 include/net/lib80211.h                      |    5 +-
 net/ieee80211/ieee80211_rx.c                |   18 ++--
 net/ieee80211/ieee80211_wx.c                |    6 +-
 net/wireless/lib80211.c                     |    9 +-
 14 files changed, 165 insertions(+), 106 deletions(-)

diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c
index df8d1b3..1846bf1 100644
--- a/drivers/net/wireless/ipw2100.c
+++ b/drivers/net/wireless/ipw2100.c
@@ -163,6 +163,8 @@ that only one external action is invoked at a time.
 #include <linux/ctype.h>
 #include <linux/pm_qos_params.h>

+#include <net/lib80211.h>
+
(Continue reading)

Permalink | Reply | 1 comment |
headers
John W. Linville | 1 Oct 04:15
Favicon

[PATCH 0/5] wireless: single escape_essid implementation and related cleanups

This is a repost of my escape_essid consolidation.  Also included are
some suggested changes from the original post and a few cleanups.  There
is still plenty to be done -- of course, this isn't really high priority
work either...

[PATCH 1/5] wireless: consolidate on a single escape_essid implementation
[PATCH 2/5] wireless: remove NETWORK_EMPTY_ESSID flag
[PATCH 3/5] wireless: escape_ssid should handle non-printables
[PATCH 4/5] wireless: use individual buffers for printing ssid values
[PATCH 5/5] wireless: avoid some net/ieee80211.h vs. linux/ieee80211.h conflicts

Comments welcome!

John
--
John W. Linville		Linux should be at the core
linville@...			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 7 comments |
headers
Marc Pignat | 1 Oct 10:43
Picon
Favicon

[RFC, PATCH v2] libertas: unify request_firmware failure

Use almost the same string for all interfaces (USB, compact flash and SDIO)
when request_firmware fails.

Signed-off-by: Marc Pignat <marc.pignat@...>
---

Hi all!

This patch is an attemp to clarify the message "firmware not found, please fix
your userspace (== this is not a libertas bug)".

changes from v1:
	* replaced %#x with %d because "ret" is supposed to be a negative
	  integer (suggested by Dan Williams).

Best regards

Marc

patch agaisnt 2.6.27-rc7:

diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 8941919..5f8e68b 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -553,7 +553,8 @@ static int if_cs_prog_helper(struct if_cs_card *card)
 	ret = request_firmware(&fw, "libertas_cs_helper.fw",
 		&handle_to_dev(card->p_dev));
 	if (ret) {
-		lbs_pr_err("can't load helper firmware\n");
(Continue reading)

Permalink | Reply | 1 comment |
headers
David Miller | 1 Oct 11:14
Favicon

Re: pull request: wireless-next-2.6 2008-09-30

From: "John W. Linville" <linville <at> tuxdriver.com>
Date: Tue, 30 Sep 2008 14:39:38 -0400

> Dave,
> 
> Here is the latest round of wireless bits intended for 2.6.28.  Among
> them is the first round of new stuff learned from the release of the
> Atheros HAL sources...
> 
> Let me know if there are problems!

Pulled and pushed back out to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Anadi Mishra | 1 Oct 11:16
Picon

Re: Problem with Libertas USB8388 WLAN card firmware

On Tue, Sep 30, 2008 at 4:37 PM, Holger Schurig
<hs4233@...> wrote:
>> regarding rest of the things u pointed out, its all greek to
>> me (I am noob). But could u plz tell me from where can i get
>> the firmware details of the card
>> USB8388??
>
> I don't think that you have a firmware problem.
>
> Probably some compiler / alignment issue.
>
> Result codes from the firmware are 16 bit, but 0x160000 doesn't
> fit into an 16 bits. So you need to search why your
> compiler/hardware creates 0x160000 out of two transferred bytes.

  Sorry for the trouble but can u give some hint how to go about it?

Thanks a lot.

> But *ANY* firmware for the 8388 chips returns the result as 16
> bits, that is two bytes. If you get bogus / hosed result, you
> have a problem there. And using a different firmware won't help
> you there. There is an underlying problem that you need to solve
> first.
>
>
> BTW: you can get the firmware specification via this driver
> portal: http://wireless.kernel.org/en/users/Drivers/libertas
>
(Continue reading)

Permalink | Reply | 0 comments |

Gmane