[PATCH 1/1] ath5k: Cleanup after API changes patch

Cleanup after API changes patch (checkpatch.pl stuff) and on
ath5k_hw_rf5112_channel() make use of the new channel->band and
existing ath5k_channel_ok() instead of re-implementing the checks
again. This was necessary to make the code cleaner and fit
the 80-chars wide limit so sending it within the same patch.

Finally make a note that we should eventually move cap_range stuff
to struct wiphy.

This patch applies ontop of Nick's API changes patch.

Signed-off-by: Luis R. Rodriguez <mcgrof@...>

drivers/net/wireless/ath5k/ath5k.h:	Changes-licensed-under: ISC
drivers/net/wireless/ath5k/base.c:	Changes-licensed-under: 3-Clause-BSD
drivers/net/wireless/ath5k/initvals.c:	Changes-licensed-under: ISC
drivers/net/wireless/ath5k/phy.c:	Changes-licensed-under: ISC
---
 drivers/net/wireless/ath5k/ath5k.h    |    8 ++-
 drivers/net/wireless/ath5k/base.c     |  126 +++++++++++++++++++--------------
 drivers/net/wireless/ath5k/initvals.c |    6 +-
 drivers/net/wireless/ath5k/phy.c      |   48 +++++++++----
 4 files changed, 118 insertions(+), 70 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index 3b03600..7b8a1df 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
 <at>  <at>  -263,8 +263,10  <at>  <at>  enum ath5k_driver_mode {
 /* adding this flag to rate_code enables short preamble, see ar5212_reg.h */

[PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band

ath5k_copy_channels() wasn't setting the channel's band so all
driver channels had a 2GHz band set. Lets set this.

Signed-off-by: Luis R. Rodriguez <mcgrof@...>

drivers/net/wireless/ath5k/base.c:	Changes-licensed-under: 3-Clause-BSD
---
 drivers/net/wireless/ath5k/base.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index bd9c9a8..1e7eeec 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
 <at>  <at>  -899,6 +899,8  <at>  <at>  ath5k_copy_channels(struct ath5k_hw *ah,

 		/* Write channel info and increment counter */
 		channels[count].center_freq = freq;
+		channels[count].band = (chfreq == CHANNEL_2GHZ) ?
+			IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;

 		if ((mode == AR5K_MODE_11A) ||
 			(mode == AR5K_MODE_11G)) {
--

-- 
1.5.2.5

Re: ath5k: reset for 5424-based card

On Thu, Jan 31, 2008 at 06:56:51PM +0200, Nick Kossifidis wrote:
> Can you plz run ath_info tool found on madwifi-trace branch and post
> the output (mac/phy revision) ?

Sure -- full output is at http://bobcopeland.com/ath5k/ along with
EEPROM dump and a scan of my neighborhood.

MAC Version:  2424  (0xa0)
MAC Revision: 5424  (0xa3)
Warning: Invalid EEPROM Magic number!
Device type:  3
5Ghz PHY Revision: SChip (0xa2)
2Ghz PHY Revision: SChip (0xa2)

> so i left it for the patch series i'm working on). If you got your
> card scanning then we are really close on fixing it !

Excellent news!

> Another important question, what band was the ap on ?

Good question - it was a Starbucks hotspot so I'm guessing 802.11b?

--

-- 
Bob Copeland %% www.bobcopeland.com 

[PATCH 1/2] iwlwifi: initialize ieee80211_channel->hw_value

From: Mohamed Abbas <mohamed.abbas@...>

hw_value is being used uninitialized. fix it.

Signed-off-by: Mohamed Abbas <mohamed.abbas@...>
Signed-off-by: Reinette Chatre <reinette.chatre@...>
---
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    1 +
 drivers/net/wireless/iwlwifi/iwl4965-base.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index f82aec5..b0f1155 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
 <at>  <at>  -5388,6 +5388,7  <at>  <at>  static int iwl3945_init_geos(struct iwl3945_priv *priv)
 		geo_ch->center_freq = ieee80211chan2mhz(ch->channel);
 		geo_ch->max_power = ch->max_power_avg;
 		geo_ch->max_antenna_gain = 0xff;
+		geo_ch->hw_value = ch->channel;

 		if (is_channel_valid(ch)) {
 			if (!(ch->flags & EEPROM_CHANNEL_IBSS))
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c b/drivers/net/wireless/iwlwifi/iwl4965-base.c
index a4fa6bf..402cd9a 100644
--- a/drivers/net/wireless/iwlwifi/iwl4965-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl4965-base.c
 <at>  <at>  -5810,6 +5810,7  <at>  <at>  static int iwl4965_init_geos(struct iwl4965_priv *priv)
 		geo_ch->center_freq = ieee80211chan2mhz(ch->channel);
 		geo_ch->max_power = ch->max_power_avg;

[PATCH 2/2] iwlwifi: set rate_idx correctly from plcp

From: Mohamed Abbas <mohamed.abbas@...>

rate_idx is derived from plcp information

Signed-off-by: Mohamed Abbas <mohamed.abbas@...>
Signed-off-by: Reinette Chatre <reinette.chatre@...>
---
 drivers/net/wireless/iwlwifi/iwl-4965.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 79545d6..29797db 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
 <at>  <at>  -3546,7 +3546,7  <at>  <at>  static void iwl4965_rx_reply_rx(struct iwl4965_priv *priv,
 			(rx_start->phy_flags & RX_RES_PHY_FLAGS_BAND_24_MSK) ?
 			IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ,
 		.antenna = 0,
-		.rate_idx = iwl4965_hw_get_rate(
+		.rate_idx = iwl4965_rate_index_from_plcp(
 				le32_to_cpu(rx_start->rate_n_flags)),
 		.flag = 0,
 	};
--

-- 
1.5.3.4

Q) I need you help... Chip selection.

Hello,

Some days before, I asked a question why 3crdag675b(3com) NIC does not
support the speed of 802.11a. and then our members tried to modify ath5k
driver.
but, we have not solved the problems.
(when connecting two NICs(3crdag675b) to each other for ad-hoc mode -
802.11a -, connection is unstable. max bandwidth is from 2Mbps to 17Mbps.)
testing tool : iperf

Our members plan to modify driver sources, mac sources and then test them
with new NICs(also, we plan to make a hardware module using atheros
chipset).
But now, the 3crdag675b we bought is -.-;; so so.....

Because of these, I want to get some helps *^_^*

We want to find out new NICs using atheros chipset(AR5414). For this, some
reqirements.
1. Shuld be opened the driver sources(linux).(because, we have to modify
mac sources, driver sources.)
2. Working well on LINUX machine.
3. AND NICs type SHOULD BE PCI.
4. if there's no nics using atheros chipset AR5414, recommend other
products supporting above requirements please...

anyone know about this, ^^ help us......

thank you~~~ 

Re: [PATCH 2/2] iwlwifi: set rate_idx correctly from plcp

On Feb 1, 2008 7:46 AM, Reinette Chatre <reinette.chatre@...> wrote:
> From: Mohamed Abbas <mohamed.abbas@...>
>
> rate_idx is derived from plcp information
>
> Signed-off-by: Mohamed Abbas <mohamed.abbas@...>
> Signed-off-by: Reinette Chatre <reinette.chatre@...>
> ---
>  drivers/net/wireless/iwlwifi/iwl-4965.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 79545d6..29797db 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
>  <at>  <at>  -3546,7 +3546,7  <at>  <at>  static void iwl4965_rx_reply_rx(struct iwl4965_priv *priv,
>                         (rx_start->phy_flags & RX_RES_PHY_FLAGS_BAND_24_MSK) ?
>                         IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ,
>                 .antenna = 0,
> -               .rate_idx = iwl4965_hw_get_rate(
> +               .rate_idx = iwl4965_rate_index_from_plcp(
>                                 le32_to_cpu(rx_start->rate_n_flags)),
>                 .flag = 0,
>         };
> --
> 1.5.3.4
>

NACK
This should be

Re: ath5k: reset for 5424-based card

2008/2/1, Bob Copeland <me@...>:
> On Thu, Jan 31, 2008 at 06:56:51PM +0200, Nick Kossifidis wrote:
> > Can you plz run ath_info tool found on madwifi-trace branch and post
> > the output (mac/phy revision) ?
>
> Sure -- full output is at http://bobcopeland.com/ath5k/ along with
> EEPROM dump and a scan of my neighborhood.
>
> MAC Version:  2424  (0xa0)
> MAC Revision: 5424  (0xa3)
> Warning: Invalid EEPROM Magic number!
> Device type:  3
> 5Ghz PHY Revision: SChip (0xa2)
> 2Ghz PHY Revision: SChip (0xa2)
>
> > so i left it for the patch series i'm working on). If you got your
> > card scanning then we are really close on fixing it !
>
> Excellent news!
>
> > Another important question, what band was the ap on ?
>
> Good question - it was a Starbucks hotspot so I'm guessing 802.11b?
>

Wow that's the first 5424 report we have 

Do you have an AP so you can run the testbed-trace as described here ?
http://madwifi.org/wiki/DevDocs/MadwifiTrace

Re: [PATCH] ieee80211: fix section mismatch warning

On Fri, 2008-02-01 at 12:52 +0100, Sam Ravnborg wrote:
> Fix the following warnings:
> WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function
ieee80211_init() to the function .exit.text:rc80211_simple_exit()
> WARNING: net/built-in.o(.init.text+0xd6c5): Section mismatch in reference from the function
ieee80211_init() to the function .exit.text:rc80211_pid_exit()
> 
> The fix was simple - I just did as modpost told me and removed the
> wrong __exit annotation of rc80211_simple_exit and rc80211_pid_exit.

Heh, I just sent the same patch.

> Signed-off-by: Sam Ravnborg <sam <at> ravnborg.org>

Acked-by: Johannes Berg <johannes <at> sipsolutions.net>

> Cc: Johannes Berg <johannes <at> sipsolutions.net>
> Cc: John W. Linville <linville <at> tuxdriver.com>
> Cc: David S. Miller <davem <at> davemloft.net>
> ---
> 
> With this patch my allyesconfig build on x86 (64 bit)
> is section mismatch clean in net/
> 
> 	Sam
> 
> diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
> index 554c4ba..c339571 100644
> --- a/net/mac80211/rc80211_pid_algo.c

Re: [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band

Your CC lists are somehow messed up... some things are on twice.

> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index bd9c9a8..1e7eeec 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
>  <at>  <at>  -899,6 +899,8  <at>  <at>  ath5k_copy_channels(struct ath5k_hw *ah,
>  
>  		/* Write channel info and increment counter */
>  		channels[count].center_freq = freq;
> +		channels[count].band = (chfreq == CHANNEL_2GHZ) ?
> +			IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;

No need, cfg80211 will do that when you register the wiphy.

johannes

_______________________________________________
ath5k-devel mailing list
ath5k-devel@...
https://lists.ath5k.org/mailman/listinfo/ath5k-devel