Michael Wu | 1 Dec 02:59 2007
Picon

Re: [RFC] mac80211: don't use if_id, use if_priv

On Friday 30 November 2007 06:48:21 Johannes Berg wrote:
> Here's a non-functioning (except for b43/b43legacy) patch that gets rid
> of the if_id stuff all over in favour of a new if_priv pointer.
>
Note that a good chunk of the if_id stuff in the api was just brain damage 
from the ERP info changes. Anywhere we have access to a skb, we have access 
to a netdev, and we don't need an extra if_id argument to tell us what we 
need to know. I would love to see that get fixed first as that simplifies all 
drivers.

Having said that, a per-interface private area for drivers is a great idea if 
drivers need it. They probably do.

-Michael Wu

John W. Linville | 1 Dec 03:23 2007

Please pull 'upstream-davem' branch of wireless-2.6

Dave/Herbert,

Here are a few intended for 2.6.25.  The bulk of them are the beginnings
of support for 802.11n in mac80211.  There is also a rework of the
support for devices which can run scans in hardware, and a couple of
additions to feature-removal-schedule.txt heralding the end of softmac.

Let me know if there are problems!

Thanks,

John

---

Individual patches are available here:

	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem/

---

The following changes since commit 3b0c5b8640d12a566cb77f24162dce9bf5988263:
  Arnaldo Carvalho de Melo (1):
        [TFRC]: Hide tx history details from the CCIDs

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-davem

Johannes Berg (2):
(Continue reading)

Ulrich Kunitz | 1 Dec 11:26 2007
Picon

[PATCH] zd1211rw: Fix alignment problems

Shaddy Baddah found an alignment problem with zd1211rw driver at
2007-11-19. This patch fixes it, it is based on the patch proposed by
Herbert Xu. The alignment 4 has been the agreed value on the
linux-wireless mailing list.

Notify that the problem does only affect the old zd1211rw softmac
driver and not the zd1211rw-mac80211 driver. Daniel Drake has
already provided a patch for the replacement of the softmac
driver, which this patch will break.

Signed-off-by: Ulrich Kunitz <kune@...>
---
 drivers/net/wireless/zd1211rw/zd_mac.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index a903645..5298a8b 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
 <at>  <at>  -1130,6 +1130,8  <at>  <at>  static void zd_mac_rx(struct zd_mac *mac, struct sk_buff *skb)
 	__skb_trim(skb, skb->len -
 		        (IEEE80211_FCS_LEN + sizeof(struct rx_status)));

+	ZD_ASSERT(IS_ALIGNED((unsigned long)skb->data, 4));
+
 	update_qual_rssi(mac, skb->data, skb->len, stats.signal,
 		         status->signal_strength);

 <at>  <at>  -1166,15 +1168,19  <at>  <at>  static void do_rx(unsigned long mac_ptr)
 int zd_mac_rx_irq(struct zd_mac *mac, const u8 *buffer, unsigned int length)
(Continue reading)

Ulrich Kunitz | 1 Dec 11:33 2007
Picon

Re: ZD1211RW unaligned accesses...

John W. Linville wrote:

> So, did the patch below fix the problem?  Should I apply it?
> 
> John

John,

the patch would have worked, but I have sent a second one to the
list, which is based on Herbert's and has an assert to be able to test
the patch on x86.

You should be notify that the mac80211 driver, doesn't suffer
from the problem and Daniel has already provided a patch to
replace zd1211rw by the mac80211 driver. Daniel's patch must of
course break by the new patch.

--

-- 
Uli Kunitz
Herbert Xu | 1 Dec 14:54 2007
Picon
Picon

Re: Please pull 'upstream-davem' branch of wireless-2.6

On Fri, Nov 30, 2007 at 09:23:06PM -0500, John W. Linville wrote:
> Dave/Herbert,
> 
> Here are a few intended for 2.6.25.  The bulk of them are the beginnings
> of support for 802.11n in mac80211.  There is also a rework of the
> support for devices which can run scans in hardware, and a couple of
> additions to feature-removal-schedule.txt heralding the end of softmac.

All applied to net-2.6.25.  Thanks John!
--

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Jeff Garzik | 1 Dec 22:20 2007

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

John W. Linville wrote:
> Jeff,
> 
> A few fixes intended for 2.6.24...
> 
> Let me know if there are any problems!
> 
> Thanks,
> 
> John
> 
> ---
> 
> Individual patches are available here:
> 
> 	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6.git fixes-jgarzik
> 
> ---
> 
> The following changes since commit d9f8bcbf67a0ee67c8cb0734f003dfe916bb5248:
>   Linus Torvalds (1):
>         Linux 2.6.24-rc3
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git fixes-jgarzik
> 
> David Woodhouse (1):
>       libertas: Don't set NETIF_F_IPV6_CSUM in dev->features
> 
(Continue reading)

Mattias Nissler | 2 Dec 20:05 2007
Picon
Picon

[RFC][PATCH] mac80211: Use PID controller for TX rate control

Hi,

the patch below is a first attempt on the PID-controller approach for TX
rate control. It kind of works here, but I haven't spent much time
tuning the coefficients.

I wanted to share this at this early stage so you can experiment with
and comment.

Mattias

Signed-off-by: Mattias Nissler <mattias.nissler@...>
---
 net/mac80211/ieee80211_rate.h |    3 -
 net/mac80211/rc80211_simple.c |  281 ++++++++++++++++++++++++++++-------------
 2 files changed, 190 insertions(+), 94 deletions(-)

diff --git a/net/mac80211/ieee80211_rate.h b/net/mac80211/ieee80211_rate.h
index 2368813..9948d0f 100644
--- a/net/mac80211/ieee80211_rate.h
+++ b/net/mac80211/ieee80211_rate.h
 <at>  <at>  -18,9 +18,6  <at>  <at> 
 #include "ieee80211_i.h"
 #include "sta_info.h"

-#define RATE_CONTROL_NUM_DOWN 20
-#define RATE_CONTROL_NUM_UP   15
-

 struct rate_control_extra {
(Continue reading)

Michael Wu | 2 Dec 23:17 2007
Picon

[PATCH 4/8] rtl8180: Add rtl8180_set_anaparam

From: Andrea Merello <andreamrl@...>

This piece of code is used everywhere, so pull it into a function.

Signed-off-by: Michael Wu <flamingice@...>
Signed-off-by: Andrea Merello <andreamrl@...>
---

 drivers/net/wireless/rtl8180.h         |    1 +
 drivers/net/wireless/rtl8180_dev.c     |   26 ++++++++++++++++----------
 drivers/net/wireless/rtl8180_rtl8225.c |   16 ++--------------
 3 files changed, 19 insertions(+), 24 deletions(-)

diff --git a/drivers/net/wireless/rtl8180.h b/drivers/net/wireless/rtl8180.h
index 4a5b44b..28431ac 100644
--- a/drivers/net/wireless/rtl8180.h
+++ b/drivers/net/wireless/rtl8180.h
 <at>  <at>  -101,6 +101,7  <at>  <at>  struct rtl8180_priv {
 };

 void rtl8180_write_phy(struct ieee80211_hw *dev, u8 addr, u32 data);
+void rtl8180_set_anaparam(struct rtl8180_priv *priv, u32 anaparam);

 static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, u8 __iomem *addr)
 {
diff --git a/drivers/net/wireless/rtl8180_dev.c b/drivers/net/wireless/rtl8180_dev.c
index a2a6791..54f9c31 100644
--- a/drivers/net/wireless/rtl8180_dev.c
+++ b/drivers/net/wireless/rtl8180_dev.c
 <at>  <at>  -243,6 +243,20  <at>  <at>  static int rtl8180_tx(struct ieee80211_hw *dev, struct sk_buff *skb,
(Continue reading)

Michael Wu | 2 Dec 23:17 2007
Picon

[PATCH 3/8] rtl818x: update register struct

From: Andrea Merello <andreamrl@...>

Add the SECURITY and CARRIER_SENSE_COUNTER registers.
Change PGSELECT length from 16 to 8 bits.

Signed-off-by: Michael Wu <flamingice@...>
Signed-off-by: Andrea Merello <andreamrl@...>
---

 drivers/net/wireless/rtl8187_dev.c |   12 ++++++------
 drivers/net/wireless/rtl818x.h     |    6 ++++--
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/rtl8187_dev.c b/drivers/net/wireless/rtl8187_dev.c
index e454ae8..859235f 100644
--- a/drivers/net/wireless/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl8187_dev.c
 <at>  <at>  -393,12 +393,12  <at>  <at>  static int rtl8187_init_hw(struct ieee80211_hw *dev)
 	priv->rf_init(dev);

 	rtl818x_iowrite16(priv, &priv->map->BRSR, 0x01F3);
-	reg = rtl818x_ioread16(priv, &priv->map->PGSELECT) & 0xfffe;
-	rtl818x_iowrite16(priv, &priv->map->PGSELECT, reg | 0x1);
+	reg = rtl818x_ioread8(priv, &priv->map->PGSELECT) & ~1;
+	rtl818x_iowrite8(priv, &priv->map->PGSELECT, reg | 1);
 	rtl818x_iowrite16(priv, (__le16 *)0xFFFE, 0x10);
 	rtl818x_iowrite8(priv, &priv->map->TALLY_SEL, 0x80);
 	rtl818x_iowrite8(priv, (u8 *)0xFFFF, 0x60);
-	rtl818x_iowrite16(priv, &priv->map->PGSELECT, reg);
+	rtl818x_iowrite8(priv, &priv->map->PGSELECT, reg);
(Continue reading)

Michael Wu | 2 Dec 23:17 2007
Picon

[PATCH 2/8] rtl8180: fix tx power reading

From: Andrea Merello <andreamrl@...>

CCK and OFDM power levels are stored in adjacent bytes, not nibbles.

Signed-off-by: Michael Wu <flamingice@...>
Signed-off-by: Andrea Merello <andreamrl@...>
---

 drivers/net/wireless/rtl8180_rtl8225.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/rtl8180_rtl8225.c b/drivers/net/wireless/rtl8180_rtl8225.c
index 96b9b7f..6fb0659 100644
--- a/drivers/net/wireless/rtl8180_rtl8225.c
+++ b/drivers/net/wireless/rtl8180_rtl8225.c
 <at>  <at>  -261,8 +261,8  <at>  <at>  static void rtl8225_rf_set_tx_power(struct ieee80211_hw *dev, int channel)
 	u32 reg;
 	int i;

-	cck_power = priv->channels[channel - 1].val & 0xF;
-	ofdm_power = priv->channels[channel - 1].val >> 4;
+	cck_power = priv->channels[channel - 1].val & 0xFF;
+	ofdm_power = priv->channels[channel - 1].val >> 8;

 	cck_power = min(cck_power, (u8)35);
 	ofdm_power = min(ofdm_power, (u8)35);
 <at>  <at>  -505,8 +505,8  <at>  <at>  static void rtl8225z2_rf_set_tx_power(struct ieee80211_hw *dev, int channel)
 	const u8 *tmp;
 	int i;

(Continue reading)


Gmane