headers
Daniel Drake | 1 Aug 02:13
Picon
Favicon

Re: mac80211 git tree reworked

Jiri Benc wrote:
> - up-2.6 - this is a branch with patches I'd like to push to vanilla.
>   It contains, among other things, Johannes' restructuring patches. I'll
>   send a pull request later today.

John, will you be pulling this into wireless-dev anytime soon? I have 
some further mac80211 development work to do but am not sure which tree 
I should be working on. Also my patch titled "don't allow scanning in 
monitor mode" has got lost somewhere and I'm not sure whether it would 
be beneficial for me to re-submit based on Jiri/Johannes' restructuring.

Thanks,
Daniel
Permalink | Reply | 2 comments |
headers
John W. Linville | 1 Aug 02:29
Favicon

Re: mac80211 git tree reworked

On Tue, Jul 31, 2007 at 08:13:24PM -0400, Daniel Drake wrote:
> Jiri Benc wrote:
> >- up-2.6 - this is a branch with patches I'd like to push to vanilla.
> >  It contains, among other things, Johannes' restructuring patches. I'll
> >  send a pull request later today.
> 
> John, will you be pulling this into wireless-dev anytime soon? I have 
> some further mac80211 development work to do but am not sure which tree 
> I should be working on. Also my patch titled "don't allow scanning in 
> monitor mode" has got lost somewhere and I'm not sure whether it would 
> be beneficial for me to re-submit based on Jiri/Johannes' restructuring.

It isn't lost, I've got it.  I haven't been in a hurry with
2.6.24-destined patches, although I suppose I could have put it in
wireless-dev.  As you know, of course, that exact state of wireless-dev
is uncertain.

I do plan to adopt Jiri's git work.  I'm sorry I haven't got it
prepared yet.  It might be worthwhile for you to reformulate your
patch based on the restructuring.

John
--

-- 
John W. Linville
linville@...
Permalink | Reply | 0 comments |
headers
John W. Linville | 1 Aug 02:45
Favicon

Re: Rate control over multiple devices

On Tue, Jul 31, 2007 at 11:28:09PM +0100, Andy Green wrote:
> Hi folks -
> 
> Just seemed a little strange, maybe it is perfectly fine.
> 
> iwl3945: Tunable channels: 13 802.11bg, 23 802.11a channels
> PM: Adding info for No Bus:phy0
> PM: Adding info for No Bus:wmaster0
> wmaster0: Selected rate control algorithm 'iwl-3945-rs'
> 
> ...but then we add an rt73usb...
> 
> PM: Adding info for No Bus:phy1
> PM: Adding info for No Bus:wmaster1
> wmaster1: Selected rate control algorithm 'iwl-3945-rs' <----
> PM: Adding info for No Bus:wlan1
> usbcore: registered new interface driver rt73usb

This looks like the reverse of a dust-up we had a couple of months ago:

	http://marc.info/?l=linux-wireless&m=117875332512693&w=2

It is possible to change the rate control algorithm now via debugfs.
In the past someone proposed letting drivers request their default
rate scaling algorithm, and I think that makes a lot of sense.
Any thoughts?

John
--

-- 
John W. Linville
(Continue reading)

Permalink | Reply | 5 comments |
headers
Luis R. Rodriguez | 1 Aug 03:12
Picon
Gravatar

Re: [PATCH 60] drivers/net/wireless/prism54/oid_mgt.c: kmalloc + memset conversion to kzalloc

On 7/31/07, Mariusz Kozlowski <m.kozlowski <at> tuxland.pl> wrote:
> Signed-off-by: Mariusz Kozlowski <m.kozlowski <at> tuxland.pl>

Acked-by: Luis R. Rodriguez <mcgrof <at> gmail.com>

>  drivers/net/wireless/prism54/oid_mgt.c | 25377 -> 25297 (-80 bytes)
>  drivers/net/wireless/prism54/oid_mgt.o | 128460 -> 128284 (-176 bytes)
>
>  drivers/net/wireless/prism54/oid_mgt.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- linux-2.6.23-rc1-mm1-a/drivers/net/wireless/prism54/oid_mgt.c       2007-07-26
13:07:43.000000000 +0200
> +++ linux-2.6.23-rc1-mm1-b/drivers/net/wireless/prism54/oid_mgt.c       2007-07-30
00:27:44.000000000 +0200
> @@ -244,13 +244,11 @@ mgt_init(islpci_private *priv)
>         /* Alloc the cache */
>         for (i = 0; i < OID_NUM_LAST; i++) {
>                 if (isl_oid[i].flags & OID_FLAG_CACHED) {
> -                       priv->mib[i] = kmalloc(isl_oid[i].size *
> +                       priv->mib[i] = kzalloc(isl_oid[i].size *
>                                                (isl_oid[i].range + 1),
>                                                GFP_KERNEL);
>                         if (!priv->mib[i])
>                                 return -ENOMEM;
> -                       memset(priv->mib[i], 0,
> -                              isl_oid[i].size * (isl_oid[i].range + 1));
>                 } else
>                         priv->mib[i] = NULL;
>         }
(Continue reading)

Permalink | Reply | 0 comments |
headers
Luis R. Rodriguez | 1 Aug 03:20
Picon
Gravatar

Re: Removing the prism54 module

On 7/28/07, Edward Ando <edwardando@...> wrote:
> Dear All,
> I am trying to set up software suspend 2 (TuxOnIce now it seems). This
> has decided it wants to remove the prism54 module before starting the
> hibernate process.
>
> When it tries to do this, (or when I manually do: "ifconfig eth1
> down"), I start getting these messages on all terminals, ad infinitum:
>
> kernel: unregister_netdevice: waiting for eth1 to become free. Usage
> count = 4

Hmm... can you show lsmod output please?

  Luis
Permalink | Reply | 2 comments |
headers
Dan Williams | 1 Aug 04:34
Picon
Favicon

Re: libertas: blows chunks on failed firmware load

On Tue, 2007-07-31 at 20:45 +0100, Andy Green wrote:
> Hi folks -
> 
> I realize I am slightly pushing my luck, but I added this el-cheapo
> 88W8338 -based "Compoint EVWL-GI-700S" USB stick's USB ID "0x1286,
> 0x1fab" to libertas/usb8xxx.c and chanced my arm.

If it's 8338, it's certainly not gonna work with this driver.  Did you
add the USB ID yourself?

Dan

> 
> I was rewarded with
> 
> PM: Adding info for No Bus:msh0
> PM: Adding info for No Bus:5-4
> PM: Removing info for No Bus:5-4
> libertas: request_firmware() failed with 0xfffffffe
> libertas: firmware usb8388.bin not found
> libertas: firmware init failed
> PM: Removing info for No Bus:msh0
> kfree_debugcheck: out of range ptr 6b6b6b6bh.
> ------------[ cut here ]------------
> kernel BUG at mm/slab.c:2825!
> invalid opcode: 0000 [#1]
> SMP
> Modules linked in: usb8xxx libertas ieee80211 ieee80211_crypt iwl3945
> rt73usb rt2x00usb rt2x00lib rfkill input_polldev crc_itu_t mac80211
> cfg80211 vfat fat vmnet(P) vmmon(P) snd_rtctimer usb_storage autofs4 aes
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Williams | 1 Aug 04:35
Picon
Favicon

Re: libertas: blows chunks on failed firmware load

On Tue, 2007-07-31 at 20:45 +0100, Andy Green wrote:
> Hi folks -
> 
> I realize I am slightly pushing my luck, but I added this el-cheapo
> 88W8338 -based "Compoint EVWL-GI-700S" USB stick's USB ID "0x1286,
> 0x1fab" to libertas/usb8xxx.c and chanced my arm.

Irregardless of my previous comment, the bug should get fixed of course.

Thanks,
Dan

> I was rewarded with
> 
> PM: Adding info for No Bus:msh0
> PM: Adding info for No Bus:5-4
> PM: Removing info for No Bus:5-4
> libertas: request_firmware() failed with 0xfffffffe
> libertas: firmware usb8388.bin not found
> libertas: firmware init failed
> PM: Removing info for No Bus:msh0
> kfree_debugcheck: out of range ptr 6b6b6b6bh.
> ------------[ cut here ]------------
> kernel BUG at mm/slab.c:2825!
> invalid opcode: 0000 [#1]
> SMP
> Modules linked in: usb8xxx libertas ieee80211 ieee80211_crypt iwl3945
> rt73usb rt2x00usb rt2x00lib rfkill input_polldev crc_itu_t mac80211
> cfg80211 vfat fat vmnet(P) vmmon(P) snd_rtctimer usb_storage autofs4 aes
> nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state
(Continue reading)

Permalink | Reply | 12 comments |
headers
Andrew Morton | 1 Aug 05:26

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <mb <at> bu3sch.de> wrote:

> The Sonics Silicon Backplane is a mini-bus used on
> various Broadcom chips and embedded devices.

Sigh.

s390:

drivers/ssb/main.c: In function 'ssb_ssb_read16':
drivers/ssb/main.c:489: error: implicit declaration of function 'readw'
drivers/ssb/main.c: In function 'ssb_ssb_read32':
drivers/ssb/main.c:497: error: implicit declaration of function 'readl'
drivers/ssb/main.c: In function 'ssb_ssb_write16':
drivers/ssb/main.c:505: error: implicit declaration of function 'writew'
drivers/ssb/main.c: In function 'ssb_ssb_write32':
drivers/ssb/main.c:513: error: implicit declaration of function 'writel'        

we shouldn't be compiling SSB on s390, because:

config SSB
        tristate "Sonics Silicon Backplane support"
        depends on EXPERIMENTAL && HAS_IOMEM

and

akpm2:/usr/src/25> grep IOMEM .config 
CONFIG_NO_IOMEM=y
akpm2:/usr/src/25>
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jouni Malinen | 1 Aug 05:33
Picon

Re: [PATCH 2.6.23 3/3] [wireless] orinoco: create a Kconfig option for Prism2

On Tue, Jul 24, 2007 at 01:07:27AM +0300, Faidon Liambotis wrote:
> [I'm adding Jouni to Cc to help us :)]

I may have missed some details from the thread, but couple of comments
here anyway..

> Pavel Roskin wrote:
> >On Sun, 2007-07-22 at 16:17 +0300, Faidon Liambotis wrote:
> >>Since v2.6.14, Prism 2/2.5/3 devices are better supported using the HostAP
> >>driver, which was made to work with these exclusively.
> >>Having the same IDs supported by orinoco too confuses users who have both
> >>drivers compiled in or as modules who expect hostap to drive the device.
> >>
> >>Telling users to echo to /sys/bus/pci/drivers/*/unbind and bind is not
> >>exactly user-friendly.
> >>
> >>Create an option to disable support for Prism devices in orinoco driver 
> >>which
> >>disabled the IDs for the PCMCIA module and creates a Kconfig dependency 
> >>for
> >>the Prism PCI modules.

This may not be a desirable change from number of reasons if it is
likely to get enabled by default in builds.

> >Nortel cards consist of a bridge and a PCMCIA card with Symbol firmware.
> >Their PCI IDs (0x126c:0x8030 and 0x1562:0x0001) are in hostap_plx, but I
> >really doubt that hostap_plx would even be able to initialize those
> >cards properly, given the fact that it lacks Nortel specific code (look
> >for "118" in orinoco_nortel and hostap_plx).
(Continue reading)

Permalink | Reply | 1 comment |
headers
Andrew Morton | 1 Aug 06:56

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <mb@...> wrote:

> The Sonics Silicon Backplane is a mini-bus used on
> various Broadcom chips and embedded devices.

A few probs with mips allmodconfig:

drivers/ssb/driver_mipscore.c:121: warning: "struct ssb_serial_ports" declared inside parameter list
drivers/ssb/driver_mipscore.c:121: warning: its scope is only this definition or declaration, which
is probably not what you want
drivers/ssb/driver_mipscore.c: In function `ssb_mips_serial_init':
drivers/ssb/driver_mipscore.c:166: warning: passing arg 1 of `ssb_extif_serial_init' from
incompatible pointer type
drivers/ssb/driver_mipscore.c:166: warning: passing arg 2 of `ssb_extif_serial_init' from
incompatible pointer type
drivers/ssb/driver_mipscore.c: At top level:
drivers/ssb/driver_mipscore.c:188: warning: 'ssb_cpu_clock' defined but not used
drivers/ssb/driver_pcicore.c: In function `ssb_fixup_pcibridge':
drivers/ssb/driver_pcicore.c:98: error: implicit declaration of function `pcibios_enable_device'
drivers/ssb/driver_pcicore.c: At top level:
drivers/ssb/driver_pcicore.c:278: warning: integer overflow in expression
drivers/ssb/driver_pcicore.c:278: warning: integer overflow in expression       

the latter is due to .end in

static struct resource ssb_pcicore_mem_resource = {
        .name   = "SSB PCIcore external memory",
        .start  = SSB_PCI_DMA,
        .end    = SSB_PCI_DMA + SSB_PCI_DMA_SZ - 1,
        .flags  = IORESOURCE_MEM,
(Continue reading)

Permalink | Reply | 0 comments |

Gmane