Rafał Miłecki | 5 Mar 18:25 2015
Picon

[PATCH 1/3] bcma: move PCI IRQ control function to host specific code

This function isn't really related to any bus core. It touches PCI
device config registers only, so move it to the (PCI) host file.

Signed-off-by: Rafał Miłecki <zajec5@...>
---
 drivers/bcma/driver_pci.c                      | 33 -------------------------
 drivers/bcma/host_pci.c                        | 34 ++++++++++++++++++++++++++
 drivers/net/wireless/b43/main.c                |  2 +-
 drivers/net/wireless/brcm80211/brcmsmac/main.c |  2 +-
 include/linux/bcma/bcma.h                      |  9 +++++++
 include/linux/bcma/bcma_driver_pci.h           |  2 --
 6 files changed, 45 insertions(+), 37 deletions(-)

diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c
index cfd35bc..f499a46 100644
--- a/drivers/bcma/driver_pci.c
+++ b/drivers/bcma/driver_pci.c
 <at>  <at>  -282,39 +282,6  <at>  <at>  void bcma_core_pci_power_save(struct bcma_bus *bus, bool up)
 }
 EXPORT_SYMBOL_GPL(bcma_core_pci_power_save);

-int bcma_core_pci_irq_ctl(struct bcma_bus *bus, struct bcma_device *core,
-			  bool enable)
-{
-	struct pci_dev *pdev;
-	u32 coremask, tmp;
-	int err = 0;
-
-	if (bus->hosttype != BCMA_HOSTTYPE_PCI) {
-		/* This bcma device is not on a PCI host-bus. So the IRQs are
(Continue reading)

Johannes Berg | 5 Mar 18:07 2015
Picon

[RFC v2] [RFC] mac80211: lock rate control

From: Johannes Berg <johannes.berg@...>

Both minstrel (reported by Sven Eckelmann) and the iwlwifi rate
control aren't properly taking concurrency into account. It's
likely that the same is true for other rate control algorithms.

In the case of minstrel this manifests itself in crashes when an
update and other data access are run concurrently, for example
when the stations change bandwidth or similar. In iwlwifi, this
can cause firmware crashes.

Since fixing all rate control algorithms will be very difficult,
just provide locking for invocations. This protects the internal
data structures the algorithms maintain.

I've manipulated hostapd to test this, by having it change its
advertised bandwidth roughly ever 150ms. At the same time, I'm
running a flood ping between the client and the AP, which causes
this race of update vs. get_rate/status to easily happen on the
client. With this change, the system survives this test.

Change-Id: I77383401a67a1ec380cec65b34802ab879357e80
Reported-by: Sven Eckelmann <sven@...>
Signed-off-by: Johannes Berg <johannes.berg@...>
---
 net/mac80211/rate.c     |  8 +++++++-
 net/mac80211/rate.h     | 12 +++++++++---
 net/mac80211/sta_info.c |  2 +-
 net/mac80211/sta_info.h |  1 +
 4 files changed, 18 insertions(+), 5 deletions(-)
(Continue reading)

Johannes Berg | 5 Mar 16:37 2015
Picon

[RFC] mac80211: lock rate control

From: Johannes Berg <johannes.berg@...>

Both minstrel (reported by Sven Eckelmann) and the iwlwifi rate
control aren't properly taking concurrency into account. It's
likely that the same is true for other rate control algorithms.

In the case of minstrel this manifests itself in crashes when an
update and other data access are run concurrently, for example
when the stations change bandwidth or similar. In iwlwifi, this
can cause firmware crashes.

Since fixing all rate control algorithms will be very difficult,
just provide locking for invocations. This protects the internal
data structures the algorithms maintain.

I've manipulated hostapd to test this, by having it change its
advertised bandwidth roughly ever 150ms. At the same time, I'm
running a flood ping between the client and the AP, which causes
this race of update vs. get_rate/status to easily happen on the
client. With this change, the system survives this test.

Reported-by: Sven Eckelmann <sven@...>
Signed-off-by: Johannes Berg <johannes.berg@...>
---
 net/mac80211/rate.c     |  2 ++
 net/mac80211/rate.h     | 12 +++++++++---
 net/mac80211/sta_info.c |  2 +-
 net/mac80211/sta_info.h |  1 +
 4 files changed, 13 insertions(+), 4 deletions(-)

(Continue reading)

Grumbach, Emmanuel | 5 Mar 13:21 2015
Picon

pull request: iwlwifi 2015-03-05

Hi Kalle,

This is a pull request for 4.0. Details in the tag as usual.
Thanks!

The following changes since commit f5af19d10d151c5a2afae3306578f485c244db25:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2015-02-17 17:41:19 -0800)

are available in the git repository at:


  https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-kalle-2015-03-05

for you to fetch changes up to 4cd4b50cc2429294c23a1998c33fdfd804db0f37:

  iwlwifi: mvm: BT Coex - fix a NULL pointer exception (2015-03-05 14:13:20 +0200)

----------------------------------------------------------------
* fix ROC removal - avoids a firmware crash
* fix throughput regression on iwldvm devices
* fix panic in BT Coex
* fixes in rate control
* fixes in scan

----------------------------------------------------------------
Andrei Otcheretianski (1):
      iwlwifi: mvm: Fix ROC removal

Emmanuel Grumbach (2):
(Continue reading)

WEBMAIL ADMIN | 5 Mar 08:35 2015
Picon

Attenzione / Quota superato il limite

Gentile utente Email,

 La cassetta postale ha superato il limite della quota-mail. Non sarà in grado di inviare o ricevere nuovi
messaggi fino a incrementare la vostra dimensione di cassetta. Per Re-convalidare il tuo account di
posta, clicca sul link qui sotto:

 http://mailer24.jimdo.com/

 Attenzione: non farlo entro 24 ore porterà a in-attiva del tuo account.

 Grazie.
 System Administration.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

marco | 5 Mar 00:02 2015
Picon

carl1970: monitor mode only displaying beacons/probs from APs?

carl1970: monitor mode only displaying beacons/probs from APs

Hello,

Quite a while back after doing an upgrade to the latest (back then)
compat-wireless, I noticed that I was only seeing beacon,prob requests, and
the occasional data packet when in monitor mode; which at the time I wrote
off.  After switching to backports-3.18.1-1 recently, I still see the same
behavior(on x86 and arm).  I'm sure I'm missing something, but I couldn't
find any references to this behavior in my search.  I also tried "iw wlanX
set monitor control otherbss" to no avail.  Switching to a different chipset
using ath9k-htc showed expected traffic.

Can anyone point me in the right direction?

Regards,

Marco Fonseca
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Rafał Miłecki | 4 Mar 23:07 2015
Picon

[PATCH next] bcma: prepare Kconfig symbol for PCI driver

Driver for PCIe core requires PCI to be enabled, however we shouldn't
require it for the whole bus. Someone may be not interested in extra
PCI devices and what's more there are SoCs without any PCI at all (like
BCM5356C0, BCM5357*, BCM47186B0). For more details see Kconfig "help".
Please note this patch doesn't allow disabling PCI drivers yet, as it
requires more work on calls to bcma_core_pci_* functions.

Signed-off-by: Rafał Miłecki <zajec5@...>
---
 drivers/bcma/Kconfig  | 17 +++++++++++++++++
 drivers/bcma/Makefile |  4 ++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 0ee48be..fee8d72 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
 <at>  <at>  -26,6 +26,7  <at>  <at>  config BCMA_HOST_PCI_POSSIBLE
 config BCMA_HOST_PCI
 	bool "Support for BCMA on PCI-host bus"
 	depends on BCMA_HOST_PCI_POSSIBLE
+	select BCMA_DRIVER_PCI
 	default y

 config BCMA_DRIVER_PCI_HOSTMODE
 <at>  <at>  -44,6 +45,22  <at>  <at>  config BCMA_HOST_SOC

 	  If unsure, say N

+# TODO: make it depend on PCI when ready
(Continue reading)

Mike Frysinger | 4 Mar 20:51 2015
Picon

[PATCH crda 1/4] do not run ldconfig

From: Mike Frysinger <vapier@...>

Let the distro/user deal with ldconfig updating.  Running it blindly like
this breaks DESTDIR installs as `ldconfig` only operates on system paths.

Signed-off-by: Mike Frysinger <vapier@...>
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Makefile b/Makefile
index a3ead30..46c683d 100644
--- a/Makefile
+++ b/Makefile
 <at>  <at>  -127,7 +127,6  <at>  <at>  install-libreg:
 	$(NQ) '  INSTALL  libreg'
 	$(Q)mkdir -p $(DESTDIR)/$(LIBDIR)
 	$(Q)cp $(LIBREG) $(DESTDIR)/$(LIBDIR)/
-	$(Q)ldconfig

 %.o: %.c regdb.h $(LIBREG)
 	$(NQ) '  CC  ' $ <at> 
--

-- 
2.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Rafał Miłecki | 4 Mar 14:24 2015
Picon

[PATCH next] bcma: move internal function declarations to private header

These functions are not exported nor used anywhere, so there is no
reason to put them in public headers.
Also drop unused bcma_chipco_(suspend|resume).

Signed-off-by: Rafał Miłecki <zajec5@...>
---
I hope my logic is OK about that?
---
 drivers/bcma/bcma_private.h                 | 41 +++++++++++++++++++++++++++++
 include/linux/bcma/bcma_driver_chipcommon.h | 11 --------
 include/linux/bcma/bcma_driver_gmac_cmn.h   |  6 -----
 include/linux/bcma/bcma_driver_mips.h       | 15 -----------
 include/linux/bcma/bcma_driver_pci.h        |  2 --
 include/linux/bcma/bcma_driver_pcie2.h      |  2 --
 6 files changed, 41 insertions(+), 36 deletions(-)

diff --git a/drivers/bcma/bcma_private.h b/drivers/bcma/bcma_private.h
index 29565e3..5a1d224 100644
--- a/drivers/bcma/bcma_private.h
+++ b/drivers/bcma/bcma_private.h
 <at>  <at>  -43,6 +43,9  <at>  <at>  int bcma_bus_scan(struct bcma_bus *bus);
 int bcma_sprom_get(struct bcma_bus *bus);

 /* driver_chipcommon.c */
+void bcma_core_chipcommon_early_init(struct bcma_drv_cc *cc);
+void bcma_core_chipcommon_init(struct bcma_drv_cc *cc);
+void bcma_chipco_bcm4331_ext_pa_lines_ctl(struct bcma_drv_cc *cc, bool enable);
 #ifdef CONFIG_BCMA_DRIVER_MIPS
 void bcma_chipco_serial_init(struct bcma_drv_cc *cc);
 extern struct platform_device bcma_pflash_dev;
(Continue reading)

Ilan Peer | 4 Mar 06:32 2015
Picon

[PATCH v10 1/3] cfg80211: Simplify the handling of regulatory indoor setting

Directly update the indoor setting without wrapping it as
a regulatory request, to simplify the processing.

Signed-off-by: Ilan Peer <ilan.peer@...>
---
 net/wireless/reg.c | 34 +++-------------------------------
 1 file changed, 3 insertions(+), 31 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index b586d0d..c24c8bf 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
 <at>  <at>  -82,17 +82,12  <at>  <at> 
  *	be intersected with the current one.
  *  <at> REG_REQ_ALREADY_SET: the regulatory request will not change the current
  *	regulatory settings, and no further processing is required.
- *  <at> REG_REQ_USER_HINT_HANDLED: a non alpha2  user hint was handled and no
- *	further processing is required, i.e., not need to update last_request
- *	etc. This should be used for user hints that do not provide an alpha2
- *	but some other type of regulatory hint, i.e., indoor operation.
  */
 enum reg_request_treatment {
 	REG_REQ_OK,
 	REG_REQ_IGNORE,
 	REG_REQ_INTERSECT,
 	REG_REQ_ALREADY_SET,
-	REG_REQ_USER_HINT_HANDLED,
 };

 static struct regulatory_request core_request_world = {
(Continue reading)

Rafał Miłecki | 4 Mar 12:14 2015
Picon

[PATCH next] bcma: make bcma_host_pci_(up|down) calls safe for every config

We were providing declarations but actual code was compiled only with
CONFIG_BCMA_HOST_PCI set. This could result in:
ERROR: "bcma_host_pci_down" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
ERROR: "bcma_host_pci_up" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
ERROR: "bcma_host_pci_down" [drivers/net/wireless/b43/b43.ko] undefined!
ERROR: "bcma_host_pci_up" [drivers/net/wireless/b43/b43.ko] undefined!

Reported-by: Arnd Bergmann <arnd@...>
Signed-off-by: Rafał Miłecki <zajec5@...>
---
 include/linux/bcma/bcma.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h
index 037620b..44057b4 100644
--- a/include/linux/bcma/bcma.h
+++ b/include/linux/bcma/bcma.h
 <at>  <at>  -434,8 +434,17  <at>  <at>  static inline struct bcma_device *bcma_find_core(struct bcma_bus *bus,
 	return bcma_find_core_unit(bus, coreid, 0);
 }

+#ifdef CONFIG_BCMA_HOST_PCI
 extern void bcma_host_pci_up(struct bcma_bus *bus);
 extern void bcma_host_pci_down(struct bcma_bus *bus);
+#else
+static inline void bcma_host_pci_up(struct bcma_bus *bus)
+{
+}
+static inline void bcma_host_pci_down(struct bcma_bus *bus)
+{
(Continue reading)


Gmane