Vivek Natarajan | 4 Aug 07:15 2015

[PATCH 1/2] ath10k: Support different txbf configuration schemes

qca61x4 uses the vdev param as a sole sufficient configuration
for txbf while qca99x0 enables txbf during peer assoc by
combining the vdev param value with peer assoc's vht capabilities

This patch gets the appropriate txbf configuration scheme
before passing the wmi command to enable the same in the firmware.

Signed-off-by: Vivek Natarajan <nataraja@...>
 drivers/net/wireless/ath/ath10k/mac.c     |  3 +++
 drivers/net/wireless/ath/ath10k/wmi-ops.h | 10 ++++++++++
 drivers/net/wireless/ath/ath10k/wmi-tlv.c |  6 ++++++
 drivers/net/wireless/ath/ath10k/wmi.c     |  6 ++++++
 drivers/net/wireless/ath/ath10k/wmi.h     |  6 ++++++
 5 files changed, 31 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index acd222f..4eb29aa 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
 <at>  <at>  -2509,6 +2509,9  <at>  <at>  static int ath10k_mac_vif_recalc_txbf(struct ath10k *ar,
 	u32 param;
 	u32 value;

+	if (ath10k_wmi_get_txbf_conf_scheme(ar) != WMI_TXBF_CONF_AFTER_ASSOC)
+		return 0;
 	if (!(ar->vht_cap_info &
(Continue reading)

Ting-Chih Hsiao | 4 Aug 05:21 2015

[PATCH] staging: rtl8723au: fix up coding style warnings reported by

remove spaces at the start of a line
align enum variable with other parameters

Signed-off-by: Ting-Chih Hsiao <s894330@...>
 drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
index 342dec3..a63c6cb 100644
--- a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
+++ b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
 <at>  <at>  -21,7 +21,7  <at>  <at>  odm_ConfigRFReg_8723A(
 	struct dm_odm_t *pDM_Odm,
 	u32					Addr,
 	u32					Data,
-  enum RF_RADIO_PATH     RF_PATH,
 	u32				    RegAddr


To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at

(Continue reading)

Thomas Hühn | 4 Aug 00:28 2015

Release of RegMon - a fast in-kernel phy/mac dmonitoring tool for QCA/Atheros WiFi cards

Hi all,

Today I’ve released my WiFi register monitoring tool RegMon on GitHub:

RegMon consists of Atheros driver patches to monitor arbitrary registers under ath9k, ath5k and madwifi
from user space with high sampling rates (up to ~20kHz). My common research use case is the fine-grained
monitoring and analysis of all busy states (tx, rx, energy detection & idle), TSF and noise floor of the
mac/phy layer from an Atheros WiFi card. But it can be used to sample any available register (like NAV,
error registers, ect.).
There are also a bunch of scripts in the repo to set-up a wireless experiment, collect RegMon traces, parse,
merge and plot them with R.

Feel free to use and change RegMon for your own purpose. As RegMon is still work in progress I am happy to
receive and include your feedback and ideas.

Greetings from Berlin
Larry Finger | 3 Aug 23:15 2015

[PATCH NEXT] rtlwifi: rtl8192c-common: Fix two typos

In this driver, two variables are masked by one quantity, and then tested
against a second number with more bits that the mask. Accordingly, the
test always fails. To minimize the possibility of such typos, a symbolic
definition of the mask is created and used.

The separate load and mask operations are also combined into a single

Reported-by: David Binderman <dcb314@...>
Signed-off-by: Larry Finger <Larry.Finger@...>
Cc: David Binderman <dcb314@...>
 drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index 0aca6f4..61c857b 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
 <at>  <at>  -39,6 +39,7  <at>  <at> 
+#define BT_MASK				0x00ffffff

 #define RTLPRIV			(struct rtl_priv *)
 <at>  <at>  -1536,13 +1537,11  <at>  <at>  static bool rtl92c_bt_state_change(struct ieee80211_hw *hw)
 		return false;

(Continue reading)

Larry Finger | 3 Aug 22:56 2015

[PATCH NEXT 0/6] rtlwifi: Fix firmware header issues

While fixing an endian issue introduced in commit e996db69833a,
I realized that there were similar endian issues in several
of the drivers. In addition, these drivers were all defining a
similar struct. A single common definition is moved into the
main header, and all drivers are converted to use it. This
process exposed several endian issues that were not previously
detected by Sparse.

Larry Finger (6):
  irtlwifi: rtl8192ce: rtl8192cu: Fix endian issue
  rtlwifi: rtl8723ae: rtl8723be: rtl8723com: Fix firmware header endian
  rtlwifi: rtl8821ae: Fix firmware endian issues
  rtlwifi: rtl8192de: Fix firmware header endian issues
  rtlwifi: rtl888ee: Fix firmware header endian issues
  rtlwifi: rtl8192ee: Fix firmware header endian issues

 drivers/net/wireless/rtlwifi/rtl8188ee/fw.c        | 10 ++++-----
 drivers/net/wireless/rtlwifi/rtl8188ee/fw.h        | 21 +-----------------
 drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c  | 12 +++++------
 drivers/net/wireless/rtlwifi/rtl8192c/fw_common.h  | 19 ----------------
 drivers/net/wireless/rtlwifi/rtl8192de/fw.h        | 22 -------------------
 drivers/net/wireless/rtlwifi/rtl8192ee/fw.c        | 12 +++++------
 drivers/net/wireless/rtlwifi/rtl8192ee/fw.h        | 21 +-----------------
 drivers/net/wireless/rtlwifi/rtl8723ae/sw.c        |  4 ++--
 drivers/net/wireless/rtlwifi/rtl8723be/sw.c        |  4 ++--
 .../net/wireless/rtlwifi/rtl8723com/fw_common.c    | 10 ++++-----
 .../net/wireless/rtlwifi/rtl8723com/fw_common.h    | 19 ----------------
 drivers/net/wireless/rtlwifi/rtl8821ae/fw.c        | 14 ++++++------
(Continue reading)

Larry Finger | 3 Aug 20:53 2015

[PATCH NEXT 0/7] Make changes in rtlwifi and dependent drivers

The Realtek engineers have suggested several improvements to this family
of drivers. The changes include:

1. Fix the 5G channel assignments to remove unused channels.
2. Fix a potential race condition when updating CAM.
3. Change retry limits to depend on vif type.
4. Fix a race condition that could allow a change in the APOL key
   before packet 4 of the handshaking sequence has been transmitted.
   This problem affects rtl8192ee, rtl8723be, and rtl8821ae.


pkshih (6):
  rtlwifi: Fix programming of CAM content
  rtlwifi: Make retry limits depend on vif type
  rtlwifi: Force disable key to wait until TX acked.
  rtlwifi: rtl8192ee: Implement new rekey logic
  rtlwifi: rtl8723be: Implement new rekey logic
  rtlwifi: rtl8821ae: Implement new rekey logic

timlee (1):
  rtlwifi: rtl8821ae: Remove unsupported 5G channels

 drivers/net/wireless/rtlwifi/base.c          | 183 ++++++++++++++++++++++-----
 drivers/net/wireless/rtlwifi/base.h          |   7 +
 drivers/net/wireless/rtlwifi/cam.c           |   6 +-
 drivers/net/wireless/rtlwifi/core.c          |  22 +++-
 drivers/net/wireless/rtlwifi/debug.h         |   1 +
 drivers/net/wireless/rtlwifi/pci.c           |   8 +-
 drivers/net/wireless/rtlwifi/ps.c            |   3 +
(Continue reading)

kbuild test robot | 3 Aug 18:18 2015

[wireless-testing:master 10/12] net/bridge/br_multicast.c:1440:4: error: too few arguments to function 'br_mdb_notify'

tree:   git:// master
head:   9a2f971eee40039d09458580a87515cb540688c2
commit: 7d96eee8472d80d72510d3c7cf9de3703ed7ad56 [10/12] Merge branch 'master' of git://
config: x86_64-rhel (attached as .config)
  git checkout 7d96eee8472d80d72510d3c7cf9de3703ed7ad56
  # save the attached .config to linux build tree
  make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   net/bridge/br_multicast.c: In function 'br_multicast_leave_group':
>> net/bridge/br_multicast.c:1440:4: error: too few arguments to function 'br_mdb_notify'
       br_mdb_notify(br->dev, port, group, RTM_DELMDB);
   In file included from net/bridge/br_multicast.c:36:0:
   net/bridge/br_private.h:490:6: note: declared here
    void br_mdb_notify(struct net_device *dev, struct net_bridge_port *port,

vim +/br_mdb_notify +1440 net/bridge/br_multicast.c

eb1d1641 Herbert Xu   2010-02-27  1424  	if (!mp)
eb1d1641 Herbert Xu   2010-02-27  1425  		goto out;
eb1d1641 Herbert Xu   2010-02-27  1426  
544586f7 Satish Ashok 2015-07-28  1427  	if (port && (port->flags & BR_MULTICAST_FAST_LEAVE)) {
544586f7 Satish Ashok 2015-07-28  1428  		struct net_bridge_port_group __rcu **pp;
544586f7 Satish Ashok 2015-07-28  1429  
544586f7 Satish Ashok 2015-07-28  1430  		for (pp = &mp->ports;
544586f7 Satish Ashok 2015-07-28  1431  		     (p = mlock_dereference(*pp, br)) != NULL;
(Continue reading)

Bertold Van den Bergh | 3 Aug 15:45 2015

[PATCH 1/1] ath: Make ath_opmode_to_string understand OCB mode

Make ath_opmode_to_string return "OCB" for NL80211_IFTYPE_OCB. Currently
it will return "UNKNOWN".

Signed-off-by: Bertold Van den Bergh <bertold.vandenbergh@...>
 drivers/net/wireless/ath/debug.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/debug.c b/drivers/net/wireless/ath/debug.c
index 508eccf..d59d83e 100644
--- a/drivers/net/wireless/ath/debug.c
+++ b/drivers/net/wireless/ath/debug.c
 <at>  <at>  -40,6 +40,8  <at>  <at>  const char *ath_opmode_to_string(enum nl80211_iftype opmode)
 		return "P2P-CLIENT";
 	case NL80211_IFTYPE_P2P_GO:
 		return "P2P-GO";
+	case NL80211_IFTYPE_OCB:
+		return "OCB";
 		return "UNKNOWN";


To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at

(Continue reading)

David Binderman | 3 Aug 14:51 2015

linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c: Bad test ?

Hello there,

[linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1542] ->
[linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1545]: (style) Mismatching
assignment and comparison, comparison 'bt_pri==4294967295' is always false.

    bt_pri = bt_pri & 0x00ffffff;

   if (bt_tx == 0xffffffff && bt_pri == 0xffffffff &&

Six f in the first line, but eight in the second.

Would use of symbol constants help prevent this kind of problem occurring
in future ? 


David Binderman

To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at

Michal Kazior | 3 Aug 11:16 2015

[PATCH 1/2] ath10k: remove futile fragmentation threshold config

Commit 1010ba4c5d1c ("ath10k: unregister and
remove frag_threshold callback") didn't remove all
instances of (futile) fragmentation threshold
configuration. No known firmware supports the
parameter so don't even bother setting it.

Signed-off-by: Michal Kazior <michal.kazior@...>
 drivers/net/wireless/ath/ath10k/mac.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index acd222f3b899..879af9c3bd4a 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
 <at>  <at>  -678,20 +678,6  <at>  <at>  static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value)
 	return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, value);

-static int ath10k_mac_set_frag(struct ath10k_vif *arvif, u32 value)
-	struct ath10k *ar = arvif->ar;
-	u32 vdev_param;
-	if (value != 0xFFFFFFFF)
-		value = clamp_t(u32, arvif->ar->hw->wiphy->frag_threshold,
-	vdev_param = ar->wmi.vdev_param->fragmentation_threshold;
(Continue reading)

Michal Kazior | 3 Aug 10:55 2015

[PATCH] cfg80211: propagate set_wiphy failure to userspace

If driver failed to setup wiphy params (e.g. rts
threshold, fragmentation treshold) userspace
wasn't properly notified about this. This could
lead to user confusion who would think the command
succeeded even if that wasn't the case.

Signed-off-by: Michal Kazior <michal.kazior@...>
 net/wireless/nl80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 76b41578a838..5849fa199f77 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
 <at>  <at>  -2321,6 +2321,7  <at>  <at>  static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
 			rdev->wiphy.frag_threshold = old_frag_threshold;
 			rdev->wiphy.rts_threshold = old_rts_threshold;
 			rdev->wiphy.coverage_class = old_coverage_class;
+			return result;
 	return 0;


To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at
(Continue reading)