Mikael Kanstrup | 28 May 01:32 2016
Picon
Gravatar

[RFCv3] brcmfmac: Add tracepoints for bcmdhd-dissector tool

From: Mikael Kanstrup <mikael.kanstrup@...>

Add tracepoints to be used with bcmdhd-dissector:
  https://github.com/kanstrup/bcmdhd-dissector

bcmdhd-dissector is a Wireshark LUA plugin dissector used to decode
protocol data between the brcmfmac driver and the wifi chip firmware.
This includes decoding firmware command requests and responses as
well as events and even tx/rx data interleaved if the dissect_data
tracepoint is enabled.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@...>
---
v3:
- Updated patch as per Arends comments, i.e:
  - Replaced memcpy in driver code with ethernet header added in
    trace-cmd plugin.
  - Removed global tmp buffer.
  - Moved tx/rx traces to start_xmit and netif_rx funcs.
  - Made functions return void.

v2:
- Add description of bcmdhd-dissector as suggested by Rafał
- Fix tx/rx data dump.
- Fix tx data dump on USB interface.

 .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c    |  4 ++
 .../wireless/broadcom/brcm80211/brcmfmac/core.c    |  5 ++
 .../wireless/broadcom/brcm80211/brcmfmac/debug.c   | 23 ++++++++++
 .../wireless/broadcom/brcm80211/brcmfmac/debug.h   | 14 ++++++
(Continue reading)

Valo, Kalle | 27 May 18:18 2016

Re: Ath9k - no bouncing...

Hi Eduardo,

Adding linux-wireless. Please don't send me mail privately, instead send
it to the list. You get faster replies, others learn from this, I get
less mail. Everybody win.

Eduardo Abinader <Eduardo.Abinader@...> writes:

> It's been some time I sent two times the following patches to ath9k-devel and
> they were not bounced. Is that a list problem or my patches were not accepted
> at all?
>
> http://article.gmane.org/gmane.linux.kernel.wireless.general/151853/match=tx99
>
> http://article.gmane.org/gmane.linux.kernel.wireless.general/152201/match=tx99
>
> http://article.gmane.org/gmane.linux.kernel.wireless.general/151714/match=
> remove+empty

I usually send an email to every patch if it's dropped or applied. In
this case I just haven't get to your patches yet. You can follow the
patch status from patchwork:

https://patchwork.kernel.org/project/linux-wireless/list/?state=*

--

-- 
Kalle Valo--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Rajkumar Manoharan | 27 May 16:45 2016

[PATCH 1/5] ath10k: fix operating irq mode for ahb device

Earlier when operating irq mode is legacy, interrupts are disabled
and re-enabled based on num_msi_intrs. commit cfe9011a05a8 ("ath10k:
remove MSI range support") replaced num_msi_intrs by oper_irq_mode.
Since oper_irq_mode is not initialized for ahb devices (i.e qca4019),
device boot up is failed during probe.

Fixes: cfe9011a05a8 ("ath10k: remove MSI range support")
Signed-off-by: Rajkumar Manoharan <rmanohar@...>
---
 drivers/net/wireless/ath/ath10k/ahb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index bd62bc19e758..37ff36fca7bc 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
 <at>  <at>  -476,6 +476,7  <at>  <at>  static irqreturn_t ath10k_ahb_interrupt_handler(int irq, void *arg)

 static int ath10k_ahb_request_irq_legacy(struct ath10k *ar)
 {
+	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);
 	struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
 	int ret;

 <at>  <at>  -487,6 +488,7  <at>  <at>  static int ath10k_ahb_request_irq_legacy(struct ath10k *ar)
 			    ar_ahb->irq, ret);
 		return ret;
 	}
+	ar_pci->oper_irq_mode = ATH10K_PCI_IRQ_LEGACY;

(Continue reading)

Mikael Kanstrup | 27 May 16:24 2016
Picon
Gravatar

[RFCv2] brcmfmac: Add tracepoints for bcmdhd-dissector tool

Add hexdump tracepoints to be used bcmdhd-dissector:
  https://github.com/kanstrup/bcmdhd-dissector

bcmdhd-dissector is a Wireshark LUA plugin dissector used to decode
protocol data between the brcmfmac driver and the wifi chip firmware.
This includes decoding firmware command requests and responses as
well as events and even tx/rx data interleaved if the data_dump
tracepoint is enabled.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@...>
---
v2:
- Add description of bcmdhd-dissector as suggested by Rafał
- Fix tx/rx data dump.
- Fix tx data dump on USB interface.

Also updated the github project page with some screenshots.

 .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c    |  4 ++
 .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c  |  2 +
 .../wireless/broadcom/brcm80211/brcmfmac/core.c    |  1 +
 .../wireless/broadcom/brcm80211/brcmfmac/debug.c   | 54 ++++++++++++++++++++++
 .../wireless/broadcom/brcm80211/brcmfmac/debug.h   | 15 ++++++
 .../wireless/broadcom/brcm80211/brcmfmac/fweh.c    |  2 +
 .../broadcom/brcm80211/brcmfmac/tracepoint.h       | 33 +++++++++++++
 .../net/wireless/broadcom/brcm80211/brcmfmac/usb.c |  3 ++
 8 files changed, 114 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c
(Continue reading)

Eduardo Abinader | 27 May 13:25 2016

[PATCH] cfg80211: remove extra space on alpha2 definition

Just small adjustment.

Signed-off-by: Eduardo Abinader <eduardo.abinader@...>
---
 net/wireless/reg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 5dbac37..5e3394d 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
 <at>  <at>  -217,7 +217,7  <at>  <at>  static DECLARE_WORK(reg_work, reg_todo);
 /* We keep a static world regulatory domain in case of the absence of CRDA */
 static const struct ieee80211_regdomain world_regdom = {
 	.n_reg_rules = 8,
-	.alpha2 =  "00",
+	.alpha2 = "00",
 	.reg_rules = {
 		/* IEEE 802.11b/g, channels 1..11 */
 		REG_RULE(2412-10, 2462+10, 40, 6, 20, 0),
--

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mohammed Shafi Shajakhan | 27 May 11:05 2016

[PATCH v2] ath10k: Fix 10.4 extended peer stats update

From: Mohammed Shafi Shajakhan <mohammed@...>

10.4 'extended peer stats' will be not be appended with normal peer stats
data and they shall be coming in separate chunks. Fix this by maintaining
a separate linked list 'extender peer stats' for 10.4 and update
rx_duration for per station statistics. Also parse through beacon filter
(if enabled), to make sure we parse the extended peer stats properly.
This issue was exposed when more than one client is connected and
extended peer stats for 10.4 is enabled

The order for the stats is as below
S - standard peer stats, E- extended peer stats, B - beacon filter stats

{S1, S2, S3..} -> {B1, B2, B3..}(if available) -> {E1, E2, E3..}

Fixes: f9575793d44c ("ath10k: enable parsing per station rx duration for 10.4")
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@...>
---

[v1: Fixed line wrap around suggested by Kalle)

 drivers/net/wireless/ath/ath10k/core.h        |    8 ++++
 drivers/net/wireless/ath/ath10k/debug.c       |   18 ++++++++-
 drivers/net/wireless/ath/ath10k/debug.h       |    8 ++--
 drivers/net/wireless/ath/ath10k/debugfs_sta.c |   34 +++++++++++++++-
 drivers/net/wireless/ath/ath10k/wmi.c         |   53 ++++++++++++++++++-------
 drivers/net/wireless/ath/ath10k/wmi.h         |   14 ++++++-
 6 files changed, 115 insertions(+), 20 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
(Continue reading)

Arend van Spriel | 27 May 10:54 2016

[PATCH V6] brcmfmac: print errors if creating interface fails

From: Rafał Miłecki <zajec5@...>

This is helpful for debugging. Without this all I was getting from "iw"
command on failed creating of P2P interface was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafal Milecki <zajec5@...>
[arend@...: reduce error prints upon iface creation]
Signed-off-by: Arend van Spriel <arend@...>
---
V2: s/in/if/ in commit message
V3: Add one more error message as suggested by Arend
V4: Also update brcmf_cfg80211_add_iface & print error for AP
V5: remove error prints from p2p.c
V6: fix compiler warning and remove duplicate calls
---
 .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c  | 16 ++++++++++------
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c   |  2 --
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index d0631b6..2248e8e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
 <at>  <at>  -669,20 +669,24  <at>  <at>  static struct wireless_dev *brcmf_cfg80211_add_iface(struct wiphy *wiphy,
 		return ERR_PTR(-EOPNOTSUPP);
 	case NL80211_IFTYPE_AP:
 		wdev = brcmf_ap_add_vif(wiphy, name, flags, params);
-		if (!IS_ERR(wdev))
-			brcmf_cfg80211_update_proto_addr_mode(wdev);
(Continue reading)

Arend van Spriel | 27 May 10:49 2016

[PATCH V5] brcmfmac: print errors if creating interface fails

From: Rafał Miłecki <zajec5@...>

This is helpful for debugging. Without this all I was getting from "iw"
command on failed creating of P2P interface was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafal Milecki <zajec5@...>
[arend@...: reduce error prints upon iface creation]
Signed-off-by: Arend van Spriel <arend@...>
---
V2: s/in/if/ in commit message
V3: Add one more error message as suggested by Arend
V4: Also update brcmf_cfg80211_add_iface & print error for AP
V5: remove error prints from p2p.c
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 12 ++++++++++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c      |  2 --
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index d0631b6..64ed003 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
 <at>  <at>  -671,18 +671,26  <at>  <at>  static struct wireless_dev *brcmf_cfg80211_add_iface(struct wiphy *wiphy,
 		wdev = brcmf_ap_add_vif(wiphy, name, flags, params);
 		if (!IS_ERR(wdev))
 			brcmf_cfg80211_update_proto_addr_mode(wdev);
-		return wdev;
+		break;
 	case NL80211_IFTYPE_P2P_CLIENT:
(Continue reading)

Avinash Patil | 26 May 20:52 2016

[PATCH] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

This patch adds support for new FullMAC WiFi driver for Quantenna
QSR10G chipsets.

QSR10G is Quantenna's 8x8, 160M, 11ac offering.
QSR10G supports 2 simultaneous WMACs- one 5G and one 2G. 5G WMAC
supports 160M, 8x8 configuration.
FW supports 8 concurrent virtual interfaces on each WMAC.

Patch introduces 2 new drivers- qtnfmac.ko for interfacing with
kernel/cfg80211 and qtnfmac_pcie.ko for PCIe bus interface.

Signed-off-by: Dmitrii Lebed <dlebed-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Sergei Maksimenko <smaksimenko-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Sergey Matyukevich <smatyukevich-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Igor Mitsyanko <imitsyanko-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Bindu Therthala <btherthala-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Huizhao Wang <hwang-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Kamlesh Rath <krath-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
Signed-off-by: Avinash Patil <avinashp-P/7pdk10T0iB+jHODAdFcQ <at> public.gmane.org>
---
 MAINTAINERS                                        |    8 +
 drivers/net/wireless/Kconfig                       |    1 +
 drivers/net/wireless/Makefile                      |    1 +
 drivers/net/wireless/quantenna/Kconfig             |   16 +
 drivers/net/wireless/quantenna/Makefile            |    6 +
 drivers/net/wireless/quantenna/include/bus.h       |  195 ++
 .../wireless/quantenna/include/pcie_regs_pearl.h   |  353 ++++
 drivers/net/wireless/quantenna/include/qlink.h     |  584 ++++++
 .../net/wireless/quantenna/include/qtn_hw_ids.h    |   34 +
 .../net/wireless/quantenna/include/shm_ipc_defs.h  |   46 +
(Continue reading)

Andy Shevchenko | 26 May 16:52 2016
Picon
Gravatar

[PATCH v1 1/1] rtl8xxxu: tuse %*ph to dump buffers

Use %*ph specifier to dump small buffers in hex format instead of doing this
byte-by-byte.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c | 9 ++-------
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 9 ++-------
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 9 ++-------
 3 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
index 2c86b55..eefb7ca 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
 <at>  <at>  -413,13 +413,8  <at>  <at>  static int rtl8192cu_parse_efuse(struct rtl8xxxu_priv *priv)
 		dev_info(&priv->udev->dev,
 			 "%s: dumping efuse (0x%02zx bytes):\n",
 			 __func__, sizeof(struct rtl8192cu_efuse));
-		for (i = 0; i < sizeof(struct rtl8192cu_efuse); i += 8) {
-			dev_info(&priv->udev->dev, "%02x: "
-				 "%02x %02x %02x %02x %02x %02x %02x %02x\n", i,
-				 raw[i], raw[i + 1], raw[i + 2],
-				 raw[i + 3], raw[i + 4], raw[i + 5],
-				 raw[i + 6], raw[i + 7]);
-		}
+		for (i = 0; i < sizeof(struct rtl8192cu_efuse); i += 8)
+			dev_info(&priv->udev->dev, "%02x: %8ph\n", i, &raw[i]);
 	}
 	return 0;
 }
(Continue reading)

Toke Høiland-Jørgensen | 26 May 15:50 2016
Picon

[RFC] ath9k: Measure per-station airtime usage

This is my attempt to add per-station airtime usage accounting to ath9k.
For now I just export it to a new debugfs entry, but my plan is to use
it to make (station) scheduling decisions. However, before attempting
that I would like some feedback from someone more familiar with the
ath9k than me as to whether this way of measuring airtime usage is
likely to give reasonable results.

I realise that there's probably some things I'm missing, but an initial
test run indicates that the values are at least in the right ballpark (I
get a total of ~170k usecs of measured airtime per 200 ms sampling
interval when running three simultaneous TCP streams to three different
stations).

So can anyone comment on whether I'm on the right track here? And
possibly provide some more detail as to what I'm missing and how to
remedy that?

Many thanks in advance,

-Toke

---

diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 5294595..a45faa3 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
 <at>  <at>  -264,6 +264,7  <at>  <at>  struct ath_node {

 #ifdef CONFIG_ATH9K_STATION_STATISTICS
(Continue reading)


Gmane