Discussion of Samsung SoC support in the Linux kernel ()

KyongHo Cho | 1 Oct 2011 01:46

Re: [PATCH v2 3/5] iommu/exynos: Add iommu driver for Exynos4 Platforms

On Fri, Sep 30, 2011 at 9:06 PM, Roedel, Joerg <Joerg.Roedel <at> amd.com> wrote:
> First comment: Pleas remove the 'inline' annotations in this patch. It
> is better to let the compiler decide what to inline and what not.
Ok. Thanks :)

>
> Hmm, may it make sense to store data directly in dev->arch.iommu? This
> will save you the list traversals to get the information.
>
That looks better.
However, adding features to dev_archdata of ARM is actively discussed
in Linaro-mm-sig and the features also include iommu_domain.

On the other hand,
I was not able to determine what will be accepted to the mainline kernel
between Linaro's one that is suggested by Marek and Ohad's one.

>> +
>> +static inline bool set_sysmmu_active(struct sysmmu_drvdata *data)
>> +{
>> +       /* return true if the System MMU was not active previously
>> +          and it needs to be initialized */
>> +
>> +       data->activations++;
>
> Is this variable only accessed under a lock? If not it should be an
> atomic.
>
All 'sysmmu' functions must be called under a lock because a System MMU
(Samsung's IOMMU) is a shared resource.

(Continue reading)

KyongHo Cho | 1 Oct 2011 01:52

Re: [PATCH v2 5/5] iommu/exynos: Use bus_set_iommu instead of register_iommu

On Fri, Sep 30, 2011 at 10:46 PM, Roedel, Joerg <Joerg.Roedel <at> amd.com> wrote:
> On Fri, Sep 30, 2011 at 03:31:49AM -0400, Kukjin Kim wrote:
>> From: KyongHo Cho <pullip.cho <at> samsung.com>
>>
>> This replaces register_iommu() with bus_set_iommu() according to the
>> suggestion of Joerg Roedel.
>
> This should be part of patch 3 already when the bus_set_iommu() change
> is merged. Otherwise it breaks bisectability too.
>
Ok.
Should I include fault handling feature (patch 4) in the patch 3 also?

Thanks.
KyongHo.

Russell King - ARM Linux | 1 Oct 2011 17:29

Picon

Re: [PATCH 1/2] ARM: CLKDEV: Add Common Macro for clk_lookup

On Fri, Sep 30, 2011 at 04:41:36PM +0530, Padmavathi Venna wrote:
> +#define CLKDEV_INIT(d, n, c) \
> +	{ \
> +		.dev_id = d, \
> +		.con_id = n, \
> +		.clk = &c, \
> +	},
> +

As Heartley says, the trailing , and the end should not be there - it
should be with each use of CLKDEV_INIT().  The reasoning is that it
makes the use of macros much more conventional and consistent throughout
the kernel:

struct cl_lookup foo_lookups[] = {
	CLKDEV_INIT(...),
	CLKDEV_INIT(...),
};

struct cl_lookup bar_lookup = CLKDEV_INIT(...);

Could you re-spin with that change please?

Thanks.

Russell King - ARM Linux | 1 Oct 2011 17:31

Picon

Re: [PATCH 2/2] ARM: Switch to using CLKDEV_INIT macro for creating clk_lookup instance

On Fri, Sep 30, 2011 at 01:26:33PM +0200, Hans J. Koch wrote:
> On Fri, Sep 30, 2011 at 04:41:37PM +0530, Padmavathi Venna wrote:
> > Replace platform specific macros that creates struct clk_lookup
> > instance with the new common CLKDEV_INIT macro
> 
> Well, for mach-tcc8k, it only saves 7 lines, but it's surely a good idea to
> have one common macro for all arm subarchs.

The savings are of course likely to be small, but it had two advantages:

1. We're not having one initializer per platform or SoC
2. We have something common which can be grepped for, or sed'd (or whatever
   your favourite in-place editing program) should it need to be changed.

Kukjin Kim | 2 Oct 2011 09:07

RE: [PATCH] ARM: EXYNOS4: Add HPD and PD support for HDMI on Origen

Sachin Kamat wrote:
> 
> This patch adds hot plug detection (HPD) and power domain (PD) support for
HDMI
> on Origen board.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat <at> linaro.org>
> ---
> I have added the KConfig entry and header file required for enabling PD
> since the patch [1] is not yet applied on Kgene's tree [2].
> 
Hmm I don't know why it is missed :(
Anyway, if required, will fix when I applying this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim <at> samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> [1] http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/6763
> [2] https://github.com/kgene/linux-samsung/tree/for-next
> ---
>  arch/arm/mach-exynos4/Kconfig       |    1 +
>  arch/arm/mach-exynos4/mach-origen.c |   14 ++++++++++++++
>  2 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig

(Continue reading)

Kukjin Kim | 2 Oct 2011 09:07

RE: [PATCH] ARM: EXYNOS4: Enable MFC on Origen

Sachin Kamat wrote:
> 
> This patch enables multi-format codec (MFC) support on Origen board.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat <at> linaro.org>
> ---
> PD related code in KConfig and header are added only because for-next
branch of
> Kgene's tree does not have it enabled yet.
> 
> ---
>  arch/arm/mach-exynos4/Kconfig       |    2 ++
>  arch/arm/mach-exynos4/mach-origen.c |   13 +++++++++++++
>  2 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index d0491c2..93f9a62 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
>  <at>  <at>  -243,6 +243,8  <at>  <at>  config MACH_ORIGEN
>  	select S5P_DEV_I2C_HDMIPHY
>  	select S5P_DEV_TV
>  	select S5P_DEV_USB_EHCI
> +	select S5P_DEV_MFC
> +	select EXYNOS4_DEV_PD
>  	select SAMSUNG_DEV_BACKLIGHT
>  	select SAMSUNG_DEV_PWM
>  	select EXYNOS4_SETUP_SDHCI
> diff --git a/arch/arm/mach-exynos4/mach-origen.c
b/arch/arm/mach-exynos4/mach-origen.c

(Continue reading)

Kukjin Kim | 2 Oct 2011 09:07

RE: [PATCH v2] ARM: EXYNOS4: Configure MAX8997 PMIC for Origen

Inderpal Singh wrote:
> 
> From: Inderpal Singh <inderpal.s <at> samsung.com>
> 
> Configure MAX8997 PMIC and provide platform specific data
> for origen.
> 
> Signed-off-by: Inderpal Singh <inderpal.singh <at> linaro.org>
> ---
> Changes from v1:
> 	- Removed soc-audio
> 	- Used macro for GPIO pin
> 	- irq assigned statically
> 	- Rectified mismatches in constraints flags
> 	- Removed assigning of array index
> 
>  arch/arm/mach-exynos4/mach-origen.c |  390
+++++++++++++++++++++++++++++++++++
>  1 files changed, 390 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/mach-origen.c
b/arch/arm/mach-exynos4/mach-origen.c
> index ed59f86..ccd2a55 100644
> --- a/arch/arm/mach-exynos4/mach-origen.c
> +++ b/arch/arm/mach-exynos4/mach-origen.c
>  <at>  <at>  -14,6 +14,9  <at>  <at> 
>  #include <linux/platform_device.h>
>  #include <linux/io.h>
>  #include <linux/input.h>
> +#include <linux/i2c.h>

(Continue reading)

Kukjin Kim | 2 Oct 2011 09:07

RE: [PATCH V2 0/3] S5P64X0 PM Support

Abhilash Kesavan wrote:
> 
> The patchset adds Power Mangement support for S5P64X0. The first
> two patches lay the groundwork for adding PM support, while the
> final patch adds the SoC specific PM code.
> 
> Changes since V1:
> - Changed register naming as per User Manual.
> - Dropped the pm-gpio warning patch as it will be taken care in the gpio
>   movement patch by Kukjin Kim.
> - Used soc_is_* for differentiating between 6440 and 6450.
> - Merged all the sleep files of S5P SoCs while leaving the S3C64XX sleep
>   code as is.
> 
> Abhilash Kesavan (3):
>   ARM: S5P: Make the common S5P PM code conditionally compile
>   ARM: S5P: Make the sleep code common for S5P series SoCs
>   ARM: S5P64X0: Add Power Management support
> 
>  arch/arm/Kconfig                                |    2 +-
>  arch/arm/mach-exynos4/Kconfig                   |    4 +
>  arch/arm/mach-exynos4/Makefile                  |    2 +-
>  arch/arm/mach-s5p64x0/Kconfig                   |    4 +
>  arch/arm/mach-s5p64x0/Makefile                  |    1 +
>  arch/arm/mach-s5p64x0/include/mach/map.h        |    1 +
>  arch/arm/mach-s5p64x0/include/mach/pm-core.h    |  117 +++++++++++++
>  arch/arm/mach-s5p64x0/include/mach/regs-clock.h |   33 ++++
>  arch/arm/mach-s5p64x0/include/mach/regs-gpio.h  |   19 ++
>  arch/arm/mach-s5p64x0/irq-eint.c                |    2 +
>  arch/arm/mach-s5p64x0/irq-pm.c                  |   92 ++++++++++

(Continue reading)

Kukjin Kim | 2 Oct 2011 09:07

RE: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

Rafael J. Wysocki wrote:
> 
> On Saturday, August 13, 2011, Russell King - ARM Linux wrote:
> > On Sat, Aug 13, 2011 at 11:24:07PM +0200, Rafael J. Wysocki wrote:
> > > On Thursday, August 11, 2011, Chanwoo Choi wrote:
> > > > The following patch set use the generic Power domain Framework
instead of
> > > > power domain code depend of Samsung SoC.
> > > >
> > > > Chanwoo Choi (4):
> > > >   ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210
> > > >   ARM: EXYNOS4: Support for generic Clock manipulation PM callbacks
> > > >   ARM: EXYNOS4: Delete the power-domain code depend on Samsung SoC
> > > >   ARM: EXYNOS4: Add power domain to use generic Power domain
Framework
> > > >
> > > >  arch/arm/mach-exynos4/Kconfig                      |   10 +-
> > > >  arch/arm/mach-exynos4/Makefile                     |    4 +-
> > > >  arch/arm/mach-exynos4/dev-pd.c                     |  139
--------------
> > > >  arch/arm/mach-exynos4/include/mach/pm-exynos4210.h |   52 ++++++
> > > >  arch/arm/mach-exynos4/include/mach/regs-clock.h    |    8 +
> > > >  arch/arm/mach-exynos4/mach-nuri.c                  |   21 ++-
> > > >  arch/arm/mach-exynos4/mach-smdkc210.c              |   26 ++-
> > > >  arch/arm/mach-exynos4/mach-smdkv310.c              |   23 ++-
> > > >  arch/arm/mach-exynos4/mach-universal_c210.c        |   21 ++-
> > > >  arch/arm/mach-exynos4/pm-exynos4210.c              |  189
++++++++++++++++++++
> > > >  arch/arm/mach-exynos4/pm-runtime.c                 |   56 ++++++
> > > >  arch/arm/plat-samsung/Kconfig                      |    8 -

(Continue reading)

Kukjin Kim | 2 Oct 2011 09:08

RE: [PATCH 2/4] ARM: EXYNOS4: Support for generic Clock manipulation PM callbacks

Chanwoo Choi wrote:
> 
> Signed-off-by: Chanwoo Choi <cw00.choi <at> samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park <at> samsung.com>
> ---
>  arch/arm/mach-exynos4/Makefile     |    2 +-
>  arch/arm/mach-exynos4/pm-runtime.c |   56 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 57 insertions(+), 1 deletions(-)
>  create mode 100644 arch/arm/mach-exynos4/pm-runtime.c
> 
> diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
> index 97c31ce..28cdb8b 100644
> --- a/arch/arm/mach-exynos4/Makefile
> +++ b/arch/arm/mach-exynos4/Makefile
>  <at>  <at>  -5,7 +5,7  <at>  <at> 
>  #
>  # Licensed under GPLv2
> 
> -obj-y				:=
> +obj-y				:= pm-runtime.o

To move under depending CONFIG_ARCH_EXYNOS4 like others is better.

>  obj-m				:=
>  obj-n				:=
>  obj-				:=
> diff --git a/arch/arm/mach-exynos4/pm-runtime.c b/arch/arm/mach-exynos4/pm-runtime.c
> new file mode 100644
> index 0000000..4fe9f73
> --- /dev/null

(Continue reading)

Group

gmane.linux.kernel.samsung-soc.

Advertisement

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 37

Articles in period: 369

October 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH V6 2/3] ARM: EXYNOS: Enable PCIe support for Exynos5440 (20 Jun 2013)
[PATCH V6 1/3] pci: Add PCIe driver for Samsung Exynos (20 Jun 2013)
[PATCH v2 0/5] DT/ARCH updates for MFC (20 Jun 2013)
[PATCH] ARM: dts: Add device tree support for dwmmc (20 Jun 2013)
[PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem (20 Jun 2013)
[PATCH] spi/s3c64xx: Make wait_for_timeout() function name less generi (19 Jun 2013)
[PATCH] ARM: dts: Add basic dts for Exynos4412-based Trats 2 board (19 Jun 2013)
[GIT PULL 2/2] Samsung CLK update for v3.11 (19 Jun 2013)
[GIT PULL 1/2] Samsung EXYNOS5420 PINCTRL for v3.11 (19 Jun 2013)
[GIT PULL 0/2] Samsung 3rd pull-request for v3.11 (19 Jun 2013)
[PATCH v6 0/7] Add generic set_rate clk_ops for PLL35xx and PLL36xx fo (10 Jun 2013)
[PATCH v3 0/3] exynos5420/hdmi: add support for hdmi subsystem (19 Jun 2013)
[PATCH] ARM: dts: Update range for vdd_arm on EXYNOS4412-origen board (19 Jun 2013)
[PATCH 1/3] ARM: dts: Add MFC clock entry for 5250 (19 Jun 2013)
[PATCH V3 0/2] Add pinctrl support to Exynos5420 (19 Jun 2013)
[PATCH v2 2/4] drm/exynos: add support for exynos5420 mixer (19 Jun 2013)
[GIT PULL 10/10] Samsung non-critical-fixes-1 for v3.11 (18 Jun 2013)
[GIT PULL 09/10] Samsung exynos_defconfig for v3.11 (18 Jun 2013)
[GIT PULL 08/10] Samsung SoC EXYNOS5420 for v3.11 (18 Jun 2013)
[GIT PULL 07/10] Samsung S3C24XX PINCTRL-2 for v3.11 (18 Jun 2013)
[GIT PULL 06/10] Samsung non-DT EXYNOS for v3.11 (18 Jun 2013)

Archives

784	June 2013
424	May 2013
699	April 2013
646	March 2013
518	February 2013
653	January 2013
308	December 2012
571	November 2012
434	October 2012
483	September 2012
372	August 2012
419	July 2012
148	June 2012
344	May 2012
260	April 2012
513	March 2012
380	February 2012
445	January 2012
586	December 2011
271	November 2011
369	October 2011
483	September 2011
362	August 2011
519	July 2011
500	June 2011
145	May 2011
171	April 2011
252	March 2011
128	February 2011
99	January 2011
226	December 2010
80	November 2010
357	October 2010
309	September 2010
226	August 2010
458	July 2010
259	June 2010
541	May 2010
16	April 2010
69	March 2010
8	February 2010
412	January 2010
74	December 2009
243	November 2009
55	October 2009
2	September 2009

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template