Discussion of Samsung SoC support in the Linux kernel ()

Kukjin Kim | 1 Oct 2009 11:22

[PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

Fix the values of S3C6400_EPLL_MDIV_MASK, S3C6400_EPLL_PDIV_MASK, and
S3C6400_EPLL_SDIV_MASK.

Signed-off-by: Kukjin Kim <kgene.kim <at> samsung.com>
---
 arch/arm/plat-s3c64xx/include/plat/pll.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/plat-s3c64xx/include/plat/pll.h b/arch/arm/plat-s3c64xx/include/plat/pll.h
index 90bbd72..3a59d3b 100644
--- a/arch/arm/plat-s3c64xx/include/plat/pll.h
+++ b/arch/arm/plat-s3c64xx/include/plat/pll.h
 <at>  <at>  -37,9 +37,9  <at>  <at>  static inline unsigned long s3c6400_get_pll(unsigned long baseclk,
 	return (unsigned long)fvco;
 }

-#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16)) - 1)
-#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8)) - 1)
-#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0)) - 1)
+#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16+1)) - 1)
+#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8+1)) - 1)
+#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0+1)) - 1)
 #define S3C6400_EPLL_MDIV_SHIFT	(16)
 #define S3C6400_EPLL_PDIV_SHIFT	(8)
 #define S3C6400_EPLL_SDIV_SHIFT	(0)
--

-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in

(Continue reading)

jassi brar | 1 Oct 2009 12:42

Picon

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim <at> samsung.com> wrote:
> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>  #define S3C6400_EPLL_SDIV_SHIFT        (0)

dunno it it's a problem but please checkout it out ....
http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mark Brown | 1 Oct 2009 14:52

Re: [PATCH 0/5] S3C: sdhci: Update Samsung 6410 SDHCI driver.

On Tue, Sep 29, 2009 at 12:18:22AM +0000, THOMAS P ABRAHAM wrote:

> It has been decided that the patches will be submitted to the
> linux-samsung-soc mailing list for initial review. After all comments
> are addressed, the patches will be submitted to Ben and
> linux-arm-kernel mailing list. This will help to resolve any simple
> issues which otherwise Ben will have to spend time looking into.

Could you clarify what the policy is here?  I've noticed that some of
the patches posted to this list are being sent to Ben directly which
seems to work against the goal of cleaning stuff up pre-submission.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

jassi brar | 1 Oct 2009 15:19

Picon

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

On Thu, Oct 1, 2009 at 7:42 PM, jassi brar <jassisinghbrar <at> gmail.com> wrote:
> On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim <at> samsung.com> wrote:
>> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
>> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
>> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
>> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
>> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
>> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>>  #define S3C6400_EPLL_SDIV_SHIFT        (0)
>
> dunno it it's a problem but please checkout it out ....
> http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
Never mind. The patch seems fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Kukjin Kim | 2 Oct 2009 06:48

RE: [PATCH 0/5] S3C: sdhci: Update Samsung 6410 SDHCI driver.

Hi Mark Brown,

On Thu, Oct 01, 2009 at 21:53PM +0900, Mark Brown wrote:
> On Tue, Sep 29, 2009 at 12:18:22AM +0000, THOMAS P ABRAHAM wrote:
> 
> > It has been decided that the patches will be submitted to the
> > linux-samsung-soc mailing list for initial review. After all comments
> > are addressed, the patches will be submitted to Ben and
> > linux-arm-kernel mailing list. This will help to resolve any simple
> > issues which otherwise Ben will have to spend time looking into.
> 
> Could you clarify what the policy is here?  I've noticed that some of
> the patches posted to this list are being sent to Ben directly which
> seems to work against the goal of cleaning stuff up pre-submission.

My name is Kukjin Kim.
I work for Samsung Electronics, System LSI division which makes Samsung SoCs
(e.g. S3C24XX, S3C6410, S5PC100, ...).

My team want to submit/push (new) Samsung SoCs' linux codes to mainline.

We need to do sufficient review of the patches with many developers who
interested in Samsung SoCs before we submit it to linux-arm-kernel mailing
list.
The policy is submit to linux-arm-kernel mailing list after review is
complete at linux-samsung-soc mailing list.

We (Samsung System LSI) had a meeting with Ben Dooks and Harald Welte at
Samsung, and decided this model.
Samsung System LSI will continue to use this model.

(Continue reading)

Harald Welte | 2 Oct 2009 09:48

Re: [PATCH 0/5] S3C: sdhci: Update Samsung 6410 SDHCI driver.

Hi Mark,

On Thu, Oct 01, 2009 at 01:52:39PM +0100, Mark Brown wrote:

> Could you clarify what the policy is here?  I've noticed that some of
> the patches posted to this list are being sent to Ben directly which
> seems to work against the goal of cleaning stuff up pre-submission.

see Kukjin Kim's explanation.  The point of this mailinglist is mainly to make
sure the actual maintainers (like Ben) already get patches that have some level
of review, and they don't have to both with things like incomplete commit
messages, whitespace changes, or other things that are "obvious" to people with
more mainline experience.

Once that has been achieved, the patches should be forwarded to Ben and
linux-arm-kernel (or whatever other apropriate mailinglist/maintainer depending
on the files the patch touches) for actual merging.

The fact that Ben has decided to also hang out on this list and spend some
of his time on review is of course great, but we cannot be sure how much time
he can dedicate to this.  The amount of code that Samsung System LSI needs
to push is very big, and not everything is already in as good a shape as the
patches that you have seen so far.

Regards,
--

-- 
- Harald Welte <laforge <at> gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

(Continue reading)

Mark Brown | 2 Oct 2009 12:19

Re: [PATCH 0/5] S3C: sdhci: Update Samsung 6410 SDHCI driver.

On Fri, Oct 02, 2009 at 01:48:03PM +0900, Kukjin Kim wrote:

> When required, Ben can be copied in the email if Ben's attention is required
> for the patch.

So the intention is still to also send things via the normal routes to
the subsystems?  The reason I asked for clarification was that one of
the patches was an isolated patch (not part of a series) - the only
difference from a normal patch submission was that linux-arm-kernel had
been replaced with this list.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mark Brown | 7 Oct 2009 13:12

Samsung git trees?

I'd been following the Samsung kernel tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/kki_ap/linux-2.6-samsung.git

but that seems to have been removed from kernel.org, as have the older
samsung-ap trees which were there.  Is there a new tree somewhere which
we should be following to see the latest work in progress stuff?  I
can't see anything obvious on kernel.org or the Samsung site.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

thomas.ab | 8 Oct 2009 08:28

[PATCH 0/7] S3C64XX: Add platform support for Samsung S3C IDE controller driver

From: Thomas Abraham <thomas.ab <at> samsung.com>

This patch set adds platform support for Samsung's S3C IDE controller 
driver. This patch set includes the following patches.

[PATCH 1/7] S3C64XX: Add physical address definition for Compact Flash controller
[PATCH 2/7] S3C64XX: Add MEM_SYS_CFG register definition
[PATCH 3/7] S3C64XX: Add IDE controller register definitions
[PATCH 4/7] S3C64XX: Add clock source definition for IDE controller
[PATCH 5/7] S3C64XX: Add platform data and driver resources for IDE controller driver
[PATCH 6/7] S3C6410: Add platform data for S3C IDE controller driver
[PATCH 7/7] S3C64XX: Include IDE device code in compilation

Signed-off-by: Abhilash Kesavan <a.kesavan <at> samsung.com>
Signed-off-by: Thomas Abraham <thomas.ab <at> samsung.com>
--

-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

thomas.ab | 8 Oct 2009 08:32

[PATCH 1/7] S3C64XX: Add physical address definition for Compact Flash controller.

From: Thomas Abraham <thomas.ab <at> samsung.com>

This patch adds the physical address definition and length of address
space for Compact Flash controller (IDE) module.

Signed-off-by: Abhilash Kesavan <a.kesavan <at> samsung.com>
Signed-off-by: Thomas Abraham <thomas.ab <at> samsung.com>
---
 arch/arm/mach-s3c6400/include/mach/map.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
index fc8b223..c1f3dd5 100644
--- a/arch/arm/mach-s3c6400/include/mach/map.h
+++ b/arch/arm/mach-s3c6400/include/mach/map.h
 <at>  <at>  -80,4 +80,8  <at>  <at> 
 #define S3C_PA_USBHOST		S3C64XX_PA_USBHOST
 #define S3C_PA_USB_HSOTG	S3C64XX_PA_USB_HSOTG

+/* CF controller */
+#define S3C64XX_PA_CFCON	(0x70300000)
+#define S3C64XX_SZ_CFCON	SZ_1M
+
 #endif /* __ASM_ARCH_6400_MAP_H */
--

-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org

(Continue reading)

Group

gmane.linux.kernel.samsung-soc.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6

Articles in period: 55

October 2009

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[GIT PULL] Samsung fixes-3 for v3.10 (25 May 2013)
[RESEND PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36X (24 May 2013)
[RESEND PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36X (24 May 2013)
[RESEND PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36X (24 May 2013)
[PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36XX for s (24 May 2013)
[PATCH] ARM: EXYNOS: fix software reset logic for EXYNOS5440 SOC (23 May 2013)
[PATCH] ARM: EXYNOS: add __cpuinit annotation to write_pen_release() (22 May 2013)
общедоступнее нежели У нас сие задаро� (22 May 2013)
[PATCH] clk: Exynos5250: Add clocks for G3D (21 May 2013)
[PATCH] clk: Exynos5250: Fix HDMI clock number in documentation (21 May 2013)
[GIT PULL] Samsung fixes-2 for v3.10 (20 May 2013)
скоро обратить надежду в вещественнос (20 May 2013)
[RFC 0/2] clk: samsung: add composite clocks (20 May 2013)
[PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU (20 May 2013)
Значительный миг (20 May 2013)
[PATCH 0/6] Samsung watchdog support clean-up (19 May 2013)
[PATCH] ARM: s5p64x0: Use common uncompress.h part for plat-samsung (19 May 2013)
[PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, par (17 May 2013)
[PATCH 0/2] Fix suspend/resume issues created by pinmux on exynos (16 May 2013)
[PATCH v2 0/6] Samsung USB PHY SoC support cleanup (16 May 2013)
Pulls and drive strengths in the pinctrl world (15 May 2013)

Archives

342	May 2013
699	April 2013
646	March 2013
518	February 2013
653	January 2013
308	December 2012
571	November 2012
434	October 2012
483	September 2012
372	August 2012
419	July 2012
148	June 2012
344	May 2012
260	April 2012
513	March 2012
380	February 2012
445	January 2012
586	December 2011
271	November 2011
369	October 2011
483	September 2011
362	August 2011
519	July 2011
500	June 2011
145	May 2011
171	April 2011
252	March 2011
128	February 2011
99	January 2011
226	December 2010
80	November 2010
357	October 2010
309	September 2010
226	August 2010
458	July 2010
259	June 2010
541	May 2010
16	April 2010
69	March 2010
8	February 2010
412	January 2010
74	December 2009
243	November 2009
55	October 2009
2	September 2009

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template