headers
jassi brar | 30 Sep 2009 04:36
Picon

clock sourcing suggestion

Hi,

 I2S audio-bus[0,1] in s3c6410 can source clock, among other options,
 from dedicated pcm_cdclk[0,1] respectively.
 Whereas in s3c6400, both I2S audio-bus[0,1]  share one common pcm_cdclk.

The arch/arm/plat-s3c64xx/s3c6400-clock.c  makes audio-bus-0,1 share the same
pcm_cdclk(s3c6400 case).

Should we use #ifdef CPU_S3C6410 to assign proper clock sources ?
But I am afraid that might come in the way of building common kernel
for 6400 and 6410.

What should be the solution, please suggest?
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Ben Dooks | 30 Sep 2009 23:13

Re: clock sourcing suggestion

On Wed, Sep 30, 2009 at 11:36:27AM +0900, jassi brar wrote:
> Hi,
> 
>  I2S audio-bus[0,1] in s3c6410 can source clock, among other options,
>  from dedicated pcm_cdclk[0,1] respectively.
>  Whereas in s3c6400, both I2S audio-bus[0,1]  share one common pcm_cdclk.
> 
> The arch/arm/plat-s3c64xx/s3c6400-clock.c  makes audio-bus-0,1 share the same
> pcm_cdclk(s3c6400 case).
> 
> Should we use #ifdef CPU_S3C6410 to assign proper clock sources ?
> But I am afraid that might come in the way of building common kernel
> for 6400 and 6410.
> 
> What should be the solution, please suggest?

A quick think would suggest two solutions:

1) Change the clocks before registering in the relevant init function

2) Moving those clocks out of the common clock code and registering
   s3c6400 version in s3c6400 clock setup and s3c6410 in s3c6410 clock
   setup.

I can have a look tommorow at the code if any further info is required.

(2) is probably the best thing to do.

--

-- 
Ben
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kukjin Kim | 1 Oct 2009 11:22

[PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

Fix the values of S3C6400_EPLL_MDIV_MASK, S3C6400_EPLL_PDIV_MASK, and
S3C6400_EPLL_SDIV_MASK.

Signed-off-by: Kukjin Kim <kgene.kim <at> samsung.com>
---
 arch/arm/plat-s3c64xx/include/plat/pll.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/plat-s3c64xx/include/plat/pll.h b/arch/arm/plat-s3c64xx/include/plat/pll.h
index 90bbd72..3a59d3b 100644
--- a/arch/arm/plat-s3c64xx/include/plat/pll.h
+++ b/arch/arm/plat-s3c64xx/include/plat/pll.h
 <at>  <at>  -37,9 +37,9  <at>  <at>  static inline unsigned long s3c6400_get_pll(unsigned long baseclk,
 	return (unsigned long)fvco;
 }

-#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16)) - 1)
-#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8)) - 1)
-#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0)) - 1)
+#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16+1)) - 1)
+#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8+1)) - 1)
+#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0+1)) - 1)
 #define S3C6400_EPLL_MDIV_SHIFT	(16)
 #define S3C6400_EPLL_PDIV_SHIFT	(8)
 #define S3C6400_EPLL_SDIV_SHIFT	(0)
--

-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
(Continue reading)

Permalink | Reply | 2 comments |
headers
jassi brar | 1 Oct 2009 12:42
Picon

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim <at> samsung.com> wrote:
> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>  #define S3C6400_EPLL_SDIV_SHIFT        (0)

dunno it it's a problem but please checkout it out ....
http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Mark Brown | 1 Oct 2009 14:52
Favicon
Gravatar

Re: [PATCH 0/5] S3C: sdhci: Update Samsung 6410 SDHCI driver.

On Tue, Sep 29, 2009 at 12:18:22AM +0000, THOMAS P ABRAHAM wrote:

> It has been decided that the patches will be submitted to the
> linux-samsung-soc mailing list for initial review. After all comments
> are addressed, the patches will be submitted to Ben and
> linux-arm-kernel mailing list. This will help to resolve any simple
> issues which otherwise Ben will have to spend time looking into.

Could you clarify what the policy is here?  I've noticed that some of
the patches posted to this list are being sent to Ben directly which
seems to work against the goal of cleaning stuff up pre-submission.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 3 comments |
headers
jassi brar | 1 Oct 2009 15:19
Picon

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

On Thu, Oct 1, 2009 at 7:42 PM, jassi brar <jassisinghbrar <at> gmail.com> wrote:
> On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim <at> samsung.com> wrote:
>> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
>> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
>> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
>> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
>> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
>> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>>  #define S3C6400_EPLL_SDIV_SHIFT        (0)
>
> dunno it it's a problem but please checkout it out ....
> http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
Never mind. The patch seems fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |

Gmane