headers
Adrian Hunter | 1 Jul 2010 12:18
Picon

Re: [PATCH V3 4/5] block: Add secure discard

Andrew Morton wrote:
> On Thu, 24 Jun 2010 11:44:23 +0300
> Adrian Hunter <adrian.hunter <at> nokia.com> wrote:
> 
>> >From b25b9a499f255ee5999c219525d82ef40382318c Mon Sep 17 00:00:00 2001
>> From: Adrian Hunter <adrian.hunter <at> nokia.com>
>> Date: Wed, 23 Jun 2010 15:41:38 +0300
>> Subject: [PATCH 4/5] block: Add secure discard
>>
>> Secure discard is the same as discard except that all copies
>> of the discarded sectors (perhaps created by garbage collection)
>> must also be erased.
> 
> That's not an awfully informative changelog.
> 
>>From a quick peek at the code it seems that you took your earlier
> design sketch:
> 
> On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote:
>> Needs a bio flag, a request flag, setup the request flag based on the
>> bio flag, prevent merging secure and non-secure discards, prevent drivers
>> doing non-secure discards for secure discards.
>>
>> Seems like a lot of little changes for something that no one wants.
>> Shouldn't it wait for someone to need it first?
> 
> and changed your mind and implemented it.
> 
> Is that a correct interpretation?
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Adrian Hunter | 1 Jul 2010 12:49
Picon

Re: [PATCH V3 1/5] mmc: Add erase, secure erase, trim and secure trim operations

Andrew Morton wrote:
> On Thu, 24 Jun 2010 11:44:00 +0300
> Adrian Hunter <adrian.hunter <at> nokia.com> wrote:
> 
>> SD/MMC cards tend to support an erase operation.  In addition,
>> eMMC v4.4 cards can support secure erase, trim and secure trim
>> operations that are all variants of the basic erase command.
> 
> The patch proposes a new userspace interface via sysfs, yes?
,
Just two read-only values

> 
> Please fully describe that interface and its operation in the
> changelog.  It'd also be nice to add permanent documentation for it.
> 

OK

>>From reading the code, it appears that erase_size and
> preferred_erase_size have units in bytes.  But users shouldn't need to
> read the code to find that out.  What are the alignemnt and size
> requirements on these?  What is their position in /sys?  What do they
> actually *do* and what is the difference between them?
> 
> etetera.  People want to review this code and other people actually
> want to use it.  I'm not sure that I want to try to review this code
> when nobody's told me what interface it implements and how it's
> supposed to work.  Seems that whoever implemented BLKDISCARD didn't
> want anyone to use it either.  Sigh.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Jul 2010 14:32
Gravatar

Re: [PATCH v5 1/2] OMAP HSMMC: Adding a Flag to determine the type of Card detect

* kishore kadiyala <kishorek.kadiyala <at> gmail.com> [100621 09:49]:
> On Fri, Jun 18, 2010 at 1:49 AM, Andrew Morton
> <akpm <at> linux-foundation.org> wrote:
> > On Thu, 17 Jun 2010 20:56:58 +0530 (IST)
> > "kishore kadiyala" <kishore.kadiyala <at> ti.com> wrote:
> >
> >> --- a/arch/arm/plat-omap/include/plat/mmc.h
> >> +++ b/arch/arm/plat-omap/include/plat/mmc.h
> >>  <at>  <at>  -43,6 +43,9  <at>  <at> 
> >>
> >>  #define OMAP_MMC_MAX_SLOTS   2
> >>
> >> +#define NON_GPIO             0
> >> +#define GPIO                 1
> >
> > I'm counting about seven different definitions of "GPIO" in the kernel
> > already.
> >
> > drivers/hwmon/it87.c:
> > #define GPIO    0x07
> >
> > drivers/media/dvb/dvb-usb/ec168.h:
> >        GPIO                 = 0x04,
> >
> > drivers/net/hamachi.c:
> >        GPIO=0x6E
> >
> > drivers/staging/rtl8187se/r8180_hw.h:
> > #define GPIO 0x91
> >
(Continue reading)

Permalink | Reply | 0 comments |
headers
Lars-Peter Clausen | 1 Jul 2010 17:47
Picon

Re: [PATCH v3] MMC: Add JZ4740 mmc driver


Matt Fleming wrote:
> On Mon, 28 Jun 2010 03:20:41 +0200, Lars-Peter Clausen <lars <at> metafoo.de> wrote:
>> This patch adds support for the mmc controller on JZ4740 SoCs.
>>
>> Signed-off-by: Lars-Peter Clausen <lars <at> metafoo.de>
>> Cc: Andrew Morton <akpm <at> linux-foundation.org>
>> Cc: Matt Fleming <matt <at> console-pimps.org>
>> Cc: linux-mmc <at> vger.kernel.org
>>
>> ---
>> Changes since v1
>> - Do not request IRQ with IRQF_DISABLED since it is a noop now
>> - Use a generous slack for the timeout timer. It does not need to be accurate.
>> Changes since v2
>> - Use sg_mapping_to iterate over sg elements in mmc read and write functions
>> - Use bitops instead of a spinlock and a variable for testing whether a request
>>   has been finished.
>> - Rework irq and timeout handling in order to get rid of locking in hot paths
> 
> Acked-by: Matt Fleming <matt <at> console-pimps.org>
> 
> Are you planning on maintaining this driver? If so, it'd be a good idea
> to update MAINTAINERS.

Hi

Thanks for reviewing the patch.
I guess I should send a MAINTAINERS patch which adds entries for all of the JZ4740
drivers.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Morton | 1 Jul 2010 22:48

Re: [PATCH 3/3] sdhci-pltfm: Add support for CNS3xxx SoC devices

On Fri, 25 Jun 2010 22:06:44 +0400
Anton Vorontsov <avorontsov <at> mvista.com> wrote:

> There's nothing special, just SoC-specific ops and quirks.
> 
> ...
>
> +static void sdhci_cns3xxx_set_clock(struct sdhci_host *host, unsigned int clock)
> +{
> +	struct device *dev = mmc_dev(host->mmc);
> +	int div = 1;
> +	u16 clk;
> +	unsigned long timeout;
> +
> +	if (clock == host->clock)
> +		return;

I assume that mmc core prevents this function from being exectued twice
at the same time?

> +	sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
> +
> +	if (clock == 0)
> +		goto out;
> +
> +	while (host->max_clk / div > clock) {
> +		/*
> +		 * On CNS3xxx divider grows linearly up to 4, and then
> +		 * exponentially up to 256.
> +		 */
(Continue reading)

Permalink | Reply | 1 comment |
headers
akpm | 2 Jul 2010 00:31

+ omap-pandora-pass-wl1251-information-to-sdio-core.patch added to -mm tree


The patch titled
     omap: pandora: pass wl1251 information to SDIO core
has been added to the -mm tree.  Its filename is
     omap-pandora-pass-wl1251-information-to-sdio-core.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: omap: pandora: pass wl1251 information to SDIO core
From: Grazvydas Ignotas <notasas <at> gmail.com>

Pandora has TI WL1251 attached on MMC3, which is non-standard SDIO chip.
Make use MMC_QUIRK_NONSTD_SDIO to tell SDIO core about it.

Signed-off-by: Grazvydas Ignotas <notasas <at> gmail.com>
Cc: Adrian Hunter <adrian.hunter <at> nokia.com>
Cc: Tony Lindgren <tony <at> atomide.com>
Cc: Bob Copeland <me <at> bobcopeland.com>
(Continue reading)

Permalink | Reply | 0 comments |
headers
akpm | 2 Jul 2010 00:31

+ omap_hsmmc-add-init_card-pass-through-callback.patch added to -mm tree


The patch titled
     omap_hsmmc: add init_card pass-through callback
has been added to the -mm tree.  Its filename is
     omap_hsmmc-add-init_card-pass-through-callback.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: omap_hsmmc: add init_card pass-through callback
From: Grazvydas Ignotas <notasas <at> gmail.com>

This will allow us to set up special cards in machine drivers just after
they are detected by MMC core.

Signed-off-by: Grazvydas Ignotas <notasas <at> gmail.com>
Cc: Adrian Hunter <adrian.hunter <at> nokia.com>
Cc: Tony Lindgren <tony <at> atomide.com>
Cc: Bob Copeland <me <at> bobcopeland.com>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Madhav | 2 Jul 2010 14:50

sdhci clock gating support

From 1917452ca1fcbb6ba52916b7535f453d86d55a1c Mon Sep 17 00:00:00 2001
From: Madhav Singh <singh.madhav <at> samsung.com>,Nitish 
Ambastha<nitish.a <at> samsung.com>
Date: Fri, 2 Jul 2010 17:28:57 +0530
Subject: [PATCH] sdhci-clk-gating-support
This patch implements clock gating support in sdhci layer.It will enable the 
clock when
host controller start sending request to attached device and will disable it 
once it
finish the command.

Signed-off-by:Madhav Chauhan <singh.madhav <at> samsung.com>, Nitish 
Ambastha<nitish.a <at> samsung.com>
Signed-off-by:Kyungmin Park <kyungmin.park <at> samsung.com>
---
 drivers/mmc/host/sdhci.c |   34 ++++++++++++++++++++++++++++++++++
 drivers/mmc/host/sdhci.h |    8 ++++++++
 2 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index c6d1bd8..54f606e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
 <at>  <at>  -1102,6 +1102,8  <at>  <at>  static void sdhci_request(struct mmc_host *mmc, struct 
mmc_request *mrq)
  host = mmc_priv(mmc);

  spin_lock_irqsave(&host->lock, flags);
+
+ sdhci_clk_enable(host);  /*Enable clock here as actual transfer starts
(Continue reading)

Permalink | Reply | 1 comment |
headers
Chris Ball | 2 Jul 2010 16:10
Favicon
Gravatar

Re: sdhci clock gating support

Hi Madhav,

The patch is extremely whitespace-damaged, and your code is also
formatted incorrectly.

Some general points:
 * have you measured whether there's a performance impact from
   bringing the clock up and down for every request?

 * I'd expect this to be implemented as an MMC capability, so
   that it can be avoided on specific controllers.

Thanks,

- Chris.
--

-- 
Chris Ball   <cjb <at> laptop.org>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
MADHAV SINGHCHAUHAN | 2 Jul 2010 16:15

[PATCH RESEND] sdhci-clk-gating-support

I fixed the all issues after running checkpatch.pl and resending it.

From 1fae693a2eef37d878066b09c89f95f57f945f64 Mon Sep 17 00:00:00 2001
From: Madhav Singh <singh.madhav <at> samsung.com>
Date: Fri, 2 Jul 2010 19:33:19 +0530
Subject: [PATCH] sdhci-clk-gating-support
 This patch implements clock gating support in sdhci layer.It will enable the clock when
 host controller start sending request to attached device and will disable it once it
 finish the command.

Signed-off-by: Madhav Chauhan <singh.madhav <at> samsung.com> , Nitish Ambastha <nitish.a <at> samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park <at> samsung.com>
---
 drivers/mmc/host/sdhci.c |   34 ++++++++++++++++++++++++++++++++++
 drivers/mmc/host/sdhci.h |    7 +++++++
 2 files changed, 41 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index c6d1bd8..37ed265 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
 <at>  <at>  -1103,6 +1103,8  <at>  <at>  static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
 
 	spin_lock_irqsave(&host->lock, flags);
 
+	sdhci_clk_enable(host);	/*Enable clock as transfer starts now*/
+
 	WARN_ON(host->mrq != NULL);
 
 #ifndef SDHCI_USE_LEDS_CLASS
(Continue reading)

Permalink | Reply | 2 comments |

Gmane