headers
Minchan Kim | 1 Sep 2009 01:29
Picon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

On Mon, 31 Aug 2009 15:54:01 -0700
Vincent Li <macli <at> brc.ubc.ca> wrote:

> commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> sc->isolate_pages() return value properly. Add similar proper return value check for
> shrink_active_list() sc->isolate_pages().
> 
> Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>
Reviewed-by: Minchan Kim <minchan.kim <at> gmail.com>

You should have write down your patch's effect clearly
in changelog although it's easy. ;-)

--

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo <at> kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont <at> kvack.org"> email <at> kvack.org </a>
Permalink | Reply | 4 comments |
headers
Rik van Riel | 1 Sep 2009 01:42
Picon
Favicon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

Vincent Li wrote:
> commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> sc->isolate_pages() return value properly. Add similar proper return value check for
> shrink_active_list() sc->isolate_pages().
> 
> Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>

Acked-by: Rik van Riel <riel <at> redhat.com>

--

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo <at> kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont <at> kvack.org"> email <at> kvack.org </a>
Permalink | Reply | 0 comments |
headers
KAMEZAWA Hiroyuki | 1 Sep 2009 01:46
Favicon

Re: [RFC][PATCH 0/4] memcg: add support for hwpoison testing

On Mon, 31 Aug 2009 18:26:40 +0800
Wu Fengguang <fengguang.wu <at> intel.com> wrote:

> Hi all,
> 
> In hardware poison testing, we want to inject hwpoison errors to pages
> of a collection of selected tasks, so that random tasks (eg. init) won't
> be killed in stress tests and lead to test failure.
> 
> Memory cgroup provides an ideal tool for tracking and testing these target
> process pages. All we have to do is to
> - export the memory cgroup id via cgroupfs
> - export two functions/structs for hwpoison_inject.c
> 
> This might be an unexpected usage of memory cgroup. The last patch and this
> script demonstrates how the exported interfaces are to be used to limit the
> scope of hwpoison injection.
> 
> 	test -d /cgroup/hwpoison && rmdir /cgroup/hwpoison
> 	mkdir /cgroup/hwpoison
> 
> 	usemem -m 100 -s 100 &   # eat 100MB and sleep 100s
> 	echo `pidof usemem` > /cgroup/hwpoison/tasks
> 
> ==>     memcg_id=$(</cgroup/hwpoison/memory.id)
> ==>     echo $memcg_id > /debug/hwpoison/corrupt-filter-memcg
> 
> 	# hwpoison all pfn
> 	pfn=0
> 	while true
(Continue reading)

Permalink | Reply | 0 comments |
headers
Vincent Li | 1 Sep 2009 02:01
Picon
Picon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

On Tue, 1 Sep 2009, Minchan Kim wrote:

> On Mon, 31 Aug 2009 15:54:01 -0700
> Vincent Li <macli <at> brc.ubc.ca> wrote:
> 
> > commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> > sc->isolate_pages() return value properly. Add similar proper return value check for
> > shrink_active_list() sc->isolate_pages().
> > 
> > Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>
> Reviewed-by: Minchan Kim <minchan.kim <at> gmail.com>
> 
> You should have write down your patch's effect clearly
> in changelog although it's easy. ;-)

Yes, I should have. This patch is inspired by Kosaki's patch, I 
thought mentioning that commit would make this patch as follow-up work and 
changelog clear enough. Would following changelog ok?

----
Add proper return value check for shrink_active_list() 
sc->isolate_pages(). 

When "nr_taken == 0"
	1: nr_scan related statistics should still be caculated.
	2: jump to the end of function and release zone->lru_lock.
----
Regards,

Vincent Li
(Continue reading)

Permalink | Reply | 3 comments |
headers
Minchan Kim | 1 Sep 2009 02:12
Picon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

On Mon, 31 Aug 2009 17:01:03 -0700 (PDT)
Vincent Li <macli <at> brc.ubc.ca> wrote:

> On Tue, 1 Sep 2009, Minchan Kim wrote:
> 
> > On Mon, 31 Aug 2009 15:54:01 -0700
> > Vincent Li <macli <at> brc.ubc.ca> wrote:
> > 
> > > commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> > > sc->isolate_pages() return value properly. Add similar proper return value check for
> > > shrink_active_list() sc->isolate_pages().
> > > 
> > > Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>
> > Reviewed-by: Minchan Kim <minchan.kim <at> gmail.com>
> > 
> > You should have write down your patch's effect clearly
> > in changelog although it's easy. ;-)
> 
> Yes, I should have. This patch is inspired by Kosaki's patch, I 
> thought mentioning that commit would make this patch as follow-up work and 
> changelog clear enough. Would following changelog ok?
> 
> ----
> Add proper return value check for shrink_active_list() 
> sc->isolate_pages(). 
> 
> When "nr_taken == 0"
> 	1: nr_scan related statistics should still be caculated.
> 	2: jump to the end of function and release zone->lru_lock.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jeremy Fitzhardinge | 1 Sep 2009 02:29
Gravatar

Re: [PATCH] x86: reuse the boot-time mappings of fixed_addresses

On 08/31/09 01:26, Ingo Molnar wrote:
>>> I'm wondering, how much space do we save this way, on a typical bootup 
>>> on a typical PC?
>>>
>>>       
>> Not a huge lot... a few dozen pages.
>>     
> I guess it's still worth doing - what do you think?
>   

It hardly seems worth it, but I guess it isn't much code.  Will having
an apparent overlap of vmalloc and fixmap spaces confuse anything?

    J

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo <at> kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont <at> kvack.org"> email <at> kvack.org </a>
Permalink | Reply | 0 comments |
headers
KOSAKI Motohiro | 1 Sep 2009 02:43
Favicon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

> On Mon, 31 Aug 2009 17:01:03 -0700 (PDT)
> Vincent Li <macli <at> brc.ubc.ca> wrote:
> 
> > On Tue, 1 Sep 2009, Minchan Kim wrote:
> > 
> > > On Mon, 31 Aug 2009 15:54:01 -0700
> > > Vincent Li <macli <at> brc.ubc.ca> wrote:
> > > 
> > > > commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> > > > sc->isolate_pages() return value properly. Add similar proper return value check for
> > > > shrink_active_list() sc->isolate_pages().
> > > > 
> > > > Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>
> > > Reviewed-by: Minchan Kim <minchan.kim <at> gmail.com>
> > > 
> > > You should have write down your patch's effect clearly
> > > in changelog although it's easy. ;-)
> > 
> > Yes, I should have. This patch is inspired by Kosaki's patch, I 
> > thought mentioning that commit would make this patch as follow-up work and 
> > changelog clear enough. Would following changelog ok?
> > 
> > ----
> > Add proper return value check for shrink_active_list() 
> > sc->isolate_pages(). 
> > 
> > When "nr_taken == 0"
> > 	1: nr_scan related statistics should still be caculated.
> > 	2: jump to the end of function and release zone->lru_lock.
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Paul Mundt | 1 Sep 2009 02:46
Gravatar

Re: page allocator regression on nommu

On Mon, Aug 31, 2009 at 11:59:52AM +0100, Mel Gorman wrote:
> On Mon, Aug 31, 2009 at 07:43:15PM +0900, Paul Mundt wrote:
> > On Mon, Aug 31, 2009 at 11:30:56AM +0100, Mel Gorman wrote:
> > > On Mon, Aug 31, 2009 at 04:48:43PM +0900, Paul Mundt wrote:
> > > > Hi Mel,
> > > > 
> > > > It seems we've managed to trigger a fairly interesting conflict between
> > > > the anti-fragmentation disabling code and the nommu region rbtree. I've
> > > > bisected it down to:
> > > > 
> > > > commit 49255c619fbd482d704289b5eb2795f8e3b7ff2e
> > > > Author: Mel Gorman <mel <at> csn.ul.ie>
> > > > Date:   Tue Jun 16 15:31:58 2009 -0700
> > > > 
> > > >     page allocator: move check for disabled anti-fragmentation out of fastpath
> > > > 
> > > >     On low-memory systems, anti-fragmentation gets disabled as there is
> > > >     nothing it can do and it would just incur overhead shuffling pages between
> > > >     lists constantly.  Currently the check is made in the free page fast path
> > > >     for every page.  This patch moves it to a slow path.  On machines with low
> > > >     memory, there will be small amount of additional overhead as pages get
> > > >     shuffled between lists but it should quickly settle.
> > > > 
> > > > which causes death on unpacking initramfs on my nommu board. With this
> > > > reverted, everything works as expected. Note that this blows up with all of
> > > > SLOB/SLUB/SLAB.
> > > > 
> > > > I'll continue debugging it, and can post my .config if it will be helpful, but
> > > > hopefully you have some suggestions on what to try :-)
> > > >
(Continue reading)

Permalink | Reply | 0 comments |
headers
Wu Fengguang | 1 Sep 2009 03:56
Picon
Favicon

Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

On Tue, Sep 01, 2009 at 06:54:01AM +0800, Vincent Li wrote:
> commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle
> sc->isolate_pages() return value properly. Add similar proper return value check for
> shrink_active_list() sc->isolate_pages().
> 
> Signed-off-by: Vincent Li <macli <at> brc.ubc.ca>

Looks good to me, thanks.

Reviewed-by: Wu Fengguang <fengguang.wu <at> intel.com>

> ---
>  mm/vmscan.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 460a6f7..2d1c846 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
>  <at>  <at>  -1319,9 +1319,12  <at>  <at>  static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
>  	if (scanning_global_lru(sc)) {
>  		zone->pages_scanned += pgscanned;
>  	}
> -	reclaim_stat->recent_scanned[file] += nr_taken;
> -
>  	__count_zone_vm_events(PGREFILL, zone, pgscanned);
> +
> +	if (nr_taken == 0)
> +		goto done;
> +
(Continue reading)

Permalink | Reply | 0 comments |
headers
Wu Fengguang | 1 Sep 2009 04:25
Picon
Favicon

Re: [RFC][PATCH 0/4] memcg: add support for hwpoison testing

On Tue, Sep 01, 2009 at 07:46:26AM +0800, KAMEZAWA Hiroyuki wrote:
> On Mon, 31 Aug 2009 18:26:40 +0800
> Wu Fengguang <fengguang.wu <at> intel.com> wrote:
> 
> > Hi all,
> > 
> > In hardware poison testing, we want to inject hwpoison errors to pages
> > of a collection of selected tasks, so that random tasks (eg. init) won't
> > be killed in stress tests and lead to test failure.
> > 
> > Memory cgroup provides an ideal tool for tracking and testing these target
> > process pages. All we have to do is to
> > - export the memory cgroup id via cgroupfs
> > - export two functions/structs for hwpoison_inject.c
> > 
> > This might be an unexpected usage of memory cgroup. The last patch and this
> > script demonstrates how the exported interfaces are to be used to limit the
> > scope of hwpoison injection.
> > 
> > 	test -d /cgroup/hwpoison && rmdir /cgroup/hwpoison
> > 	mkdir /cgroup/hwpoison
> > 
> > 	usemem -m 100 -s 100 &   # eat 100MB and sleep 100s
> > 	echo `pidof usemem` > /cgroup/hwpoison/tasks
> > 
> > ==>     memcg_id=$(</cgroup/hwpoison/memory.id)
> > ==>     echo $memcg_id > /debug/hwpoison/corrupt-filter-memcg
> > 
> > 	# hwpoison all pfn
> > 	pfn=0
(Continue reading)

Permalink | Reply | 0 comments |

Gmane