15 May 2013 20:43
[PATCH] makedumpfile: buddy identification when noncyclic
From: Cliff Wickman <cpw@...> The 'buddy' identification of free pages should be done for non-cyclical dumps as well as cyclical. Remove the cyclic test from this condition: if (info->flag_cyclic && (info->dump_level & DL_EXCLUDE_FREE)) I find this to speed the scan of page structures for a 1TB system from 60sec to 30sec. And only do the exclude_free_page() procedure if free pages cannot be identified using the buddy technique. Signed-off-by: Cliff Wickman <cpw@...> --- makedumpfile.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: makedumpfile.mmap/makedumpfile.c =================================================================== --- makedumpfile.mmap.orig/makedumpfile.c +++ makedumpfile.mmap/makedumpfile.c <at> <at> -2979,7 +2979,9 <at> <at> out: if (!get_value_for_old_linux()) return FALSE; - if (info->flag_cyclic && (info->dump_level & DL_EXCLUDE_FREE)) + /* use buddy identification of free pages whether cyclic or not */ + /* (this can reduce pages scan of 1TB memory from 60sec to 30sec) */ + if (info->dump_level & DL_EXCLUDE_FREE) setup_page_is_buddy();(Continue reading)
RSS Feed