chris | 1 Feb 05:03

[PATCH 2/2] input: wacom - add 0xE5 (MT device) support

From: Ping Cheng <pinglinux <at> gmail.com>

And getting rid of duplicate code since X/Y will always be present.

Tested-by: Chris Bagwell <chris <at> cnpbagwell.com>
Reviewed-by: Chris Bagwell <chris <at> cnpbagwell.com>
Signed-off-by: Ping Cheng <pingc <at> wacom.com>
---
 drivers/input/tablet/wacom_sys.c |   57 ++++++++++++------------
 drivers/input/tablet/wacom_wac.c |   88 ++++++++++++++++++++++++++++++++++++-
 drivers/input/tablet/wacom_wac.h |    8 +++
 3 files changed, 122 insertions(+), 31 deletions(-)

diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index 5004a75..dc00386 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -306,6 +306,10 @@ static int wacom_parse_hid(struct usb_interface *intf,
 							/* need to reset back */
 							features->pktlen = WACOM_PKGLEN_TPC2FG;
 						}
+
+						if (features->type == MTSCREEN)
+							features->pktlen = WACOM_PKGLEN_MTOUCH;
+
 						if (features->type == BAMBOO_PT) {
 							/* need to reset back */
 							features->pktlen = WACOM_PKGLEN_BBTOUCH;
@@ -338,18 +342,15 @@ static int wacom_parse_hid(struct usb_interface *intf,
 			case HID_USAGE_Y:
(Continue reading)

chris | 1 Feb 05:03

[PATCH 1/2] input : wacom - retrieve maximum number of touch points

From: Ping Cheng <pinglinux <at> gmail.com>

From the HID usage table when it is supported.

Tested-by: Chris Bagwell <chris <at> cnpbagwell.com>
Signed-off-by: Chris Bagwell <chris <at> cnpbagwell.com>
Signed-off-by: Ping Cheng <pingc <at> wacom.com>
---

These two patches were originally in a set of 4 from Ping.
2 of those 4 have already been committed to next branch.

The change between this version and Ping's last version is
making use of features to set the new touch_max value.
The 2nd patch is unmodified.

 drivers/input/tablet/wacom_sys.c |   26 +++++++++++++++++-
 drivers/input/tablet/wacom_wac.c |   55 +++++++++++++++++++++++--------------
 drivers/input/tablet/wacom_wac.h |    1 +
 3 files changed, 60 insertions(+), 22 deletions(-)

diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index c9588ee..5004a75 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -28,6 +28,7 @@
 #define HID_USAGE_Y_TILT		0x3e
 #define HID_USAGE_FINGER		0x22
 #define HID_USAGE_STYLUS		0x20
+#define HID_USAGE_CONTACTMAX		0x55
(Continue reading)

Che-Liang Chiou | 1 Feb 09:19

[PATCH] Input: serio_raw - return proper result when serio_raw_read fails

serio_raw_read now returns (sometimes partially) successful number of
bytes transferred to the caller, and only returns error code to the
caller on completely failed transfers.

Signed-off-by: Che-Liang Chiou <clchiou <at> chromium.org>
---

I think serio_raw_write() and serio_raw_read() should have the same returning
value behavior.

---
 drivers/input/serio/serio_raw.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index 8250299..4494233 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -164,7 +164,8 @@ static ssize_t serio_raw_read(struct file *file, char __user *buffer,
 	struct serio_raw_client *client = file->private_data;
 	struct serio_raw *serio_raw = client->serio_raw;
 	char uninitialized_var(c);
-	ssize_t retval = 0;
+	ssize_t read = 0;
+	int retval;

 	if (serio_raw->dead)
 		return -ENODEV;
@@ -180,13 +181,15 @@ static ssize_t serio_raw_read(struct file *file, char __user *buffer,
 	if (serio_raw->dead)
(Continue reading)

Jussi Pakkanen | 1 Feb 09:54
Favicon

Re: [PATCH v2] Input: Document the device properties

On 01/31/2012 08:55 PM, Henrik Rydberg wrote:

> Add a section which defines the input device properties and provides
> guidelines on how to use them.
>
> Cc: Jussi Pakkanen<jussi.pakkanen <at> canonical.com>
> Cc: Chase Douglas<chase.douglas <at> canonical.com>
> Signed-off-by: Henrik Rydberg<rydberg <at> euromail.se>

Looking good. Thanks.

Reviewed-by: Jussi Pakkanen <jussi.pakkanen <at> canonical.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dan Carpenter | 1 Feb 10:40
Picon
Favicon

re: Input: add Cypress TTSP capacitive multi-touch screen support

Hello Javier Martinez Canillas,

This is a semi-automatic email about new static checker warnings.

The patch 4065d1e7b216: "Input: add Cypress TTSP capacitive 
multi-touch screen support" from Jan 31, 2012, leads to the following 
Smatch complaint:

drivers/input/touchscreen/cyttsp_core.c +526 cyttsp_probe()
	 warn: variable dereferenced before check 'dev' (see line 521)

drivers/input/touchscreen/cyttsp_core.c
   520	{
   521		const struct cyttsp_platform_data *pdata = dev->platform_data;
                                                           ^^^^^
dereference.

   522		struct cyttsp *ts;
   523		struct input_dev *input_dev;
   524		int error;
   525	
   526		if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {
                    ^^^^
check.

   527			error = -EINVAL;
   528			goto err_out;

"dev" is never NULL here so the check can be removed probably.

(Continue reading)

Maurus Cuelenaere | 1 Feb 12:53
Picon

Re: [PATCH 1/2] input : wacom - retrieve maximum number of touch points

Op 01-02-12 05:03, chris <at> cnpbagwell.com schreef:
> From: Ping Cheng<pinglinux <at> gmail.com>
>
>  From the HID usage table when it is supported.
>
> Tested-by: Chris Bagwell<chris <at> cnpbagwell.com>
> Signed-off-by: Chris Bagwell<chris <at> cnpbagwell.com>
> Signed-off-by: Ping Cheng<pingc <at> wacom.com>
> ---
>
> These two patches were originally in a set of 4 from Ping.
> 2 of those 4 have already been committed to next branch.
>
> The change between this version and Ping's last version is
> making use of features to set the new touch_max value.
> The 2nd patch is unmodified.
>
>   drivers/input/tablet/wacom_sys.c |   26 +++++++++++++++++-
>   drivers/input/tablet/wacom_wac.c |   55 +++++++++++++++++++++++--------------
>   drivers/input/tablet/wacom_wac.h |    1 +
>   3 files changed, 60 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index c9588ee..5004a75 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -28,6 +28,7 @@
>   #define HID_USAGE_Y_TILT		0x3e
>   #define HID_USAGE_FINGER		0x22
>   #define HID_USAGE_STYLUS		0x20
(Continue reading)

Chris Bagwell | 1 Feb 17:16

Re: [PATCH 1/2] input : wacom - retrieve maximum number of touch points

On Wed, Feb 1, 2012 at 5:53 AM, Maurus Cuelenaere <mcuelenaere <at> gmail.com> wrote:
> Op 01-02-12 05:03, chris <at> cnpbagwell.com schreef:
>
>> From: Ping Cheng<pinglinux <at> gmail.com>
>>
>>  From the HID usage table when it is supported.
>>
>> Tested-by: Chris Bagwell<chris <at> cnpbagwell.com>
>> Signed-off-by: Chris Bagwell<chris <at> cnpbagwell.com>
>> Signed-off-by: Ping Cheng<pingc <at> wacom.com>
>> ---
>>
>> These two patches were originally in a set of 4 from Ping.
>> 2 of those 4 have already been committed to next branch.
>>
>> The change between this version and Ping's last version is
>> making use of features to set the new touch_max value.
>> The 2nd patch is unmodified.
>>
>>  drivers/input/tablet/wacom_sys.c |   26 +++++++++++++++++-
>>  drivers/input/tablet/wacom_wac.c |   55
>> +++++++++++++++++++++++--------------
>>  drivers/input/tablet/wacom_wac.h |    1 +
>>  3 files changed, 60 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/input/tablet/wacom_sys.c
>> b/drivers/input/tablet/wacom_sys.c
>> index c9588ee..5004a75 100644
>> --- a/drivers/input/tablet/wacom_sys.c
>> +++ b/drivers/input/tablet/wacom_sys.c
(Continue reading)

Jonathan Nieder | 1 Feb 20:35
Picon

Re: not supported hardware: Gigabyte K8100 Aivia USB Gaming Keyboard

zitev wrote:

> I did every step of test, but after testing the /tmp/mon.out file is
> 0byte (empty)

Drat.  Just to make sure I have the method right, could you do the
same with another keyboard (setting the bus number accordingly), or
using some key that does work, if any (e.g., backspace is said to
work)?

But anyway, this is believable.  There is a Windows driver for the
keyboard, so if you are able to run Windows (e.g., in a VM), the hints
from

 http://libnetmd.sourceforge.net/howto.html

might help.  Also, contacting the manufacturer might help.

Given a rough description of the protocol the keyboard uses, folks on
this mailing list might be able to come up with a rough patch to try
out.  One way to make progress.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

zitev | 1 Feb 20:33
Picon
Favicon

Re: not supported hardware: Gigabyte K8100 Aivia USB Gaming Keyboard

i attached the detail of syslog:

"Feb  1 20:26:40 player kernel: [ 1247.275287] usb 1-1.1: new high-speed 
USB device number 6 using ehci_hcd
Feb  1 20:26:40 player kernel: [ 1247.444488] usb 1-1.1: New USB device 
found, idVendor=05e3, idProduct=0608
Feb  1 20:26:40 player kernel: [ 1247.520511] usb 1-1.1: New USB device 
strings: Mfr=0, Product=1, SerialNumber=0
Feb  1 20:26:40 player kernel: [ 1247.596369] usb 1-1.1: Product: USB2.0 Hub
Feb  1 20:26:40 player kernel: [ 1247.672160] hub 1-1.1:1.0: USB hub found
Feb  1 20:26:40 player kernel: [ 1247.736605] hub 1-1.1:1.0: 4 ports 
detected
Feb  1 20:26:41 player kernel: [ 1248.074036] usb 1-1.1.2: new 
full-speed USB device number 7 using ehci_hcd
Feb  1 20:26:41 player kernel: [ 1248.240627] usb 1-1.1.2: New USB 
device found, idVendor=1044, idProduct=7a02
Feb  1 20:26:41 player kernel: [ 1248.314881] usb 1-1.1.2: New USB 
device strings: Mfr=0, Product=0, SerialNumber=0
Feb  1 20:26:41 player mtp-probe: checking bus 1, device 7: 
"/sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2"
Feb  1 20:26:41 player kernel: [ 1248.391648] generic-usb: probe of 
0003:1044:7A02.0006 failed with error -22
Feb  1 20:26:41 player kernel: [ 1248.459226] input: HID 1044:7a02 as 
/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.1/input/input7
Feb  1 20:26:41 player kernel: [ 1248.523851] generic-usb 
0003:1044:7A02.0007: input,hiddev0,hidraw0: USB HID v1.11 Mouse [HID 
1044:7a02] on usb-0000:00:1a.0-1.1.2/input1
Feb  1 20:26:41 player kernel: [ 1248.592068] generic-usb 
0003:1044:7A02.0008: input,hidraw1: USB HID v1.11 Device [HID 1044:7a02] 
on usb-0000:00:1a.0-1.1.2/input2
(Continue reading)


Gmane