Linux Kernel Mailing List | 1 Jan 01:59 2010

pci: avoid compiler warning in quirks.c

Gitweb:     http://git.kernel.org/linus/df9d1e8a4379119cbc47c474f168b5103e404e17
Commit:     df9d1e8a4379119cbc47c474f168b5103e404e17
Parent:     c03f6bfc9f4fbeee14abef81ece67e39150a1ab1
Author:     Linus Torvalds <torvalds <at> linux-foundation.org>
AuthorDate: Thu Dec 31 16:44:43 2009 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Thu Dec 31 16:44:43 2009 -0800

    pci: avoid compiler warning in quirks.c

    Introduced by commit 5b889bf23 ("PCI: Fix build if quirks are not
    enabled"), which made the pci_dev_reset_methods[] array static and
    'const', but didn't then change the code to match, and use a const
    pointer when moving it to quirks.c.

    Trivially fixed by just adding the required 'const' to the iterator
    variable.

    Reported-by: Stephen Rothwell <sfr <at> canb.auug.org.au>
    Cc: Rafael J. Wysocki <rjw <at> sisk.pl>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 drivers/pci/quirks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 5c449fc..c746943 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
 <at>  <at>  -2694,7 +2694,7  <at>  <at>  static const struct pci_dev_reset_methods pci_dev_reset_methods[] = {
(Continue reading)

Linux Kernel Mailing List | 1 Jan 02:59 2010

twl4030-irq.c: fix compiler warning due to raw-spinlock conversion

Gitweb:     http://git.kernel.org/linus/cd6e125c58ae1561bedb6ea6f70b00d6c2599d62
Commit:     cd6e125c58ae1561bedb6ea6f70b00d6c2599d62
Parent:     df9d1e8a4379119cbc47c474f168b5103e404e17
Author:     Linus Torvalds <torvalds <at> linux-foundation.org>
AuthorDate: Thu Dec 31 17:26:05 2009 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Thu Dec 31 17:26:05 2009 -0800

    twl4030-irq.c: fix compiler warning due to raw-spinlock conversion

    Commit 239007b844 ("genirq: Convert irq_desc.lock to raw_spinlock")
    seems to have missed this driver, leaving it to use the normal spin-lock
    functions for the irq descriptor lock, which is now a raw lock.

    Reported-and-compile-tested-by: Stephen Rothwell <sfr <at> canb.auug.org.au>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 drivers/mfd/twl4030-irq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 20d29ba..9df9a5a 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
 <at>  <at>  -568,12 +568,12  <at>  <at>  static void twl4030_sih_do_edge(struct work_struct *work)

 		bytes[byte] &= ~(0x03 << off);

-		spin_lock_irq(&d->lock);
+		raw_spin_lock_irq(&d->lock);
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

writeback: add missing kernel-doc notation

Gitweb:     http://git.kernel.org/linus/4b6764fa9e25cf628e42bbd192eca1e0b8e59061
Commit:     4b6764fa9e25cf628e42bbd192eca1e0b8e59061
Parent:     cd6e125c58ae1561bedb6ea6f70b00d6c2599d62
Author:     Jaswinder Singh Rajput <jaswinderrajput <at> gmail.com>
AuthorDate: Fri Jan 1 20:35:23 2010 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Sat Jan 2 10:09:44 2010 -0800

    writeback: add missing kernel-doc notation

    Fix the following htmldocs warning:

      Warning(fs/fs-writeback.c:255): No description found for parameter 'sb'

    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput <at> gmail.com>
    Signed-off-by: Randy Dunlap <randy.dunlap <at> oracle.com>
    Acked-by: Wu Fengguang <fengguang.wu <at> intel.com>
    Cc: Peter Zijlstra <a.p.zijlstra <at> chello.nl>
    Cc: Jan Kara <jack <at> suse.cz>
    Cc: Jens Axboe <jens.axboe <at> oracle.com>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 fs/fs-writeback.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index f6c2155..1a7c42c 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
 <at>  <at>  -242,6 +242,7  <at>  <at>  static void bdi_sync_writeback(struct backing_dev_info *bdi,
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

reiserfs: Fix possible recursive lock

Gitweb:     http://git.kernel.org/linus/500f5a0bf5f0624dae34307010e240ec090e4cde
Commit:     500f5a0bf5f0624dae34307010e240ec090e4cde
Parent:     6548698f929814375fa5d62ae1db96959b0418c1
Author:     Frederic Weisbecker <fweisbec <at> gmail.com>
AuthorDate: Sun Dec 13 22:48:54 2009 +0100
Committer:  Frederic Weisbecker <fweisbec <at> gmail.com>
CommitDate: Mon Dec 14 11:43:09 2009 +0100

    reiserfs: Fix possible recursive lock

    While allocating the bitmap using vmalloc, we hold the reiserfs lock,
    which makes lockdep later reporting a possible deadlock as we may
    swap out pages to allocate memory and then take the reiserfs lock
    recursively:

    inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage.
    kswapd0/312 [HC0[0]:SC0[0]:HE1:SE1] takes:
     (&REISERFS_SB(s)->lock){+.+.?.}, at: [<c11108a8>] reiserfs_write_lock+0x28/0x40
    {RECLAIM_FS-ON-W} state was registered at:
      [<c104e1c2>] mark_held_locks+0x62/0x90
      [<c104e28a>] lockdep_trace_alloc+0x9a/0xc0
      [<c108e396>] kmem_cache_alloc+0x26/0xf0
      [<c10850ec>] __get_vm_area_node+0x6c/0xf0
      [<c10857de>] __vmalloc_node+0x7e/0xa0
      [<c108597b>] vmalloc+0x2b/0x30
      [<c10e00b9>] reiserfs_init_bitmap_cache+0x39/0x70
      [<c10f8178>] reiserfs_fill_super+0x2e8/0xb90
      [<c1094345>] get_sb_bdev+0x145/0x180
      [<c10f5a11>] get_super_block+0x21/0x30
      [<c10931f0>] vfs_kern_mount+0x40/0xd0
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

reiserfs: Fix reiserfs lock and journal lock inversion dependency

Gitweb:     http://git.kernel.org/linus/cb1c2e51c5a72f093b5af384b11d2f1c2abd6c13
Commit:     cb1c2e51c5a72f093b5af384b11d2f1c2abd6c13
Parent:     500f5a0bf5f0624dae34307010e240ec090e4cde
Author:     Frederic Weisbecker <fweisbec <at> gmail.com>
AuthorDate: Sun Dec 13 23:32:06 2009 +0100
Committer:  Frederic Weisbecker <fweisbec <at> gmail.com>
CommitDate: Mon Dec 14 11:47:11 2009 +0100

    reiserfs: Fix reiserfs lock and journal lock inversion dependency

    When we were using the bkl, we didn't care about dependencies against
    other locks, but the mutex conversion created new ones, which is why
    we have reiserfs_mutex_lock_safe(), which unlocks the reiserfs lock
    before acquiring another mutex.

    But this trick actually fails if we have acquired the reiserfs lock
    recursively, as we try to unlock it to acquire the new mutex without
    inverted dependency, but we eventually only decrease its depth.

    This happens in the case of a nested inode creation/deletion.
    Say we have no space left on the device, we create an inode
    and tak the lock but fail to create its entry, then we release the
    inode using iput(), which calls reiserfs_delete_inode() that takes
    the reiserfs lock recursively. The path eventually ends up in
    journal_begin() where we try to take the journal safely but we
    fail because of the reiserfs lock recursion:

    [ INFO: possible circular locking dependency detected ]
    2.6.32-06486-g053fe57 #2
    -------------------------------------------------------
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

Documentation: fix ioremap return type

Gitweb:     http://git.kernel.org/linus/143724fd3d3c154009fe95846dcbf7afadca8ab1
Commit:     143724fd3d3c154009fe95846dcbf7afadca8ab1
Parent:     4b6764fa9e25cf628e42bbd192eca1e0b8e59061
Author:     H Hartley Sweeten <hsweeten <at> visionengravers.com>
AuthorDate: Fri Jan 1 20:35:41 2010 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Sat Jan 2 10:09:44 2010 -0800

    Documentation: fix ioremap return type

    ioremap() returns a void __iomem * not a char *.  Update the documentation
    file to reflect this.

    Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
    Signed-off-by: Randy Dunlap <randy.dunlap <at> oracle.com>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 Documentation/IO-mapping.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/IO-mapping.txt b/Documentation/IO-mapping.txt
index 78a4406..1b5aa10 100644
--- a/Documentation/IO-mapping.txt
+++ b/Documentation/IO-mapping.txt
 <at>  <at>  -157,7 +157,7  <at>  <at>  For such memory, you can do things like
 	 * access only the 640k-1MB area, so anything else
 	 * has to be remapped.
 	 */
-	char * baseptr = ioremap(0xFC000000, 1024*1024);
+	void __iomem *baseptr = ioremap(0xFC000000, 1024*1024);
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

reiserfs: Fix reiserfs lock <-> inode mutex dependency inversion

Gitweb:     http://git.kernel.org/linus/47376ceba54600cec4dd9e7c4fe8b98e4269633a
Commit:     47376ceba54600cec4dd9e7c4fe8b98e4269633a
Parent:     cb1c2e51c5a72f093b5af384b11d2f1c2abd6c13
Author:     Frederic Weisbecker <fweisbec <at> gmail.com>
AuthorDate: Wed Dec 16 23:25:50 2009 +0100
Committer:  Frederic Weisbecker <fweisbec <at> gmail.com>
CommitDate: Wed Dec 16 23:25:50 2009 +0100

    reiserfs: Fix reiserfs lock <-> inode mutex dependency inversion

    The reiserfs lock -> inode mutex dependency gets inverted when we
    relax the lock while walking to the tree.

    To fix this, use a specialized version of reiserfs_mutex_lock_safe
    that takes care of mutex subclasses. Then we can grab the inode
    mutex with I_MUTEX_XATTR subclass without any reiserfs lock
    dependency.

    This fixes the following report:

    [ INFO: possible circular locking dependency detected ]
    2.6.32-06793-gf405425-dirty #2
    -------------------------------------------------------
    mv/18566 is trying to acquire lock:
     (&REISERFS_SB(s)->lock){+.+.+.}, at: [<c1110708>] reiserfs_write_lock+0x28=
    /0x40

    but task is already holding lock:
     (&sb->s_type->i_mutex_key#5/3){+.+.+.}, at: [<c111033c>]
    reiserfs_for_each_xattr+0x10c/0x380
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

Documentation: Rename Documentation/DMA-mapping.txt

Gitweb:     http://git.kernel.org/linus/4207a152bc242effd0b8231143aa5b9f7a1593a9
Commit:     4207a152bc242effd0b8231143aa5b9f7a1593a9
Parent:     8d9f99c335ef66e4c44afe8f61816b0edeafba91
Author:     Kusanagi Kouichi <slash <at> ac.auone-net.jp>
AuthorDate: Fri Jan 1 20:36:09 2010 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Sat Jan 2 10:09:44 2010 -0800

    Documentation: Rename Documentation/DMA-mapping.txt

    It seems that Documentation/DMA-mapping.txt was supposed to be renamed
    to Documentation/PCI/PCI-DMA-mapping.txt.

    Signed-off-by: Kusanagi Kouichi <slash <at> ac.auone-net.jp>
    Signed-off-by: Randy Dunlap <randy.dunlap <at> oracle.com>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 .../{DMA-mapping.txt => PCI/PCI-DMA-mapping.txt}   |    0
 Documentation/block/biodoc.txt                     |    2 +-
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/DMA-mapping.txt b/Documentation/PCI/PCI-DMA-mapping.txt
similarity index 100%
rename from Documentation/DMA-mapping.txt
rename to Documentation/PCI/PCI-DMA-mapping.txt
diff --git a/Documentation/block/biodoc.txt b/Documentation/block/biodoc.txt
index 8d2158a..6fab97e 100644
--- a/Documentation/block/biodoc.txt
+++ b/Documentation/block/biodoc.txt
 <at>  <at>  -186,7 +186,7  <at>  <at>  a virtual address mapping (unlike the earlier scheme of virtual address
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

DocBook: fix ioremap return type

Gitweb:     http://git.kernel.org/linus/8d9f99c335ef66e4c44afe8f61816b0edeafba91
Commit:     8d9f99c335ef66e4c44afe8f61816b0edeafba91
Parent:     143724fd3d3c154009fe95846dcbf7afadca8ab1
Author:     H Hartley Sweeten <hsweeten <at> visionengravers.com>
AuthorDate: Fri Jan 1 20:35:54 2010 -0800
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Sat Jan 2 10:09:44 2010 -0800

    DocBook: fix ioremap return type

    ioremap() returns a void __iomem * not an unsigned long.  Update the
    Documentation file to reflect this.

    Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
    Signed-off-by: Randy Dunlap <randy.dunlap <at> oracle.com>
    Cc: David Woodhouse <dwmw2 <at> infradead.org>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 Documentation/DocBook/mtdnand.tmpl |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/DocBook/mtdnand.tmpl b/Documentation/DocBook/mtdnand.tmpl
index f508a8a..5e7d84b 100644
--- a/Documentation/DocBook/mtdnand.tmpl
+++ b/Documentation/DocBook/mtdnand.tmpl
 <at>  <at>  -174,7 +174,7  <at>  <at> 
 		</para>
 		<programlisting>
 static struct mtd_info *board_mtd;
-static unsigned long baseaddr;
(Continue reading)

Linux Kernel Mailing List | 2 Jan 21:59 2010

reiserfs: Fix remaining in-reclaim-fs <-> reclaim-fs-on locking inversion

Gitweb:     http://git.kernel.org/linus/98ea3f50bcc97689cc0e1fa3b6733f03aeb8fef4
Commit:     98ea3f50bcc97689cc0e1fa3b6733f03aeb8fef4
Parent:     47376ceba54600cec4dd9e7c4fe8b98e4269633a
Author:     Frederic Weisbecker <fweisbec <at> gmail.com>
AuthorDate: Tue Dec 29 21:51:15 2009 +0100
Committer:  Frederic Weisbecker <fweisbec <at> gmail.com>
CommitDate: Tue Dec 29 22:34:59 2009 +0100

    reiserfs: Fix remaining in-reclaim-fs <-> reclaim-fs-on locking inversion

    Commit 500f5a0bf5f0624dae34307010e240ec090e4cde
    (reiserfs: Fix possible recursive lock) fixed a vmalloc under reiserfs
    lock that triggered a lockdep warning because of a
    IN-FS-RECLAIM <-> RECLAIM-FS-ON locking dependency inversion.

    But this patch has ommitted another vmalloc call in the same path
    that allocates the journal. Relax the lock for this one too.

    Reported-by: Alexander Beregalov <a.beregalov <at> gmail.com>
    Signed-off-by: Frederic Weisbecker <fweisbec <at> gmail.com>
    Cc: Chris Mason <chris.mason <at> oracle.com>
    Cc: Ingo Molnar <mingo <at> elte.hu>
---
 fs/reiserfs/journal.c |   15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index 2f8a7e7..a059879 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
(Continue reading)


Gmane