Linux Kernel Mailing List | 3 Jul 04:59 2008

e100: Do pci_dma_sync after skb_alloc for proper operation on ixp4xx

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1923815d855e1daec931fc9f2221fb73ca708870
Commit:     1923815d855e1daec931fc9f2221fb73ca708870
Parent:     70081ac55df939363b27c1ebd27c51f510129139
Author:     Kevin Hao <kexin.hao <at> windriver.com>
AuthorDate: Sat Jun 21 18:20:35 2008 +0800
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:30:59 2008 -0400

    e100: Do pci_dma_sync after skb_alloc for proper operation on ixp4xx

    The E100 device can't work on current kernel (2.6.26-rc6) and will cause
    kernel corruption on intel ixdp4xx.

    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/e100.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index f3cba5e..1037b13 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
 <at>  <at>  -1803,6 +1803,8  <at>  <at>  static int e100_rx_alloc_skb(struct nic *nic, struct rx *rx)
 	if (rx->prev->skb) {
 		struct rfd *prev_rfd = (struct rfd *)rx->prev->skb->data;
 		put_unaligned_le32(rx->dma_addr, &prev_rfd->link);
+		pci_dma_sync_single_for_device(nic->pdev, rx->prev->dma_addr,
+			sizeof(struct rfd), PCI_DMA_TODEVICE);
 	}

(Continue reading)

Linux Kernel Mailing List | 3 Jul 05:02 2008

hamradio: remove unused variable

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=479798211967cd828e09ce27775b8cbfe99462ab
Commit:     479798211967cd828e09ce27775b8cbfe99462ab
Parent:     00eb7fe77eb455f807c396f9917f0f623d4c84bb
Author:     Andre Haupt <andre <at> bitwigglers.org>
AuthorDate: Fri Jun 27 17:22:08 2008 -0700
Committer:  David S. Miller <davem <at> davemloft.net>
CommitDate: Fri Jun 27 17:22:08 2008 -0700

    hamradio: remove unused variable

    Signed-off-by: Andre Haupt <andre <at> bitwigglers.org>
    Signed-off-by: David S. Miller <davem <at> davemloft.net>
---
 drivers/net/hamradio/dmascc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c
index 0b94833..e8cfade 100644
--- a/drivers/net/hamradio/dmascc.c
+++ b/drivers/net/hamradio/dmascc.c
 <at>  <at>  -1077,8 +1077,6  <at>  <at>  static inline void rx_off(struct scc_priv *priv)

 static void start_timer(struct scc_priv *priv, int t, int r15)
 {
-	unsigned long flags;
Linux Kernel Mailing List | 3 Jul 04:59 2008

qla3xxx: Hold RTNL while calling dev_close()

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c81ec80bc86f4eacd5f48229c1de623865acbb92
Commit:     c81ec80bc86f4eacd5f48229c1de623865acbb92
Parent:     64c42f697661e27c9688a32c1ba61d0228e81d84
Author:     Ben Hutchings <bhutchings <at> solarflare.com>
AuthorDate: Tue May 6 19:36:26 2008 +0100
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:31:50 2008 -0400

    qla3xxx: Hold RTNL while calling dev_close()

    dev_close() must be called holding the RTNL.  Compile-tested only.

    Signed-off-by: Ben Hutchings <bhutchings <at> solarflare.com>
    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/qla3xxx.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index b7f7b22..bccee68 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
 <at>  <at>  -3701,7 +3701,9  <at>  <at>  static int ql_cycle_adapter(struct ql3_adapter *qdev, int reset)
 		printk(KERN_ERR PFX
 				"%s: Driver up/down cycle failed, "
 				"closing device\n",qdev->ndev->name);
+		rtnl_lock();
 		dev_close(qdev->ndev);
+		rtnl_unlock();
 		return -1;
(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

e1000: only enable TSO6 via ethtool when using correct hardware

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=581abbc26a7adb693fb8b913f1be18d1c349c1ab
Commit:     581abbc26a7adb693fb8b913f1be18d1c349c1ab
Parent:     1923815d855e1daec931fc9f2221fb73ca708870
Author:     Andy Gospodarek <andy <at> greyhouse.net>
AuthorDate: Thu Jun 19 17:19:02 2008 -0400
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:31:08 2008 -0400

    e1000: only enable TSO6 via ethtool when using correct hardware

    When enabling TSO via ethool on e1000, it is possible to set
    NETIF_F_TSO6 on hardware that does not support it.  Setting TSO via
    ethtool now matches the settings used when the hardware is probed.

    Signed-off-by: Andy Gospodarek <andy <at> greyhouse.net>
    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/e1000/e1000_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
index 701531e..a3f6a9c 100644
--- a/drivers/net/e1000/e1000_ethtool.c
+++ b/drivers/net/e1000/e1000_ethtool.c
 <at>  <at>  -347,7 +347,7  <at>  <at>  e1000_set_tso(struct net_device *netdev, u32 data)
 	else
 		netdev->features &= ~NETIF_F_TSO;

-	if (data)
+	if (data && (adapter->hw.mac_type > e1000_82547_rev_2))
(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

tc35815: Mark carrier-off before starting PHY

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=59524a37446e18a672188d86d23c8c76fd488621
Commit:     59524a37446e18a672188d86d23c8c76fd488621
Parent:     f471f92339860c35b561cf45ad563ab1ff07c386
Author:     Atsushi Nemoto <anemo <at> mba.ocn.ne.jp>
AuthorDate: Wed Jun 25 11:41:01 2008 +0900
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:27:33 2008 -0400

    tc35815: Mark carrier-off before starting PHY

    Call netif_carrier_off() before starting PHY device.  This is a
    behavior before converting to generic PHY layer.

    Signed-off-by: Atsushi Nemoto <anemo <at> mba.ocn.ne.jp>
    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/tc35815.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 10e4e85..dccea52 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
 <at>  <at>  -1394,6 +1394,7  <at>  <at>  tc35815_open(struct net_device *dev)
 	tc35815_chip_init(dev);
 	spin_unlock_irq(&lp->lock);

+	netif_carrier_off(dev);
 	/* schedule a link state check */
 	phy_start(lp->phy_dev);
(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

mac80211: implement EU regulatory domain

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=59d393ad92f719d9ef36b96eae56d4817a7eeb10
Commit:     59d393ad92f719d9ef36b96eae56d4817a7eeb10
Parent:     88a6f4ad76be425f47df7f892baf913bcd466fb3
Author:     Tony Vroon <tony <at> linx.net>
AuthorDate: Wed Jun 11 16:23:56 2008 -0400
Committer:  John W. Linville <linville <at> tuxdriver.com>
CommitDate: Wed Jun 25 10:31:29 2008 -0400

    mac80211: implement EU regulatory domain

    Implement missing EU regulatory domain for mac80211. Based on the
    information in IEEE 802.11-2007 (specifically pages 1142, 1143 & 1148)
    and ETSI 301 893 (V1.4.1).
    With thanks to Johannes Berg.

    Signed-off-by: Tony Vroon <tony <at> linx.net>
    Acked-by: Johannes Berg <johannes <at> sipsolutions.net>
    Signed-off-by: John W. Linville <linville <at> tuxdriver.com>
---
 net/wireless/reg.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 185488d..855bff4 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
 <at>  <at>  -80,6 +80,23  <at>  <at>  static const struct ieee80211_channel_range ieee80211_JP_channels[] = {
 				     IEEE80211_CHAN_RADAR),
 };

(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

Hold RTNL while calling dev_close()

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3e3cda96d014b69f7723d1d4507897e5be6aceb7
Commit:     3e3cda96d014b69f7723d1d4507897e5be6aceb7
Parent:     c81ec80bc86f4eacd5f48229c1de623865acbb92
Author:     Ben Hutchings <bhutchings <at> solarflare.com>
AuthorDate: Tue May 6 19:41:48 2008 +0100
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:31:52 2008 -0400

    Hold RTNL while calling dev_close()

    dev_close() must be called holding the RTNL.  Compile-tested only.

    Signed-off-by: Ben Hutchings <bhutchings <at> solarflare.com>
    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/wan/x25_asy.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index 249e180..069f8bb 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
 <at>  <at>  -32,6 +32,7  <at>  <at> 
 #include <linux/x25.h>
 #include <linux/lapb.h>
 #include <linux/init.h>
+#include <linux/rtnetlink.h>
 #include "x25_asy.h"

 #include <net/x25device.h>
(Continue reading)

Linux Kernel Mailing List | 3 Jul 05:02 2008

af_unix: fix 'poll for write'/connected DGRAM sockets

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ec0d215f9420564fc8286dcf93d2d068bb53a07e
Commit:     ec0d215f9420564fc8286dcf93d2d068bb53a07e
Parent:     db43a282d3ec92ea45109c5551fff3dcc5afef02
Author:     Rainer Weikusat <rweikusat <at> mssgmbh.com>
AuthorDate: Fri Jun 27 19:34:18 2008 -0700
Committer:  David S. Miller <davem <at> davemloft.net>
CommitDate: Fri Jun 27 19:34:18 2008 -0700

    af_unix: fix 'poll for write'/connected DGRAM sockets

    For n:1 'datagram connections' (eg /dev/log), the unix_dgram_sendmsg
    routine implements a form of receiver-imposed flow control by
    comparing the length of the receive queue of the 'peer socket' with
    the max_ack_backlog value stored in the corresponding sock structure,
    either blocking the thread which caused the send-routine to be called
    or returning EAGAIN. This routine is used by both SOCK_DGRAM and
    SOCK_SEQPACKET sockets. The poll-implementation for these socket types
    is datagram_poll from core/datagram.c. A socket is deemed to be
    writeable by this routine when the memory presently consumed by
    datagrams owned by it is less than the configured socket send buffer
    size. This is always wrong for PF_UNIX non-stream sockets connected to
    server sockets dealing with (potentially) multiple clients if the
    abovementioned receive queue is currently considered to be full.
    'poll' will then return, indicating that the socket is writeable, but
    a subsequent write result in EAGAIN, effectively causing an (usual)
    application to 'poll for writeability by repeated send request with
    O_NONBLOCK set' until it has consumed its time quantum.

    The change below uses a suitably modified variant of the datagram_poll
    routines for both type of PF_UNIX sockets, which tests if the
(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

[netdrvr] Fix IOMMU overflow checking in s2io.c

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=64c42f697661e27c9688a32c1ba61d0228e81d84
Commit:     64c42f697661e27c9688a32c1ba61d0228e81d84
Parent:     581abbc26a7adb693fb8b913f1be18d1c349c1ab
Author:     Andi Kleen <andi <at> firstfloor.org>
AuthorDate: Wed Jun 18 13:58:36 2008 +0200
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:31:22 2008 -0400

    [netdrvr] Fix IOMMU overflow checking in s2io.c

    s2io has IOMMU overflow checking, but unfortunately it is wrong.

    It didn't use the standard macros, which meant that it only worked
    on POWER and SPARC because only those define DMA_ERROR_CODE. Convert it to
    use the standard macros instead.

    I also commented two more bugs in the IOMMU handling. It assumes
    that 0 DMA addresses cannot happen, but that's not true in all IOMMU setups.
    The information if a buffer has been already mapped needs to be stored
    elsewhere.

    Didn't fix those because it needs careful checking of the buffer handling
    by the maintainers.

    Cc: ram.vepa <at> neterion.com
    Cc: santosh.rastapur <at> neterion.com
    Cc: sivakumar.subramani <at> neterion.com
    Cc: sreenivasa.honnur <at> neterion.com

    Signed-off-by: Andi Kleen <ak <at> linux.intel.com>
(Continue reading)

Linux Kernel Mailing List | 3 Jul 04:59 2008

ipg: use NULL, not zero, for pointers

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e8399fed7e9f2e76eb65852612b16732129b9f3f
Commit:     e8399fed7e9f2e76eb65852612b16732129b9f3f
Parent:     ecfecfb5e39165b3f7f6d93aacd268edfe7c3524
Author:     Pekka Enberg <penberg <at> cs.helsinki.fi>
AuthorDate: Mon Jun 23 14:34:50 2008 +0300
Committer:  Jeff Garzik <jgarzik <at> redhat.com>
CommitDate: Fri Jun 27 01:28:31 2008 -0400

    ipg: use NULL, not zero, for pointers

    Fixes a sparse warning in a code block that's hidden under JUMBO_FRAME #ifdef.

    Tested-by: Andrew Savchenko <Bircoph <at> list.ru>
    Signed-off-by: Pekka Enberg <penberg <at> cs.helsinki.fi>
    Signed-off-by: Jeff Garzik <jgarzik <at> redhat.com>
---
 drivers/net/ipg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
index dbb77e3..2c03f4e 100644
--- a/drivers/net/ipg.c
+++ b/drivers/net/ipg.c
 <at>  <at>  -1808,7 +1808,7  <at>  <at>  static int ipg_nic_open(struct net_device *dev)
 	/* initialize JUMBO Frame control variable */
 	sp->jumbo.found_start = 0;
 	sp->jumbo.current_size = 0;
-	sp->jumbo.skb = 0;
+	sp->jumbo.skb = NULL;
 	dev->mtu = IPG_TXFRAG_SIZE;
(Continue reading)


Gmane