Linux Kernel Mailing List | 1 May 02:59 2008

Fix ACPI vs proc_create_data() mismerge

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e0066c4ea9ffa420cb79814411ff74fdc7b7d98e
Commit:     e0066c4ea9ffa420cb79814411ff74fdc7b7d98e
Parent:     08acd4f8af42affd8cbed81cc1b69fa12ddb213f
Author:     Alexey Dobriyan <adobriyan <at> gmail.com>
AuthorDate: Thu May 1 04:10:02 2008 +0400
Committer:  Linus Torvalds <torvalds <at> linux-foundation.org>
CommitDate: Wed Apr 30 16:26:27 2008 -0700

    Fix ACPI vs proc_create_data() mismerge

    acpi_device_dir() is NULL until all files are createst, so everyting is
    created in straight in /proc/ and creation code warns.

    Signed-off-by: Alexey Dobriyan <adobriyan <at> gmail.com>
    Signed-off-by: Linus Torvalds <torvalds <at> linux-foundation.org>
---
 drivers/acpi/video.c |   20 +++++++++++---------
 1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f7eb12e..5e5dda3 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
 <at>  <at>  -1070,7 +1070,7  <at>  <at>  static int acpi_video_device_add_fs(struct acpi_device *device)
 	device_dir->owner = THIS_MODULE;

 	/* 'info' [R] */
-	entry = proc_create_data("info", S_IRUGO, acpi_device_dir(device),
+	entry = proc_create_data("info", S_IRUGO, device_dir,
 			&acpi_video_device_info_fops, acpi_driver_data(device));
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

sysfs: sysfs_update_group stub for CONFIG_SYSFS=n

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cbfb7a5acd357de6c3f8e27e8d8f92b3867b1f3
Commit:     1cbfb7a5acd357de6c3f8e27e8d8f92b3867b1f3
Parent:     883ce42ec45c2dbef5be7c133ade9741ac978329
Author:     Randy Dunlap <randy.dunlap <at> oracle.com>
AuthorDate: Wed Apr 30 09:01:17 2008 -0700
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:47 2008 -0700

    sysfs: sysfs_update_group stub for CONFIG_SYSFS=n

    scsi_transport_spi uses sysfs_update_group() when CONFIG_SYSFS=n,
    so provide a stub for it.

    next-20080423/drivers/scsi/scsi_transport_spi.c:1467: error: implicit declaration of function 'sysfs_update_group'
    make[3]: *** [drivers/scsi/scsi_transport_spi.o] Error 1

    Signed-off-by: Randy Dunlap <randy.dunlap <at> oracle.com>
    Cc: James Bottomley <James.Bottomley <at> HansenPartnership.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 include/linux/sysfs.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index add3c5a..7858eac 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
 <at>  <at>  -190,6 +190,12  <at>  <at>  static inline int sysfs_create_group(struct kobject *kobj,
 	return 0;
 }
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

driver core: warn about duplicate driver names on the same bus

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c
Commit:     16dc42e018c2868211b4928f20a957c0c216126c
Parent:     93dd40013f4f7f4b18d19d0d77855f025bcc57c3
Author:     Stas Sergeev <stsp <at> aknet.ru>
AuthorDate: Sat Apr 26 19:52:35 2008 +0400
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:47 2008 -0700

    driver core: warn about duplicate driver names on the same bus

    Currently an attempt to register multiple
    drivers with the same name causes the
    stack trace with some cryptic error message.
    The attached patch adds the necessary check
    and the clear error message.

    Signed-off-by: Stas Sergeev <stsp <at> aknet.ru>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 drivers/base/driver.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 9a6537f..2ef5acf 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
 <at>  <at>  -217,12 +217,22  <at>  <at>  static void driver_remove_groups(struct device_driver *drv,
 int driver_register(struct device_driver *drv)
 {
 	int ret;
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

klist: implement KLIST_INIT() and DEFINE_KLIST()

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1da43e4a9ee942c9c967dbe8839476571df0c3ed
Commit:     1da43e4a9ee942c9c967dbe8839476571df0c3ed
Parent:     40a2159abf3d0107bba359246554bd7d56f2171b
Author:     Tejun Heo <htejun <at> gmail.com>
AuthorDate: Sat Apr 26 03:16:04 2008 +0900
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:47 2008 -0700

    klist: implement KLIST_INIT() and DEFINE_KLIST()

    klist is missing static initializers and definition helper.  Add them.

    Signed-off-by: Tejun Heo <htejun <at> gmail.com>
    Cc: Peter Zijlstra <peterz <at> infradead.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 include/linux/klist.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/include/linux/klist.h b/include/linux/klist.h
index 7407125..a119c0d 100644
--- a/include/linux/klist.h
+++ b/include/linux/klist.h
 <at>  <at>  -25,6 +25,14  <at>  <at>  struct klist {
 	void			(*put)(struct klist_node *);
 };

+#define KLIST_INIT(_name, _get, _put)					\
+	{ .k_lock	= __SPIN_LOCK_UNLOCKED(_name.k_lock),		\
+	  .k_list	= LIST_HEAD_INIT(_name.k_list),			\
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

sysfs: Disallow truncation of files in sysfs

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=40a2159abf3d0107bba359246554bd7d56f2171b
Commit:     40a2159abf3d0107bba359246554bd7d56f2171b
Parent:     08acd4f8af42affd8cbed81cc1b69fa12ddb213f
Author:     Ben Hutchings <bhutchings <at> solarflare.com>
AuthorDate: Mon Apr 28 15:59:58 2008 +0100
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:46 2008 -0700

    sysfs: Disallow truncation of files in sysfs

    sysfs allows attribute files to be truncated, e.g. using ftruncate(), with the
    expected effect on their inode.   For most attributes, this doesn't change the
    "real" size of the file i.e. how much can be read from it.  However, the
    parameter validation for reading and writing binary attribute files is based
    on the inode size and not the size specified in the file's bin_attribute, so it
    can be broken by this. For example, if we try using dd to write to such a file:

    # pwd
    /sys/bus/pci/devices/0000:08:00.0
    # ls -l config
    -rw-r--r--  1 root root 4096 Feb  1 17:35 config
    # dd if=/dev/zero of=config bs=4 count=1
    1+0 records in
    1+0 records out
    # ls -l config
    -rw-r--r--  1 root root 0 Feb  1 17:50 config
    # dd if=/dev/zero of=config bs=4 count=1 seek=128
    dd: writing `config': No space left on device
    1+0 records in
    0+0 records out
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

pcmcia: remove pccard_sysfs_interface warnings

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4356d73d028ad0726cfaf31ad30c5d28fcd98795
Commit:     4356d73d028ad0726cfaf31ad30c5d28fcd98795
Parent:     4f452e8aa492c0b8028ca9b4bdb4d018ba28c6c7
Author:     David Brownell <dbrownell <at> users.sourceforge.net>
AuthorDate: Mon Apr 28 01:03:20 2008 -0700
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:48 2008 -0700

    pcmcia: remove pccard_sysfs_interface warnings

    Make the PCMCIA core stop using class_interface to hide socket attribute
    registration.  This removes the associated section mismatch warnings, and
    helps get to the point where that mechanism can finally be removed.

    Simplify that attribute registration by using an attribute_group.
    This is a net shrink in object size.

    Signed-off-by: David Brownell <dbrownell <at> users.sourceforge.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 drivers/pcmcia/cs.c           |   13 ++++------
 drivers/pcmcia/cs_internal.h  |    3 +-
 drivers/pcmcia/socket_sysfs.c |   52 ++++++++++++++++------------------------
 3 files changed, 28 insertions(+), 40 deletions(-)

diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
index 56230db..29276bd 100644
--- a/drivers/pcmcia/cs.c
+++ b/drivers/pcmcia/cs.c
 <at>  <at>  -652,6 +652,9  <at>  <at>  static int pccardd(void *__skt)
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

DEBUGFS: Correct location of debugfs API documentation.

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=883ce42ec45c2dbef5be7c133ade9741ac978329
Commit:     883ce42ec45c2dbef5be7c133ade9741ac978329
Parent:     16dc42e018c2868211b4928f20a957c0c216126c
Author:     Robert P. J. Day <rpjday <at> crashcourse.ca>
AuthorDate: Fri Apr 25 08:52:51 2008 -0400
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:47 2008 -0700

    DEBUGFS: Correct location of debugfs API documentation.

    Signed-off-by: Robert P. J. Day <rpjday <at> crashcourse.ca>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 fs/debugfs/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index fddffe4..159a5ef 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
 <at>  <at>  -9,7 +9,7  <at>  <at> 
  *	2 as published by the Free Software Foundation.
  *
  *  debugfs is for people to use instead of /proc or /sys.
- *  See Documentation/DocBook/kernel-api for more details.
+ *  See Documentation/DocBook/filesystems for more details.
  *
  */

--
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

klist: fix coding style errors in klist.h and klist.c

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c3bb7fadaf52de3637b834002dac27f6250b4b49
Commit:     c3bb7fadaf52de3637b834002dac27f6250b4b49
Parent:     c3b19ff06e0808555403491d61e8f0cbbb53e933
Author:     Greg Kroah-Hartman <gregkh <at> suse.de>
AuthorDate: Wed Apr 30 16:43:45 2008 -0700
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:58 2008 -0700

    klist: fix coding style errors in klist.h and klist.c

    Finally clean up the odd spacing in these files.

    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 include/linux/klist.h |   30 ++++----
 lib/klist.c           |  206 ++++++++++++++++++++-----------------------------
 2 files changed, 100 insertions(+), 136 deletions(-)

diff --git a/include/linux/klist.h b/include/linux/klist.h
index b49385f..06c338e 100644
--- a/include/linux/klist.h
+++ b/include/linux/klist.h
 <at>  <at>  -34,38 +34,38  <at>  <at>  struct klist {
 #define DEFINE_KLIST(_name, _get, _put)					\
 	struct klist _name = KLIST_INIT(_name, _get, _put)

-extern void klist_init(struct klist * k, void (*get)(struct klist_node *),
+extern void klist_init(struct klist *k, void (*get)(struct klist_node *),
 		       void (*put)(struct klist_node *));

(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

devres: support addresses greater than an unsigned long via dev_ioremap

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4f452e8aa492c0b8028ca9b4bdb4d018ba28c6c7
Commit:     4f452e8aa492c0b8028ca9b4bdb4d018ba28c6c7
Parent:     a4ca6617421188f50774780cdc91c3782b7d08fe
Author:     Kumar Gala <galak <at> kernel.crashing.org>
AuthorDate: Tue Apr 29 10:25:48 2008 -0500
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:48 2008 -0700

    devres: support addresses greater than an unsigned long via dev_ioremap

    Use a resource_size_t instead of unsigned long since some arch's are
    capable of having ioremap deal with addresses greater than the size of a
    unsigned long.

    Signed-off-by: Kumar Gala <galak <at> kernel.crashing.org>
    Cc: Tejun Heo <htejun <at> gmail.com>
    Cc: Jeff Garzik <jgarzik <at> pobox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 include/linux/io.h |    4 ++--
 lib/devres.c       |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/io.h b/include/linux/io.h
index e3b2dda..3a03a36 100644
--- a/include/linux/io.h
+++ b/include/linux/io.h
 <at>  <at>  -58,9 +58,9  <at>  <at>  static inline void devm_ioport_unmap(struct device *dev, void __iomem *addr)
 }
 #endif
(Continue reading)

Linux Kernel Mailing List | 1 May 02:59 2008

klist: implement klist_add_{after|before}()

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=93dd40013f4f7f4b18d19d0d77855f025bcc57c3
Commit:     93dd40013f4f7f4b18d19d0d77855f025bcc57c3
Parent:     1da43e4a9ee942c9c967dbe8839476571df0c3ed
Author:     Tejun Heo <htejun <at> gmail.com>
AuthorDate: Tue Apr 22 18:58:46 2008 +0900
Committer:  Greg Kroah-Hartman <gregkh <at> suse.de>
CommitDate: Wed Apr 30 16:52:47 2008 -0700

    klist: implement klist_add_{after|before}()

    Add klist_add_after() and klist_add_before() which puts a new node
    after and before an existing node, respectively.  This is useful for
    callers which need to keep klist ordered.  Note that synchronizing
    between simultaneous additions for ordering is the caller's
    responsibility.

    Signed-off-by: Tejun Heo <htejun <at> gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>
---
 include/linux/klist.h |    2 ++
 lib/klist.c           |   33 +++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 0 deletions(-)

diff --git a/include/linux/klist.h b/include/linux/klist.h
index a119c0d..b49385f 100644
--- a/include/linux/klist.h
+++ b/include/linux/klist.h
 <at>  <at>  -46,6 +46,8  <at>  <at>  struct klist_node {

 extern void klist_add_tail(struct klist_node * n, struct klist * k);
(Continue reading)


Gmane