1 Mar 2004 16:44
[PATCH] fix CDROM_SEND_PACKET 32 -> 64-bit translation
Linux Kernel Mailing List <linux-kernel <at> vger.kernel.org>
2004-03-01 15:44:38 GMT
2004-03-01 15:44:38 GMT
ChangeSet 1.1629, 2004/03/01 07:44:38-08:00, axboe <at> suse.de [PATCH] fix CDROM_SEND_PACKET 32 -> 64-bit translation Here's a much better version. The real bug was of course that the get_user/put_user for data_direction were transposed. This patch also fixes the translation of "quiet" and "timeout" to be safer and clearer (instead of memcpying them as two ints and knowing that "quiet" is first and assuming that "compat_int_t" is always the same as the native "int", the code now handles them explicitly). We should use "access_ok()" and __get_user/__put_user to generate better code for this, but it's not performance-critical, so we don't care. Some other day, perhaps. # This patch includes the following deltas: # ChangeSet 1.1628 -> 1.1629 # fs/compat_ioctl.c 1.19 -> 1.20 # compat_ioctl.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff -Nru a/fs/compat_ioctl.c b/fs/compat_ioctl.c --- a/fs/compat_ioctl.c Mon Mar 1 09:07:56 2004 +++ b/fs/compat_ioctl.c Mon Mar 1 09:07:56 2004 <at> <at> -1458,6 +1458,7 <at> <at> struct cdrom_generic_command *cgc; struct cdrom_generic_command32 *cgc32;(Continue reading)
RSS Feed