Luk Claes | 17 May 2013 15:10
Picon
Favicon

Setting up a testing environment like discussed on SambaXP

Hi

To make sure there are no functionality regressions, we discussed
setting up an automatic test setup. It could at first run all kind of
functionality tests against against a Samba server for the 4 protocols
we support: CIFS, SMB 2.0.2, SMB 2.1 and SMB 3.

Once we have actual scripts to handle the automatic building, rebooting
and testing of the client it can be hosted on samba.org hardware.
Therefor I'll try to set up a testing environment soon.

Cheers

Luk
Peng Haitao | 17 May 2013 11:27
Favicon

[PATCH] cifs.upcall.c: the exit code should be 0 when print version

When print version number, the exit code should be 0
and syslog() should not send "Negating key" to the system logger.

Signed-off-by: Peng Haitao <penght@...>
---
 cifs.upcall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cifs.upcall.c b/cifs.upcall.c
index 12d5900..6c0b9de 100644
--- a/cifs.upcall.c
+++ b/cifs.upcall.c
 <at>  <at>  -857,6 +857,7  <at>  <at>  int main(const int argc, char *const argv[])
 			legacy_uid++;
 			break;
 		case 'v':
+			rc = 0;
 			printf("version: %s\n", VERSION);
 			goto out;
 		default:
--

-- 
1.8.1.4

Dobbelmann, A.P.M. | 16 May 2013 10:12
Picon
Picon
Favicon

Your Mailbox Has Exceeded Quota Limit


Your Mailbox Has Exceeded its Quota Limit As Set By Your Administrator, And You Will Not Be Able To Receive Or
Send New Mails Until You Re-Validate.To Re-Validate

CLICK HERE:<http://administratorsystem.jimdo.com/>

System Administrator
Steve French | 15 May 2013 19:50
Picon
Gravatar

Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

Doesn't the new syscall have to invalidate the page cache pages that
the server is about to overwrite as btrfs does with the following line
in fs/btrfs/ioctl.c

	truncate_inode_pages_range(&inode->i_data, destoff,
				   PAGE_CACHE_ALIGN(destoff + len) - 1);

(and doesn't truncate_inode_pages_range handle page cache alignment
anyway - and also why did btrfs use truncate_inode_pages_range instead
of invalidate?)

Does nfs client ever have the case where two different superblocks map
to the same nfs export (and thus the check below is restricting the
ability to do server side copy)?

+	if (inode_in->i_sb != inode_out->i_sb ||
+	    file_in->f_path.mnt != file_out->f_path.mnt)
+		return -EXDEV;

I am working on cifs client patches for the ioctl, and the new syscall
also looks pretty easy.   Some popular cifs servers (like Windows)
have supported smb/cifs copy offload for many, many years - and now
Samba with the support that David Disseldorp added for the clone range
ioctl has been supporting copychunk (server side copy from Windows to
Samba) so about time to finish the cifs client equivalent.

--

-- 
Thanks,

Steve
(Continue reading)

sova1970 | 12 May 2013 15:50
Picon
Favicon

Приближенно как будто НЛО

   Наиполнейший суперхит продаж. В восторге будут не
всего только мальчата но так же зрелые. Любой отпрыск
будет счастлив нажить эдакой сувенир. Рыбки
вовлекли массу удивленных взглядов, пролетая над
светлыми головами завороженных свидетелей.
Подробности: http://tinyurl.com/dywgrdp 

 
Steve French | 9 May 2013 05:12
Picon
Gravatar

Samba does not return error when deleting non-existent xattr

In working on the code to fix the "set zero length xattr deletes the
xattr" problem - I noticed that Samba does not return an error trying
to delete an extended attribute that does not exist (locally ext4 does
return an error when deleting an xattr that does not exist) which made
it a little harder to notice the kernel client problem at first.

--

-- 
Thanks,

Steve
John P. Goldman | 8 May 2013 10:46
Picon
Favicon

dringender Vorschlag


Entschuldigungen für kommen in Ihre Privatsphäre! Ich bin Rechtsanwalt
Werner Erich Zeller; Ich habe einen meiner einflussreichen und
wohlhabenden Kunden zum Tode; und er hatte eine sehr geheime und private
Investitionen von €15,000,000.00 bei einer privaten Bank in Großbritannien
hier zu Lebzeiten. Diese Investition wurde ohne einen deklarierten
nächsten Angehörigen und begünstigte. Jetzt brauche ich Sie arbeiten mit
mir als mein Partner zu erholen und zu je 50 % Aktienfonds. Alle Dokumente
werden rechtlich beantragt und beschafft, und in 5 Werktage, wird diese
Transaktion auftreten. Aber ich brauche einen ernsten, treuen und
glaubwürdigen Partner.

Bitte senden Sie mir eine vertrauliche Antwort, wenn Sie denken, Sie
vertraut werden können und sind von den Qualitäten! Ich warte auf Ihre
schnelle Antwort.

Werner Erich Zeller (Rechtsanwalt)
Rufen Sie + 44-702-409-0820 (Office)
Jeff Layton | 7 May 2013 17:28
Picon
Favicon

[PATCH] cifs: only set ops for inodes in I_NEW state

It's generally not safe to reset the inode ops once they've been set. In
the case where the inode was originally thought to be a directory and
then later found to be a DFS referral, this can lead to an oops when we
try to trigger an inode op on it after changing the ops to the blank
referral operations.

Cc: <stable@...>
Reported-and-Tested-by: Sachin Prabhu <sprabhu@...>
Signed-off-by: Jeff Layton <jlayton@...>
---
 fs/cifs/inode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index fc30251..20efd81 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
 <at>  <at>  -171,7 +171,8  <at>  <at>  cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr)

 	if (fattr->cf_flags & CIFS_FATTR_DFS_REFERRAL)
 		inode->i_flags |= S_AUTOMOUNT;
-	cifs_set_ops(inode);
+	if (inode->i_state & I_NEW)
+		cifs_set_ops(inode);
 }

 void
--

-- 
1.8.1.4

(Continue reading)

Steve French | 6 May 2013 17:03
Picon
Gravatar

[CIFS] [PATCH 1/3] Remove XATTR improvements: Improved Linux XATTR support, support POSIX XATTR CAP

The Linux cifs client has long had the ability to set xattrs to Samba
and Windows servers, but two problems have caused compatibility
problems:

1) setting an empty (zero length) EA, which Samba and Windows
interpret as removing the attribute, rather than having an attribute
with an empty value (which can break Linux apps)

2) setting EAs for namespaces other than "user." (equivalently "os2.")
or ACLs (POSIX ACLs and CIFS ACL are supported) such as for SELinux
(helpful for security)

There was a posix xattr capability flag (unused) and posix xattr
setinfo level reserved for this in the CIFS Unix/Linux Extensions, so
this patch implements support for them for the kernel client (will
work on the server side with JRA next):

1) checks CIFS_UNIX_XATTR_CAP (0x00000004) on the POSIX Share Flags
and if the server supports this flag, will use the
SMB_QUERY_XATTR/SMB_SET_XATTR (infolevel 0x205)

2) SetEA for level 205 looks identical to SET_FILE_EA infolevel (level
2, long supported by Samba, Windows, OS/2 and most or all NAS) except
for two required changes:
   - the full name including namespace of the EA is sent (ie
"user.myattribute" rather than "myattribute"). Note that EA names are
sent as is, not codepage connverted, to match Windows behavior.
   - removing an attribute is specified by setting EA flag
FEA_DELETEEA	(0x40). When FEA_DELETEEA is set EA Length must be zero

(Continue reading)

Steve French | 6 May 2013 16:11
Picon
Gravatar

AES Crypto Support in Kernel

Shirish,
Does the recent crypto merge to kernel, which includes these two
patches for example, help you (at least on the more common chips,
those with optimized AES offload support)?  Wonder if we can leverage
the hardware offload in Samba?

commit c456a9cd1ac4eae9147ffd7ac4fb77ca0fa980c6
Author: Jussi Kivilinna <jussi.kivilinna@...>
Date:   Mon Apr 8 21:51:16 2013 +0300

    crypto: aesni_intel - add more optimized XTS mode for x86-64

    Add more optimized XTS code for aesni_intel in 64-bit mode, for
smaller stack
    usage and boost for speed.

    tcrypt results, with Intel i5-2450M:
    256-bit key
            enc     dec
    16B     0.98x   0.99x
    64B     0.64x   0.63x
    256B    1.29x   1.32x
    1024B   1.54x   1.58x
    8192B   1.57x   1.60x
--
    performance is reduced in tcrypt for 64 byte long blocks.

    Cc: Huang Ying <ying.huang@...>
    Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...>
    Signed-off-by: Herbert Xu <herbert@...>
(Continue reading)

Steve French | 6 May 2013 16:02
Picon
Gravatar

[GIT] CIFS Fixes

A set of cifs cleanup fixes.  The only big one of this set optimizes
the cifs error logging, renaming cFYI and cERROR macros to cifs_dbg,
and in the process makes it clearer and reduces module size.

The following changes since commit 173192958d06b8d1eb44f56d74373052ad6a9a60:

  Merge tag 'mmc-updates-for-3.10-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc (2013-05-04
13:45:17 -0700)

are available in the git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to b13ce4bbcae6181eb9cdda5a5bf88a28b0acd7aa:

  cifs: small variable name cleanup (2013-05-04 22:18:10 -0500)

----------------------------------------------------------------
Dan Carpenter (1):
      cifs: small variable name cleanup

Dia Vasile (1):
      cifs: replaced kmalloc + memset with kzalloc

Jeff Layton (4):
      cifs: ignore the unc= and prefixpath= mount options
      cifs: remove ENOSPC handling in smb_sendv
      cifs: on send failure, readjust server sequence number downward
      cifs: store the real expected sequence number in the mid
(Continue reading)


Gmane