Yiqiao Pu | 1 Jun 2011 06:47
Picon
Favicon

[PATCH] KVM-test: Use isAlive to check the status of Thread

The attribute is_alive is imported in python 2.6, so can not run
it in hosts with python 2.4 such as RHEL5. Just use isAlive().

Signed-off-by: Yiqiao Pu <ypu <at> redhat.com>
---
 client/virt/tests/netperf.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/virt/tests/netperf.py b/client/virt/tests/netperf.py
index 8a80d13..458364a 100644
--- a/client/virt/tests/netperf.py
+++ b/client/virt/tests/netperf.py
 <at>  <at>  -95,7 +95,7  <at>  <at>  def run_netperf(test, params, env):
         while not completed:
             completed = True
             for b in bg:
-                if b.is_alive():
+                if b.isAlive():
                     completed = False
     finally:
         try:
--

-- 
1.7.1
Cleber Rosa | 1 Jun 2011 19:59
Picon
Favicon

[PATCH 2/2] Web frontend Apache configuration: serve django admin media files

Currently, server installations can either rely on Django be installed
in an operating system default path, or on autotest local site-packages
(/usr/local/autotest/site-packages).

The added directives to Apache configuration attempt to serve media
files despite how they were installed.

Signed-off-by: Cleber Rosa <crosa <at> redhat.com>
---
 apache/conf/django-directives |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)

diff --git a/apache/conf/django-directives b/apache/conf/django-directives
index 2c604a1..a5fe7e2 100644
--- a/apache/conf/django-directives
+++ b/apache/conf/django-directives
 <at>  <at>  -5,7 +5,25  <at>  <at> 
     ERROR__DJANGO_REQUIRES_THE_PREFORK_MPM
 </IfModule>

-Alias /media "/usr/local/autotest/site-packages/django/contrib/admin/media"
+#
+# Try to serve admin media files, no matter where django is actually installed
+# Covers python versions 2.4 through 2.7 and also django installed by utils/build_externals.py
+#
+RewriteEngine On
+RewriteCond /usr/local/autotest/site-packages/django/contrib/admin/media -d
+RewriteRule /media(.*) /usr/local/autotest/site-packages/django/contrib/admin/media$1
+
+RewriteCond /usr/lib/python2.4/site-packages/django/contrib/admin/media -d
(Continue reading)

Cleber Rosa | 1 Jun 2011 19:59
Picon
Favicon

[PATCH 1/2] Web frontend Apache configuration: include directive for cgi scripts

The "AddHandler" directive for cgi scripts can be enabled in a
config file, so that server installation instructions can skip
this step.

Signed-off-by: Cleber Rosa <crosa <at> redhat.com>
---
 apache/conf/all-directives |    1 +
 apache/conf/cgi-directives |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 apache/conf/cgi-directives

diff --git a/apache/conf/all-directives b/apache/conf/all-directives
index c1c30a9..5092c13 100644
--- a/apache/conf/all-directives
+++ b/apache/conf/all-directives
 <at>  <at>  -2,6 +2,7  <at>  <at> 
 # This does not include stuff like proxy-directives and some of the files here
 # include other directive files.

+Include "/usr/local/autotest/apache/conf/cgi-directives"
 Include "/usr/local/autotest/apache/conf/gwt-directives"
 Include "/usr/local/autotest/apache/conf/django-directives"
 Include "/usr/local/autotest/apache/conf/afe-directives"
diff --git a/apache/conf/cgi-directives b/apache/conf/cgi-directives
new file mode 100644
index 0000000..f644ef8
--- /dev/null
+++ b/apache/conf/cgi-directives
 <at>  <at>  -0,0 +1  <at>  <at> 
+AddHandler cgi-script .cgi
(Continue reading)

Lucas Meneghel Rodrigues | 1 Jun 2011 20:02
Picon
Favicon
Gravatar

Re: [PATCH 2/8] Fix frontend afe readonly connection

Applied, as this one is a bugfix. The other changes on this patchset
will be deferred until we have more confidence that they won't bring
functional regressions.

Thanks Eric,

On Mon, May 30, 2011 at 12:40 AM, Lucas Meneghel Rodrigues
<lmr <at> redhat.com> wrote:
> From: Eric Li <ericli <at> google.com>
>
> I think this is a bug on frontend/afe/readonly_connection for a long time.
> Maybe nobody really looked at it. In short, the readonly connection
> never talked to the readonly databased based on global_config.ini's
> readonly db configuration.
>
> This patch should fix it properly.
>
> Changes from v1:
> * Fix a comparison among self._connection and django.connection. The
> intended comparison was among self._connection and
> django.connection.connection. This other bug has gone unnoticed because
> of the first bug Eric fixed.
>
> Signed-off-by: Lucas Meneghel Rodrigues <lmr <at> redhat.com>
> Signed-off-by: Eric Li <ericli <at> google.com>
> ---
>  frontend/afe/readonly_connection.py |   28 ++++++++++++++--------------
>  1 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/frontend/afe/readonly_connection.py b/frontend/afe/readonly_connection.py
(Continue reading)

Lucas Meneghel Rodrigues | 1 Jun 2011 21:31
Picon
Favicon
Gravatar

Re: [PATCH 0/4] Make possible to run client tests as subtests

Ok, I have applied patches from 1 to 3, after verifying the unittests.
I haven't applied patch 4, as this would bring some loss of
functionality of the current netperf test. I count on you guys (Jiri
and Lukas) to write the tests that actually use the functionality.

Cheers,

On Tue, May 24, 2011 at 4:08 AM, Lucas Meneghel Rodrigues
<lmr <at> redhat.com> wrote:
> In order to avoid duplication of code, make it possible to run the
> existing autotest client tests as subtests. This patchset is result
> of work on Jiri Zupka original single patch, the differences:
>
> * Removed example subtest KVM autotest test
> * Renamed some API introduced to net_utils for consistency
> * Rewrote netperf in terms of the new 'subtest' infrastructure
>
> Lucas Meneghel Rodrigues (4):
>  client.bin.net.net_utils: Introduce get_local_ip()
>  client: Make it possible to run subtests in autotest
>  tools: Make html_report to deal with subtest results
>  KVM test: Rewrite netperf in terms of subtest
>
>  client/bin/client_logging_config.py |    5 +-
>  client/bin/net/net_utils.py         |   17 +++++
>  client/common_lib/base_job.py       |    2 +
>  client/common_lib/logging_config.py |    3 +-
>  client/common_lib/test.py           |   21 ++++++-
>  client/tools/html_report.py         |  124 +++++++++++++++++++---------------
>  client/virt/tests/netperf.py        |  117 +++++++++------------------------
(Continue reading)

Lucas Meneghel Rodrigues | 2 Jun 2011 06:11
Picon
Favicon
Gravatar

Re: [PATCH] KVM-test: Use isAlive to check the status of Thread

On Wed, 2011-06-01 at 12:47 +0800, Yiqiao Pu wrote:
> The attribute is_alive is imported in python 2.6, so can not run
> it in hosts with python 2.4 such as RHEL5. Just use isAlive().

Applied, thanks!

> Signed-off-by: Yiqiao Pu <ypu <at> redhat.com>
> ---
>  client/virt/tests/netperf.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/client/virt/tests/netperf.py b/client/virt/tests/netperf.py
> index 8a80d13..458364a 100644
> --- a/client/virt/tests/netperf.py
> +++ b/client/virt/tests/netperf.py
>  <at>  <at>  -95,7 +95,7  <at>  <at>  def run_netperf(test, params, env):
>          while not completed:
>              completed = True
>              for b in bg:
> -                if b.is_alive():
> +                if b.isAlive():
>                      completed = False
>      finally:
>          try:
Lucas Meneghel Rodrigues | 2 Jun 2011 06:13
Picon
Favicon
Gravatar

Re: [PATCH 1/2] Web frontend Apache configuration: include directive for cgi scripts

Great, specially the last patch that fixes a long time bug with using
django from the distributor rather than the one installed by
build_externals.py

Both applied, thanks Cleber!

On Wed, 2011-06-01 at 13:59 -0400, Cleber Rosa wrote:
> The "AddHandler" directive for cgi scripts can be enabled in a
> config file, so that server installation instructions can skip
> this step.
> 
> Signed-off-by: Cleber Rosa <crosa <at> redhat.com>
> ---
>  apache/conf/all-directives |    1 +
>  apache/conf/cgi-directives |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
>  create mode 100644 apache/conf/cgi-directives
> 
> diff --git a/apache/conf/all-directives b/apache/conf/all-directives
> index c1c30a9..5092c13 100644
> --- a/apache/conf/all-directives
> +++ b/apache/conf/all-directives
>  <at>  <at>  -2,6 +2,7  <at>  <at> 
>  # This does not include stuff like proxy-directives and some of the files here
>  # include other directive files.
>  
> +Include "/usr/local/autotest/apache/conf/cgi-directives"
>  Include "/usr/local/autotest/apache/conf/gwt-directives"
>  Include "/usr/local/autotest/apache/conf/django-directives"
>  Include "/usr/local/autotest/apache/conf/afe-directives"
(Continue reading)

Lucas Meneghel Rodrigues | 2 Jun 2011 06:23
Picon
Favicon
Gravatar

[PATCH 1/5] KVM test: Adding framework code to control bridge creation

Provide in framework utility code to control the creation
of a bridge, in order to provide TAP functionality for
autotest users without relying on previous setup made by
the user.

This is a reimplementation of Amos's code, the differences
are:

 * Implemented as a setup class, taking advantage of object
internal state to use in different places of the code
 * Split up the operations to make it easier to understand
the steps and why we are doing them
 * Use of autotest API instead of commands

Changes from v2:
 * Changed firewall rules to match libvirt rules,
made the rules to be added with -I, which will place
them before exclusion rules
 * Safer cleanup, always try to cleanup when something
wrong happens during setup.

Signed-off-by: Cleber Rosa <crosa <at> redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr <at> redhat.com>
Signed-off-by: Amos Kong <akong <at> redhat.com>
---
 client/virt/virt_test_setup.py |  172 ++++++++++++++++++++++++++++++++++++++++
 1 files changed, 172 insertions(+), 0 deletions(-)

diff --git a/client/virt/virt_test_setup.py b/client/virt/virt_test_setup.py
index f915c1b..8e69b01 100644
(Continue reading)

Lucas Meneghel Rodrigues | 2 Jun 2011 06:23
Picon
Favicon
Gravatar

[PATCH 2/5] KVM test: Add helpers to control the TAP/bridge

This patch adds some helpers to assist virt test to setup the bridge or
macvtap based guest networking.

Changes from v1:
 * Fixed undefined variable errors on the exception class definitions

Changes from v2:
 * On RHEL5, the io operation TUNGETFEATURES = 0x800454cf may return an
integer bigger than the max signed integer, triggering an OverflowError.
Let's catch that exception and make vnet_hdr_probe() return False in
case it happens.

Signed-off-by: Jason Wang <jasowang <at> redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr <at> redhat.com>

fixup
---
 client/virt/virt_utils.py |  212 +++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 212 insertions(+), 0 deletions(-)

diff --git a/client/virt/virt_utils.py b/client/virt/virt_utils.py
index 0f02f3d..0700509 100644
--- a/client/virt/virt_utils.py
+++ b/client/virt/virt_utils.py
 <at>  <at>  -6,6 +6,7  <at>  <at>  KVM test utility functions.

 import time, string, random, socket, os, signal, re, logging, commands, cPickle
 import fcntl, shelve, ConfigParser, threading, sys, UserDict, inspect
+import struct
 from autotest_lib.client.bin import utils, os_dep
(Continue reading)

Lucas Meneghel Rodrigues | 2 Jun 2011 06:23
Picon
Favicon
Gravatar

[PATCH 3/5] KVM test: virt_env_process: Setup private bridge during postprocessing

Call bridge setup at preprocessing and cleanup at postprocessing.
The bridge can be cleaned up when no tap interfaces are using it.

Signed-off-by: Lucas Meneghel Rodrigues <lmr <at> redhat.com>
---
 client/virt/virt_env_process.py |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/client/virt/virt_env_process.py b/client/virt/virt_env_process.py
index 625b422..1742a02 100644
--- a/client/virt/virt_env_process.py
+++ b/client/virt/virt_env_process.py
 <at>  <at>  -196,6 +196,11  <at>  <at>  def preprocess(test, params, env):
      <at> param env: The environment (a dict-like object).
     """
     error.context("preprocessing")
+
+    if params.get("bridge") == "private":
+        brcfg = virt_test_setup.PrivateBridgeConfig(params)
+        brcfg.setup()
+
     # Start tcpdump if it isn't already running
     if "address_cache" not in env:
         env["address_cache"] = {}
 <at>  <at>  -365,6 +370,10  <at>  <at>  def postprocess(test, params, env):
                         int(params.get("post_command_timeout", "600")),
                         params.get("post_command_noncritical") == "yes")

+    if params.get("bridge") == "private":
+        brcfg = virt_test_setup.PrivateBridgeConfig()
(Continue reading)


Gmane