headers
Michal Marek | 1 Sep 2011 16:23
Picon
Gravatar

Re: [PATCH] kconfig: protect locale-unsafe calls

On 31.8.2011 14:19, Michal Marek wrote:
> As for the tollower/toupper issue, I would propose a much simpler way:
> Let's not try to be cute and simply use include/config/FOO_BAR.h for
> each CONFIG_FOO_BAR. x86_64 allmodconfig results in some 5k symbols
> enabled, I'm sure any filesystem will handle a directory with 5k files
> in it.

Unfortunately, we can't do this, because updating from a tree that used
include/config/foo/bar.h would result in missed rebuilds :-(.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
crquan | 1 Sep 2011 19:52
Picon
Gravatar

[PATCH V3 1/5] scripts/kconfig/nconf: fix typo: unknow => unknown

From: Cheng Renquan <crquan <at> gmail.com>

Signed-off-by: Cheng Renquan <crquan <at> gmail.com>
Acked-by: Arnaud Lacombe <lacombar <at> gmail.com>
---
 scripts/kconfig/nconf.gui.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c
index f8137b3..d3af04e 100644
--- a/scripts/kconfig/nconf.gui.c
+++ b/scripts/kconfig/nconf.gui.c
 <at>  <at>  -461,7 +461,7  <at>  <at>  int dialog_inputbox(WINDOW *main_window,
 				result[cursor_position] = res;
 				cursor_position++;
 			} else {
-				mvprintw(0, 0, "unknow key: %d\n", res);
+				mvprintw(0, 0, "unknown key: %d\n", res);
 			}
 			break;
 		}
--

-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 5 comments |
headers
crquan | 1 Sep 2011 19:52
Picon
Gravatar

[PATCH V3 5/5] scripts/kconfig/nconf: add KEY_HOME / KEY_END for dialog_inputbox

From: Cheng Renquan <crquan <at> gmail.com>

to make it easier to locate begin/end when editing long strings;

Signed-off-by: Cheng Renquan <crquan <at> gmail.com>
Acked By: Nir Tzachar <nir.tzachar <at> gmail.com>
---
 scripts/kconfig/nconf.gui.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c
index 4b9d8b6..3b18dd8 100644
--- a/scripts/kconfig/nconf.gui.c
+++ b/scripts/kconfig/nconf.gui.c
 <at>  <at>  -465,6 +465,14  <at>  <at>  int dialog_inputbox(WINDOW *main_window,
 				cursor_form_win--;
 			}
 			break;
+		case KEY_HOME:
+			cursor_position = 0;
+			cursor_form_win = 0;
+			break;
+		case KEY_END:
+			cursor_position = len;
+			cursor_form_win = min(cursor_position, prompt_width-1);
+			break;
 		default:
 			if ((isgraph(res) || isspace(res))) {
 				/* one for new char, one for '\0' */
--

--
(Continue reading)

Permalink | Reply | 1 comment |
headers
crquan | 1 Sep 2011 19:52
Picon
Gravatar

[PATCH V3 4/5] scripts/kconfig/nconf: fix editing long strings

From: Cheng Renquan <crquan <at> gmail.com>

The original dialog_inputbox doesn't work with longer than prompt_width
strings, here fixed it in this way:
1) add variable cursor_form_win to record cursor of form_win,
   keep its value always between [0, prompt_width-1];
   reuse the original cursor_position as cursor of the string result,
   use (cursor_position-cursor_form_win) as begin offset to show part of
   the string in form_win;

Signed-off-by: Cheng Renquan <crquan <at> gmail.com>
Cc: Arnaud Lacombe <lacombar <at> gmail.com>
Cc: Nir Tzachar <nir.tzachar <at> gmail.com>
---
 scripts/kconfig/nconf.gui.c |   29 +++++++++++++++++++++++------
 1 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c
index d64bc1c..4b9d8b6 100644
--- a/scripts/kconfig/nconf.gui.c
+++ b/scripts/kconfig/nconf.gui.c
 <at>  <at>  -367,6 +367,7  <at>  <at>  int dialog_inputbox(WINDOW *main_window,
 	int i, x, y;
 	int res = -1;
 	int cursor_position = strlen(init);
+	int cursor_form_win;
 	char *result = *resultp;

 	if (strlen(init)+1 > *result_len) {
 <at>  <at>  -410,7 +411,9  <at>  <at>  int dialog_inputbox(WINDOW *main_window,
(Continue reading)

Permalink | Reply | 2 comments |
headers
Mimi Zohar | 2 Sep 2011 03:40
Picon

Re: linux-next: Tree for Aug 22 (evm)

On Thu, 2011-09-01 at 20:32 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe <lacombar <at> gmail.com> wrote:
> > Hi,
> >
> > On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap <at> xenotime.net> wrote:
> >> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
> >>
> >>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> >>> > Hi,
> >>> >
> >>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap <at> xenotime.net> wrote:
> >>> > > I think that you are going to need to do something like Arnaud suggested
> >>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> >>> > > unless you can convince someone that this is a kconfig bug.
> >>> > >
> >>> > dammit... I guess there is...
> >>> >
> >>> > If you consider the following Kconfig:
> >>> >
> >>> > config MOD
> >>> >         bool
> >>> >         default y
> >>> >         option modules
> >>> >
> >>> > config EXPERIMENTAL
> >>> >         bool
> >>> >         default y
> >>> >
(Continue reading)

Permalink | Reply | 2 comments |
headers
Matthieu CASTET | 6 Sep 2011 10:52
Favicon

randconfig broken on choice

Hi,

I am using v3.1-rc4 and make randconfig look broken for choice.
The choice config is always the same or choice entry can have more than one entry.

After some debugging, it seems in randomize_choice_values, we don't clean
SYMBOL_VALID for choice entry.
And we don't take "sym->def[S_DEF_USER].tri" but the "default sym->cur.tri".

The following patch seems to fix the problem.

Matthieu
Attachment (randconfig.diff): text/x-diff, 492 bytes
Permalink | Reply | 5 comments |
headers
Davidlohr Bueso | 6 Sep 2011 14:33
Picon

Re: [PATCH v2] kconfig: handle SIGINT in menuconfig

On Mon, 2011-08-29 at 22:12 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Mon, Aug 29, 2011 at 9:55 PM, Arnaud Lacombe <lacombar <at> gmail.com> wrote:
> > Hi,
> >
> > On Sun, Aug 21, 2011 at 9:04 PM, Davidlohr Bueso <dave <at> gnu.org> wrote:
> >> From: Davidlohr Bueso <dave <at> gnu.org>
> >>
> >> I recently got bitten in the ass when pressing Ctrl-C and lost all my current configuration changes.
This patch captures SIGINT and allows the user to save any changes.
> >> Some code refactoring was made in order to handle the exit behavior.
> >>
> >> Signed-off-by: Davidlohr Bueso <dave <at> gnu.org>
> >> Signed-off-by: Arnaud Lacombe <lacombar <at> gmail.com>
> >> ---
> >>  scripts/kconfig/mconf.c |   86 ++++++++++++++++++++++++++++------------------
> >>  1 files changed, 52 insertions(+), 34 deletions(-)
> >>
> >> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> >> index 820d2b6..19e200d 100644
> >> --- a/scripts/kconfig/mconf.c
> >> +++ b/scripts/kconfig/mconf.c
> >>  <at>  <at>  -15,6 +15,7  <at>  <at> 
> >>  #include <stdarg.h>
> >>  #include <stdlib.h>
> >>  #include <string.h>
> >> +#include <signal.h>
> >>  #include <unistd.h>
> >>  #include <locale.h>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Arnaud Lacombe | 6 Sep 2011 17:04
Picon
Gravatar

Re: randconfig broken on choice

Hi,

On Tue, Sep 6, 2011 at 4:52 AM, Matthieu CASTET
<matthieu.castet <at> parrot.com> wrote:
> Hi,
>
> I am using v3.1-rc4 and make randconfig look broken for choice.
> The choice config is always the same or choice entry can have more than one entry.
>
Could you includes testcases showing that behavior, please ?

Btw, try also to include patch inlined, not multipart. That makes
review easier. I know, gmail is not making that easy, but git
send-email works just fine.

Thanks,
 - Arnaud

>
> After some debugging, it seems in randomize_choice_values, we don't clean
> SYMBOL_VALID for choice entry.
> And we don't take "sym->def[S_DEF_USER].tri" but the "default sym->cur.tri".
>
> The following patch seems to fix the problem.
>
>
> Matthieu
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
(Continue reading)

Permalink | Reply | 4 comments |
headers
Arnaud Lacombe | 6 Sep 2011 17:05
Picon
Gravatar

Re: [PATCH 0/4] Kbuild/Kconfig

Hi,

On Mon, Aug 29, 2011 at 8:29 PM, Arnaud Lacombe <lacombar <at> gmail.com> wrote:
> Hi,
>
> On Mon, Aug 22, 2011 at 11:49 AM, Arnaud Lacombe <lacombar <at> gmail.com> wrote:
>> Hi,
>>
>> On Tue, Aug 16, 2011 at 1:34 AM, Arnaud Lacombe <lacombar <at> gmail.com> wrote:
>>> Hi Michal,
>>>
>>> The following small serie unexpose a few Kconfig variable from Kbuild, and
>>> vice-versa. The idea is that Kbuild is a user of Kconfig, not the other way
>>> around.
>>>
>>> In the same time, fix a couple of place where we hardcode the `.config' string.
>>>
>>> Comments Welcome !
>>>  - Arnaud
>>>
>> ping ?
>>
> ping^2 ?
>
ping^3 ?

 - Arnaud

>  - Arnaud
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Arnaud Lacombe | 6 Sep 2011 17:32
Picon
Gravatar

Re: randconfig broken on choice

Hi,

On Tue, Sep 6, 2011 at 11:13 AM, Matthieu CASTET
<matthieu.castet <at> parrot.com> wrote:
> Hi,
>
> Arnaud Lacombe a écrit :
>> Hi,
>>
>> On Tue, Sep 6, 2011 at 4:52 AM, Matthieu CASTET
>> <matthieu.castet <at> parrot.com> wrote:
>>> Hi,
>>>
>>> I am using v3.1-rc4 and make randconfig look broken for choice.
>>> The choice config is always the same or choice entry can have more than one entry.
>>>
>> Could you includes testcases showing that behavior, please ?
> $ make randconfig
>
> $ grep -e SLUB -e SLAB -e SLOB .config
> # CONFIG_SLAB is not set
> CONFIG_SLUB=y
> CONFIG_SLOB=y
> # CONFIG_FAILSLAB is not set
>
> We have 2 choice selected (SLUB and SLOB). You may run randconfig (more than one
> time to get this result).
>
ok, I reproduced it with:
(Continue reading)

Permalink | Reply | 2 comments |

Gmane